[Bug] 次要资源X费牌，自动打出不计算X

[iouter]

模块范围

Public API（公开 API）

严重程度

Minor（轻微）

发生了什么？

次要资源X费牌，自动打出不计算X（当skipXCapture为false时）

复现步骤

用蕾忍的暗影魔刃打出哈利路小旋风

期望行为

当skipXCapture为false时，自动打出应计算X的效果并打出

日志 / 堆栈

RitsuLib 版本

0.4.46

运行环境

No response

[ritsukage-local-analyzer]

Warning

此分析由 AI 自动生成，仅供开发者参考，最终判断请以人工确认为准。如有疑问建议结合本地环境进一步复现确认。

摘要

该问题指向“自动打出”路径下，次级资源的 X 值没有像原生能量/星星 X 一样在 skipXCapture=false 时被捕获，导致依赖次级资源 X 的效果按 0 或免费处理。影响范围看起来集中在次级资源 API 与自动打出联动，严重度与现有 severity/minor 基本一致。建议优先在自动打出入口或 OnPlayWrapper 前置补丁中补齐次级 X 捕获语义，并用报告中的蕾忍“暗影魔刃”打出“哈利路小旋风”作为回归用例。

重点结论

项目	结论
简单介绍	次级资源 X 费牌被效果自动打出时，skipXCapture=false 的预期 X 捕获没有反映到次级资源 ledger/效果值。
可能原因	较高可能是 RitsuLib 的自动打出补丁只在 CardModel.OnPlayWrapper(..., bool isAutoPlay, ...) 层面处理次级资源，拿不到 CardCmd.AutoPlay(..., skipXCapture) 参数；同时自动打出且无 pending ledger 时会用 SecondaryResourcePaymentFreeMode.AllCosts 创建免费 ledger。
可能解决方案	在 CardCmd.AutoPlay 层增加补丁/桥接：当 skipXCapture=false 时按当前次级资源量解析并排队 X ledger；当 skipXCapture=true 时保留“已由调用方提前 SpendResources/ledger 捕获”的语义。另需补回归测试覆盖自动打出 X 次级资源与手动打出路径。
需要补充	请补充运行环境/游戏构建号，以及“哈利路小旋风”实际造成的数值或日志截图，以便确认是 X 值为 0、未激活，还是只是不消耗资源。

展开详细分析、证据与验证

问题描述

期望行为

• 当 skipXCapture=false 时，自动打出的次级资源 X 费牌应根据当前可用次级资源计算 X，并让卡牌效果读取到对应 X 值。

实际行为

• 报告称“次要资源X费牌，自动打出不计算X”；也就是自动打出时没有得到应有的 X 计算结果。

复现步骤

1. 使用蕾忍的“暗影魔刃”。
2. 通过该效果自动打出“哈利路小旋风”。
3. 观察该 X 费牌在 skipXCapture=false 时是否计算次级资源 X。

环境与版本

• RitsuLib 版本：0.4.46
• 模块范围：Public API（公开 API）
• 严重程度：Minor（轻微）
• 运行环境：未提供

日志、附件与原文摘录

• 原文：次要资源X费牌，自动打出不计算X（当skipXCapture为false时）
  • 要点：问题不是普通手动打出，而是自动打出路径与 skipXCapture=false 的组合。
• 原文：用蕾忍的暗影魔刃打出哈利路小旋风
  • 要点：已有一条具体复现链，但缺少实际数值/截图/日志来区分“X=0”和“未消耗但仍有值”。

详细分析依据

• 原生自动打出入口 official-source/src/Core/Commands/CardCmd.cs:51 带有 skipXCapture 参数；其注释说明 skipXCapture=true 用于调用方已通过 SpendResources 捕获 X 的情况（official-source/src/Core/Commands/CardCmd.cs:46）。
• 原生逻辑在 skipXCapture=false 时会捕获能量 X 与星星 X：能量 X 在 official-source/src/Core/Commands/CardCmd.cs:99 设置，星星 X 在 official-source/src/Core/Commands/CardCmd.cs:103 后处理。
• RitsuLib 当前次级资源补丁挂在 CardModel.OnPlayWrapper：src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:109，前缀方法只接收 isAutoPlay（src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:120），没有 skipXCapture 参数，因此无法直接区分“应重新捕获 X”和“调用方已经捕获”。
• 该前缀在自动打出且没有 pending ledger 时，会执行 SecondaryResourcePaymentResolver.Plan(__instance, SecondaryResourcePaymentFreeMode.AllCosts) 并 CommitFree（src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:127 至 src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:134）。这更像“自动打出不支付次级资源”的兜底，而不是复刻原生 skipXCapture=false 的 X 捕获语义。
• 次级资源 X 解析位于 src/Combat/SecondaryResources/SecondaryResourceCosts.cs:1128 起：X 值基于可用资源计算并经 SecondaryResourceHook.ModifyXValue 修正，随后写入 payment line 的 Value。但如果自动打出入口没有按 skipXCapture=false 预先建立正确 ledger，后续 CardPlay.SecondaryResources().Value(...) / ValueByUse(...) 读取到的值就可能不符合预期。
• ledger 绑定依赖 pending 队列：SecondaryResourcePaymentResolver.Commit / CommitFree 会 SetPending（src/Combat/SecondaryResources/SecondaryResourceCosts.cs:809、src/Combat/SecondaryResources/SecondaryResourceCosts.cs:897），随后 Hook.BeforeCardPlayed 前缀绑定到 CardPlay（src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:172 至 src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:175）。因此修复点应保证自动打出创建 CardPlay 前已有符合 skipXCapture 语义的 pending ledger。

反馈规范性提醒

维度	状态
复现步骤	已提供：给出了具体角色/效果/卡牌组合。
期望/实际	已提供：说明了 skipXCapture=false 时应计算 X、实际不计算。
环境与版本	含糊：RitsuLib 版本已给出，但游戏构建、Mod 列表、运行平台缺失。
日志/附件	缺失：日志块为空，未提供截图或实际数值对比。
标题与背景	已提供：标题与正文范围一致，指向自动打出与次级资源 X。

详细验证建议

• 在本地构造或使用报告组合：给玩家设置非零次级资源，给“哈利路小旋风”附加 SecondaryResourceCost.X(...) 或等价 play use。
• 手动打出同一牌，确认 SecondaryResourcePaymentResolver.Plan / CardPlay.SecondaryResources().Value(...) 能得到非零 X，作为基线。
• 通过“暗影魔刃”或直接调用 CardCmd.AutoPlay(..., skipXCapture:false) 自动打出，检查绑定到 CardPlay 的 ledger 中 CostsX=true 且 Value 等于预期资源量。
• 再覆盖 skipXCapture:true 场景：先由调用方显式 SpendResources 或等价次级资源提交 ledger，再自动打出，确认不会重复捕获/重复消耗。
• 增加回归测试或最小集成测试，断言 skipXCapture=false 与 true 两条路径的次级 X ledger 行为不同且均符合语义。

风险与未决

• 直接把 OnPlayWrapper 自动打出兜底从 AllCosts 改成普通支付可能会破坏原本“自动打出不消耗次级固定费用”的兼容行为；更稳妥的是在 CardCmd.AutoPlay 层显式传递/记录 skipXCapture 语义。
• 需要确认“哈利路小旋风”的次级资源 X 是 required cost、optional spend 还是 capability contributor；不同 use kind 在 free ledger 中的 Value 行为可能不同。
• 缺少实际数值和运行环境，暂不能排除复现卡牌自身读取 ledger key/use id 不一致的问题。

---

English translation

Summary

This issue points to the autoplay path not capturing secondary-resource X the same way native energy/star X is captured when skipXCapture=false, so effects depending on secondary-resource X may see 0 or a free-play value. The likely impact is limited to the secondary-resource API's interaction with autoplay, matching the current severity/minor label. The next step is to bridge secondary X capture at the autoplay entry point or before OnPlayWrapper, then use the reported Shadow Blade → Hallelu Whirlwind scenario as a regression case.

Key Takeaways

Item	Takeaway
Brief description	A secondary-resource X-cost card does not receive the expected X value when it is autoplayed with skipXCapture=false.
Likely cause	High confidence: RitsuLib handles secondary resources in a CardModel.OnPlayWrapper(..., bool isAutoPlay, ...) patch that cannot see CardCmd.AutoPlay(..., skipXCapture), and the current no-pending-ledger autoplay fallback creates a free ledger via SecondaryResourcePaymentFreeMode.AllCosts.
Possible fix	Add a patch/bridge around CardCmd.AutoPlay: when skipXCapture=false, resolve and queue an X ledger from the current secondary-resource amount; when skipXCapture=true, preserve the “caller already captured via SpendResources/ledger” behavior. Add regression coverage for autoplayed secondary-resource X and manual play.
Needs follow-up	Please provide the runtime/game build and the actual Hallelu Whirlwind value or a screenshot/log, so maintainers can distinguish X=0, not activated, and no-spend-but-valued cases.

Expand detailed analysis, evidence, and verification

Problem Description

Expected behavior

• When skipXCapture=false, an autoplayed secondary-resource X-cost card should calculate X from the currently available secondary resource and expose that value to the card effect.

Actual behavior

• The reporter says that an autoplayed secondary-resource X-cost card “does not calculate X,” meaning the autoplay path does not produce the expected X result.

Reproduction steps

1. Use Leiren's “Shadow Blade.”
2. Let that effect autoplay “Hallelu Whirlwind.”
3. Observe whether the X-cost card calculates secondary-resource X when skipXCapture=false.

Environment and Versions

• RitsuLib version: 0.4.46
• Module scope: Public API
• Severity: Minor
• Runtime environment: not provided

Logs, Attachments, and Original Excerpts

• Original: 次要资源X费牌，自动打出不计算X（当skipXCapture为false时）
  • Key point: this is specifically about autoplay combined with skipXCapture=false, not ordinary manual play.
• Original: 用蕾忍的暗影魔刃打出哈利路小旋风
  • Key point: a concrete reproduction chain is provided, but the actual value/screenshot/log is missing, so X=0 cannot yet be distinguished from “not spent but still valued.”

Detailed Analysis Basis

• The native autoplay entry point official-source/src/Core/Commands/CardCmd.cs:51 has a skipXCapture parameter; its comment says skipXCapture=true is for callers that already captured X through SpendResources (official-source/src/Core/Commands/CardCmd.cs:46).
• Native logic captures energy X and star X when skipXCapture=false: energy X is assigned at official-source/src/Core/Commands/CardCmd.cs:99, and star X is handled after official-source/src/Core/Commands/CardCmd.cs:103.
• RitsuLib's secondary-resource patch is attached to CardModel.OnPlayWrapper at src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:109; the prefix only receives isAutoPlay (src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:120) and therefore cannot directly distinguish “capture X now” from “the caller already captured it.”
• In that prefix, when the play is autoplayed and no pending ledger exists, the code runs SecondaryResourcePaymentResolver.Plan(__instance, SecondaryResourcePaymentFreeMode.AllCosts) followed by CommitFree (src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:127 through src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:134). This looks more like a fallback for “autoplay does not pay secondary resources” than a reproduction of native skipXCapture=false X capture semantics.
• Secondary-resource X resolution starts at src/Combat/SecondaryResources/SecondaryResourceCosts.cs:1128: the X value is based on available resource, adjusted by SecondaryResourceHook.ModifyXValue, and stored in the payment line's Value. If the autoplay entry does not create the right pending ledger for skipXCapture=false, later reads through CardPlay.SecondaryResources().Value(...) / ValueByUse(...) may not match expectations.
• Ledger binding depends on the pending queue: SecondaryResourcePaymentResolver.Commit / CommitFree call SetPending (src/Combat/SecondaryResources/SecondaryResourceCosts.cs:809, src/Combat/SecondaryResources/SecondaryResourceCosts.cs:897), then the Hook.BeforeCardPlayed prefix binds it to CardPlay (src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:172 through src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:175). A fix should ensure a pending ledger with the correct skipXCapture semantics exists before the autoplayed CardPlay is created.

Feedback Hygiene Reminder

Dimension	Status
Reproduction steps	Provided: the character/effect/card combination is named.
Expected/actual	Provided: it states that X should be calculated when skipXCapture=false, but is not.
Environment and versions	Ambiguous: RitsuLib version is provided, but game build, mod list, and platform are missing.
Logs/attachments	Missing: the log block is empty and no screenshot or value comparison is attached.
Title and background	Provided: the title and body consistently point to autoplay plus secondary-resource X.

Detailed Verification Suggestions

• Locally construct or use the reported combination: give the player a nonzero secondary resource and attach SecondaryResourceCost.X(...) or an equivalent play use to Hallelu Whirlwind.
• Manually play the same card and confirm that SecondaryResourcePaymentResolver.Plan / CardPlay.SecondaryResources().Value(...) returns a nonzero X baseline.
• Autoplay it through Shadow Blade or a direct CardCmd.AutoPlay(..., skipXCapture:false) call, and verify the ledger bound to CardPlay has CostsX=true and the expected Value.
• Cover skipXCapture:true as well: have the caller explicitly SpendResources or otherwise commit an equivalent secondary-resource ledger first, then autoplay and confirm X is not captured/spent twice.
• Add a regression or minimal integration test asserting that the skipXCapture=false and skipXCapture=true secondary-X ledger paths differ and both match their intended semantics.

Risks and Open Questions

• Simply changing the OnPlayWrapper autoplay fallback from AllCosts to ordinary payment may break existing compatibility where autoplay intentionally does not spend fixed secondary resources; explicitly carrying skipXCapture semantics at the CardCmd.AutoPlay layer is safer.
• Maintainers should confirm whether Hallelu Whirlwind's secondary-resource X is implemented as a required cost, optional spend, or capability contributor; different use kinds can have different Value behavior in a free ledger.
• Without actual values and runtime details, it is still possible that the reproducing card reads a mismatched ledger key/use id rather than the X capture itself being absent.

---

工具侧记录

• BAKAOLC/STS2-RitsuLib#79 · 退出码 0 · 进程 424.46s
• gpt-5.5(high) · API 423438ms · 32 轮 · ↓78982 ↑9118 · 缓存读765952 写0 · $1.0058
• MCP available: management tools exposed to Claude.

[BAKAOLC]

由于明天应该会发版本，所以我先修了，但是今天应该不会更新
我会在明天在版本更新后一起更新
/r set confirmed