fix errors

Author: mandipsanger

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -15,9 +15,6 @@ function isProperFraction(numerator, denominator) {
   if (denominator <= 0) {
     return false;
   }
-  if (numerator < 0) {
-    return false;
-  }
   return numerator < denominator;
 }
 

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -27,6 +27,7 @@ function getCardValue(card) {
   // Get the suit (last character) and rank (everything before it)
   const suit = card.slice(-1);
   const rank = card.slice(0, -1);
+  console.log(suit, rank);
 
   // Check that the suit is valid
   if (!validSuits.includes(suit)) {
@@ -56,24 +57,6 @@ function getCardValue(card) {
   }
 
   throw new Error("Invalid card");
-
-  {
-    return Number(rank);
-  }
-
-  // Invalid rank
-  throw new Error("Invalid card");
-  getCardValue("1♠");
-  getCardValue("11♣");
-  getCardValue("0♦");
-  getCardValue("B♥");
-  getCardValue("X♠");
-
-  //invalid suit
-  getCardValue("AX");
-  getCardValue("5*");
-  getCardValue("10H");
-  getCardValue("QS");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -88,19 +71,32 @@ function assertEquals(actualOutput, targetOutput) {
   );
 }
 
-// TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
-// Examples:
-assertEquals(getCardValue("9♠"), 9);
-
-// Handling invalid cards
-try {
-  getCardValue("invalid");
-
-  // This line will not be reached if an error is thrown as expected
-  console.error("Error was not thrown for invalid card 😢");
-} catch (e) {
-  console.log("Error thrown for invalid card 🎉");
-}
-
-// What other invalid card cases can you think of?
-//invalid rank
+// // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
+// // Examples:
+// assertEquals(getCardValue("9♠"), 9);
+
+// // Handling invalid cards
+// try {
+//   getCardValue("invalid");
+
+//   // This line will not be reached if an error is thrown as expected
+//   console.error("Error was not thrown for invalid card 😢");
+// } catch (e) {
+//   console.log("Error thrown for invalid card 🎉");
+// }
+
+// // What other invalid card cases can you think of?
+// //invalid rank
+// getCardValue("1♠");
+// getCardValue("11♣");
+// getCardValue("0♦");
+// getCardValue("B♥");
+// getCardValue("X♠");
+
+// //invalid suit
+// getCardValue("AX");
+// getCardValue("5*");
+// getCardValue("10H");
+// getCardValue("QS");
+
+getCardValue("1♠");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -23,11 +23,14 @@ test("should return 10 for face cards", () => {
 });
 
 // Case 4: Invalid cards
-test("should return 0 for invalid cards", () => {
-  expect(getCardValue("1♠")).toEqual(0);
-  expect(getCardValue("11♣")).toEqual(0);
-  expect(getCardValue("X♦")).toEqual(0);
-  expect(getCardValue("")).toEqual(0);
+test("should return error for invalid cards", () => {
+  expect(() => {
+    getCardValue("1♠");
+  }).toThrow("Invalid card");
+  // expect(getCardValue("1♠")).toEqual(0);
+  // expect(getCardValue("11♣")).toEqual(0);
+  // expect(getCardValue("X♦")).toEqual(0);
+  // expect(getCardValue("")).toEqual(0);
 });
 
 // Suggestion: Group the remaining test data into these categories: