From 6e54c76d844f5001c1adccf28b0d10060604ead7 Mon Sep 17 00:00:00 2001 From: abduhasen Date: Sun, 12 Jul 2026 18:50:14 +0100 Subject: [PATCH 1/2] writing test for the given function and writing a function by test driven development --- Sprint-3/2-practice-tdd/count.js | 8 ++++- Sprint-3/2-practice-tdd/count.test.js | 30 +++++++++++++++++++ Sprint-3/2-practice-tdd/get-ordinal-number.js | 16 +++++++++- .../2-practice-tdd/get-ordinal-number.test.js | 16 ++++++++++ Sprint-3/2-practice-tdd/repeat-str.js | 12 ++++++-- Sprint-3/2-practice-tdd/repeat-str.test.js | 19 ++++++++++-- 6 files changed, 95 insertions(+), 6 deletions(-) diff --git a/Sprint-3/2-practice-tdd/count.js b/Sprint-3/2-practice-tdd/count.js index 95b6ebb7d4..d59e425d6b 100644 --- a/Sprint-3/2-practice-tdd/count.js +++ b/Sprint-3/2-practice-tdd/count.js @@ -1,5 +1,11 @@ function countChar(stringOfCharacters, findCharacter) { - return 5 + let count = 0; + for (let i = 0; i < stringOfCharacters.length; i++) { + if (stringOfCharacters[i] === findCharacter) { + count++; + } + } + return count; } module.exports = countChar; diff --git a/Sprint-3/2-practice-tdd/count.test.js b/Sprint-3/2-practice-tdd/count.test.js index 179ea0ddf7..f67d6f1e91 100644 --- a/Sprint-3/2-practice-tdd/count.test.js +++ b/Sprint-3/2-practice-tdd/count.test.js @@ -16,9 +16,39 @@ test("should count multiple occurrences of a character", () => { const count = countChar(str, char); expect(count).toEqual(5); }); +test("should count multiple occurrences of a character", () => { + const str = "hello"; + const char = "l"; + const count = countChar(str, char); + expect(count).toEqual(2); +}); +test("should count multiple occurrences of a character", () => { + const str = "speed"; + const char = "e"; + const count = countChar(str, char); + expect(count).toEqual(2); +}); // Scenario: No Occurrences // Given the input string `str`, // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. +test("should count multiple occurrences of a character", () => { + const str = "kkkk"; + const char = "l"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); +test("should count multiple occurrences of a character", () => { + const str = "bbbb"; + const char = "c"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); +test("should count multiple occurrences of a character", () => { + const str = "mmmmmzmze"; + const char = "d"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.js b/Sprint-3/2-practice-tdd/get-ordinal-number.js index f95d71db13..ad37ef8e6b 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.js @@ -1,5 +1,19 @@ function getOrdinalNumber(num) { - return "1st"; + let numberValue = num; + let lastDigit = numberValue % 10; + let lastTwoDigit = numberValue % 100; + if (lastTwoDigit === 11 || lastTwoDigit === 12 || lastTwoDigit === 13) { + return String(numberValue) + "th"; + } + if (lastDigit === 1) { + return String(numberValue) + "st"; + } + if (lastDigit === 2) { + return String(numberValue) + "nd"; + } + if (lastDigit === 3) { + return String(numberValue) + "rd"; + } else return String(numberValue) + "th"; } module.exports = getOrdinalNumber; diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index adfa58560f..0b62cf4a28 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,19 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); +// Case 2: Numbers ending with 2 (but not 12) +// When the number ends with 2, except those ending with 12, +// Then the function should return a string by appending "nd" to the number. +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(22)).toEqual("22nd"); + expect(getOrdinalNumber(52)).toEqual("52nd"); +}); +// Case 3: Numbers ending with 3 (but not 13) +// When the number ends with 3, except those ending with 13, +// Then the function should return a string by appending "rd" to the number. +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(33)).toEqual("33rd"); + expect(getOrdinalNumber(133)).toEqual("133rd"); +}); diff --git a/Sprint-3/2-practice-tdd/repeat-str.js b/Sprint-3/2-practice-tdd/repeat-str.js index 2af0a2cea7..3374fce3e3 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.js +++ b/Sprint-3/2-practice-tdd/repeat-str.js @@ -1,7 +1,15 @@ -function repeatStr() { +function repeatStr(str, num) { + let result = ""; // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). // The goal is to re-implement that function, not to use it. - return "hellohellohello"; + for (let i = 0; i < num; i++) { + result += str; + } + if (num > 0) { + return result; + } else if (num === 0) { + return ""; + } else throw new error(); } module.exports = repeatStr; diff --git a/Sprint-3/2-practice-tdd/repeat-str.test.js b/Sprint-3/2-practice-tdd/repeat-str.test.js index a3fc1196c4..6d9ef29a0c 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.test.js +++ b/Sprint-3/2-practice-tdd/repeat-str.test.js @@ -20,13 +20,28 @@ test("should repeat the string count times", () => { // Given a target string `str` and a `count` equal to 1, // When the repeatStr function is called with these inputs, // Then it should return the original `str` without repetition. - +test("should return the original string when count equal to 1", () => { + const str = "manchester"; + const count = 1; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual("manchester"); +}); // Case: Handle count of 0: // Given a target string `str` and a `count` equal to 0, // When the repeatStr function is called with these inputs, // Then it should return an empty string. - +test("should return the empty string when count equal to 0", () => { + const str = "ahmed"; + const count = 0; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual(""); +}); // Case: Handle negative count: // Given a target string `str` and a negative integer `count`, // When the repeatStr function is called with these inputs, // Then it should throw an error, as negative counts are not valid. +test("should throw an error when negative values pass to it", () => { + expect(() => { + repeatedStr("hi", -3); + }).toThrow(); +}); From 5ef5dacf4517fb2bcb8d8bfa166b3d29fe4bf72d Mon Sep 17 00:00:00 2001 From: abduhasen Date: Wed, 29 Jul 2026 10:13:36 +0100 Subject: [PATCH 2/2] fixing codes based on mentor feedback --- Sprint-3/2-practice-tdd/count.test.js | 12 ++++++------ .../2-practice-tdd/get-ordinal-number.test.js | 16 ++++++++++++++++ Sprint-3/2-practice-tdd/repeat-str.js | 12 +++++------- 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/Sprint-3/2-practice-tdd/count.test.js b/Sprint-3/2-practice-tdd/count.test.js index f67d6f1e91..7d7cc161f4 100644 --- a/Sprint-3/2-practice-tdd/count.test.js +++ b/Sprint-3/2-practice-tdd/count.test.js @@ -10,19 +10,19 @@ const countChar = require("./count"); // When the function is called with these inputs, // Then it should correctly count occurrences of `char`. -test("should count multiple occurrences of a character", () => { +test("The function should return the number of times a character appears ", () => { const str = "aaaaa"; const char = "a"; const count = countChar(str, char); expect(count).toEqual(5); }); -test("should count multiple occurrences of a character", () => { +test("The function should return the number of times a character appears", () => { const str = "hello"; const char = "l"; const count = countChar(str, char); expect(count).toEqual(2); }); -test("should count multiple occurrences of a character", () => { +test("The function should return the number of times a character appears", () => { const str = "speed"; const char = "e"; const count = countChar(str, char); @@ -34,19 +34,19 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. -test("should count multiple occurrences of a character", () => { +test("the function should return 0 when there are no appears of the character", () => { const str = "kkkk"; const char = "l"; const count = countChar(str, char); expect(count).toEqual(0); }); -test("should count multiple occurrences of a character", () => { +test("the function should return 0 when there are no appears of the character", () => { const str = "bbbb"; const char = "c"; const count = countChar(str, char); expect(count).toEqual(0); }); -test("should count multiple occurrences of a character", () => { +test("the function should return 0 when there are no appears of the character", () => { const str = "mmmmmzmze"; const char = "d"; const count = countChar(str, char); diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index 0b62cf4a28..32362ea9b3 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -34,3 +34,19 @@ test("should append 'rd' for numbers ending with 3, except those ending with 13" expect(getOrdinalNumber(33)).toEqual("33rd"); expect(getOrdinalNumber(133)).toEqual("133rd"); }); +//Case 4: Numbers ending with 11,12 and 13 +// When the number ends with 11,12 and 13, +// Then the function should return a string by appending "th" to the number. +test("should append 'th' for numbers ending with 11,12 and 13", () => { + expect(getOrdinalNumber(1011)).toEqual("1011th"); + expect(getOrdinalNumber(312)).toEqual("312th"); + expect(getOrdinalNumber(113)).toEqual("113th"); +}); +//Case 5: Numbers 11,12 and 13 +// When the number is 11,12 and 13, +// Then the function should return a string by appending "th" to the number. +test("should append 'th' for numbers ending with 11,12 and 13", () => { + expect(getOrdinalNumber(11)).toEqual("11th"); + expect(getOrdinalNumber(12)).toEqual("12th"); + expect(getOrdinalNumber(13)).toEqual("13th"); +}); diff --git a/Sprint-3/2-practice-tdd/repeat-str.js b/Sprint-3/2-practice-tdd/repeat-str.js index 3374fce3e3..639a7c627a 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.js +++ b/Sprint-3/2-practice-tdd/repeat-str.js @@ -2,14 +2,12 @@ function repeatStr(str, num) { let result = ""; // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). // The goal is to re-implement that function, not to use it. - for (let i = 0; i < num; i++) { - result += str; + + if (num < 0) { + throw new Error(); } - if (num > 0) { - return result; - } else if (num === 0) { - return ""; - } else throw new error(); + + return str.repeat(num); } module.exports = repeatStr;