From eb668ef9b73409d522f67b9f09ef65a39fdf16f7 Mon Sep 17 00:00:00 2001
From: Kevin Cantrell <kevin@cropwatch.io>
Date: Sun, 21 Jun 2026 02:06:11 +0900
Subject: [PATCH] added major fix to log users out when their session token
 expires, and added minor temp/humid/co2 heatmap selection button group

---
 .../displays/AirDisplay/AirDisplay.svelte     |  91 +++++++++--
 src/lib/utils/session-expiry.svelte.spec.ts   | 143 ++++++++++++++++++
 src/lib/utils/session-expiry.ts               | 103 +++++++++++++
 src/routes/+layout.svelte                     |  29 +++-
 4 files changed, 355 insertions(+), 11 deletions(-)
 create mode 100644 src/lib/utils/session-expiry.svelte.spec.ts
 create mode 100644 src/lib/utils/session-expiry.ts

diff --git a/src/lib/components/displays/AirDisplay/AirDisplay.svelte b/src/lib/components/displays/AirDisplay/AirDisplay.svelte
index a120d0e2..bb80abb3 100644
--- a/src/lib/components/displays/AirDisplay/AirDisplay.svelte
+++ b/src/lib/components/displays/AirDisplay/AirDisplay.svelte
@@ -1,5 +1,6 @@
 <script lang="ts">
 	import {
+		CwButton,
 		CwCard,
 		CwDataTable,
 		CwDuration,
@@ -185,12 +186,66 @@
 		};
 	});
 
+	type HeatmapMetricKey = 'temperature' | 'humidity' | 'co2';
+
+	interface HeatmapMetric {
+		key: HeatmapMetricKey;
+		label: string;
+		unit: string;
+		colors: [string, string, string];
+		// Returns the cell value, or null to omit the row (rendered as a no-data gap).
+		value: (row: AirRow) => number | null;
+	}
+
+	// Metrics the heatmap can render from the data already loaded. Temperature and
+	// humidity are always reported; CO2 only appears when the device actually sent
+	// readings (see `hasCo2`). Switching metric just re-points the heatmap value —
+	// no re-fetch.
+	let heatmapMetrics: HeatmapMetric[] = $derived.by(() => {
+		const metrics: HeatmapMetric[] = [
+			{
+				key: 'temperature',
+				label: m.rule_subject_temperature(),
+				unit: '°C',
+				colors: ['#0ea5e9', '#84cc16', '#f97316'],
+				value: (row) => row.temperature_c
+			},
+			{
+				key: 'humidity',
+				label: m.rule_subject_humidity(),
+				unit: '%',
+				colors: ['#bae6fd', '#38bdf8', '#1d4ed8'],
+				value: (row) => row.humidity
+			}
+		];
+		if (hasCo2) {
+			metrics.push({
+				key: 'co2',
+				label: m.rule_subject_co2(),
+				unit: 'ppm',
+				colors: ['#84cc16', '#f59e0b', '#dc2626'],
+				// CO2 is sent on only ~1 of 3 uplinks, so most rows carry no reading
+				// (co2 === 0). Omit those so the heatmap shows gaps, not fake-low cells.
+				value: (row) => (row.co2 > 0 ? row.co2 : null)
+			});
+		}
+		return metrics;
+	});
+
+	let selectedMetric = $state<HeatmapMetricKey>('temperature');
+	// Fall back to the first metric when the selection is unavailable (e.g. CO2 was
+	// selected then dropped out of the data). `heatmapMetrics` always has ≥1 entry.
+	let activeMetric = $derived(
+		heatmapMetrics.find((metric) => metric.key === selectedMetric) ?? heatmapMetrics[0]
+	);
+
 	let heatmapSeries = $derived<(CwHeatmapDataPoint & { timestamp: string })[]>(
-		rows.map((row) => ({
-			timestamp: row.created_at,
-			created_at: row.created_at,
-			value: row.temperature_c
-		}))
+		rows.flatMap((row) => {
+			const value = activeMetric.value(row);
+			return value === null
+				? []
+				: [{ timestamp: row.created_at, created_at: row.created_at, value }];
+		})
 	);
 
 	let heatmapDays = $derived.by(() => {
@@ -340,16 +395,27 @@
 	</div>
 
 	{#if !loading && rows.length > 0}
-		<div class="air-wind-row" class:air-wind-row--paired={hasWind}>
-			<CwCard title={m.display_temperature_heatmap()} subtitle={m.display_reading_density()} elevated>
+		<div class="air-wind-row" class:air-wind-row--paired={hasWind} id="HeatMapDiv">
+			<CwCard title={activeMetric.label} subtitle={m.display_reading_density()} elevated>
+				<div class="heatmap-metric-toggle">
+					{#each heatmapMetrics as metric (metric.key)}
+						<CwButton
+							size="sm"
+							variant={activeMetric.key === metric.key ? 'info' : 'secondary'}
+							onclick={() => (selectedMetric = metric.key)}
+						>
+							{metric.label}
+						</CwButton>
+					{/each}
+				</div>
 				<CwHeatmap
 					labels={cwHeatmapLabels()}
 					data={heatmapSeries}
 					days={heatmapDays}
-					unit="°C"
+					unit={activeMetric.unit}
 					title=""
 					rowHeight={18}
-					colors={['#0ea5e9', '#84cc16', '#f97316']}
+					colors={activeMetric.colors}
 				/>
 			</CwCard>
 
@@ -426,6 +492,13 @@
 	.air-wind-row > :global(*) {
 		min-width: 0;
 	}
+	/* Metric select buttons above the heatmap. */
+	.heatmap-metric-toggle {
+		display: flex;
+		flex-wrap: wrap;
+		gap: 0.5rem;
+		margin-bottom: 0.75rem;
+	}
 	@media (min-width: 48rem) {
 		.air-wind-row--paired {
 			display: grid;
diff --git a/src/lib/utils/session-expiry.svelte.spec.ts b/src/lib/utils/session-expiry.svelte.spec.ts
new file mode 100644
index 00000000..69635f3a
--- /dev/null
+++ b/src/lib/utils/session-expiry.svelte.spec.ts
@@ -0,0 +1,143 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+
+import { createSessionExpiryWatcher } from './session-expiry';
+
+// `queueMicrotask` is intentionally left real so the already-expired path can be
+// flushed with `await Promise.resolve()`; `setTimeout`/`Date` are faked so the
+// scheduling math is deterministic.
+const MAX_DELAY_MS = 2_000_000_000;
+
+describe('createSessionExpiryWatcher', () => {
+	beforeEach(() => {
+		vi.useFakeTimers({ toFake: ['setTimeout', 'clearTimeout', 'Date'] });
+		vi.setSystemTime(new Date('2026-01-01T00:00:00Z'));
+	});
+
+	afterEach(() => {
+		vi.useRealTimers();
+	});
+
+	const nowSeconds = () => Math.floor(Date.now() / 1000);
+
+	it('fires onExpired at the expiry instant, not before', () => {
+		const onExpired = vi.fn();
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => nowSeconds() + 100,
+			onExpired,
+			leadTimeMs: 0
+		});
+		watcher.rearm();
+
+		vi.advanceTimersByTime(99_000);
+		expect(onExpired).not.toHaveBeenCalled();
+
+		vi.advanceTimersByTime(1_000);
+		expect(onExpired).toHaveBeenCalledTimes(1);
+
+		watcher.destroy();
+	});
+
+	it('fires slightly early by the lead-time buffer', () => {
+		const onExpired = vi.fn();
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => nowSeconds() + 100,
+			onExpired,
+			leadTimeMs: 5_000
+		});
+		watcher.rearm();
+
+		vi.advanceTimersByTime(95_000);
+		expect(onExpired).toHaveBeenCalledTimes(1);
+
+		watcher.destroy();
+	});
+
+	it('fires immediately (next microtask) when already expired', async () => {
+		const onExpired = vi.fn();
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => nowSeconds() - 10,
+			onExpired,
+			leadTimeMs: 0
+		});
+		watcher.rearm();
+
+		expect(onExpired).not.toHaveBeenCalled(); // deferred off the synchronous body
+		await Promise.resolve();
+		expect(onExpired).toHaveBeenCalledTimes(1);
+
+		watcher.destroy();
+	});
+
+	it('does not fire after destroy()', () => {
+		const onExpired = vi.fn();
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => nowSeconds() + 50,
+			onExpired,
+			leadTimeMs: 0
+		});
+		watcher.rearm();
+		watcher.destroy();
+
+		vi.advanceTimersByTime(60_000);
+		expect(onExpired).not.toHaveBeenCalled();
+	});
+
+	it('re-arms to the new expiry when the session changes (re-login)', () => {
+		const onExpired = vi.fn();
+		let exp = nowSeconds() + 30;
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => exp,
+			onExpired,
+			leadTimeMs: 0
+		});
+		watcher.rearm();
+
+		// Re-login extends the session before the original timer fires.
+		exp = nowSeconds() + 300;
+		watcher.rearm();
+
+		vi.advanceTimersByTime(31_000); // past the original expiry
+		expect(onExpired).not.toHaveBeenCalled();
+
+		vi.advanceTimersByTime(270_000); // reach the new expiry
+		expect(onExpired).toHaveBeenCalledTimes(1);
+
+		watcher.destroy();
+	});
+
+	it('does nothing when there is no session', () => {
+		const onExpired = vi.fn();
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => null,
+			onExpired
+		});
+		watcher.rearm();
+
+		vi.advanceTimersByTime(10_000_000);
+		expect(onExpired).not.toHaveBeenCalled();
+
+		watcher.destroy();
+	});
+
+	it('clamps a far-future expiry to avoid the 32-bit setTimeout immediate-fire bug', () => {
+		const onExpired = vi.fn();
+		const exp = nowSeconds() + 60 * 60 * 24 * 30; // 30 days out
+		const watcher = createSessionExpiryWatcher({
+			getExpSeconds: () => exp,
+			onExpired,
+			leadTimeMs: 0
+		});
+		watcher.rearm();
+
+		// At the clamp boundary it must re-arm, not fire.
+		vi.advanceTimersByTime(MAX_DELAY_MS);
+		expect(onExpired).not.toHaveBeenCalled();
+
+		// It still fires once the real expiry is finally reached.
+		const remainingMs = exp * 1000 - Date.now();
+		vi.advanceTimersByTime(remainingMs);
+		expect(onExpired).toHaveBeenCalledTimes(1);
+
+		watcher.destroy();
+	});
+});
diff --git a/src/lib/utils/session-expiry.ts b/src/lib/utils/session-expiry.ts
new file mode 100644
index 00000000..bf4666dd
--- /dev/null
+++ b/src/lib/utils/session-expiry.ts
@@ -0,0 +1,103 @@
+import { onAppForeground } from './onAppForeground';
+
+/**
+ * Proactively detect JWT session expiry on the client.
+ *
+ * The server hook (`src/hooks.server.ts`) is the authoritative session guard,
+ * but it only runs on a server request/navigation. A user idling on a page — or
+ * one that only triggers client-side `ApiService` fetches — never causes a
+ * navigation, so the hook never fires and the session can expire while the page
+ * keeps showing stale data.
+ *
+ * This watcher fills that gap. It schedules a single `setTimeout` for the exact
+ * instant the token expires (its `exp` claim) and, because background tabs throttle
+ * timers, also re-checks the moment the tab regains focus via `onAppForeground`.
+ * When expiry is reached it invokes `onExpired` (which redirects to login).
+ *
+ * Re-arm whenever the session changes (re-login / navigation) by calling `rearm()`.
+ * Safe to construct during SSR (becomes a no-op).
+ */
+
+// `setTimeout` stores its delay in a 32-bit int; delays above ~24.8 days wrap and
+// fire immediately. Clamp to this ceiling and re-arm instead.
+const MAX_DELAY_MS = 2_000_000_000;
+
+export interface SessionExpiryWatcher {
+	/** Cancel any pending timer and schedule a fresh one from the current expiry. */
+	rearm: () => void;
+	/** Clear the timer and detach the foreground listener. */
+	destroy: () => void;
+}
+
+export function createSessionExpiryWatcher(options: {
+	/** Returns the session expiry as a UNIX timestamp in seconds, or null if no session. */
+	getExpSeconds: () => number | null | undefined;
+	/** Called once when the session has expired. */
+	onExpired: () => void;
+	/** Fire this many ms before the real expiry to absorb minor clock skew. Default 1000. */
+	leadTimeMs?: number;
+}): SessionExpiryWatcher {
+	if (typeof window === 'undefined') {
+		return { rearm: () => {}, destroy: () => {} };
+	}
+
+	const { getExpSeconds, onExpired, leadTimeMs = 1000 } = options;
+
+	let handle: ReturnType<typeof setTimeout> | null = null;
+	let redirecting = false;
+
+	const clear = () => {
+		if (handle) {
+			clearTimeout(handle);
+			handle = null;
+		}
+	};
+
+	const fire = () => {
+		if (redirecting) return;
+		redirecting = true;
+		onExpired();
+	};
+
+	const rearm = () => {
+		clear();
+
+		const exp = getExpSeconds();
+		if (exp == null) return; // no session (e.g. /auth routes) — nothing to watch
+
+		const delayMs = exp * 1000 - leadTimeMs - Date.now();
+
+		if (delayMs <= 0) {
+			// Already expired — defer so we never navigate during a synchronous $effect body.
+			queueMicrotask(fire);
+			return;
+		}
+
+		// A future-dated session is valid again (e.g. after re-login): allow a fresh fire.
+		redirecting = false;
+
+		if (delayMs > MAX_DELAY_MS) {
+			handle = setTimeout(rearm, MAX_DELAY_MS);
+			return;
+		}
+
+		handle = setTimeout(fire, delayMs);
+	};
+
+	const checkNow = () => {
+		const exp = getExpSeconds();
+		if (exp == null) return;
+		if (exp * 1000 - leadTimeMs - Date.now() <= 0) {
+			fire();
+		}
+	};
+
+	const detach = onAppForeground(checkNow);
+
+	const destroy = () => {
+		clear();
+		detach();
+	};
+
+	return { rearm, destroy };
+}
diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte
index 54a24cee..0b7c0334 100644
--- a/src/routes/+layout.svelte
+++ b/src/routes/+layout.svelte
@@ -12,12 +12,14 @@
 	} from '@cropwatchdevelopment/cwui';
 	import { cwOfflineOverlayLabels } from '$lib/i18n/cwuiLabels';
 
-	import { afterNavigate } from '$app/navigation';
+	import { afterNavigate, goto } from '$app/navigation';
 	import { page } from '$app/state';
 	import OverviewDrawer from './OverviewDrawer.svelte';
 	import Sidebar from './Sidebar.svelte';
 	import Analytics from '$lib/components/Analytics.svelte';
-	import { createAppContext, setAppContext } from '$lib/appContext.svelte';
+	import { createAppContext, defaultAppContext, setAppContext } from '$lib/appContext.svelte';
+	import { createSessionExpiryWatcher } from '$lib/utils/session-expiry';
+	import { buildLoginPath } from '$lib/utils/auth-redirect';
 	import type { DeviceStatusSummary, RuleTemplateDto } from '$lib/api/api.dtos';
 	import type { IJWT } from '$lib/interfaces/jwt.interface';
 	import type { LayoutProps } from './$types';
@@ -62,6 +64,28 @@
 	syncAppFromPageData();
 	afterNavigate(syncAppFromPageData);
 
+	function onExpired() {
+		if (isAuthRoute) return; // already on login/logout — don't loop
+		Object.assign(app, defaultAppContext); // clear so no stale data flashes during the redirect
+		const loginPath = buildLoginPath({
+			path: resolve('/auth/login'),
+			redirectTo: page.url.pathname + page.url.search,
+			reason: 'expired'
+		});
+		// eslint-disable-next-line svelte/no-navigation-without-resolve -- path already resolved above
+		void goto(loginPath);
+	}
+
+	const sessionWatcher = createSessionExpiryWatcher({
+		getExpSeconds: () => app.session?.exp ?? null,
+		onExpired
+	});
+
+	$effect(() => {
+		void app.session?.exp; // track: re-arm whenever the session (and its expiry) changes
+		sessionWatcher.rearm();
+	});
+
 	function handleWindowResize() {
 		document.querySelector('.cw-sidenav')?.classList.add('cw-sidenav--resizing');
 
@@ -78,6 +102,7 @@
 		if (resizeTimer) {
 			clearTimeout(resizeTimer);
 		}
+		sessionWatcher.destroy();
 	});
 
 	function localizedHref(locale: (typeof locales)[number]): string {