[SC-40] Expand multisig-wallet test coverage (942 lines, only 4 tests)

[yusuftomilola]

Overview

contracts/multisig-wallet/ is 942 lines across lib.rs, types.rs, errors.rs, and tests.rs with only 4 #[test] functions. A multisig wallet is a security-critical primitive — four tests is far short of what it needs.

Tasks

• Enumerate every public entrypoint in lib.rs and identify which lack coverage.
• Test signer management: add, remove, replace, and the boundary where removal would drop signers below the threshold.
• Test threshold changes, including rejecting a threshold greater than the signer count or equal to zero.
• Test proposal lifecycle: create, approve, reach threshold, execute, and reject re-execution of an already-executed proposal.
• Test edge cases: duplicate approvals, approval by a removed signer, and expired proposals if supported.
• Add negative auth tests without mock_all_auths.
• Assert every errors.rs variant is reachable.

Acceptance Criteria

• At least 30 tests covering every entrypoint.
• Threshold and signer-count invariants are enforced and tested at their boundaries.
• A removed signer's prior approval cannot be counted toward a threshold.

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 22, members: assetsup, contrib, multisig-wallet, multisig_transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

[georgeonweb3]

Hello, I'd appreciate it if this issue was assigned to me, I'm confident I should be able to finish and submit a PR within a day

[amberly-d]

@amberly-d has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

can i solve this?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @amberly-d to this issue.

[drips-wave]

Congratulations, @amberly-d! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @amberly-d: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @amberly-d as part of the Stellar Wave Program's 7th Wave 🥳

😎 @amberly-d: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.