From 323b68497a3cec9b45e56a9fe95fab4323632090 Mon Sep 17 00:00:00 2001 From: ludat-coding-agent Date: Sun, 19 Jul 2026 15:22:03 +0000 Subject: [PATCH 1/2] Remove noncanonical definitions. This appeases the `-Wnoncanonical-monad-instances` warning. A future GHC release will treat noncanonical definitions as errors. See https://github.com/haskell/core-libraries-committee/issues/328. --- Text/Reform/Result.hs | 1 - 1 file changed, 1 deletion(-) diff --git a/Text/Reform/Result.hs b/Text/Reform/Result.hs index 32eca75..2485d47 100644 --- a/Text/Reform/Result.hs +++ b/Text/Reform/Result.hs @@ -31,7 +31,6 @@ instance Functor (Result e) where fmap f (Ok x) = Ok (f x) instance Monad (Result e) where - return = Ok Error x >>= _ = Error x Ok x >>= f = f x From 52466085cc6bff5db4bde1897db4f8d213f4a535 Mon Sep 17 00:00:00 2001 From: L0neGamer Date: Sun, 26 Jul 2026 17:42:24 +0100 Subject: [PATCH 2/2] remove redundant definition --- Text/Reform/Core.hs | 1 - 1 file changed, 1 deletion(-) diff --git a/Text/Reform/Core.hs b/Text/Reform/Core.hs index dfd614e..270267f 100644 --- a/Text/Reform/Core.hs +++ b/Text/Reform/Core.hs @@ -103,7 +103,6 @@ instance (SG.Semigroup input, Monad m) => SG.Semigroup (Environment m input) whe -- | Not quite sure when this is useful and so hard to say if the rules for combining things with Missing/Default are correct instance (SG.Semigroup input, Monad m) => Monoid (Environment m input) where mempty = NoEnvironment - mappend = (SG.<>) -- | Utility function: returns the current 'FormId'. This will only make sense -- if the form is not composed