Bug: tide prompt shows tide_character_vi_icon_default despite fish_key_bindings being default and fish_bind_mode being insert

[MunsuBahk]

Describe the bug

The tide prompt incorrectly displays the vi-mode default icon (❮ fromtide_character_vi_icon_default) even when the fish shell is in emacs-style key bindings (fish_default_key_bindings) and the fish_bind_mode variable is correctly set to insert. This suggests a logic error within the _tide_item_character.fish script.

Steps to reproduce

1. Configure fish shell to use default key bindings (emacs style).
   (e.g., set -U fish_key_bindings fish_default_key_bindings or rely on
   default).

2. Install tide v6 and complete basic setup via tide configure
   (Style: Rainbow, Color: True Color).

3. Set tide_character_icon to ❯ (e.g., set -U tide_character_icon '❯').

4. Set tide_character_vi_icon_default to ❮ (e.g., set -U tide_character_vi_icon_default '❮').

5. Ensure fish_bind_mode is set to insert. In this case, set -g fish_bind_mode insert was added unconditionally at the end of
   config.fish because conditional setting failed. (Confirm echo $fish_bind_mode outputs insert).

6. (Optional: Modified _tide_item_character.fish directly in an
   attempt to fix, but the core issue persisted, indicating the logic was
   still flawed or ignored).
   The relevant part of _tide_item_character.fish was originally
   similar to:
   test "$fish_key_bindings" = fish_default_key_bindings && echo -ns
   $tide_character_icon ||
   switch $fish_bind_mode
   case insert
   echo -ns $tide_character_icon
   case default
   echo -ns $tide_character_vi_icon_default
   ... other cases
   end

   (Note: This part was later modified to an explicit if/else block,
   but the issue still occurred).

7. Start a new terminal session.

Expected Behavior:
Since fish_key_bindings is default (emacs) and fish_bind_mode is
insert, the prompt icon should display the value of
tide_character_icon, which is ❯.

Actual Behavior:
The prompt icon displays the value of tide_character_vi_icon_default,
which is ❮. This occurs despite fish_bind_mode being insert and
tide_character_icon being explicitly set to ❯.

Screenshots

Environment

Output of tide bug-report:

fish version: 4.5.0
tide version: 6.2.0
term: xterm-kitty
os: macOS Tahoe 26.3
terminal emulator: Kitty
fish startup: 12.41 millis
fisher plugins: jorgebucaran/fisher patrickf1/fzf.fish gazorby/fish-abbreviation-tips ilancosman/tide@v6

Additional context

Root Cause Analysis (Based on user's and agent's findings):
The _tide_item_character.fish script's logic for determining the
character icon appears to be flawed.

• The original &&/|| structure for fish_default_key_bindings case
  seems to allow the switch $fish_bind_mode block to execute or take
  precedence even when it shouldn't.
• Even with fish_bind_mode explicitly set to insert, the switch
  statement (if executed) appears to incorrectly fall through to a case
  that uses tide_character_vi_icon_default or tide's internal state
  forces tide_character_vi_icon_default regardless.
• This specific behavior suggests that tide is somehow prioritizing
  the vi-mode icon (from tide_character_vi_icon_default) despite
  fish_key_bindings indicating emacs mode and fish_bind_mode being
  insert.

Proposed Solution (for tide maintainers):
The icon determination logic within _tide_item_character.fish needs a
robust review. The core issue is that tide is displaying the vi-mode
icon even when fish_key_bindings is default and fish_bind_mode is
insert. An explicit and clear if/else structure that correctly
prioritizes tide_character_icon when not in actual vi-mode (or
specifically, when fish_key_bindings is fish_default_key_bindings) is
necessary.

Workaround (currently in use by the user):
To achieve the desired ❯ icon, the user has set
tide_character_vi_icon_default to ❯. This forces tide to display
❯ regardless of its internal icon selection logic.

[kenchou]

I'm encountering the same issue.
On macOS, fish 4.5.0 displays ❮,
whereas on Ubuntu with fish 3.7.1, it displays ❯.
When I upgraded fish to version 4.5.0 on Ubuntu using the apt PPA repository, the prompt also changed to ❮.
I strongly suspect this is related to changes in the fish shell version.

[perisage]

the same issue.

[lawrenceakka]

See #622 #625