F-037 (P8) — CI does not verify formatting (the documented `reihitsu-format` step is missing from the pipeline)

[LarsLaskowski]

Severity: 🟡 · Criterion: Build-CI / K12 · Phase: P8 · Status (review): 🆕

File(s): .github/workflows/ci.yml:27-39; .github/workflows/release.yml:33-44; intended docs README.md:48, .github/copilot-instructions.md:24,30

Finding

The README, Copilot instructions and the Serena memories list reihitsu-format ./ as a mandatory step before every build. Both workflows, however, run only restore → build → test; there is no format/lint verification step (no reihitsu-format --check/dotnet format --verify-no-changes). Formatting drift is not detected in CI. (The RHxxxx analyzer rules do apply as errors at build time in the release ruleset — but pure formatting is not fully covered by that.)

Impact

The formatting documented as mandatory is not enforced; style/format regressions can reach main unnoticed. Low functional impact.

Recommendation

Add a verification step (e.g. reihitsu-format in check mode if available, otherwise dotnet format --verify-no-changes) that fails the build on drift.

---

_{Auto-generated from the repository code review. Source of truth: docs/review/findings.md → F-037 (P8), branch review/review-analysis-plan.}