From 89ae84f0289c57d4ed82451e74154a107c3518a2 Mon Sep 17 00:00:00 2001 From: shakedregev Date: Thu, 16 Jul 2026 10:30:23 -0400 Subject: [PATCH 1/4] expect warning --- tests/functionality/testSysGmres.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/functionality/testSysGmres.cpp b/tests/functionality/testSysGmres.cpp index c7790bd8c..dee84a807 100644 --- a/tests/functionality/testSysGmres.cpp +++ b/tests/functionality/testSysGmres.cpp @@ -233,6 +233,10 @@ int test(int argc, char* argv[]) << "\tReturned residual : " << rejected_guess_rnorm << "\n\n"; error_sum++; } + else + { + std::cout << "A warning on the next line is expected for the bad initial guess test" << std::endl; + } // Use a scaled converged solution as a nonzero initial guess. vector_type vec_x_guess(vec_x.getSize()); From 7202e81cad3d24ad84df88915acf08a56c8739c9 Mon Sep 17 00:00:00 2001 From: shakedregev Date: Thu, 16 Jul 2026 10:31:33 -0400 Subject: [PATCH 2/4] expect warning --- tests/functionality/testSysGmres.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functionality/testSysGmres.cpp b/tests/functionality/testSysGmres.cpp index dee84a807..429242fbc 100644 --- a/tests/functionality/testSysGmres.cpp +++ b/tests/functionality/testSysGmres.cpp @@ -235,7 +235,7 @@ int test(int argc, char* argv[]) } else { - std::cout << "A warning on the next line is expected for the bad initial guess test" << std::endl; + std::cout << "Expect a warning on the next line for the bad initial guess test." << std::endl; } // Use a scaled converged solution as a nonzero initial guess. From fbf5079847d4333b5b96384f942c3c15320cc5aa Mon Sep 17 00:00:00 2001 From: shakedregev Date: Thu, 16 Jul 2026 10:36:56 -0400 Subject: [PATCH 3/4] [Skip CI] changelog update --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32c8b0fa4..52ba5e91f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,8 @@ - Set Re::Solve's real type and matrix/vector index type at CMake configuration time. * Added size assertions to `VectorHandler::gemv` and fixed vector sizing in `GramSchmidt` accordingly. +- Added line to testlog to tell the user to expect warnings as part of normal testing. + ## Changes to Re::Solve in release 0.99.2 ### Major Features From b661b587e6bfde061b9fb2f46c98ef17547a666f Mon Sep 17 00:00:00 2001 From: Shaked Regev <35384901+shakedregev@users.noreply.github.com> Date: Thu, 16 Jul 2026 11:01:54 -0400 Subject: [PATCH 4/4] Update tests/functionality/testSysGmres.cpp Co-authored-by: pelesh --- tests/functionality/testSysGmres.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functionality/testSysGmres.cpp b/tests/functionality/testSysGmres.cpp index 429242fbc..8457a40aa 100644 --- a/tests/functionality/testSysGmres.cpp +++ b/tests/functionality/testSysGmres.cpp @@ -235,7 +235,7 @@ int test(int argc, char* argv[]) } else { - std::cout << "Expect a warning on the next line for the bad initial guess test." << std::endl; + Log::misc << "Expect a warning on the next line for the bad initial guess test." << std::endl; } // Use a scaled converged solution as a nonzero initial guess.