Was trying to track down the intermittent missing fronting history issue people have been reporting. I don't think this is the issue (or at least I'm not confident that it is), but this logic seems inverted to me:
|
if (_frontHistory.value.isEmpty()) { |
I believe this should be:
// We need to invalidate the front history so there isn't a stale reference
if (!_frontHistory.value.isEmpty()) {
clearAllFrontHistory()
}
Making an "issue" instead of a PR because I don't feel confident that I understand the logic well enough to be 100% certain.
Was trying to track down the intermittent missing fronting history issue people have been reporting. I don't think this is the issue (or at least I'm not confident that it is), but this logic seems inverted to me:
app/shared/src/commonMain/kotlin/app/octocon/app/ui/model/interfaces/api.kt
Line 434 in 10f98f6
I believe this should be:
Making an "issue" instead of a PR because I don't feel confident that I understand the logic well enough to be 100% certain.