From 466e80c27651aae56c369b5d37fcaaed995ce38d Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 6 Oct 2025 18:37:16 +0200 Subject: [PATCH 1/6] =?UTF-8?q?=F0=9F=A9=B9=20[Patch]:=20Add=20linter=20en?= =?UTF-8?q?vironment=20variables=20to=20PSModule=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/PSModule.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/PSModule.yml b/.github/PSModule.yml index a1912f7..e26e338 100644 --- a/.github/PSModule.yml +++ b/.github/PSModule.yml @@ -19,3 +19,12 @@ Test: # Build: # Docs: # Skip: true +Linter: + env: + VALIDATE_BIOME_FORMAT: false + VALIDATE_BIOME_LINT: false + VALIDATE_GITHUB_ACTIONS_ZIZMOR: false + VALIDATE_JSCPD: false + VALIDATE_JSON_PRETTIER: false + VALIDATE_MARKDOWN_PRETTIER: false + VALIDATE_YAML_PRETTIER: false From a9b321fef993389b3df3fe9577dcceb063245889 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Mon, 6 Oct 2025 22:37:33 +0200 Subject: [PATCH 2/6] Fix Docs --- .github/PSModule.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/PSModule.yml b/.github/PSModule.yml index a1912f7..21ca114 100644 --- a/.github/PSModule.yml +++ b/.github/PSModule.yml @@ -19,3 +19,13 @@ Test: # Build: # Docs: # Skip: true + +Linter: + env: + VALIDATE_BIOME_FORMAT: false + VALIDATE_BIOME_LINT: false + VALIDATE_GITHUB_ACTIONS_ZIZMOR: false + VALIDATE_JSCPD: false + VALIDATE_JSON_PRETTIER: false + VALIDATE_MARKDOWN_PRETTIER: false + VALIDATE_YAML_PRETTIER: false From 3488998cb952e703615f815b681210d1f2d19372 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Wed, 8 Oct 2025 11:47:20 +0200 Subject: [PATCH 3/6] =?UTF-8?q?=F0=9F=A9=B9=20[Patch]:=20Clean=20up=20comm?= =?UTF-8?q?ents=20in=20markdown-lint=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/linters/.markdown-lint.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml index b9ecdfa..57db57e 100644 --- a/.github/linters/.markdown-lint.yml +++ b/.github/linters/.markdown-lint.yml @@ -8,18 +8,19 @@ ############### # Rules by id # ############### -MD004: false # Unordered list style +MD004: false # Unordered list style MD007: - indent: 2 # Unordered list indentation + indent: 2 # Unordered list indentation MD013: - line_length: 808 # Line length + line_length: 808 # Line length +MD024: false # no-duplicate-heading, INPUTS and OUTPUTS _can_ be the same item MD026: - punctuation: ".,;:!。，；:" # List of not allowed -MD029: false # Ordered list item prefix -MD033: false # Allow inline HTML -MD036: false # Emphasis used instead of a heading + punctuation: '.,;:!。，；:' # List of not allowed +MD029: false # Ordered list item prefix +MD033: false # Allow inline HTML +MD036: false # Emphasis used instead of a heading ################# # Rules by tags # ################# -blank_lines: false # Error on blank lines +blank_lines: false # Error on blank lines From 939fd8a67492958708c95c05afd153ffca105807 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Fri, 10 Oct 2025 16:31:08 +0200 Subject: [PATCH 4/6] =?UTF-8?q?=F0=9F=A9=B9=20[Patch]:=20Improve=20paramet?= =?UTF-8?q?er=20documentation=20in=20Get-WoWRealm=20function=20and=20add?= =?UTF-8?q?=20a=20test=20for=20module=20loading?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/functions/public/Realm/Get-WoWRealm.ps1 | 6 +++--- tests/WoW.Tests.ps1 | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/functions/public/Realm/Get-WoWRealm.ps1 b/src/functions/public/Realm/Get-WoWRealm.ps1 index ab5a582..c0b13bb 100644 --- a/src/functions/public/Realm/Get-WoWRealm.ps1 +++ b/src/functions/public/Realm/Get-WoWRealm.ps1 @@ -18,9 +18,9 @@ function Get-WoWRealm { [CmdletBinding()] [OutputType([Addon[]])] param( - [String] - $Name + # The name of the realm to get + [Parameter(Mandatory)] + [String] $Name ) return $Script:WoW_Realms | Where-Object Name -Match $Name } -#SkipTest:FunctionTest:Difficult to test due to the nature of the function. diff --git a/tests/WoW.Tests.ps1 b/tests/WoW.Tests.ps1 index 9dbb517..635cbdd 100644 --- a/tests/WoW.Tests.ps1 +++ b/tests/WoW.Tests.ps1 @@ -2,4 +2,7 @@ param() Describe 'WoW' { + It 'Module is loaded' { + Get-Module -Name WoW | Should -Not -Be $null + } } From d7abaaa7c5d891eefbebcbb58916f15409f09133 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Fri, 10 Oct 2025 16:36:35 +0200 Subject: [PATCH 5/6] =?UTF-8?q?=F0=9F=A9=B9=20[Patch]:=20Add=20skip=20test?= =?UTF-8?q?=20comment=20for=20Get-WoWRealm=20function=20due=20to=20testing?= =?UTF-8?q?=20difficulties?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/functions/public/Realm/Get-WoWRealm.ps1 | 1 + 1 file changed, 1 insertion(+) diff --git a/src/functions/public/Realm/Get-WoWRealm.ps1 b/src/functions/public/Realm/Get-WoWRealm.ps1 index c0b13bb..62fe507 100644 --- a/src/functions/public/Realm/Get-WoWRealm.ps1 +++ b/src/functions/public/Realm/Get-WoWRealm.ps1 @@ -24,3 +24,4 @@ function Get-WoWRealm { ) return $Script:WoW_Realms | Where-Object Name -Match $Name } +#SkipTest:FunctionTest:Difficult to test due to the nature of the function. From 5ba5b8b213ed45f1b13c377d0c41d630699aee59 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Fri, 10 Oct 2025 16:46:53 +0200 Subject: [PATCH 6/6] Update src/functions/public/Realm/Get-WoWRealm.ps1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/functions/public/Realm/Get-WoWRealm.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/functions/public/Realm/Get-WoWRealm.ps1 b/src/functions/public/Realm/Get-WoWRealm.ps1 index 62fe507..6c98007 100644 --- a/src/functions/public/Realm/Get-WoWRealm.ps1 +++ b/src/functions/public/Realm/Get-WoWRealm.ps1 @@ -16,7 +16,7 @@ function Get-WoWRealm { General notes #> [CmdletBinding()] - [OutputType([Addon[]])] + [OutputType([Realm[]])] param( # The name of the realm to get [Parameter(Mandatory)]