Skip to content

Commit 08ae3a8

Browse files
ToolboxAidToolboxAid
authored
Merge PR #7: [codex] PR_26171_032 idea board accordion table model
[codex] PR_26171_032 idea board accordion table model
2 parents 82ff294 + 5a3b364 commit 08ae3a8

37 files changed

Lines changed: 1813 additions & 1741 deletions

‎docs_build/dev/codex_commands.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
# Codex Commands
22

33
## PR
4-
- `PR_26171_031-idea-board-inline-tree-grid-actions`
4+
- `PR_26171_032-idea-board-accordion-table-model`
55

66
## Source Documents
77
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
8-
- `docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md`
9-
- `docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md`
10-
- `docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md`
8+
- `docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md`
9+
- `docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md`
10+
- `docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md`
1111

1212
## Git Workflow Commands
1313
- `git branch --show-current`
1414
- `git status -sb`
1515
- `git branch --list`
1616
- `git pull --ff-only origin main`
17-
- `git switch -c codex/pr-26171-031-idea-board-inline-tree-grid-actions`
17+
- `git switch -c codex/pr-26171-032-idea-board-accordion-table-model`
1818

1919
## Inspection Commands
2020
- `Get-Content -Raw docs_build/dev/PROJECT_INSTRUCTIONS.md`
@@ -35,5 +35,5 @@
3535
## Artifact Commands
3636
- Generate `docs_build/dev/reports/codex_changed_files.txt`
3737
- Generate `docs_build/dev/reports/codex_review.diff`
38-
- Create `tmp/PR_26171_031-idea-board-inline-tree-grid-actions_delta.zip`
38+
- Create `tmp/PR_26171_032-idea-board-accordion-table-model_delta.zip`
3939
- Verify ZIP size and repo-relative paths

‎docs_build/dev/commit_comment.txt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
PR_26171_031 idea board inline tree grid actions
1+
PR_26171_032 idea board accordion table model
22

3-
- render selected idea notes directly under the idea row
4-
- add inline idea and note add/edit/delete workflows
5-
- update targeted Idea Board Playwright coverage and reports
3+
- reshape Idea Board in-page data into idea and note table records
4+
- default to collapsed notes with row-level expand/collapse controls
5+
- update targeted Playwright coverage and reports

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 29 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# Codex Changed Files - PR_26171_031-idea-board-inline-tree-grid-actions
1+
# Codex Changed Files - PR_26171_032-idea-board-accordion-table-model
22

33
## Git Workflow
4-
- Current branch: `codex/pr-26171-031-idea-board-inline-tree-grid-actions`
4+
- Current branch: `codex/pr-26171-032-idea-board-accordion-table-model`
55
- Expected starting branch: `main` (PASS before branch creation).
6-
- Created branch: `codex/pr-26171-031-idea-board-inline-tree-grid-actions`.
6+
- Created branch: `codex/pr-26171-032-idea-board-accordion-table-model`.
77
- Push result: pending until after commit.
88
- PR URL: pending until after push.
99
- Merge result: pending until after PR validation/merge.
@@ -12,9 +12,6 @@
1212
## Changed Files
1313
- docs_build/dev/codex_commands.md
1414
- docs_build/dev/commit_comment.txt
15-
- docs_build/dev/reports/codex_changed_files.txt
16-
- docs_build/dev/reports/codex_review.diff
17-
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
1815
- docs_build/dev/reports/dependency_gating_report.md
1916
- docs_build/dev/reports/dependency_hydration_reuse_report.md
2017
- docs_build/dev/reports/execution_graph_reuse_report.md
@@ -24,18 +21,14 @@
2421
- docs_build/dev/reports/lane_compilation_report.md
2522
- docs_build/dev/reports/lane_deduplication_report.md
2623
- docs_build/dev/reports/lane_input_validation_report.md
27-
- docs_build/dev/reports/lane_manifests/workspace-contract.json
2824
- docs_build/dev/reports/lane_runtime_optimization_report.md
2925
- docs_build/dev/reports/lane_snapshot_report.md
30-
- docs_build/dev/reports/lane_snapshots/workspace-contract.json
3126
- docs_build/dev/reports/lane_warm_start_report.md
32-
- docs_build/dev/reports/lane_warm_starts/workspace-contract.json
3327
- docs_build/dev/reports/monolith_trigger_removal_report.md
3428
- docs_build/dev/reports/persistent_lane_manifest_report.md
3529
- docs_build/dev/reports/playwright_discovery_ownership_report.md
3630
- docs_build/dev/reports/playwright_discovery_scope_report.md
3731
- docs_build/dev/reports/playwright_structure_audit.md
38-
- docs_build/dev/reports/playwright_v8_coverage_report.txt
3932
- docs_build/dev/reports/retry_suppression_report.md
4033
- docs_build/dev/reports/slow_path_pruning_report.md
4134
- docs_build/dev/reports/static_validation_report.md
@@ -45,9 +38,9 @@
4538
- docs_build/dev/reports/testing_lane_execution_report.md
4639
- docs_build/dev/reports/validation_cache_report.md
4740
- docs_build/dev/reports/zero_browser_preflight_report.md
48-
- docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md
49-
- docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md
50-
- docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md
41+
- docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md
42+
- docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md
43+
- docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md
5144
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
5245
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
5346
- toolbox/idea-board/index.html
@@ -56,9 +49,6 @@
5649
## Name Status
5750
- M docs_build/dev/codex_commands.md
5851
- M docs_build/dev/commit_comment.txt
59-
- M docs_build/dev/reports/codex_changed_files.txt
60-
- M docs_build/dev/reports/codex_review.diff
61-
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
6252
- M docs_build/dev/reports/dependency_gating_report.md
6353
- M docs_build/dev/reports/dependency_hydration_reuse_report.md
6454
- M docs_build/dev/reports/execution_graph_reuse_report.md
@@ -68,18 +58,14 @@
6858
- M docs_build/dev/reports/lane_compilation_report.md
6959
- M docs_build/dev/reports/lane_deduplication_report.md
7060
- M docs_build/dev/reports/lane_input_validation_report.md
71-
- M docs_build/dev/reports/lane_manifests/workspace-contract.json
7261
- M docs_build/dev/reports/lane_runtime_optimization_report.md
7362
- M docs_build/dev/reports/lane_snapshot_report.md
74-
- M docs_build/dev/reports/lane_snapshots/workspace-contract.json
7563
- M docs_build/dev/reports/lane_warm_start_report.md
76-
- M docs_build/dev/reports/lane_warm_starts/workspace-contract.json
7764
- M docs_build/dev/reports/monolith_trigger_removal_report.md
7865
- M docs_build/dev/reports/persistent_lane_manifest_report.md
7966
- M docs_build/dev/reports/playwright_discovery_ownership_report.md
8067
- M docs_build/dev/reports/playwright_discovery_scope_report.md
8168
- M docs_build/dev/reports/playwright_structure_audit.md
82-
- M docs_build/dev/reports/playwright_v8_coverage_report.txt
8369
- M docs_build/dev/reports/retry_suppression_report.md
8470
- M docs_build/dev/reports/slow_path_pruning_report.md
8571
- M docs_build/dev/reports/static_validation_report.md
@@ -89,45 +75,43 @@
8975
- M docs_build/dev/reports/testing_lane_execution_report.md
9076
- M docs_build/dev/reports/validation_cache_report.md
9177
- M docs_build/dev/reports/zero_browser_preflight_report.md
92-
- A docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md
93-
- A docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md
94-
- A docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md
78+
- A docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md
79+
- A docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md
80+
- A docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md
9581
- M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
9682
- M tests/playwright/tools/ToolboxRoutePages.spec.mjs
9783
- M toolbox/idea-board/index.html
9884
- M toolbox/idea-board/index.js
9985

10086
## Requirement Evidence
101-
- PASS: Main Idea Board table removes the Owner column.
102-
- PASS: Main table columns are Idea, Pitch, Status, Updated, Notes, Actions.
103-
- PASS: Notes column shows note counts such as `2 Notes` and `0 Notes`.
104-
- PASS: Selected idea expands as `data-idea-board-expanded-row` immediately after its matching `data-idea-board-idea-row`.
105-
- PASS: Detached `Notes for Sky Orchard` section was removed.
106-
- PASS: Visible `Selected idea context` text was removed.
107-
- PASS: Notes subtable no longer shows Type, Created By, Created, or Updated columns.
108-
- PASS: Notes subtable visible columns are Note and Actions.
109-
- PASS: Idea normal rows expose Edit and Delete in the Actions column.
110-
- PASS: Idea edit/add rows expose Save and Cancel.
111-
- PASS: Idea edit Status field is a `select` dropdown.
112-
- PASS: Note normal rows expose Edit and Delete when deletion is allowed.
113-
- PASS: System notes expose Edit and do not expose Delete.
114-
- PASS: Note edit/add rows expose Save and Cancel.
115-
- PASS: Add Idea opens an inline idea row inside the main table.
116-
- PASS: Add Note opens an inline note row inside the selected idea expanded row.
117-
- PASS: The implementation changes runtime HTML/JS and Playwright tests; this is not docs-only work.
118-
- PASS: No detached notes panels were introduced.
119-
- PASS: The primary workflow remains table-first, not form-first.
87+
- PASS: Idea records use DB-shaped fields `ideaId`, `userId`, `idea`, `pitch`, `status`, and `updated` in `toolbox/idea-board/index.js`.
88+
- PASS: Note records use DB-shaped fields `noteId`, `ideaId`, `note`, `system`, and `updated` in `toolbox/idea-board/index.js`.
89+
- PASS: Relationship semantics are represented in-page by `userId` on idea records and `ideaId` on note records.
90+
- PASS: No real DB persistence, adapters, SQLite services, SQLite DDL, or SQLite seed files were added.
91+
- PASS: Default state has `expandedIdeaId: null`, no expanded rows, and the main table shows all ideas only.
92+
- PASS: Add Idea appears as the final table row/action area and opens an inline idea row at the bottom.
93+
- PASS: Visible Idea table columns are Idea, Pitch, Status, Updated, Notes, Actions.
94+
- PASS: Seed rows render Top Thoughts, Sky Orchard, and Clockwork Courier with the requested pitches, statuses, dates, note counts, and Edit/Delete actions.
95+
- PASS: Notes count and chevron buttons expand/collapse notes for that idea.
96+
- PASS: Expanded notes render directly under the owning idea row, and only one expanded idea is required/active at a time.
97+
- PASS: Notes are not selected context; visible selected-idea terminology, `Selected idea context`, and detached `Notes for Sky Orchard` heading were removed.
98+
- PASS: Visible note metadata columns are removed; expanded note table shows only Note and Actions columns.
99+
- PASS: Expanded notes include a `Notes` header.
100+
- PASS: Note rows expose Edit/Delete when allowed; system notes expose Edit and do not expose Delete.
101+
- PASS: Add Note appears under the expanded notes area for that idea.
102+
- PASS: Add/Edit Idea rows use inline controls with a Status dropdown and Save/Cancel actions on the same row.
103+
- PASS: Add/Edit Note rows use inline controls with Save/Cancel actions on the same row inside the expanded notes area.
120104

121105
## Validation
122106
- PASS: `node --check toolbox/idea-board/index.js`.
123107
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
124108
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
125109
- PASS: Idea Board inline HTML guard found no inline `<script>`, `<style>`, `style=`, or inline event handlers.
126-
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed).
127-
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed).
110+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed after correcting a test regex typo).
111+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed after correcting the status assertion order).
128112
- PASS: `npm run test:workspace-v2` (5 passed).
129113
- SKIP: Full samples smoke was not run; samples are not in scope and the user explicitly prohibited full samples smoke.
130114

131115
## ZIP
132-
- Path: `tmp/PR_26171_031-idea-board-inline-tree-grid-actions_delta.zip`.
116+
- Path: `tmp/PR_26171_032-idea-board-accordion-table-model_delta.zip`.
133117
- Size and contents: reported after final ZIP generation.

0 commit comments

Comments
 (0)