Move page template to root, remove tool template, and continue Theme V2 cleanup - PR_26154_007-theme-v2-template-cleanup

Author: ToolboxAid

…heme/v2/templates/_page_template_v2.html _page_template_v2.htmlsrc/engine/theme/v2/templates/_page_template_v2.html renamed to _page_template_v2.html src/engine/theme/v2/templates/_page_template_v2.html renamed to _page_template_v2.html

@@ -1,34 +1,30 @@
 # Codex Commands
 
-Task: PR_26154_006-theme-v2-asset-ownership-normalization
+Task: PR_26154_007-theme-v2-template-cleanup
 
 Commands run:
 
 - `Get-Content .codex/skills/repo-build/SKILL.md`
 - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
 - `git status --short --untracked-files=all`
-- Targeted `Get-Content`, `rg`, `Get-ChildItem`, and `git diff` reads for Theme V2 image ownership, `tool-display-mode.js`, affected pages/templates/tools, and report state.
-- Node migration script to copy the engine-owned Theme V2 image tree to `assets/theme/v2/images/`, verify file parity, remove the former source image folder, and remove the temporary nested public image folder.
-- Node rewrite script to update active text references to `assets/theme/v2/images/` while excluding protected `start_of_day/`, deprecated sample/game folders, generated review artifacts, and `tmp/`.
-- `node --check src/engine/theme/v2/assets/js/tool-display-mode.js`
-- Targeted public asset checks for:
-  - `assets/theme/v2/images/badges/index.png`
-  - `assets/theme/v2/images/characters/index.png`
-- Targeted reference checks for the former engine-owned image folder, the temporary nested public image folder, and the canonical public image root.
+- Targeted `Get-Content`, `rg`, and `Get-ChildItem` reads for the Theme V2 templates, template references, and remaining Theme V2 asset surface.
+- Node file operation script to move the page template to `/_page_template_v2.html`, remove the retired tool template, and delete the empty template folder.
+- Node reference cleanup script for historical report references to the old template folder and retired tool template.
+- Root template browser/HTTP validation found the header logo still resolving through the old partial-local image convention; patched `src/engine/theme/v2/assets/partials/header-nav.html` to use the public Theme V2 image root.
+- Targeted reference checks for the old template folder, the retired tool template filename, and the root page template filename.
 - Static validation for changed HTML, JS, CSS, and Markdown files.
-- Local browser validation of `tools/_templates-v2/index.html` with request status capture for both display-mode image requests.
 - `git diff --check`
 - `npm run codex:review-artifacts`
-- Python ZIP packaging for `tmp/PR_26154_006-theme-v2-asset-ownership-normalization_delta.zip`
+- Python ZIP packaging for `tmp/PR_26154_007-theme-v2-template-cleanup_delta.zip`
 
 Validation summary:
 
-- PASS `node --check src/engine/theme/v2/assets/js/tool-display-mode.js`.
-- PASS public asset checks for `badges/index.png` and `characters/index.png`.
-- PASS zero-reference checks for the former engine-owned image folder and temporary nested public image folder, excluding protected/generated paths.
-- PASS canonical public image root exists with 111 files.
-- PASS local browser validation: `/assets/theme/v2/images/badges/index.png` and `/assets/theme/v2/images/characters/index.png` both returned `200`.
+- PASS root page template exists at `/_page_template_v2.html`.
+- PASS root page template browser/HTTP check: page, Theme V2 CSS modules, partials, placeholder image, and logo all returned `200`.
+- PASS old template folder was removed.
+- PASS retired tool template file was removed.
+- PASS zero-reference checks for the old template folder and retired tool template filename, excluding protected/generated paths.
 - PASS static validation for changed HTML, JS, CSS, and Markdown files.
 - PASS `git diff --check`.
-- SKIPPED `npm run test:workspace-v2`; image ownership/pathing changed, tool launch/navigation behavior did not.
+- SKIPPED `npm run test:workspace-v2`; template location/report cleanup changed, active tool launch/navigation behavior did not.
 - SKIPPED old_games, old_samples, and full samples smoke validation per request.

docs_build/dev/codex_commands.md

@@ -1,7 +1,8 @@
-Theme V2 asset ownership normalization - PR_26154_006-theme-v2-asset-ownership-normalization
+Theme V2 template cleanup - PR_26154_007-theme-v2-template-cleanup
 
-- Move Theme V2 image content into the public canonical image root at `assets/theme/v2/images/`.
-- Remove the former engine-owned image folder and temporary nested public image folder after path rewiring.
-- Update `tool-display-mode.js`, templates, public/root pages, tool pages, and tool index scripts to resolve public images from `assets/theme/v2/images/`.
-- Keep `src/engine/theme/v2/` in place for remaining CSS, JS, partial, template, and placeholder assets.
-- Validate changed static files, targeted references, browser image request statuses, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
+- Move the Theme V2 page template to the repository root as `/_page_template_v2.html`.
+- Delete the retired Theme V2 tool template and remove the empty old template folder.
+- Normalize historical report references to the old template location and retired tool template.
+- Fix the shared header partial logo path so the relocated root page template resolves cleanly.
+- Inventory remaining files under `src/engine/theme/v2/`, classify ownership, and recommend next cleanup moves.
+- Validate targeted template references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.

docs_build/dev/commit_comment.txt

@@ -29,7 +29,7 @@ Updated affected public/root pages, tool pages, templates, and scripts so image
 Notable runtime/helper updates:
 
 - `src/engine/theme/v2/assets/js/tool-display-mode.js` uses `/assets/theme/v2/images` as its badge and character root.
-- `src/engine/theme/v2/templates/_tool_template_v2.html` and `tools/_templates-v2/index.html` use `data-asset-root="assets/theme/v2/images"`.
+- `retired Theme V2 tool template` and `tools/_templates-v2/index.html` use `data-asset-root="assets/theme/v2/images"`.
 - `tools/tools-page-accordions.js` points generated tool-card and badge images at `../assets/theme/v2/images/...`.
 
 No layout, CSS, ToolDisplayMode behavior, Storage Inspector runtime, or unrelated tool implementation work was changed.
@@ -53,7 +53,7 @@ Remaining `assets/` surface:
 Remaining template surface:
 
 - `_page_template_v2.html`
-- `_tool_template_v2.html`
+- `retired Theme V2 tool template`
 
 The folder was not deleted because these Theme V2 CSS, JS, partial, template, and placeholder files remain active.
 

docs_build/dev/reports/theme_v2_asset_ownership_normalization_report.md

@@ -206,13 +206,13 @@ Task: PR_26152_278-theme-v2-asset-ssot-inventory
 - `src` -> `../assets/js/gamefoundry-partials.js`
 - `src` -> `../assets/js/tool-display-mode.js`
 
-### `src/engine/theme/v2/templates/_page_template_v2.html`
+### `/_page_template_v2.html`
 - `href` -> `assets/images/favicon.svg`
 - `href` -> `assets/css/theme/v2/theme.css`
 - `src` -> `assets/js/gamefoundry-partials.js`
 - `base` -> `../../../../../GameFoundryStudio/`
 
-### `src/engine/theme/v2/templates/_tool_template_v2.html`
+### `retired Theme V2 tool template`
 - `href` -> `assets/images/favicon.svg`
 - `href` -> `assets/css/theme/v2/theme.css`
 - `src` -> `assets/js/gamefoundry-partials.js`

docs_build/dev/reports/theme_v2_asset_ssot_inventory.md

@@ -65,8 +65,8 @@ Task: PR_26152_280-theme-v2-reference-rewire
 - `GameFoundryStudio/tools/publisher.html`
 - `GameFoundryStudio/tools/world-vector-studio.html`
 - `GameFoundryStudio/tools.html`
-- `src/engine/theme/v2/templates/_page_template_v2.html`
-- `src/engine/theme/v2/templates/_tool_template_v2.html`
+- `/_page_template_v2.html`
+- `retired Theme V2 tool template`
 - `tools/tools-page-accordions.js`
 
 ## Runtime Helper Adjustments

docs_build/dev/reports/theme_v2_reference_rewire.md

@@ -0,0 +1,75 @@
+# PR_26154_007 Theme V2 Remaining Inventory Report
+
+## Summary
+
+Audited the remaining `src/engine/theme/v2/` surface after template cleanup.
+
+The folder still contains active public/root Theme V2 CSS, JS, partials, and one placeholder asset. No files under this folder are classified as runtime engine ownership for this PR; runtime engine styling remains outside this folder under `src/engine/theme/`.
+
+## Remaining Folders
+
+- `src/engine/theme/v2/assets/`
+- `src/engine/theme/v2/assets/css/`
+- `src/engine/theme/v2/assets/css/theme/v2/`
+- `src/engine/theme/v2/assets/css/tools/grouping/`
+- `src/engine/theme/v2/assets/js/`
+- `src/engine/theme/v2/assets/partials/`
+
+The old templates folder no longer exists.
+
+## File Classification
+
+| File | Classification | Notes |
+|---|---|---|
+| `assets/css/theme/v2/accordion.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/buttons.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/colors.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/controls.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/dialogs.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/forms.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/layout.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/panels.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/spacing.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/status.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/tables.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/theme/v2/theme.css` | public asset ownership | Active Theme V2 CSS entrypoint. |
+| `assets/css/theme/v2/typography.css` | public asset ownership | Active approved Theme V2 CSS module. |
+| `assets/css/base.css` | public asset ownership | Active legacy public CSS wrapper module imported by `styles.css`; recommend consolidation into approved Theme V2 modules. |
+| `assets/css/colors.css` | public asset ownership | Active legacy public color token module imported by `styles.css`; overlaps newer Theme V2 color ownership. |
+| `assets/css/controls.css` | public asset ownership | Active legacy public controls module imported by `styles.css`; recommend consolidation into approved Theme V2 controls/forms modules. |
+| `assets/css/gamefoundrystudio.css` | public asset ownership | Active public component/pattern module imported by `styles.css`; outside approved module path. |
+| `assets/css/pages.css` | public asset ownership | Active public page layout module imported by `styles.css`; recommend consolidation or explicit public ownership decision. |
+| `assets/css/styles.css` | public asset ownership | Active public CSS aggregator consumed by pages/tools. |
+| `assets/css/tokens.css` | public asset ownership | Active legacy public token module imported by `styles.css`; overlaps newer Theme V2 token/module ownership. |
+| `assets/css/tools.css` | public asset ownership | Active public tool-shell CSS module imported by `styles.css`; recommend review against shared runtime shell boundaries before moving. |
+| `assets/css/tools/grouping/ai-learning.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/build-create.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/community-marketplace.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/content-assets.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/development-system.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/media-audio.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/platform-cloud.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/css/tools/grouping/play.css` | public asset ownership | Active public tool grouping color module imported by `styles.css`. |
+| `assets/js/account-controls.js` | public asset ownership | Active public admin controls page helper. |
+| `assets/js/gamefoundry-partials.js` | public asset ownership | Active public header/footer partial loader and route mapper. |
+| `assets/js/tool-display-mode.js` | public asset ownership | Active public/root tool display-mode helper. |
+| `assets/js/tools-page-accordions.js` | public asset ownership | Active public tools index accordion helper. |
+| `assets/partials/footer.html` | public asset ownership | Active public footer partial loaded by `gamefoundry-partials.js`. |
+| `assets/partials/header-nav.html` | public asset ownership | Active public header/nav partial loaded by `gamefoundry-partials.js`; logo image now resolves from the public Theme V2 image root. |
+| `assets/image-missing.svg` | public asset ownership | Active placeholder asset used by the root page template and tool template baseline. Recommend moving to the public Theme V2 image root in a later asset cleanup PR. |
+| `assets/partials/page-shell.html` | obsolete/deprecated | Shell stub exists, but no active partial loader mapping or page reference was found. |
+| `assets/partials/tool-shell.html` | obsolete/deprecated | Shell stub exists, but no active partial loader mapping or page reference was found. |
+
+## Runtime Engine Ownership
+
+No remaining file under `src/engine/theme/v2/` was classified as runtime engine ownership in this PR.
+
+Runtime engine styling remains under `src/engine/theme/`, including the shared engine/runtime shell styling called out by project governance. This PR did not move or modify that runtime engine surface.
+
+## Recommended Next Moves
+
+1. Decide whether public Theme V2 CSS/JS/partials should remain served from `src/engine/theme/v2/assets/` or move to a public asset root in a dedicated ownership PR.
+2. If public asset ownership moves, migrate active public files as a unit: CSS entrypoints/modules, public JS helpers, header/footer partials, and `image-missing.svg`.
+3. Consolidate active legacy wrapper CSS modules into the approved Theme V2 module set instead of keeping parallel top-level CSS ownership indefinitely.
+4. Remove or explicitly revive the unused page/tool shell partial stubs in a separate PR after confirming no planned consumer needs them.
+5. Keep runtime engine shell styling under `src/engine/theme/` until a shared shell contract is approved.

docs_build/dev/reports/theme_v2_remaining_inventory_report.md

@@ -0,0 +1,68 @@
+# PR_26154_007 Theme V2 Template Cleanup Report
+
+## Summary
+
+Completed the focused Theme V2 template cleanup.
+
+- Moved the Theme V2 page template to the repository root as `/_page_template_v2.html`.
+- Deleted the retired Theme V2 tool template.
+- Removed the old Theme V2 templates folder after it became empty.
+- Updated historical report references that still pointed to the old template folder or retired tool template.
+- Updated the shared header partial logo path to the canonical public Theme V2 image root so the relocated root page template loads without a logo 404.
+- Did not move Theme V2 runtime/public helper code.
+- Did not modify `start_of_day/`.
+- Did not expand into tool implementation work.
+
+## Template Path Changes
+
+Moved:
+
+- Theme V2 page template from the old template folder -> `/_page_template_v2.html`
+
+Deleted:
+
+- retired Theme V2 tool template
+- empty Theme V2 templates folder
+
+## Reference Audit
+
+Audited references for:
+
+- the old Theme V2 templates folder
+- the root page template filename
+- the retired tool template filename
+
+Results:
+
+- No references remain to the old Theme V2 templates folder, excluding generated review artifacts and `tmp/`.
+- No references remain to the retired tool template filename, excluding generated review artifacts and `tmp/`.
+- The page template resolves at the repository root as `/_page_template_v2.html`.
+- Historical report references were normalized to point to the root page template or to describe the retired tool template without preserving stale paths.
+
+Files with historical reference cleanup:
+
+- `docs_build/dev/reports/theme_v2_asset_ownership_normalization_report.md`
+- `docs_build/dev/reports/theme_v2_asset_ssot_inventory.md`
+- `docs_build/dev/reports/theme_v2_reference_rewire.md`
+- `docs_build/dev/reports/theme_v2_template_correction.md`
+- `docs_build/dev/reports/theme_v2_template_dependency_map.md`
+- `docs_build/dev/reports/theme_v2_template_foundation.md`
+- `docs_build/dev/reports/tool_template_display_mode_layout.md`
+
+## Validation
+
+Passed:
+
+- targeted template-path reference checks
+- root page template path existence check
+- root page template browser/HTTP check with page, CSS modules, partials, placeholder image, and logo all returning `200`
+- changed-file static validation for HTML, JS, CSS, and Markdown files
+- `git diff --check`
+- review artifact generation
+- repo-structured delta ZIP packaging
+
+Skipped by scope:
+
+- `npm run test:workspace-v2`, unless active tool launch/navigation behavior changes
+- tests against `old_games` or `old_samples`
+- full samples smoke test

docs_build/dev/reports/theme_v2_template_cleanup_report.md

@@ -2,8 +2,8 @@
 
 ## Scope
 
-- Corrected `src/engine/theme/v2/templates/_tool_template_v2.html`.
-- Corrected `src/engine/theme/v2/templates/_page_template_v2.html`.
+- Corrected `retired Theme V2 tool template`.
+- Corrected `/_page_template_v2.html`.
 - Removed standalone/demo-looking header and footer markup from both templates.
 - Rewired both templates to the shared reusable page chrome pattern.
 - Kept Storage Inspector, samples, and all tools untouched.

docs_build/dev/reports/theme_v2_template_correction.md

@@ -4,9 +4,9 @@
 
 | Dependency | Used By | Purpose | Status |
 |---|---|---|---|
-| `GameFoundryStudio/assets/partials/header-nav.html` | `_tool_template_v2.html`, `_page_template_v2.html` | Shared Theme V2 header and navigation chrome | Existing |
-| `GameFoundryStudio/assets/partials/footer.html` | `_tool_template_v2.html`, `_page_template_v2.html` | Shared Theme V2 footer chrome | Existing |
-| `GameFoundryStudio/assets/js/gamefoundry-partials.js` | `_tool_template_v2.html`, `_page_template_v2.html` | Existing shared partial loader for header/footer | Existing |
+| `GameFoundryStudio/assets/partials/header-nav.html` | `retired Theme V2 tool template`, `_page_template_v2.html` | Shared Theme V2 header and navigation chrome | Existing |
+| `GameFoundryStudio/assets/partials/footer.html` | `retired Theme V2 tool template`, `_page_template_v2.html` | Shared Theme V2 footer chrome | Existing |
+| `GameFoundryStudio/assets/js/gamefoundry-partials.js` | `retired Theme V2 tool template`, `_page_template_v2.html` | Existing shared partial loader for header/footer | Existing |
 
 ## Theme V2 Style Dependencies