Skip to content

Commit 0c35f32

Browse files
authored
PR_26171_041 polish Idea Board production behavior
Move Idea Board project actions into rows, add archived filtering, and clean creator-facing copy.
1 parent 0a364f8 commit 0c35f32

11 files changed

Lines changed: 1334 additions & 352 deletions

File tree

assets/theme-v2/css/tables.css

Lines changed: 68 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,67 @@ td {
3838
color: var(--text)
3939
}
4040

41+
.idea-board-table-caption {
42+
position: relative;
43+
z-index: var(--z-index-sm);
44+
display: flex;
45+
align-items: center;
46+
justify-content: space-between;
47+
gap: var(--space-10);
48+
padding: var(--space-10);
49+
font-weight: var(--font-weight-heavy)
50+
}
51+
52+
.idea-board-show-filter {
53+
position: relative;
54+
z-index: var(--z-index-md);
55+
color: var(--text);
56+
font-size: var(--font-size-xs);
57+
font-weight: var(--font-weight-bold)
58+
}
59+
60+
.idea-board-show-filter summary {
61+
display: inline-flex;
62+
align-items: center;
63+
min-height: var(--space-28);
64+
padding: var(--space-3) var(--space-10);
65+
border: var(--border-standard);
66+
border-radius: var(--radius-md);
67+
background: var(--panel-soft);
68+
cursor: pointer;
69+
list-style: none
70+
}
71+
72+
.idea-board-show-filter summary::-webkit-details-marker {
73+
display: none
74+
}
75+
76+
.idea-board-show-filter__menu {
77+
position: static;
78+
min-width: 12rem;
79+
margin-top: var(--space-6);
80+
padding: var(--space-10);
81+
border: var(--border-standard);
82+
border-radius: var(--radius-md);
83+
background: var(--panel);
84+
box-shadow: var(--shadow-md)
85+
}
86+
87+
.idea-board-show-filter__options {
88+
display: grid;
89+
gap: var(--space-6);
90+
margin-top: var(--space-10)
91+
}
92+
93+
.idea-board-show-filter__option {
94+
display: flex;
95+
align-items: center;
96+
gap: var(--space-8);
97+
color: var(--text);
98+
font-weight: var(--font-weight-regular);
99+
white-space: nowrap
100+
}
101+
41102
.data-table th {
42103
color: var(--gold);
43104
font-size: var(--font-size-sm);
@@ -60,8 +121,13 @@ td {
60121
gap: .35em;
61122
color: inherit;
62123
font: inherit;
63-
line-height: inherit;
64-
vertical-align: baseline
124+
line-height: var(--line-height-single);
125+
vertical-align: baseline;
126+
white-space: nowrap
127+
}
128+
129+
.idea-board-idea-label__text {
130+
line-height: var(--line-height-single)
65131
}
66132

67133
.idea-board-idea-chevron {

assets/theme-v2/js/tool-display-mode.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
const diagnostic = document.createElement("p");
158158
diagnostic.className = "status";
159159
diagnostic.setAttribute("role", "status");
160-
diagnostic.textContent = "Tool navigation could not load from the server API. Start the local server API and refresh.";
160+
diagnostic.textContent = "Tool navigation is temporarily unavailable. Refresh the page or try again shortly.";
161161
body.appendChild(diagnostic);
162162
}
163163
}
Lines changed: 82 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,91 @@
1-
# Codex Changed Files - PR_26171_063-codex-instruction-enforcement-hardening
1+
# Codex Changed Files - PR_26171_041-idea-board-production-polish
22

3-
## Conflict Resolution Note
4-
- Merged latest `origin/main` into the PR branch after GitHub reported merge conflicts.
5-
- Regenerated Codex artifacts from the PR_063 delta against updated `origin/main`.
6-
- No implementation scope was changed while resolving conflicts.
3+
## Git Workflow
4+
- Current branch: `codex/pr-26171-041-idea-board-production-polish`.
5+
- Expected starting branch: `main` (PASS before branch creation).
6+
- Created branch: `codex/pr-26171-041-idea-board-production-polish`.
7+
- Commit before conflict resolution: `ca626873a4cf19925229851b0da2a4ff55c2073f`.
8+
- Initial push result: PASS, branch pushed to `origin/codex/pr-26171-041-idea-board-production-polish`.
9+
- PR URL: `https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/17`.
10+
- Conflict resolution: merged `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`; conflicts were limited to `codex_changed_files.txt` and `codex_review.diff`.
11+
- Conflict resolution push result: pending until after merge-validation commit.
12+
- Merge result: pending until after PR validation/merge.
13+
- Final main sync: pending until after merge and final pull.
714

8-
## Changed Files
9-
- docs_build/dev/PROJECT_INSTRUCTIONS.md
10-
- docs_build/dev/PROJECT_MULTI_PC.txt
11-
- docs_build/dev/reports/PR_26171_063-codex-instruction-enforcement-hardening.md
12-
- docs_build/dev/reports/PR_26171_063-instruction-compliance-checklist.md
13-
- docs_build/dev/reports/PR_26171_063-validation.md
14-
- docs_build/dev/reports/PR_26171_063-manual-validation-notes.md
15-
- docs_build/dev/reports/codex_review.diff
16-
- docs_build/dev/reports/codex_changed_files.txt
15+
## Git Status
16+
```text
17+
M assets/theme-v2/css/tables.css
18+
M assets/theme-v2/js/tool-display-mode.js
19+
M docs_build/dev/reports/codex_changed_files.txt
20+
M docs_build/dev/reports/codex_review.diff
21+
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
22+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
23+
M src/shared/toolbox/tool-metadata-inventory.js
24+
M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
25+
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
26+
M toolbox/idea-board/index.html
27+
M toolbox/idea-board/index.js
28+
```
1729

18-
## Git Diff Stat Against Updated origin/main
30+
## Diff Stat
1931
```text
20-
docs_build/dev/PROJECT_INSTRUCTIONS.md | 47 ++
21-
docs_build/dev/PROJECT_MULTI_PC.txt | 58 ++
22-
..._063-codex-instruction-enforcement-hardening.md | 48 ++
23-
...R_26171_063-instruction-compliance-checklist.md | 37 ++
24-
.../PR_26171_063-manual-validation-notes.md | 19 +
25-
docs_build/dev/reports/PR_26171_063-validation.md | 32 +
26-
docs_build/dev/reports/codex_changed_files.txt | 48 ++
27-
docs_build/dev/reports/codex_review.diff | 699 +++++++++------------
28-
8 files changed, 569 insertions(+), 419 deletions(-)
32+
assets/theme-v2/css/tables.css | 70 +++++++-
33+
assets/theme-v2/js/tool-display-mode.js | 2 +-
34+
.../dev/reports/coverage_changed_js_guardrail.txt | 5 +-
35+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
36+
src/shared/toolbox/tool-metadata-inventory.js | 6 +-
37+
.../playwright/tools/IdeaBoardTableNotes.spec.mjs | 71 +++++++-
38+
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 26 ++-
39+
toolbox/idea-board/index.html | 31 ++--
40+
toolbox/idea-board/index.js | 191 ++++++++++++++++++++-
41+
9 files changed, 368 insertions(+), 45 deletions(-)
2942
```
3043

44+
## Requirement Evidence
45+
- PASS: Removed creator-visible Create Project from the right-side Next Steps area; no disabled `data-idea-board-create-project` panel remains.
46+
- PASS: Create Project is shown only in a Ready idea row's Actions column.
47+
- PASS: Clicking Create Project changes the idea status from Ready to Project and replaces Create Project/Delete with Open Project and Archive.
48+
- PASS: Project rows show Open Project and Archive and do not show Delete.
49+
- PASS: Added Archived status; archived rows are hidden by default.
50+
- PASS: Archived rows show Restore and Delete.
51+
- PASS: Restore returns archived ideas to their previous non-archived status, with Refining fallback in runtime.
52+
- PASS: Delete is guarded so Project ideas cannot be deleted unless archived first.
53+
- PASS: Status dropdown uses New, Exploring, Refining, Ready, Project, and Archived.
54+
- PASS: Added compact Show checkbox dropdown beside the visible table description line, with default statuses New, Exploring, Refining, Ready, and Project selected and Archived unselected.
55+
- PASS: Show dropdown supports any checkbox combination plus Select All and Clear All.
56+
- PASS: Updated creator-facing copy to "Capture, compare, and shape game ideas." and "Scan, compare, and update early ideas."
57+
- PASS: Replaced creator-visible Tool Display Mode navigation error with safe copy that does not mention server/API/local server/port/implementation details.
58+
- PASS: Chevron renders to the left of the Idea text, inline, same size, same color, and on the same text line; the whole Idea cell remains the expansion target.
59+
- PASS: Notes count remains informational only.
60+
- PASS: Table-first structure, inline Add Idea/Add Note, row-level Save/Cancel, status dropdown edit mode, notes indentation, and single-open accordion behavior remain covered.
61+
3162
## Validation
32-
- PASS: `git diff --check` after conflict resolution.
33-
- PASS: targeted required instruction-anchor validation after conflict resolution.
34-
- SKIP: Playwright, because the PR explicitly requires no Playwright and changes docs/workflow only.
63+
- PASS: `node --check toolbox/idea-board/index.js`.
64+
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`.
65+
- PASS: `node --check src/shared/toolbox/tool-metadata-inventory.js`.
66+
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
67+
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
68+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000`.
69+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000`.
70+
- PASS: `npm run test:workspace-v2` (workspace-contract lane, 5 passed).
71+
- PASS: `git diff --check`.
72+
- PASS: Post-conflict rerun completed after merging `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`.
73+
- PASS: Playwright V8 coverage report produced because runtime JavaScript changed.
74+
- WARN: Coverage report marks `src/shared/toolbox/tool-metadata-inventory.js` as not collected by browser V8 coverage; advisory only per project instructions.
75+
- SKIPPED: Full samples smoke was not run per request.
3576

3677
## ZIP
37-
- Path: `tmp/PR_26171_063-codex-instruction-enforcement-hardening_delta.zip`.
78+
- Path: `tmp/PR_26171_041-idea-board-production-polish_delta.zip`.
79+
- Size: final size reported in the delivery summary after conflict-resolution ZIP refresh.
80+
- Contents:
81+
- assets/theme-v2/css/tables.css
82+
- assets/theme-v2/js/tool-display-mode.js
83+
- docs_build/dev/reports/codex_changed_files.txt
84+
- docs_build/dev/reports/codex_review.diff
85+
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
86+
- docs_build/dev/reports/playwright_v8_coverage_report.txt
87+
- src/shared/toolbox/tool-metadata-inventory.js
88+
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
89+
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
90+
- toolbox/idea-board/index.html
91+
- toolbox/idea-board/index.js

0 commit comments

Comments
 (0)