Skip to content

Commit 0da5561

Browse files
committed
Establish theme v2 governance and migration rules for GameFoundryStudio - PR_26152_021-theme-v2-css-governance
1 parent af360f0 commit 0da5561

2 files changed

Lines changed: 96 additions & 0 deletions

File tree

docs/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,57 @@ Use that phrase as a compact IA and copywriting anchor:
145145
- Play: playable games, arcade browsing, testing, saves, and discovery.
146146
- Share: marketplace assets, tutorials, community visibility, publishing, and creator identity.
147147

148+
## GAMEFOUNDRYSTUDIO THEME V2 GOVERNANCE
149+
150+
`theme/v2` is the only approved styling surface for new GameFoundryStudio work.
151+
152+
Existing CSS is deprecated and compatibility-only.
153+
154+
Rules:
155+
- Do not extend deprecated CSS.
156+
- Do not create new CSS files outside `theme/v2`.
157+
- No page-local CSS.
158+
- No tool-local CSS.
159+
- No inline style attributes.
160+
- No `<style>` blocks.
161+
- No JavaScript-generated styling except toggling approved `theme/v2` classes.
162+
- No hardcoded colors.
163+
- No hardcoded spacing.
164+
- No hardcoded borders.
165+
- No hardcoded shadows.
166+
- No hardcoded font sizes.
167+
- No hardcoded z-index values.
168+
- No duplicate component styling.
169+
- No copy/paste of deprecated selectors into `theme/v2`.
170+
- No one-off classes for a single page or tool unless approved and promoted into `theme/v2`.
171+
- New UI work must first attempt to use existing `theme/v2` tokens and classes.
172+
- Missing styling requirements must be reported as design-system gaps.
173+
- Design-system gaps should be documented rather than solved locally.
174+
175+
Allowed:
176+
- Adding reusable `theme/v2` tokens.
177+
- Adding reusable `theme/v2` component classes.
178+
- Toggling approved `theme/v2` classes from JavaScript.
179+
- Removing deprecated CSS.
180+
- Consolidating duplicate CSS into `theme/v2`.
181+
182+
Exception documentation is required for any approved deviation and must include:
183+
- File.
184+
- Reason.
185+
- Follow-up plan.
186+
187+
Migration order:
188+
1. Home
189+
2. Company pages
190+
3. Admin pages
191+
4. Account pages
192+
5. Tools index
193+
6. Tool families
194+
7. Games
195+
8. Samples
196+
197+
Do not migrate pages during governance-only PRs unless the PR explicitly authorizes migration work.
198+
148199
## FILE SCOPE GUARD
149200

150201
Allowed change scope is PR-specific.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# Theme V2 Governance Validation
2+
3+
Task: PR_26152_021-theme-v2-css-governance
4+
5+
Scope:
6+
- Governance documentation only.
7+
- No GameFoundryStudio page migration.
8+
- No runtime, CSS, HTML, or JavaScript behavior changes.
9+
10+
Changed files:
11+
- `docs/dev/PROJECT_INSTRUCTIONS.md`
12+
- `docs/dev/reports/theme_v2_governance_validation.md`
13+
- `docs/dev/reports/codex_changed_files.txt`
14+
- `docs/dev/reports/codex_review.diff`
15+
- `docs/dev/commit_comment.txt`
16+
17+
Validation performed:
18+
- Ran `git diff --check -- docs/dev/PROJECT_INSTRUCTIONS.md`.
19+
- Result: Passed.
20+
- Note: Git reported a line-ending normalization warning only.
21+
- Ran targeted documentation validation for `docs/dev/PROJECT_INSTRUCTIONS.md`.
22+
- Verified the Theme V2 Governance section exists exactly once.
23+
- Verified `theme/v2` is documented as the only approved styling surface for new GameFoundryStudio work.
24+
- Verified deprecated CSS is documented as compatibility-only.
25+
- Verified no page-local CSS and no tool-local CSS rules exist.
26+
- Verified inline style, `<style>` block, JavaScript-generated styling, hardcoded values, duplicate styling, and deprecated selector copy/paste restrictions exist.
27+
- Verified allowed Theme V2 token, component, class toggling, deprecated CSS removal, and consolidation guidance exists.
28+
- Verified exception documentation requires file, reason, and follow-up plan.
29+
- Verified migration order exists:
30+
1. Home
31+
2. Company pages
32+
3. Admin pages
33+
4. Account pages
34+
5. Tools index
35+
6. Tool families
36+
7. Games
37+
8. Samples
38+
39+
Explicitly not run:
40+
- No repo-wide tests.
41+
- No tests outside GameFoundryStudio.
42+
- No full samples smoke test.
43+
- No runtime tests because this PR is governance-only documentation.
44+
45+
Result: Passed.

0 commit comments

Comments
 (0)