Skip to content

Commit 0f2d6ac

Browse files
ToolboxAidToolboxAid
committed
Continue PR_26163_081-assets-upload-progress-auto-hide. Include diagnostics-accordion evidence, status-log-clear evidence, upload-hide evidence, failure-retains-details evidence, impacted lanes, skipped lanes, samples SKIP reason, Playwright PASS/FAIL, and requirement-by-requirement PASS evidence.
1 parent 23e81c3 commit 0f2d6ac

34 files changed

Lines changed: 1280 additions & 3768 deletions

‎docs_build/dev/reports/PR_26163_081-assets-upload-progress-auto-hide.md‎

Lines changed: 124 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,124 @@
1+
# PR_26163_081-assets-upload-progress-auto-hide
2+
3+
## Branch Validation
4+
5+
- PASS: Current branch is `main`.
6+
- Expected branch: `main`.
7+
8+
## Requirement Checklist
9+
10+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before execution.
11+
- PASS: Upload Diagnostics now lives in its own vertical accordion in the right Inspector column.
12+
- PASS: Upload Diagnostics appears above Status Log. Playwright validates the accordion vertical position.
13+
- PASS: Inline upload progress remains under the relevant asset table while an upload is active.
14+
- PASS: After an all-OK upload completes, verbose progress/details are hidden and a compact summary remains in Upload Diagnostics.
15+
- PASS: User-facing upload file results table removes the Message column.
16+
- PASS: User-facing upload file results table shows only `File` and `Status`.
17+
- PASS: Long write-path/debug messages are not rendered in the user-facing file results table.
18+
- PASS: Verbose write-path/debug details remain out of page UI and are preserved only through diagnostics/report evidence.
19+
- PASS: Status Log has a Clear button.
20+
- PASS: Clear clears only user-facing Status Log and batch log content.
21+
- PASS: Clear does not delete asset records, upload diagnostics, uploaded files, or reports.
22+
- PASS: All-OK upload hides verbose progress/details after completion and leaves compact success status.
23+
- PASS: FAIL/WARN/SKIP details remain visible through concise upload issue rows without a long debug Message column.
24+
- PASS: Delete-file behavior from PR_26163_080 remains covered by targeted Assets Playwright.
25+
- PASS: Server-received byte progress and one-second update behavior from PR_26163_080 remain covered by targeted Assets Playwright.
26+
- PASS: Duplicate blocking remains covered by targeted Assets Playwright.
27+
- PASS: `/projects/` path safety remains covered by targeted Assets Playwright.
28+
- PASS: `codex_review.diff` is generated as readable UTF-8 text.
29+
30+
## Diagnostics Accordion Evidence
31+
32+
- `toolbox/assets/index.html` adds `data-asset-tool-upload-diagnostics-accordion` as a right-column vertical accordion.
33+
- `toolbox/assets/index.html` places Upload Diagnostics before `data-asset-tool-status-log-accordion`.
34+
- `tests/playwright/tools/AssetToolMockRepository.spec.mjs` validates Upload Diagnostics appears above Status Log using rendered bounding boxes.
35+
36+
## Status Log Clear Evidence
37+
38+
- `toolbox/assets/index.html` adds `data-asset-tool-clear-status-log`.
39+
- `toolbox/assets/assets.js` wires Clear to empty `data-asset-tool-log` and `data-asset-tool-batch-log` only.
40+
- Playwright validates Clear leaves Upload Diagnostics visible and leaves uploaded asset rows intact.
41+
42+
## Upload Auto-Hide Evidence
43+
44+
- `toolbox/assets/assets.js` hides `data-asset-tool-upload-progress-details` when upload phase is `Complete`.
45+
- `toolbox/assets/assets.js` keeps `data-asset-tool-upload-compact-status` populated with the final summary.
46+
- Inline upload progress is populated with final values and hidden after completion.
47+
- Playwright validates all-OK upload leaves `Upload summary: 2 written, 0 failed, 0 skipped, 0 warnings.` and hides verbose progress/details.
48+
49+
## Failure Detail Evidence
50+
51+
- `toolbox/assets/assets.js` renders concise issue rows in `data-asset-tool-upload-issues` for WARN/FAIL/SKIP.
52+
- File status rows render only file name and status.
53+
- Playwright validates duplicate, path escape, missing project, unsupported write, invalid type, warning, and skip cases remain visible without `projects/` debug paths in the user-facing file status table.
54+
55+
## Changed Files
56+
57+
- `toolbox/assets/index.html`
58+
- `toolbox/assets/assets.js`
59+
- `tests/playwright/tools/AssetToolMockRepository.spec.mjs`
60+
- Workspace validation reports refreshed by required `npm run test:workspace-v2`
61+
- `docs_build/dev/reports/PR_26163_081-assets-upload-progress-auto-hide.md`
62+
- `docs_build/dev/reports/codex_review.diff`
63+
- `docs_build/dev/reports/codex_changed_files.txt`
64+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
65+
66+
## Impacted Lanes
67+
68+
- Toolbox Assets runtime/UI lane.
69+
- Assets mock repository Playwright lane.
70+
- Workspace V2 validation command was run because it is explicitly required by the PR request.
71+
72+
## Skipped Lanes
73+
74+
- Full samples smoke: SKIP. Samples are not in scope, no sample JSON was changed, and the request explicitly says not to run full samples smoke.
75+
- Engine runtime: SKIP. No engine runtime files were changed.
76+
- Auth/account runtime: SKIP. Account prompt behavior was preserved; no account/auth code was changed.
77+
78+
## Validation Performed
79+
80+
- PASS: `git branch --show-current`
81+
- PASS: `node --check toolbox/assets/assets.js`
82+
- PASS: `node --check toolbox/assets/assets-upload-worker.js`
83+
- PASS: `node --check src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`
84+
- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
85+
- PASS: `git diff --check -- toolbox/assets/assets.js toolbox/assets/index.html src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js tests/playwright/tools/AssetToolMockRepository.spec.mjs`
86+
- Note: Git reported expected CRLF normalization warnings for touched HTML/spec files.
87+
- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list`
88+
- Result: 15 passed.
89+
- PASS: `npm run test:workspace-v2`
90+
- Result: Workspace contract validation passed, 5 tests passed.
91+
- PASS: V8 coverage report generated at `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
92+
93+
## Playwright Result
94+
95+
- PASS: Targeted Assets Playwright passed.
96+
- PASS: Required workspace validation passed.
97+
98+
## V8 Coverage
99+
100+
- PASS: `toolbox/assets/assets.js` collected by browser V8 coverage at 93% function coverage.
101+
- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` is listed as changed runtime JS but is Node/dev-runtime mock code and is not collected by browser V8 coverage. This is advisory per project instructions.
102+
103+
## Manual Validation Steps
104+
105+
1. Open `toolbox/assets/index.html` with a Local DB/dev storage-backed project selected.
106+
2. Expand the right Inspector column and confirm Upload Diagnostics is above Status Log.
107+
3. Upload image files and confirm inline progress appears below the Images table while active.
108+
4. Confirm a successful upload leaves a compact Upload Diagnostics summary and hides verbose progress details.
109+
5. Confirm the upload file results table has only File and Status columns.
110+
6. Click Clear in Status Log and confirm status text/log entries clear while upload diagnostics and asset rows remain.
111+
7. Re-upload an existing filename and confirm the concise duplicate warning appears without a verbose project path in the table.
112+
113+
## Samples Decision
114+
115+
- SKIP: Full samples smoke was not run because this PR only changes Toolbox Assets UI/runtime diagnostics and targeted tests, and the user explicitly requested not to run full samples smoke.
116+
117+
## Review Artifacts
118+
119+
- `docs_build/dev/reports/codex_review.diff`
120+
- `docs_build/dev/reports/codex_changed_files.txt`
121+
122+
## Delta ZIP
123+
124+
- `tmp/PR_26163_081-assets-upload-progress-auto-hide_delta.zip`

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 35 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# git status --short
2-
M docs_build/dev/reports/codex_changed_files.txt
3-
M docs_build/dev/reports/codex_review.diff
4-
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
2+
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
53
M docs_build/dev/reports/dependency_gating_report.md
64
M docs_build/dev/reports/dependency_hydration_reuse_report.md
75
M docs_build/dev/reports/execution_graph_reuse_report.md
@@ -11,12 +9,9 @@ M docs_build/dev/reports/codex_changed_files.txt
119
M docs_build/dev/reports/lane_compilation_report.md
1210
M docs_build/dev/reports/lane_deduplication_report.md
1311
M docs_build/dev/reports/lane_input_validation_report.md
14-
M docs_build/dev/reports/lane_manifests/workspace-contract.json
1512
M docs_build/dev/reports/lane_runtime_optimization_report.md
1613
M docs_build/dev/reports/lane_snapshot_report.md
17-
M docs_build/dev/reports/lane_snapshots/workspace-contract.json
1814
M docs_build/dev/reports/lane_warm_start_report.md
19-
M docs_build/dev/reports/lane_warm_starts/workspace-contract.json
2015
M docs_build/dev/reports/monolith_trigger_removal_report.md
2116
M docs_build/dev/reports/persistent_lane_manifest_report.md
2217
M docs_build/dev/reports/playwright_discovery_ownership_report.md
@@ -32,51 +27,44 @@ M docs_build/dev/reports/codex_changed_files.txt
3227
M docs_build/dev/reports/testing_lane_execution_report.md
3328
M docs_build/dev/reports/validation_cache_report.md
3429
M docs_build/dev/reports/zero_browser_preflight_report.md
35-
M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
3630
M tests/playwright/tools/AssetToolMockRepository.spec.mjs
3731
M toolbox/assets/assets.js
3832
M toolbox/assets/index.html
39-
?? docs_build/dev/reports/PR_26163_080-assets-delete-file-and-received-progress.md
33+
?? docs_build/dev/reports/PR_26163_081-assets-upload-progress-auto-hide.md
4034

4135
# git ls-files --others --exclude-standard
42-
docs_build/dev/reports/PR_26163_080-assets-delete-file-and-received-progress.md
36+
docs_build/dev/reports/PR_26163_081-assets-upload-progress-auto-hide.md
4337

4438
# git diff --stat
45-
docs_build/dev/reports/codex_changed_files.txt | 80 +-
46-
docs_build/dev/reports/codex_review.diff | 2088 +++++++++++++++-----
47-
.../dev/reports/coverage_changed_js_guardrail.txt | 15 +-
48-
docs_build/dev/reports/dependency_gating_report.md | 2 +-
49-
.../reports/dependency_hydration_reuse_report.md | 12 +-
50-
.../dev/reports/execution_graph_reuse_report.md | 16 +-
51-
.../dev/reports/failure_fingerprint_report.md | 2 +-
52-
.../reports/filesystem_scan_reduction_report.md | 2 +-
53-
.../dev/reports/incremental_validation_report.md | 14 +-
54-
docs_build/dev/reports/lane_compilation_report.md | 2 +-
55-
.../dev/reports/lane_deduplication_report.md | 2 +-
56-
.../dev/reports/lane_input_validation_report.md | 2 +-
57-
.../reports/lane_manifests/workspace-contract.json | 10 +-
58-
.../reports/lane_runtime_optimization_report.md | 14 +-
59-
docs_build/dev/reports/lane_snapshot_report.md | 12 +-
60-
.../reports/lane_snapshots/workspace-contract.json | 26 +-
61-
docs_build/dev/reports/lane_warm_start_report.md | 12 +-
62-
.../lane_warm_starts/workspace-contract.json | 18 +-
63-
.../dev/reports/monolith_trigger_removal_report.md | 2 +-
64-
.../dev/reports/persistent_lane_manifest_report.md | 12 +-
65-
.../playwright_discovery_ownership_report.md | 2 +-
66-
.../reports/playwright_discovery_scope_report.md | 2 +-
67-
.../dev/reports/playwright_structure_audit.md | 2 +-
68-
.../dev/reports/playwright_v8_coverage_report.txt | 6 +-
69-
docs_build/dev/reports/retry_suppression_report.md | 2 +-
70-
docs_build/dev/reports/slow_path_pruning_report.md | 16 +-
71-
docs_build/dev/reports/static_validation_report.md | 12 +-
72-
.../dev/reports/targeted_file_manifest_report.md | 8 +-
73-
.../dev/reports/test_cleanup_performance_report.md | 22 +-
74-
.../dev/reports/test_cleanup_routing_report.md | 2 +-
75-
.../dev/reports/testing_lane_execution_report.md | 52 +-
76-
docs_build/dev/reports/validation_cache_report.md | 30 +-
77-
.../dev/reports/zero_browser_preflight_report.md | 10 +-
78-
.../tool-repositories/assets-mock-repository.js | 126 +-
79-
.../tools/AssetToolMockRepository.spec.mjs | 153 +-
80-
toolbox/assets/assets.js | 94 +-
81-
toolbox/assets/index.html | 2 +-
82-
37 files changed, 2124 insertions(+), 760 deletions(-)
39+
.../dev/reports/coverage_changed_js_guardrail.txt | 4 +-
40+
docs_build/dev/reports/dependency_gating_report.md | 2 +-
41+
.../reports/dependency_hydration_reuse_report.md | 12 ++--
42+
.../dev/reports/execution_graph_reuse_report.md | 16 ++---
43+
.../dev/reports/failure_fingerprint_report.md | 2 +-
44+
.../reports/filesystem_scan_reduction_report.md | 2 +-
45+
.../dev/reports/incremental_validation_report.md | 14 ++--
46+
docs_build/dev/reports/lane_compilation_report.md | 2 +-
47+
.../dev/reports/lane_deduplication_report.md | 2 +-
48+
.../dev/reports/lane_input_validation_report.md | 2 +-
49+
.../reports/lane_runtime_optimization_report.md | 14 ++--
50+
docs_build/dev/reports/lane_snapshot_report.md | 12 ++--
51+
docs_build/dev/reports/lane_warm_start_report.md | 12 ++--
52+
.../dev/reports/monolith_trigger_removal_report.md | 2 +-
53+
.../dev/reports/persistent_lane_manifest_report.md | 12 ++--
54+
.../playwright_discovery_ownership_report.md | 2 +-
55+
.../reports/playwright_discovery_scope_report.md | 2 +-
56+
.../dev/reports/playwright_structure_audit.md | 2 +-
57+
.../dev/reports/playwright_v8_coverage_report.txt | 7 +-
58+
docs_build/dev/reports/retry_suppression_report.md | 2 +-
59+
docs_build/dev/reports/slow_path_pruning_report.md | 16 ++---
60+
docs_build/dev/reports/static_validation_report.md | 10 +--
61+
.../dev/reports/targeted_file_manifest_report.md | 8 +--
62+
.../dev/reports/test_cleanup_performance_report.md | 22 +++---
63+
.../dev/reports/test_cleanup_routing_report.md | 2 +-
64+
.../dev/reports/testing_lane_execution_report.md | 52 +++++++-------
65+
docs_build/dev/reports/validation_cache_report.md | 30 ++++----
66+
.../dev/reports/zero_browser_preflight_report.md | 10 +--
67+
.../tools/AssetToolMockRepository.spec.mjs | 77 ++++++++++++--------
68+
toolbox/assets/assets.js | 83 ++++++++++++++++++++--
69+
toolbox/assets/index.html | 76 +++++++++++---------
70+
31 files changed, 305 insertions(+), 206 deletions(-)

0 commit comments

Comments
 (0)