Skip to content

Commit 1167a79

Browse files
ToolboxAidToolboxAid
committed
Implement real SoundFont playback and rendering to remove final MIDI Studio V2 release blockers - PR_26146_421-500-midi-studio-v2-real-soundfont-and-release-closeout
1 parent cd225fb commit 1167a79

13 files changed

Lines changed: 1278 additions & 111 deletions

‎docs/dev/reports/PR_26146_421_500_release_readiness_report.md‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# PR_26146_421-500 Release Readiness Report
2+
3+
## PASS
4+
5+
- Fast JS Synth playback remains working.
6+
- SoundFont Preview playback is working with the embedded SoundFont asset.
7+
- SoundFont instrument audition is working.
8+
- SoundFont canvas note audition is working.
9+
- SoundFont Play Section is working.
10+
- SoundFont loop playback is working.
11+
- Stop clears Fast JS Synth and SoundFont scheduled audio nodes.
12+
- Natural preview completion still clears playback state.
13+
- WAV rendering is implemented through the SoundFont render path.
14+
- Export readiness describes the SoundFont WAV render path.
15+
- MP3/OGG unavailable behavior is visible and honest.
16+
- No duplicate editable ownership was found by the targeted MIDI Studio ownership audit.
17+
- Diagnostics remain read-only derived.
18+
19+
## WARN
20+
21+
- `npm run test:workspace-v2` remains WARN for existing Workspace Manager V2 failures outside MIDI Studio V2 scope:
22+
- 49 passed.
23+
- 23 failed.
24+
- Main failure pattern: Workspace Manager tests expect 11 tool tiles while the current UI renders 12.
25+
- One Asset Manager V2 session-context test timed out.
26+
- Changed runtime JS coverage is advisory. `MidiStudioV2App.js` is exercised but remains below 50 percent function coverage.
27+
28+
## FAIL
29+
30+
No in-scope MIDI Studio V2 PR421-500 FAIL items remain.
31+
32+
## Release Gate
33+
34+
MIDI Studio V2 is release-closeout ready for UAT with real SoundFont preview and WAV rendering. MP3/OGG encoding remains an honest future encoder dependency and is visibly marked when selected.

‎docs/dev/reports/PR_26146_421_500_render_pipeline_report.md‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
# PR_26146_421-500 Render Pipeline Report
2+
3+
## Render Ownership
4+
5+
Export tab owns the rendered output workflow:
6+
7+
- Output Type
8+
- Save WAV
9+
- Save MP3
10+
- Save OGG
11+
- Preview Engine
12+
- SoundFont Asset
13+
- Export Status
14+
- Export/Manifest readiness
15+
16+
JSON export remains separate from rendered audio export.
17+
18+
## Implemented Render Path
19+
20+
PASS: Save WAV now renders from the SoundFont pipeline.
21+
22+
The WAV renderer:
23+
24+
- Uses the selected song.
25+
- Uses the normalized Octave Timeline grid.
26+
- Renders the full current timeline, not only the visible section.
27+
- Uses selected instruments and lane settings.
28+
- Applies volume, transpose, velocity, duration, and practical effects.
29+
- Generates an `audio/wav` Blob.
30+
- Starts the browser download using the existing Save action.
31+
32+
## Format Status
33+
34+
| Format | Status | Behavior |
35+
| --- | --- | --- |
36+
| WAV | PASS | Generated from the SoundFont render pipeline. |
37+
| MP3 | FAIL/WARN honest | Marked encoder-unavailable; click reports no MP3 file was created. |
38+
| OGG | FAIL/WARN honest | Marked encoder-unavailable; click reports no OGG file was created. |
39+
40+
## No False Success
41+
42+
Save MP3 and Save OGG do not claim success. They report that browser encoders are unavailable and no file was created.
43+
44+
## Playwright Coverage
45+
46+
The PR421-500 test verifies:
47+
48+
- WAV output Blob type is `audio/wav`.
49+
- WAV output size is greater than the WAV header.
50+
- MP3 and OGG Save controls are marked `encoder-unavailable`.
51+
- MP3 and OGG clicks report FAIL.

‎docs/dev/reports/PR_26146_421_500_soundfont_runtime_report.md‎

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# PR_26146_421-500 SoundFont Runtime Report
2+
3+
Task: PR_26146_421-500-midi-studio-v2-real-soundfont-and-release-closeout
4+
5+
## Result
6+
7+
PASS: MIDI Studio V2 now has a working SoundFont Preview path backed by a verified embedded General MIDI SoundFont bank. Fast JS Synth remains available as the fallback preview engine.
8+
9+
## Runtime Implementation
10+
11+
- Added `SoundFontPreviewEngine`.
12+
- Added default SoundFont asset configuration:
13+
- `midi-studio-embedded-general-midi`
14+
- Label: `MIDI Studio Embedded GM SoundFont`
15+
- Format: `embedded-web-audio-soundfont`
16+
- Added SoundFont asset population in the Export-owned SoundFont Asset selector.
17+
- Added asset validation for missing or empty SoundFont banks.
18+
- Added playback status reporting for loaded, unavailable, and failed states.
19+
- Routed SoundFont playback through the same canonical grid and lane settings as Fast JS Synth.
20+
21+
## Supported SoundFont Workflows
22+
23+
- Play
24+
- Play Section
25+
- Play Sequence
26+
- Loop
27+
- Stop
28+
- Canvas note audition
29+
- Instrument audition keyboard
30+
31+
## Instrument And Effects Mapping
32+
33+
SoundFont Preview maps existing instrument selections into embedded SoundFont roles:
34+
35+
- Lead
36+
- Bass
37+
- Pad
38+
- Piano
39+
- Percussion
40+
41+
The SoundFont path applies practical support for:
42+
43+
- Reverb
44+
- Chorus
45+
- Delay
46+
- Filter
47+
- Brightness/Tone
48+
- Volume
49+
- Pan data path
50+
- Transpose
51+
- Octave range data path
52+
- Velocity
53+
- Duration
54+
55+
## Validation
56+
57+
- PASS targeted Playwright:
58+
- `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs --grep "PR341-420|PR421-500" --project=playwright`
59+
- Result: 2 passed.
60+
- PASS changed-file syntax checks.
61+
62+
## Remaining Honest Limits
63+
64+
MP3 and OGG encoding are not available in this browser build. The UI marks those selections as encoder-unavailable and reports FAIL when clicked. WAV rendering is implemented.

‎docs/dev/reports/PR_26146_421_500_ssot_audit.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# PR_26146_421-500 SSoT Audit
2+
3+
| Canonical Value Or Workflow | Editable Owner | Derived Readers |
4+
| --- | --- | --- |
5+
| Song details | Song Setup / Song Details | Export readiness, Manifest readiness, Diagnostics, JSON Details |
6+
| Generated ID | Derived from Name and Classification | Read-only displays |
7+
| Song Sheet sections | Song Sheet | Available Sections, Sequence, Timeline, JSON Details |
8+
| Song Sequence | Song Sheet | Timeline playback/build order, Export readiness |
9+
| Timeline notes | Octave Timeline canvas | Playback engines, Export render, Diagnostics |
10+
| Instrument selection/settings | Instruments | Timeline quick display, Playback engines, Export render, JSON Details |
11+
| Effects | Instruments | Fast JS Synth, SoundFont Preview, SoundFont WAV render, JSON Details |
12+
| Useful advanced settings | Instruments | Fast JS Synth, SoundFont Preview, SoundFont WAV render, JSON Details |
13+
| Preview engine | Export audio/render settings | PlaybackControl, Diagnostics, Export readiness |
14+
| SoundFont asset | Export audio/render settings | SoundFont runtime, Export readiness, Diagnostics |
15+
| Save WAV/MP3/OGG | Export | Status, Diagnostics |
16+
| Diagnostics | Read-only derived except Copy/Clear actions | None |
17+
18+
## Findings
19+
20+
- PASS: No duplicate SoundFont asset control was added.
21+
- PASS: No duplicate preview engine control was added.
22+
- PASS: No duplicate effects or advanced ownership was added.
23+
- PASS: Octave Timeline remains quick select/mute/solo/hide only for instrument interaction.
24+
- PASS: Instruments remain the editable owner for instrument configuration.
25+
- PASS: Diagnostics remain derived/read-only.
26+
27+
## Playwright Verification
28+
29+
The PR421-500 targeted test walks visible MIDI Studio controls across Studio, Instruments, Diagnostics, and Export and asserts no duplicate editable canonical owners.

‎docs/dev/reports/PR_26146_421_500_unwired_audit.md‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# PR_26146_421-500 Unwired Audit
2+
3+
## PROD Controls
4+
5+
PASS: Required PROD SoundFont controls are wired:
6+
7+
- Preview Engine
8+
- SoundFont Asset
9+
- Play
10+
- Play Section
11+
- Play Sequence
12+
- Loop
13+
- Stop
14+
- Canvas note audition
15+
- Instrument audition keyboard
16+
- Save WAV
17+
18+
## Honest Unavailable Controls
19+
20+
MP3 and OGG rendered export controls remain visible because they are required output formats, but browser encoding is not available in this build.
21+
22+
When selected:
23+
24+
- Save MP3 is marked `encoder-unavailable`.
25+
- Save OGG is marked `encoder-unavailable`.
26+
- Clicking either action reports FAIL and states that no file was created.
27+
28+
## Future Controls
29+
30+
Existing future-only controls outside this lane remain red/unwired where appropriate, including render quality/sample-rate/normalize/stems/loop export style controls and non-PROD future workflow controls.
31+
32+
## Status
33+
34+
PASS for PROD SoundFont playback and WAV rendering. WARN for MP3/OGG encoder dependency, with no false success.

0 commit comments

Comments
 (0)