Skip to content

Commit 1191d44

Browse files
committed
Execute approved creator platform implementation stack from PLAN_PR source of truth - PR_26169_001-creator-platform-foundation
1 parent 4bf4e5c commit 1191d44

9 files changed

Lines changed: 649 additions & 4425 deletions

.env.example

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Game Foundry Studio local development environment
2+
# ENVIRONMENT
23

34
# Configure the runtime auth and database connections here.
45
# Missing connection configuration reports diagnostics instead of falling back.
@@ -40,6 +41,7 @@ GAMEFOUNDRY_DB_BACKUP_DIR=
4041
# Browser uploads must go through the server API and must not receive these secrets.
4142
GAMEFOUNDRY_STORAGE_ENDPOINT=
4243
GAMEFOUNDRY_STORAGE_ACCESS_KEY_ID=
44+
4345
GAMEFOUNDRY_STORAGE_SECRET_ACCESS_KEY=
4446
GAMEFOUNDRY_STORAGE_BUCKET=
4547
GAMEFOUNDRY_STORAGE_PROJECTS_PREFIX=

docs_build/dev/codex_commands.md

Lines changed: 14 additions & 2705 deletions
Large diffs are not rendered by default.

docs_build/dev/commit_comment.txt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,12 @@
1-
PR_26169_auth-preview-signin-regression
2-
Fix preview sign-in fallback blocking Supabase authentication.
1+
PR_26169_002-auth-preview-signin-regression
2+
3+
Summary:
4+
- Reject malformed selected preview user keys before identity-table lookup.
5+
- Preserve persisted users/roles/user_roles session resolution for valid preview users.
6+
- Add targeted contract coverage for malformed keys, logout cleanup, Creator/Admin/Owner role states, missing users, and missing roles.
7+
8+
Validation:
9+
- node --check src/dev-runtime/server/local-api-router.mjs
10+
- node --check tests/dev-runtime/SupabaseProviderContractStub.test.mjs
11+
- node --test --test-name-pattern "malformed|Creator Admin and Owner|missing user and missing role" tests/dev-runtime/SupabaseProviderContractStub.test.mjs
12+
- git diff --check -- src/dev-runtime/server/local-api-router.mjs tests/dev-runtime/SupabaseProviderContractStub.test.mjs docs_build/pr/BUILD_PR_26169_002-auth-preview-signin-regression.md
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# PR_26169_002-auth-preview-signin-regression Report
2+
3+
## Scope
4+
- PR: `PR_26169_002-auth-preview-signin-regression`
5+
- Source PLAN: `docs_build/pr/PLAN_PR_26169_002-auth-preview-signin-regression.md`
6+
- Approved business model dependency: `docs_build/pr/PLAN_PR_26169_001-creator-platform-foundation.md`
7+
- BUILD doc: `docs_build/pr/BUILD_PR_26169_002-auth-preview-signin-regression.md`
8+
9+
## Branch Validation
10+
- Current branch: `main`
11+
- Expected branch: `main`
12+
- Local branches found: `main`
13+
- Result: PASS
14+
15+
## Requirement Checklist
16+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`: PASS
17+
- Read source PLAN docs before implementation: PASS
18+
- Create BUILD_PR before implementation: PASS
19+
- Implement only PR_26169_002 purpose: PASS
20+
- Preserve public sign-in page and avoid public Local DB controls: PASS
21+
- Resolve preview users through persisted `users`, `roles`, and `user_roles` records: PASS
22+
- Keep Creator, Admin, and Owner role states distinguishable/testable: PASS
23+
- Return actionable diagnostics for malformed selected user keys: PASS
24+
- Preserve existing missing user and missing role diagnostics: PASS
25+
- Keep sign-out cleanup scoped to selected session state: PASS
26+
- Do not add membership, marketplace, AI credit, team, or legal behavior: PASS
27+
- No Playwright/runtime broad validation: PASS, not required for this API/dev-runtime scoped PR
28+
29+
## Implementation Summary
30+
- Exported `sessionUserFromIdentityTables` for targeted contract coverage.
31+
- Trimmed selected preview user keys before persisting session state.
32+
- Rejected malformed non-empty selected user keys before database lookup, returning an actionable diagnostic instead of a silent Guest fallback or database-read diagnostic.
33+
- Preserved valid selected-user resolution through persisted identity tables.
34+
- Added targeted tests for malformed selected keys, logout cleanup after invalid preview state, Creator/Admin/Owner role resolution, missing users, and missing referenced roles.
35+
36+
## Validation
37+
- `node --check src/dev-runtime/server/local-api-router.mjs`: PASS
38+
- `node --check tests/dev-runtime/SupabaseProviderContractStub.test.mjs`: PASS
39+
- `node --test --test-name-pattern "malformed|Creator Admin and Owner|missing user and missing role" tests/dev-runtime/SupabaseProviderContractStub.test.mjs`: PASS
40+
- `git diff --check -- src/dev-runtime/server/local-api-router.mjs tests/dev-runtime/SupabaseProviderContractStub.test.mjs docs_build/pr/BUILD_PR_26169_002-auth-preview-signin-regression.md`: PASS
41+
- Note: Git reported Windows line-ending warnings for touched tracked JS files; no whitespace errors were reported.
42+
43+
## Lanes
44+
- Impacted lane: contract/runtime auth preview session lane under `src/dev-runtime/`.
45+
- Skipped lanes: Playwright, full runtime server suite, integration, engine, samples.
46+
- Skip rationale: PR touches server-side dev-runtime auth/session resolution and targeted contract coverage only; no browser UI, engine, sample, or broad product-data behavior was changed.
47+
- Full suite requirement: Not triggered by this PR scope.
48+
49+
## Acceptance Criteria Evidence
50+
- Creator preview/session role state: PASS via targeted resolver test.
51+
- Admin preview/session role state: PASS via targeted resolver test.
52+
- Owner preview/session role state: PASS via targeted resolver test.
53+
- Missing selected user diagnostic: PASS via targeted resolver test preserving existing message family.
54+
- Missing referenced role diagnostic: PASS via targeted resolver test preserving existing message family.
55+
- Malformed selected user key diagnostic: PASS via route-level test.
56+
- Sign-out/session clear behavior: PASS via route-level logout assertion after malformed selected state.
57+
- No business-model data in auth session state: PASS, no pricing/limits/credits/marketplace data added.
58+
59+
## Artifacts
60+
- Changed files list: `docs_build/dev/reports/codex_changed_files.txt`
61+
- Review diff: `docs_build/dev/reports/codex_review.diff`
62+
- ZIP artifact: `tmp/PR_26169_002-auth-preview-signin-regression_delta.zip`
63+
- ZIP validation: PASS, size > 0, contains repo-relative changed files and reports.
Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,8 @@
1-
# Codex Changed Files
2-
3-
## PR Scope
4-
- PLAN-only documentation stack for PR_26169 creator platform foundation.
5-
- No runtime files changed.
6-
- No Playwright files changed.
7-
8-
## Files
9-
- docs_build/pr/PLAN_PR_26169_001-creator-platform-foundation.md
10-
- docs_build/pr/PLAN_PR_26169_002-auth-preview-signin-regression.md
11-
- docs_build/pr/PLAN_PR_26169_003-beta-invitations-admin.md
12-
- docs_build/pr/PLAN_PR_26169_004-membership-data-model.md
13-
- docs_build/pr/PLAN_PR_26169_005-membership-assignment.md
14-
- docs_build/pr/PLAN_PR_26169_006-memberships-page-v2.md
15-
- docs_build/pr/PLAN_PR_26169_007-ai-credit-foundation.md
16-
- docs_build/pr/PLAN_PR_26169_008-ai-credit-display.md
17-
- docs_build/pr/PLAN_PR_26169_009-marketplace-membership-rules.md
18-
- docs_build/pr/PLAN_PR_26169_010-marketplace-revenue-model.md
19-
- docs_build/pr/PLAN_PR_26169_011-marketplace-categories.md
20-
- docs_build/pr/PLAN_PR_26169_012-teams-foundation.md
21-
- docs_build/pr/PLAN_PR_26169_013-team-enforcement.md
22-
- docs_build/pr/PLAN_PR_26169_014-legal-foundation.md
23-
- docs_build/pr/PLAN_PR_26169_015-terms-of-service.md
24-
- docs_build/pr/PLAN_PR_26169_016-privacy-cookies-community-copyright-dmca.md
25-
- docs_build/pr/PLAN_PR_26169_017-owner-memberships.md
26-
- docs_build/pr/PLAN_PR_26169_018-owner-ai-credits.md
27-
- docs_build/pr/PLAN_PR_26169_019-admin-health-operations.md
28-
- docs_build/dev/reports/codex_review.diff
29-
- docs_build/dev/reports/codex_changed_files.txt
30-
- docs_build/dev/reports/pr_stack_summary.md
31-
32-
## Artifact
33-
- tmp/PR_26169_plan_stack_delta.zip
1+
docs_build/dev/codex_commands.md
2+
docs_build/dev/commit_comment.txt
3+
docs_build/dev/reports/PR_26169_002-auth-preview-signin-regression.md
4+
docs_build/dev/reports/codex_changed_files.txt
5+
docs_build/dev/reports/codex_review.diff
6+
docs_build/pr/BUILD_PR_26169_002-auth-preview-signin-regression.md
7+
src/dev-runtime/server/local-api-router.mjs
8+
tests/dev-runtime/SupabaseProviderContractStub.test.mjs

0 commit comments

Comments
 (0)