Keep State and make Objects Asset a linked render record display - PR_26161_010-objects-asset-return-display

Author: ToolboxAid

docs_build/dev/codex_commands.md

@@ -1323,3 +1323,34 @@ Required reports:
 - `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
+
+
+## PR_26161_010-objects-asset-return-display
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main` before edits.
+- Continued from `PR_26161_009`.
+- Kept `State` visible in the Objects table.
+- Kept Object Type Catalog compact with only `Template` and `Capability`.
+- Updated Objects render asset cells to display the linked shared sprite asset key/name instead of any user-editable Asset field.
+- Added linked asset display refresh on return/focus and an Objects-local refresh event for deterministic validation.
+- Kept `Edit Sprite` actions tied to the linked sprite asset key.
+- Preserved table-first input, `Add Object` below the table, disabled Add while adding, Cancel, Edit, Trash, Reset Table, Object Status, and Sprite asset linking.
+- Did not change engine runtime behavior, sample JSON, auth behavior, production DB behavior, or unrelated tool behavior.
+
+Validation:
+- `node --check toolbox/objects/objects.js`
+- `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- HTML restriction check for `toolbox/objects/index.html`
+- Objects forbidden wording scan for requested terms
+- `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line`
+- `git diff --check`
+- Full samples validation skipped by request and because samples/runtime behavior were not changed.
+
+Required reports:
+- `docs_build/dev/reports/objects-asset-return-display-report.md`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Compact Objects type catalog display - PR_26161_009-object-catalog-compact-display
+Display returned Objects render assets - PR_26161_010-objects-asset-return-display

docs_build/dev/reports/codex_changed_files.txt

@@ -3,8 +3,7 @@ docs_build/dev/commit_comment.txt
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
 docs_build/dev/reports/coverage_changed_js_guardrail.txt
-docs_build/dev/reports/object-catalog-compact-display-report.md
+docs_build/dev/reports/objects-asset-return-display-report.md
 docs_build/dev/reports/playwright_v8_coverage_report.txt
 tests/playwright/tools/ObjectsTool.spec.mjs
-toolbox/objects/index.html
 toolbox/objects/objects.js

docs_build/dev/reports/codex_review.diff

@@ -6,7 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(95%) toolbox/objects/objects.js - executed lines 985/985; executed functions 94/99
+(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,77 @@
+# PR_26161_010 Objects Asset Return Display Report
+
+## Branch Guard
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches found: `* main`
+- Branch validation: PASS
+
+## Source Of Truth
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before branch validation and edits.
+- PASS: Used the user-provided `PR_26161_010-objects-asset-return-display` request as the active BUILD source.
+- PASS: Confirmed the PR purpose is singular: keep Objects render assets as linked shared-record display data.
+
+## Requirement Checklist
+- PASS: Continued from `PR_26161_009`.
+- PASS: Left `State` visible in the Objects table.
+- PASS: Treated Asset as a linked render asset display, not a free-text user field.
+- PASS: When `Render = Sprite`, the Asset cell displays the linked shared sprite asset key/name.
+- PASS: Users cannot type an invalid Asset value in the Objects table.
+- PASS: Asset display and preview refresh from the linked shared asset record when returning to Objects.
+- PASS: `Edit Sprite` stays tied to the linked sprite asset key.
+- PASS: Preserved Object Type Catalog compact display with `Template` and `Capability` only.
+- PASS: Preserved table-first input, `Add Object` below the table, Add disabled while adding, Cancel, Edit, Trash, Reset Table, Object Status, and Sprite asset linking.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only and preserved HTML restrictions.
+
+## Implementation Evidence
+- `toolbox/objects/objects.js`: render asset cells now resolve display text from the shared asset repository and refresh on return/focus.
+- `toolbox/objects/objects.js`: active and saved Asset cells are text-only display cells, with no text input for manual Asset entry.
+- `tests/playwright/tools/ObjectsTool.spec.mjs`: verifies State visibility, compact catalog preservation, linked Asset display, no Asset input, Sprite asset create/resolve, and return-refresh behavior.
+
+## Impacted Lane
+- Impacted lane: Objects tool UI/runtime.
+- Playwright impacted: Yes.
+- Changed runtime JavaScript: `toolbox/objects/objects.js`.
+
+## Testing Performed
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: HTML restriction check for `toolbox/objects/index.html`
+- PASS: Objects forbidden wording scan for requested terms.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line` (5 passed)
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` was produced by targeted Objects Playwright.
+- PASS: `docs_build/dev/reports/coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+- PASS: `git diff --check` exited 0 with line-ending warnings only.
+
+## Playwright Behavior Coverage
+- PASS: `State` remains visible in the Objects table headers.
+- PASS: Object Type Catalog shows only `Template` and `Capability`.
+- PASS: Active Sprite rows show Asset as display text with no input/select/textarea.
+- PASS: Saved Sprite rows show Asset as display text with no input/select/textarea.
+- PASS: Sprite render creates/resolves a linked shared asset record.
+- PASS: Updated linked sprite record data refreshes the Objects Asset display and preview on return.
+- PASS: `Edit Sprite` href remains tied to the linked sprite asset key after the display refresh.
+
+## Skipped Lanes
+- Full samples validation: SKIP. Safe because no sample JSON, sample launch path, or sample runtime behavior changed.
+- Engine runtime validation beyond changed-file syntax/import coverage: SKIP. Safe because no engine runtime files or behavior changed.
+- Production DB/auth validation: SKIP. Safe because no production DB or auth behavior changed.
+- Broad Toolbox/Admin validation: SKIP. Safe because no shared navigation, registration, metadata, or admin surface changed.
+
+## Manual Validation Steps
+- Open `/toolbox/objects/index.html`.
+- Confirm the Objects table still shows `State`.
+- Confirm Object Type Catalog shows only `Template` and `Capability`.
+- Add a Sprite object and confirm the Asset cell says `Links on save` and has no editable Asset input.
+- Save the Sprite object and confirm the Asset cell shows the linked sprite asset key/name.
+- Open the linked Sprite action, update the shared sprite asset record, and return to Objects.
+- Confirm the Objects Asset cell and Sprite Preview refresh to the updated shared asset record.
+- Confirm `Edit Sprite` still opens with the linked asset key.
+
+## Required Artifacts
+- PASS: `docs_build/dev/reports/objects-asset-return-display-report.md`
+- PASS: `docs_build/dev/reports/codex_review.diff`
+- PASS: `docs_build/dev/reports/codex_changed_files.txt`
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- PASS: `tmp/PR_26161_010-objects-asset-return-display_delta.zip`

docs_build/dev/reports/objects-asset-return-display-report.md

@@ -17,7 +17,7 @@ Exercised tool entry points detected:
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(95%) toolbox/objects/objects.js - executed lines 985/985; executed functions 94/99
+(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
 
 Files with executed line/function counts where available:
 (33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
@@ -31,7 +31,7 @@ Files with executed line/function counts where available:
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
 (86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(95%) toolbox/objects/objects.js - executed lines 985/985; executed functions 94/99
+(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
@@ -40,4 +40,4 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(95%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
+(94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -345,11 +345,13 @@ test("Objects table save preserves linked sprite asset create and resolve behavi
       type: "Projectile",
     });
     await expect(page.locator("[data-objects-row-render-asset-preview]")).toHaveText("Links on save");
+    await expect(page.locator("[data-objects-row-render-asset-preview]").locator("input, textarea, select")).toHaveCount(0);
     await page.locator("[data-objects-save-row]").click();
 
     await expect(page.locator("[data-objects-log]")).toContainText("Added Bolt.");
     await expect(page.locator("[data-objects-log]")).toContainText("Created editable default sprite asset sprite_bolt for Bolt.");
     await expect(page.locator("[data-objects-list]")).toContainText("sprite_bolt");
+    await expect(page.locator("[data-objects-list] tr").first().locator("td").nth(5).locator("input, textarea, select")).toHaveCount(0);
     await expect(page.locator("[data-objects-asset-status]")).toHaveText("1 Linked");
     await expect(page.locator("[data-objects-status-summary]")).toContainText("Bolt");
     await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Missing Render Asset");
@@ -376,12 +378,47 @@ test("Objects table save preserves linked sprite asset create and resolve behavi
       "/toolbox/sprites/index.html?assetKey=sprite_bolt&objectKey=bolt&sourceTool=objects"
     );
 
+    const originalSprite = await page.evaluate(async () => {
+      const response = await fetch("/api/mock-db/snapshot");
+      const payload = await response.json();
+      return payload.data.tables.asset_library_items.find((row) => row.id === "sprite_bolt");
+    });
+    const updatedSprite = {
+      ...originalSprite,
+      fileName: "sprite_bolt_reworked.png",
+      name: "Bolt Reworked Sprite",
+      originalName: "sprite_bolt_reworked.png",
+      path: "projects/01K8M3K0EX7V5A3W9Q2Y6R4T1B/image/sprite/sprite_bolt_reworked.png",
+      storedPath: "projects/01K8M3K0EX7V5A3W9Q2Y6R4T1B/image/sprite/sprite_bolt_reworked.png",
+      updatedAt: new Date().toISOString(),
+    };
+    await page.route("**/api/toolbox/assets/repositories/*/methods/listAssets", async (route) => {
+      await route.fulfill({
+        body: JSON.stringify({ data: { result: [updatedSprite] }, ok: true }),
+        contentType: "application/json",
+        status: 200,
+      });
+    });
+    expect(updatedSprite.name).toBe("Bolt Reworked Sprite");
+    await page.evaluate(() => {
+      window.dispatchEvent(new Event("focus"));
+      window.dispatchEvent(new Event("gamefoundry:objects-refresh-assets"));
+    });
+    await expect(page.locator("[data-objects-list]")).toContainText("Bolt Reworked Sprite (sprite_bolt)");
+    await expect(page.locator("[data-objects-output-render-asset]")).toHaveText("Bolt Reworked Sprite (sprite_bolt)");
+    await expect(page.locator("[data-objects-output-sprite-preview]")).toContainText("sprite_bolt_reworked.png");
+    await expect(page.locator("[data-objects-edit-sprite]")).toHaveAttribute(
+      "href",
+      "/toolbox/sprites/index.html?assetKey=sprite_bolt&objectKey=bolt&sourceTool=objects"
+    );
+
     await page.locator("[data-objects-edit-row='bolt']").click();
-    await expect(page.locator("[data-objects-row-render-asset-preview]")).toHaveText("sprite_bolt");
+    await expect(page.locator("[data-objects-row-render-asset-preview]")).toHaveText("Bolt Reworked Sprite (sprite_bolt)");
+    await expect(page.locator("[data-objects-row-render-asset-preview]").locator("input, textarea, select")).toHaveCount(0);
     await page.locator("[data-objects-save-row]").click();
     await expect(page.locator("[data-objects-log]")).toHaveText("Saved Bolt.");
     await expect(page.locator("[data-objects-log]")).not.toContainText("Sprite asset link blocked");
-    await expect(page.locator("[data-objects-list]")).toContainText("sprite_bolt");
+    await expect(page.locator("[data-objects-list]")).toContainText("Bolt Reworked Sprite (sprite_bolt)");
     await expect(page.locator("main")).not.toContainText(OLD_INTERNAL_COPY_PATTERN);
 
     await page.getByRole("button", { name: "Reset Table" }).click();