Skip to content

Commit 1630e65

Browse files
committed
Add PR completion rule and fix Project Journey filter behavior - PR_26157_014-pr-completion-rule-and-journey-filter-fix
1 parent 479d2f4 commit 1630e65

31 files changed

Lines changed: 392 additions & 111 deletions

docs_build/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,6 +1378,19 @@ No PR is complete with:
13781378
- missing review artifacts
13791379
- unintended file changes
13801380

1381+
## PR COMPLETION RULE
1382+
1383+
A PR is not complete until every requested item is implemented, validated, and explicitly marked PASS.
1384+
1385+
Before packaging any PR, Codex must:
1386+
- re-read the original PR request
1387+
- create a requirement-by-requirement checklist
1388+
- validate each requested item individually
1389+
- fix any failures before packaging
1390+
- include PASS/FAIL evidence for each requested item in the PR report
1391+
1392+
Codex must not package partially completed PRs.
1393+
13811394
## ERROR HANDLING CONTRACT
13821395

13831396
- No silent fallback.
Lines changed: 37 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,37 @@
1-
Ideas
2-
- [ ] Capture admin-only project ideas here.
3-
- [.] Keep nested ideas visible while they are still taking shape.
4-
- Use bracket links for connected notes, such as [other].
5-
- Open a file from this folder with [quick-reference, docs_build/dev/admin-notes/quick-reference.txt].
6-
- Review generated achievement prompts at [HERE, docs_build\tools-images-generated\achievements.txt].
7-
- Review the same generated prompts with a forward slash path at [HERE-FWD, docs_build/tools-images-generated/achievements.txt].
8-
9-
Things to Fix
10-
- [!] Replace placeholder notes with concrete admin follow-up items.
11-
- [-] Keep intentionally skipped work visible without counting it as open.
12-
- Track fixes that are not ready for a dedicated BUILD_PR yet.
13-
14-
Undecided Questions
15-
- [?] Decide which project questions need their own subnote files.
16-
- Keep open decisions visible until they become scoped work.
1+
2+
[ ] http://127.0.0.1:5500/admin/db-viewer.html
3+
4+
[ ] Tiles
5+
-
6+
7+
[ ] Project Life Cycle
8+
9+
10+
[ ] Palette updates
11+
- tone (earthy, human, water, floral, TV Age, console age, arcade)
12+
13+
[ ] Picker
14+
- left to right
15+
- Middle Gray ROYGBIV
16+
- step sizes (2-255)
17+
18+
[ ] Project dificullty
19+
- left to right easiest to hardest
20+
- build off of, type, enemy, heros, levels, etc.
21+
22+
[x] Admin notes
23+
- reads txt file (this one) and displays
24+
- if a note has [subnote] it should be a link on the page and display [subnote].txt
25+
- example [other] should display other.txt,
26+
- at the top of subnote pages, have a return take you to note.txt
27+
- name is up for discuttion (this is my ideas, things I want to fix, undecided question)
28+
[ ] Correction Notes update
29+
[subnote] should be /[subnote]/note.txt
30+
31+
32+
[ ] Test/Debug Performance
33+
- use the game engine hooks to track performance
34+
- each section of the loop(draw, physics, move, etc)
35+
- each section will have a start end time
36+
- The test/debug page will be the location for test,
37+
- only on when run from test
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
Ideas
2+
- [ ] Capture admin-only project ideas here.
3+
- [.] Keep nested ideas visible while they are still taking shape.
4+
- Use bracket links for connected notes, such as [other].
5+
- Open a file from this folder with [quick-reference, docs_build/dev/admin-notes/quick-reference.txt].
6+
- Review generated achievement prompts at [HERE, docs_build\tools-images-generated\achievements.txt].
7+
- Review the same generated prompts with a forward slash path at [HERE-FWD, docs_build/tools-images-generated/achievements.txt].
8+
9+
Things to Fix
10+
- [!] Replace placeholder notes with concrete admin follow-up items.
11+
- [-] Keep intentionally skipped work visible without counting it as open.
12+
- Track fixes that are not ready for a dedicated BUILD_PR yet.
13+
14+
Undecided Questions
15+
- [?] Decide which project questions need their own subnote files.
16+
- Keep open decisions visible until they become scoped work.

docs_build/dev/reports/coverage_changed_js_guardrail.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ Missing changed runtime JS files are WARN, not FAIL.
66
Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
77

88
Changed runtime JS files considered:
9-
(70%) toolbox/colors/palette-workspace-repository.js - executed lines 1315/1315; executed functions 89/127
10-
(74%) toolbox/tools-page-accordions.js - executed lines 764/764; executed functions 53/72
11-
(81%) toolbox/assets/assets-mock-repository.js - executed lines 918/918; executed functions 61/75
12-
(94%) src/engine/persistence/mock-db-store.js - executed lines 599/599; executed functions 58/62
13-
(97%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 1034/1034; executed functions 93/96
14-
(98%) toolbox/project-journey/project-journey.js - executed lines 997/997; executed functions 107/109
9+
(73%) toolbox/assets/assets-mock-repository.js - executed lines 918/918; executed functions 55/75
10+
(90%) src/engine/persistence/mock-db-store.js - executed lines 599/599; executed functions 54/60
11+
(97%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 1043/1043; executed functions 93/96
12+
(97%) toolbox/project-journey/project-journey.js - executed lines 1000/1000; executed functions 105/108
1513

1614
Guardrail warnings:
1715
(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/dependency_gating_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-06-07T01:14:55.492Z
3+
Generated: 2026-06-07T01:29:15.503Z
44
Status: PASS
55

66
## Gate Order

docs_build/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-06-07T01:14:55.492Z
3+
Generated: 2026-06-07T01:29:15.503Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/execution_graph_reuse_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-06-07T01:14:55.492Z
3+
Generated: 2026-06-07T01:29:15.503Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/failure_fingerprint_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-06-07T01:14:55.492Z
3+
Generated: 2026-06-07T01:29:15.503Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/incremental_validation_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-06-07T01:14:55.493Z
3+
Generated: 2026-06-07T01:29:15.504Z
44
Status: PASS
55

66
## Reuse Summary

docs_build/dev/reports/lane_compilation_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Lane Compilation Report
22

3-
Generated: 2026-06-07T01:14:55.491Z
3+
Generated: 2026-06-07T01:29:15.503Z
44
Status: PASS
55

66
## Lane Graph

0 commit comments

Comments
 (0)