Skip to content

Commit 1dd4035

Browse files
ToolboxAidToolboxAid
committed
PR_26171_030 idea board workflow fix
1 parent b01045a commit 1dd4035

55 files changed

Lines changed: 4146 additions & 525 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs_build/dev/codex_commands.md‎

Lines changed: 21 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,23 @@
11
# Codex Commands
22

3-
## PR
4-
- `PR_26169_019-admin-health-operations`
5-
6-
## Source Documents
7-
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
8-
- `docs_build/pr/PLAN_PR_26169_019-admin-health-operations.md`
9-
- `docs_build/pr/BUILD_PR_26169_019-admin-health-operations.md`
10-
11-
## Validation Commands
12-
```bash
13-
git branch --show-current
14-
```
15-
16-
```bash
17-
node --check src/dev-runtime/server/local-api-router.mjs
18-
node --check assets/theme-v2/js/admin-system-health.js
19-
node --check tests/dev-runtime/AdminHealthOperations.test.mjs
20-
node --check tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
21-
```
22-
23-
```bash
24-
node -e "<static HTML restriction check for admin/system-health.html>"
25-
```
26-
27-
```bash
28-
node --test tests/dev-runtime/AdminHealthOperations.test.mjs
29-
```
30-
31-
```bash
32-
npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
33-
```
34-
35-
```bash
36-
git diff --check -- <PR_26169_019 scoped file list>
37-
```
38-
39-
## Artifact Commands
40-
```bash
41-
python - <<'PY'
42-
# Generate docs_build/dev/reports/codex_changed_files.txt
43-
# Generate docs_build/dev/reports/codex_review.diff
44-
# Create tmp/PR_26169_019-admin-health-operations_delta.zip
45-
# Verify ZIP size and repo-relative paths
46-
PY
47-
```
3+
- Read skill: repo-build.
4+
- Read skill: github:yeet.
5+
- Read source of truth: docs_build/dev/PROJECT_INSTRUCTIONS.md.
6+
- Re-read original Idea Board request from prior conversation and docs_build/pr/BUILD_PR_26170_002-idea-board-tool.md.
7+
- Inspected toolbox/_tool_template-v2/index.html.
8+
- Inspected toolbox/idea-board/index.html and toolbox/idea-board/index.js.
9+
- Inspected tests/playwright/tools/IdeaBoardTableNotes.spec.mjs.
10+
- Inspected tests/playwright/tools/ToolboxRoutePages.spec.mjs.
11+
- Inspected tests/playwright/tools/RootToolsFutureState.spec.mjs.
12+
- git fetch origin main --prune.
13+
- git pull --ff-only origin main.
14+
- git switch -c codex/fix-idea-board-pr-workflow.
15+
- node --check toolbox/idea-board/index.js.
16+
- node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs.
17+
- node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs.
18+
- node --check tests/playwright/tools/RootToolsFutureState.spec.mjs.
19+
- Inline HTML guard for toolbox/idea-board/index.html.
20+
- npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line.
21+
- npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches".
22+
- npm run test:workspace-v2.
23+
- git diff --check.

‎docs_build/dev/commit_comment.txt‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
1-
Add browser-local Messages speech preview - PR_26171_010
1+
PR_26171_030 idea board workflow fix
2+
3+
- fix Idea Board selected-idea notes context
4+
- update targeted Playwright and workspace-v2 validation harness
5+
- refresh Idea Board workflow docs and reports

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 151 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,151 @@
1-
docs_build/dev/PROJECT_INSTRUCTIONS.md
2-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership.md
3-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership-validation.md
4-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership-manual-validation.md
5-
docs_build/dev/reports/codex_review.diff
6-
docs_build/dev/reports/codex_changed_files.txt
1+
# Codex Changed Files - PR_26171_030-idea-board-workflow-fix
2+
3+
## Changed Files
4+
- docs_build/dev/codex_commands.md
5+
- docs_build/dev/commit_comment.txt
6+
- docs_build/dev/reports/codex_changed_files.txt
7+
- docs_build/dev/reports/codex_review.diff
8+
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
9+
- docs_build/dev/reports/dependency_gating_report.md
10+
- docs_build/dev/reports/dependency_hydration_reuse_report.md
11+
- docs_build/dev/reports/execution_graph_reuse_report.md
12+
- docs_build/dev/reports/failure_fingerprint_report.md
13+
- docs_build/dev/reports/filesystem_scan_reduction_report.md
14+
- docs_build/dev/reports/incremental_validation_report.md
15+
- docs_build/dev/reports/lane_compilation_report.md
16+
- docs_build/dev/reports/lane_deduplication_report.md
17+
- docs_build/dev/reports/lane_input_validation_report.md
18+
- docs_build/dev/reports/lane_manifests/workspace-contract.json
19+
- docs_build/dev/reports/lane_runtime_optimization_report.md
20+
- docs_build/dev/reports/lane_snapshot_report.md
21+
- docs_build/dev/reports/lane_snapshots/workspace-contract.json
22+
- docs_build/dev/reports/lane_warm_start_report.md
23+
- docs_build/dev/reports/lane_warm_starts/workspace-contract.json
24+
- docs_build/dev/reports/monolith_trigger_removal_report.md
25+
- docs_build/dev/reports/persistent_lane_manifest_report.md
26+
- docs_build/dev/reports/playwright_discovery_ownership_report.md
27+
- docs_build/dev/reports/playwright_discovery_scope_report.md
28+
- docs_build/dev/reports/playwright_structure_audit.md
29+
- docs_build/dev/reports/playwright_v8_coverage_report.txt
30+
- docs_build/dev/reports/retry_suppression_report.md
31+
- docs_build/dev/reports/slow_path_pruning_report.md
32+
- docs_build/dev/reports/static_validation_report.md
33+
- docs_build/dev/reports/targeted_file_manifest_report.md
34+
- docs_build/dev/reports/test_cleanup_performance_report.md
35+
- docs_build/dev/reports/test_cleanup_routing_report.md
36+
- docs_build/dev/reports/testing_lane_execution_report.md
37+
- docs_build/dev/reports/validation_cache_report.md
38+
- docs_build/dev/reports/zero_browser_preflight_report.md
39+
- docs_build/pr/APPLY_PR_26171_026-idea-board-template-cleanup.md
40+
- docs_build/pr/APPLY_PR_26171_027-idea-board-table-work-surface.md
41+
- docs_build/pr/APPLY_PR_26171_028-idea-board-notes-table-governance.md
42+
- docs_build/pr/APPLY_PR_26171_029-idea-board-validation-playwright.md
43+
- docs_build/pr/APPLY_PR_26171_030-idea-board-workflow-fix.md
44+
- docs_build/pr/BUILD_PR_26171_026-idea-board-template-cleanup.md
45+
- docs_build/pr/BUILD_PR_26171_027-idea-board-table-work-surface.md
46+
- docs_build/pr/BUILD_PR_26171_028-idea-board-notes-table-governance.md
47+
- docs_build/pr/BUILD_PR_26171_029-idea-board-validation-playwright.md
48+
- docs_build/pr/BUILD_PR_26171_030-idea-board-workflow-fix.md
49+
- docs_build/pr/PLAN_PR_26171_026-idea-board-template-cleanup.md
50+
- docs_build/pr/PLAN_PR_26171_027-idea-board-table-work-surface.md
51+
- docs_build/pr/PLAN_PR_26171_028-idea-board-notes-table-governance.md
52+
- docs_build/pr/PLAN_PR_26171_029-idea-board-validation-playwright.md
53+
- docs_build/pr/PLAN_PR_26171_030-idea-board-workflow-fix.md
54+
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
55+
- tests/playwright/tools/RootToolsFutureState.spec.mjs
56+
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
57+
- toolbox/idea-board/index.html
58+
- toolbox/idea-board/index.js
59+
60+
## Copied Files Verified
61+
- PASS: Re-read `toolbox/_tool_template-v2/index.html`; the template source contains the Theme V2 stylesheet, header/footer partials, left/center/right `tool-workspace tool-workspace--wide` shell, accordion stack, ToolDisplayMode host, and external Theme V2 scripts.
62+
- PASS: Verified `toolbox/_tool_template-v2` currently contains `index.html` only; there was no template-local JavaScript file to copy.
63+
- PASS: Verified `toolbox/idea-board/index.html` preserves/adapts the template structure with Theme V2 CSS, header/footer partials, left and right tool columns, center panel, ToolDisplayMode host, accordions, and external scripts.
64+
- PASS: Verified no inline `<script>`, `<style>`, `style=`, or inline event handlers in `toolbox/idea-board/index.html`.
65+
66+
## Requirement Evidence
67+
- PASS 026: Idea Board is migrated to Tool Template V2 / Theme V2 shell with clean left/center/right layout and external-only JavaScript/CSS.
68+
- PASS 027: Idea Board is table-first; the primary work surface is `data-idea-board-table`, with selected idea row controls and no form-first primary workflow.
69+
- PASS 028: Notes are scoped to the selected idea through `data-idea-board-selected-title`, `data-idea-board-notes-table`, and selected idea state in `toolbox/idea-board/index.js`; Add Note opens an inline row inside the selected notes table; creator notes expose Edit/Delete on the right; system notes expose neither Edit nor Delete; note metadata is table columns.
70+
- PASS 029: Targeted Playwright coverage validates table columns, selected idea switching, scoped note add/edit/delete, system note lockout, placeholder-only Create Project, and no mutating API calls.
71+
- PASS 030: Workspace V2 validation harness now pins public API/site env to the ephemeral test server and updates current Message Studio registry expectations so the required workspace lane passes.
72+
73+
## Validation
74+
- PASS: `node --check toolbox/idea-board/index.js`.
75+
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
76+
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
77+
- PASS: `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`.
78+
- PASS: Inline HTML guard for `toolbox/idea-board/index.html`.
79+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed).
80+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed).
81+
- PASS: `npm run test:workspace-v2` (5 passed).
82+
- PASS: `git diff --cached --check`.
83+
- SKIP: Full samples smoke, per user instruction.
84+
85+
## Git Workflow Fields
86+
- Current branch: codex/fix-idea-board-pr-workflow.
87+
- Created branch: codex/fix-idea-board-pr-workflow from refreshed main.
88+
- Push result: pending.
89+
- PR URL: pending.
90+
- Merge result: pending.
91+
- Final main commit: pending.
92+
93+
## ZIP
94+
- Path: tmp/PR_26171_030-idea-board-workflow-fix_delta.zip.
95+
- Size: 100283 bytes.
96+
- Contents:
97+
- docs_build/dev/codex_commands.md
98+
- docs_build/dev/commit_comment.txt
99+
- docs_build/dev/reports/codex_changed_files.txt
100+
- docs_build/dev/reports/codex_review.diff
101+
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
102+
- docs_build/dev/reports/dependency_gating_report.md
103+
- docs_build/dev/reports/dependency_hydration_reuse_report.md
104+
- docs_build/dev/reports/execution_graph_reuse_report.md
105+
- docs_build/dev/reports/failure_fingerprint_report.md
106+
- docs_build/dev/reports/filesystem_scan_reduction_report.md
107+
- docs_build/dev/reports/incremental_validation_report.md
108+
- docs_build/dev/reports/lane_compilation_report.md
109+
- docs_build/dev/reports/lane_deduplication_report.md
110+
- docs_build/dev/reports/lane_input_validation_report.md
111+
- docs_build/dev/reports/lane_manifests/workspace-contract.json
112+
- docs_build/dev/reports/lane_runtime_optimization_report.md
113+
- docs_build/dev/reports/lane_snapshot_report.md
114+
- docs_build/dev/reports/lane_snapshots/workspace-contract.json
115+
- docs_build/dev/reports/lane_warm_start_report.md
116+
- docs_build/dev/reports/lane_warm_starts/workspace-contract.json
117+
- docs_build/dev/reports/monolith_trigger_removal_report.md
118+
- docs_build/dev/reports/persistent_lane_manifest_report.md
119+
- docs_build/dev/reports/playwright_discovery_ownership_report.md
120+
- docs_build/dev/reports/playwright_discovery_scope_report.md
121+
- docs_build/dev/reports/playwright_structure_audit.md
122+
- docs_build/dev/reports/playwright_v8_coverage_report.txt
123+
- docs_build/dev/reports/retry_suppression_report.md
124+
- docs_build/dev/reports/slow_path_pruning_report.md
125+
- docs_build/dev/reports/static_validation_report.md
126+
- docs_build/dev/reports/targeted_file_manifest_report.md
127+
- docs_build/dev/reports/test_cleanup_performance_report.md
128+
- docs_build/dev/reports/test_cleanup_routing_report.md
129+
- docs_build/dev/reports/testing_lane_execution_report.md
130+
- docs_build/dev/reports/validation_cache_report.md
131+
- docs_build/dev/reports/zero_browser_preflight_report.md
132+
- docs_build/pr/APPLY_PR_26171_026-idea-board-template-cleanup.md
133+
- docs_build/pr/APPLY_PR_26171_027-idea-board-table-work-surface.md
134+
- docs_build/pr/APPLY_PR_26171_028-idea-board-notes-table-governance.md
135+
- docs_build/pr/APPLY_PR_26171_029-idea-board-validation-playwright.md
136+
- docs_build/pr/APPLY_PR_26171_030-idea-board-workflow-fix.md
137+
- docs_build/pr/BUILD_PR_26171_026-idea-board-template-cleanup.md
138+
- docs_build/pr/BUILD_PR_26171_027-idea-board-table-work-surface.md
139+
- docs_build/pr/BUILD_PR_26171_028-idea-board-notes-table-governance.md
140+
- docs_build/pr/BUILD_PR_26171_029-idea-board-validation-playwright.md
141+
- docs_build/pr/BUILD_PR_26171_030-idea-board-workflow-fix.md
142+
- docs_build/pr/PLAN_PR_26171_026-idea-board-template-cleanup.md
143+
- docs_build/pr/PLAN_PR_26171_027-idea-board-table-work-surface.md
144+
- docs_build/pr/PLAN_PR_26171_028-idea-board-notes-table-governance.md
145+
- docs_build/pr/PLAN_PR_26171_029-idea-board-validation-playwright.md
146+
- docs_build/pr/PLAN_PR_26171_030-idea-board-workflow-fix.md
147+
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
148+
- tests/playwright/tools/RootToolsFutureState.spec.mjs
149+
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
150+
- toolbox/idea-board/index.html
151+
- toolbox/idea-board/index.js

0 commit comments

Comments
 (0)