Skip to content

Commit 1e5ce8e

Browse files
committed
Document Theme V2 and engine theme ownership boundaries - PR_26152_057-theme-surface-boundary
1 parent 1f2ac0e commit 1e5ce8e

1 file changed

Lines changed: 70 additions & 0 deletions

File tree

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
# PR_26152_056 Tool Shell Flex Center Layout Validation
2+
3+
## Scope
4+
- Read docs/dev/PROJECT_INSTRUCTIONS.md before implementation.
5+
- Changed only the active reusable public tool-shell layout CSS used by the affected root public shell pages.
6+
- Affected behavior surface: the 11 root /tools/*.html pages that use .tool-workspace and tool-display-mode.js side-column collapse controls.
7+
- /tools/index.html was validated as the root Tools entry/link surface.
8+
- No tool HTML, JavaScript, data, images, partials, Admin, Account, Company, Games, Samples, or root index files were changed.
9+
- No page-local CSS, tool-local CSS, inline style/script/event handlers, or new component behavior were added.
10+
11+
## Implementation
12+
- Updated GameFoundryStudio/assets/css/gamefoundrystudio.css .tool-workspace grid tracks.
13+
- Open side columns now use the same fixed approved width already used by focus mode: 280px.
14+
- Collapsed side columns use the existing fixed rail width: 56px.
15+
- Center column now uses minmax(0, 1fr) so it flexes to fill available horizontal space.
16+
- The existing focus-mode grid tracks were left unchanged.
17+
18+
## Targeted Browser Validation
19+
Command: inline Node static server plus Playwright Chromium targeted to /tools/index.html and the affected root shell pages.
20+
Viewport: 1440 x 960.
21+
22+
Validated pages:
23+
- /tools/ai-assistant.html
24+
- /tools/animation-studio.html
25+
- /tools/asset-studio.html
26+
- /tools/code-studio.html
27+
- /tools/input-studio.html
28+
- /tools/midi-studio.html
29+
- /tools/object-vector-studio.html
30+
- /tools/palette-manager.html
31+
- /tools/particle-studio.html
32+
- /tools/sound-studio.html
33+
- /tools/storage-inspector.html
34+
35+
Measured result on every affected shell page:
36+
- Initial open layout: 280px / 584px / 280px.
37+
- Left collapsed: 56px / 808px / 280px.
38+
- Left reopened: 280px / 584px / 280px.
39+
- Right collapsed: 280px / 808px / 56px.
40+
- Right reopened: 280px / 584px / 280px.
41+
- Both collapsed: 56px / 1032px / 56px.
42+
- Final reopened: 280px / 584px / 280px.
43+
44+
PASS - Left column stayed fixed at 280px when open.
45+
PASS - Right column stayed fixed at 280px when open.
46+
PASS - Collapsed left rail measured 56px.
47+
PASS - Collapsed right rail measured 56px.
48+
PASS - Left collapse expanded the center column from 584px to 808px.
49+
PASS - Right collapse expanded the center column from 584px to 808px.
50+
PASS - Both collapsed expanded the center column to the maximum measured width of 1032px.
51+
PASS - Reopening columns restored both side columns to 280px and did not resize them beyond the approved width.
52+
PASS - Center header remained h2 Workspace on every affected page.
53+
PASS - Center image, display-mode badge, and display-mode character image loaded on every affected page.
54+
PASS - Existing vertical accordions closed and reopened on every affected page.
55+
PASS - No browser console errors, request failures, 404s, or 403s were detected.
56+
PASS - /tools/index.html rendered, loaded 18 tile images, and contained links to all 11 affected root shell pages.
57+
58+
## Static Validation
59+
PASS - git diff --check HEAD~1 HEAD -- GameFoundryStudio/assets/css/gamefoundrystudio.css.
60+
PASS - git diff --name-only HEAD~1 HEAD reported only GameFoundryStudio/assets/css/gamefoundrystudio.css.
61+
PASS - git diff --name-only HEAD~1 HEAD across tools, GameFoundryStudio/assets/js, GameFoundryStudio/assets/partials, GameFoundryStudio/assets/css/theme/v2, Admin, Account, Company, Games, Samples, and root index returned no files.
62+
PASS - No inline style/script/event handlers or imageDataUrl references were introduced.
63+
64+
## Tests Intentionally Not Run
65+
- No repo-wide tests were run.
66+
- No tests outside affected root Tools/GameFoundryStudio paths were run.
67+
- No Admin, Account, Company, Games, Samples, root index, or first-class runtime tool pages were exercised beyond static scope checks.
68+
69+
## Samples Decision
70+
- SKIP because this PR changes only the root public tool-shell layout behavior and does not affect samples.

0 commit comments

Comments
 (0)