Implement normalized Controls architecture with player profiles game mappings and defaults - PR_26161_033-controls-normalized-default-input-architecture

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,32 +1,30 @@
 # git status --short
-M docs_build/dev/reports/codex_changed_files.txt
- M docs_build/dev/reports/codex_review.diff
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
  M src/dev-runtime/persistence/mock-db-store.js
  M src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
  M src/engine/input/InputService.js
+ M src/engine/input/NormalizedInputRegistry.js
+ M tests/input/NormalizedInputRegistry.test.mjs
+ M tests/playwright/tools/AdminDbViewer.spec.mjs
  M tests/playwright/tools/InputMappingV2Tool.spec.mjs
  M toolbox/controls/controls.js
  M toolbox/controls/index.html
-?? docs_build/dev/reports/controls-player-controller-split-report.md
-?? src/engine/input/NormalizedInputRegistry.js
-?? tests/input/NormalizedInputRegistry.test.mjs
+?? docs_build/dev/reports/controls-normalized-default-input-architecture-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-player-controller-split-report.md
-src/engine/input/NormalizedInputRegistry.js
-tests/input/NormalizedInputRegistry.test.mjs
+docs_build/dev/reports/controls-normalized-default-input-architecture-report.md
 
 # git diff --stat
-docs_build/dev/reports/codex_changed_files.txt     |   40 +-
- docs_build/dev/reports/codex_review.diff           | 3424 +++++++++++++++-----
- .../dev/reports/coverage_changed_js_guardrail.txt  |   13 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   35 +-
- src/dev-runtime/persistence/mock-db-store.js       |    4 +-
- .../input-mapping-mock-repository.js               |   16 +-
- src/engine/input/InputService.js                   |   22 +
- tests/playwright/tools/InputMappingV2Tool.spec.mjs |  836 +----
- toolbox/controls/controls.js                       |  661 ++--
- toolbox/controls/index.html                        |   58 +-
- 10 files changed, 3062 insertions(+), 2047 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |  10 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |  21 ++-
+ src/dev-runtime/persistence/mock-db-store.js       |   6 +-
+ .../input-mapping-mock-repository.js               |  93 +++++-------
+ src/engine/input/InputService.js                   |  12 +-
+ src/engine/input/NormalizedInputRegistry.js        | 167 ++++++++++++++++++---
+ tests/input/NormalizedInputRegistry.test.mjs       |  75 +++++++--
+ tests/playwright/tools/AdminDbViewer.spec.mjs      |  10 +-
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs | 107 +++++++------
+ toolbox/controls/controls.js                       | 103 ++++++-------
+ toolbox/controls/index.html                        |  30 ++--
+ 11 files changed, 410 insertions(+), 224 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,76 @@
+# PR_26161_033 Controls Normalized Default Input Architecture
+
+## Branch Validation
+- PASS: Current git branch was verified as `main` before edits.
+
+## Impacted Lane
+- Controls / Input Mapping
+- `src/engine/input` normalized input helpers
+- Shared DB/mock adapter Controls tables
+
+## Playwright Impacted
+- Yes.
+
+## Summary
+- Renamed the visible Controls sections to `Game Input Mapping` and `Player Input Mapping`.
+- Added the normalized input contract used by keyboard, mouse, and gamepad defaults:
+  - `action.primary`, `action.secondary`, `action.tertiary`, `action.quaternary`
+  - `action.confirm`, `action.cancel`, `action.start`, `action.select`, `action.pause`
+  - movement, aim, d-pad, and trigger normalized inputs remain in the same registry.
+- Added visible system default fallback profiles:
+  - `System Default Gamepad`
+  - `System Default Keyboard/Mouse`
+- Documented and tested runtime lookup order:
+  1. user/player controller profile exact match
+  2. user/player keyboard/mouse profile
+  3. system default gamepad profile
+  4. system default keyboard/mouse profile
+  5. missing mapping warning
+- Replaced Controls persistence ownership with two DB-backed contracts:
+  - `player_controller_profiles`: player-owned Physical Input -> Normalized Input
+  - `game_input_mappings`: project-owned Normalized Input -> Game Action
+- Confirmed `game_input_mappings` does not store raw physical input, controller name, or controller id.
+- Confirmed `player_controller_profiles` does not store game actions or object actions.
+
+## Validation
+- PASS: `node --check src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js`
+- PASS: `node --check src/dev-runtime/persistence/mock-db-store.js`
+- PASS: `node --check src/engine/input/InputService.js`
+- PASS: `node --check src/engine/input/NormalizedInputRegistry.js`
+- PASS: `node --check toolbox/controls/controls.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: `node --check tests/playwright/tools/AdminDbViewer.spec.mjs`
+- PASS: `node --check tests/input/NormalizedInputRegistry.test.mjs`
+- PASS: `node tests/input/NormalizedInputRegistry.test.mjs`
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+
+## Extra Check
+- PARTIAL: `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs`
+- Result: 6 passed, 1 failed from unrelated missing asset requests for `assets/theme-v2/images/characters/palette-manager.png`.
+- The changed Admin DB Viewer Controls table expectation passed before the unrelated failure.
+
+## Manual Validation Steps
+1. Open `/toolbox/controls/index.html`.
+2. Confirm the center accordions read `Game Input Mapping` and `Player Input Mapping`.
+3. Open Inspector > Devices and confirm the fallback profiles and runtime lookup order are visible.
+4. Select `Keyboard/Mouse`, create a player input mapping, and confirm `Space` maps to `action.primary`.
+5. Add a Game Input Mapping row from `action.primary` to `Jump`, save, reload, and confirm persistence.
+6. Open the mock DB snapshot and confirm game mappings are stored in `game_input_mappings`.
+7. Confirm player physical mappings are stored in `player_controller_profiles`.
+8. Confirm `game_input_mappings` has no controller id/name or raw physical input fields.
+9. Confirm `player_controller_profiles` has no game action/object action fields.
+
+## Skipped Lanes
+- Full samples validation was skipped by request.
+- Full repository Playwright was not run; targeted Controls/Input Mapping Playwright was the impacted lane.
+- `npm run test:workspace-v2` was not run because this PR does not change Workspace V2 behavior.
+
+## Runtime Engine Behavior
+- No production game runtime behavior or sample JSON alignment was added.
+- `src/engine/input` was extended only for the requested normalized input/default profile contract and lookup helper used by Controls validation.
+
+## Required Artifacts
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `tmp/PR_26161_033-controls-normalized-default-input-architecture_delta.zip`

docs_build/dev/reports/controls-normalized-default-input-architecture-report.md

@@ -8,13 +8,11 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 Changed runtime JS files considered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(31%) src/engine/input/InputService.js - executed lines 443/443; executed functions 20/64
-(61%) src/engine/input/GamepadInputClassifier.js - executed lines 412/412; executed functions 23/38
-(80%) src/engine/input/GamepadState.js - executed lines 100/100; executed functions 16/20
-(93%) toolbox/controls/controls.js - executed lines 1417/1417; executed functions 154/165
-(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 120/120; executed functions 19/19
+(32%) src/engine/input/InputService.js - executed lines 451/451; executed functions 21/66
+(93%) toolbox/controls/controls.js - executed lines 1412/1412; executed functions 154/165
+(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 242/242; executed functions 26/26
 
 Guardrail warnings:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(31%) src/engine/input/InputService.js - WARNING: advisory low coverage below 50%; executed lines 443/443; executed functions 20/64
+(32%) src/engine/input/InputService.js - WARNING: advisory low coverage below 50%; executed lines 451/451; executed functions 21/66

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -19,16 +19,14 @@ Exercised tool entry points detected:
 Changed runtime JS files covered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(31%) src/engine/input/InputService.js - executed lines 443/443; executed functions 20/64
-(61%) src/engine/input/GamepadInputClassifier.js - executed lines 412/412; executed functions 23/38
-(80%) src/engine/input/GamepadState.js - executed lines 100/100; executed functions 16/20
-(93%) toolbox/controls/controls.js - executed lines 1417/1417; executed functions 154/165
-(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 120/120; executed functions 19/19
+(32%) src/engine/input/InputService.js - executed lines 451/451; executed functions 21/66
+(93%) toolbox/controls/controls.js - executed lines 1412/1412; executed functions 154/165
+(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 242/242; executed functions 26/26
 
 Files with executed line/function counts where available:
 (11%) src/engine/input/InputMappingManifest.js - executed lines 78/78; executed functions 1/9
 (23%) src/engine/input/InputComboState.js - executed lines 173/173; executed functions 3/13
-(31%) src/engine/input/InputService.js - executed lines 443/443; executed functions 20/64
+(32%) src/engine/input/InputService.js - executed lines 451/451; executed functions 21/66
 (33%) src/engine/input/InputMap.js - executed lines 62/62; executed functions 3/9
 (40%) src/engine/input/MouseState.js - executed lines 57/57; executed functions 4/10
 (43%) src/engine/input/KeyboardState.js - executed lines 34/34; executed functions 3/7
@@ -40,23 +38,22 @@ Files with executed line/function counts where available:
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
 (80%) src/engine/input/GamepadState.js - executed lines 100/100; executed functions 16/20
-(93%) toolbox/controls/controls.js - executed lines 1417/1417; executed functions 154/165
-(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 120/120; executed functions 19/19
+(93%) toolbox/controls/controls.js - executed lines 1412/1412; executed functions 154/165
+(100%) src/engine/input/NormalizedInputRegistry.js - executed lines 242/242; executed functions 26/26
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(31%) src/engine/input/InputService.js - WARNING: advisory low coverage; executed lines 443/443
+(32%) src/engine/input/InputService.js - WARNING: advisory low coverage; executed lines 451/451
 
 Changed JS files considered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/input/NormalizedInputRegistry.test.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(31%) src/engine/input/InputService.js - changed JS file with browser V8 coverage
-(61%) src/engine/input/GamepadInputClassifier.js - changed JS file with browser V8 coverage
-(80%) src/engine/input/GamepadState.js - changed JS file with browser V8 coverage
+(32%) src/engine/input/InputService.js - changed JS file with browser V8 coverage
 (93%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
 (100%) src/engine/input/NormalizedInputRegistry.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -89,7 +89,7 @@ export const MOCK_DB_TOOL_GROUPS = Object.freeze({
   }),
   controls: Object.freeze({
     label: "Controls",
-    tableNames: Object.freeze(["input_mapping_records", "input_controller_profile_records", "input_custom_action_records"]),
+    tableNames: Object.freeze(["game_input_mappings", "player_controller_profiles", "input_custom_action_records"]),
   }),
   "project-journey": Object.freeze({
     label: "Project Journey",
@@ -136,8 +136,8 @@ const MOCK_DB_TABLE_SCHEMAS = Object.freeze({
   game_configuration_records: Object.freeze(["key", "projectKey", "status", "summary", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   game_configuration_validation_items: Object.freeze(["key", "projectKey", "label", "status", "action", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   object_definition_records: Object.freeze(["key", "id", "projectId", "name", "type", "state", "modelType", "renderType", "renderAssetKey", "renderPreviewPath", "capabilities", "behavior", "interaction", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
-  input_mapping_records: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "action", "actionLabel", "normalizedInput", "inputDevice", "source", "binding", "label", "engine", "controllerProfileId", "mappingProfile", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
-  input_controller_profile_records: Object.freeze(["key", "id", "projectId", "deviceType", "controllerName", "controllerId", "mappingProfile", "inputs", "actions", "inputMappings", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  game_input_mappings: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "gameAction", "gameActionLabel", "normalizedInput", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  player_controller_profiles: Object.freeze(["key", "id", "playerId", "deviceType", "controllerName", "controllerId", "profileName", "inputs", "inputMappings", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   input_custom_action_records: Object.freeze(["key", "id", "projectId", "label", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_note_types: Object.freeze(["key", "typeSlug", "name", "seeded", "userExtensible", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_notes: Object.freeze(["key", "slug", "projectKey", "ownerKey", "name", "typeKey", "createdAt", "updatedAt", "createdBy", "updatedBy"]),