Generate Controls controller profiles with custom actions and confirmed reset - PR_26161_027-controls-controller-profile-generation

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,20 +1,10 @@
-# git status --short
- M docs_build/dev/reports/codex_changed_files.txt
- M docs_build/dev/reports/codex_review.diff
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
- M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M tests/playwright/tools/InputMappingV2Tool.spec.mjs
- M toolbox/controls/controls.js
- M toolbox/controls/index.html
-?? docs_build/dev/reports/controls-object-action-mapping-validation-report.md
-
-# git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-object-action-mapping-validation-report.md
-
-# git diff --stat (excluding review artifact files)
- .../dev/reports/coverage_changed_js_guardrail.txt  |   2 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   8 +-
- tests/playwright/tools/InputMappingV2Tool.spec.mjs | 220 +++++++++++++++++++++
- toolbox/controls/controls.js                       | 205 +++++++++++++++++--
- toolbox/controls/index.html                        |   5 +
- 5 files changed, 416 insertions(+), 24 deletions(-)
+docs_build/dev/reports/controls-controller-profile-generation-report.md
+docs_build/dev/reports/codex_review.diff
+docs_build/dev/reports/codex_changed_files.txt
+docs_build/dev/reports/playwright_v8_coverage_report.txt
+docs_build/dev/reports/coverage_changed_js_guardrail.txt
+src/dev-runtime/persistence/mock-db-store.js
+src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
+tests/playwright/tools/InputMappingV2Tool.spec.mjs
+toolbox/controls/controls.js
+toolbox/controls/index.html

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,57 @@
+# PR_26161_027 Controls Controller Profile Generation
+
+## Branch Validation
+PASS: current branch was verified as `main` before edits.
+
+## Impacted Lane
+Controls / Input Mapping V2 targeted lane.
+
+## Playwright Impacted
+Yes.
+
+## Summary
+- Added explicit DB-backed controller profile generation from detected Device Type selections.
+- Added visible fallback status for Exact saved profile, Default Gamepad Mapping, Keyboard/Mouse Default, and Missing Mapping.
+- Added Create Profile From Default as a visible fallback action for unsaved detected gamepads.
+- Added generated gamepad input layout rows from exposed browser gamepad buttons, axes, triggers, and d-pad entries.
+- Added DB-backed custom Actions and exposed saved custom Actions in the Action catalog and mapping dropdowns after reload.
+- Converted center Input Mapping and Controller Profile areas into accordions.
+- Updated Reset Mappings to require the exact confirm dialog text: `This will delete all Mappings, are you sure?`
+
+## Persistence
+- Input mappings remain DB-backed through the shared Controls repository.
+- Controller profiles remain DB-backed through the shared Controls repository.
+- Custom actions are now DB-backed through the shared Controls repository.
+- No page-local memory is used as the source of truth.
+
+## Testing Performed
+- `node --check toolbox/controls/controls.js`
+- `node --check src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js`
+- `node --check src/dev-runtime/persistence/mock-db-store.js`
+- `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+  - Result: 7 passed.
+
+## Playwright Coverage
+- Produced `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
+- Changed browser runtime JS covered: `toolbox/controls/controls.js` at 92% function coverage.
+- Shared DB/mock adapter files are server-side and reported by the V8 coverage artifact as advisory WARN entries because Playwright browser V8 coverage does not collect server-side modules; their behavior was exercised through the targeted Controls Playwright API flows.
+
+## Manual Validation Steps
+1. Open `toolbox/controls/index.html`.
+2. Click Refresh Devices and verify Keyboard, Mouse, and detected gamepads appear in Device Type.
+3. Select a gamepad and verify `Using Default Gamepad Mapping` and `Missing saved profile for this controller` appear without saving a profile.
+4. Click Add Profile and verify a DB-backed profile is created with generated input rows requiring Action assignment.
+5. Delete the saved profile, then click Create Profile From Default and verify a real DB-backed profile is created.
+6. Add a custom Action and verify it appears in the Actions catalog and Action dropdown after reload.
+7. Add, edit, and reset mappings; verify Reset Mappings opens the required confirm dialog and OK persists deletion after reload.
+
+## Skipped Lanes
+- Full samples validation was skipped as requested. This PR is scoped to Controls UI/tool persistence and does not change sample JSON alignment or game runtime behavior.
+- `npm run test:workspace-v2` was skipped because the requested validation lane is the targeted Controls/Input Mapping Playwright suite, which covers the changed Controls tool behavior directly.
+
+## Runtime Engine Behavior
+Confirmed: no production game runtime behavior was changed.
+
+## Completion Check
+PASS: 100% of requested PR_26161_027 items were implemented and validated in the targeted lane.

docs_build/dev/reports/controls-controller-profile-generation-report.md

@@ -6,15 +6,10 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(93%) toolbox/controls/controls.js - executed lines 1379/1379; executed functions 138/149
-(100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
+(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
 
 Guardrail warnings:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -17,35 +17,25 @@ Exercised tool entry points detected:
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(93%) toolbox/controls/controls.js - executed lines 1379/1379; executed functions 138/149
-(100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
+(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(93%) toolbox/controls/controls.js - executed lines 1379/1379; executed functions 138/149
+(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs - changed JS file not collected as browser runtime coverage
-(93%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
-(100%) toolbox/controls/controls-api-client.js - changed JS file with browser V8 coverage
+(92%) toolbox/controls/controls.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -89,7 +89,7 @@ export const MOCK_DB_TOOL_GROUPS = Object.freeze({
   }),
   controls: Object.freeze({
     label: "Controls",
-    tableNames: Object.freeze(["input_mapping_records", "input_controller_profile_records"]),
+    tableNames: Object.freeze(["input_mapping_records", "input_controller_profile_records", "input_custom_action_records"]),
   }),
   "project-journey": Object.freeze({
     label: "Project Journey",
@@ -138,6 +138,7 @@ const MOCK_DB_TABLE_SCHEMAS = Object.freeze({
   object_definition_records: Object.freeze(["key", "id", "projectId", "name", "type", "state", "modelType", "renderType", "renderAssetKey", "renderPreviewPath", "capabilities", "behavior", "interaction", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   input_mapping_records: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "action", "actionLabel", "inputDevice", "source", "binding", "label", "engine", "controllerProfileId", "mappingProfile", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   input_controller_profile_records: Object.freeze(["key", "id", "projectId", "deviceType", "controllerName", "controllerId", "mappingProfile", "inputs", "actions", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  input_custom_action_records: Object.freeze(["key", "id", "projectId", "label", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_note_types: Object.freeze(["key", "typeSlug", "name", "seeded", "userExtensible", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_notes: Object.freeze(["key", "slug", "projectKey", "ownerKey", "name", "typeKey", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_templates: Object.freeze(["key", "templateSlug", "originalMeaning", "systemGuidance", "linkedToolContexts", "version", "isActive", "createdAt", "updatedAt", "createdBy", "updatedBy"]),

src/dev-runtime/persistence/mock-db-store.js

@@ -7,6 +7,7 @@ import {
 export const INPUT_MAPPING_TOOL_TABLES = Object.freeze([
   "input_mapping_records",
   "input_controller_profile_records",
+  "input_custom_action_records",
 ]);
 
 const INPUT_MAPPING_DB_OWNER = "controls";
@@ -26,6 +27,7 @@ function cloneTables(tables) {
 function createEmptyTables() {
   return {
     input_controller_profile_records: [],
+    input_custom_action_records: [],
     input_mapping_records: [],
   };
 }
@@ -44,9 +46,11 @@ function mappingKeyFromText(value) {
 function initialTables(options = {}) {
   const explicitRows = options.memoryDbTables?.input_mapping_records;
   const explicitProfiles = options.memoryDbTables?.input_controller_profile_records;
-  if (Array.isArray(explicitRows) || Array.isArray(explicitProfiles)) {
+  const explicitCustomActions = options.memoryDbTables?.input_custom_action_records;
+  if (Array.isArray(explicitRows) || Array.isArray(explicitProfiles) || Array.isArray(explicitCustomActions)) {
     return normalizeMockDbTables(INPUT_MAPPING_DB_OWNER, {
       input_controller_profile_records: Array.isArray(explicitProfiles) ? explicitProfiles : [],
+      input_custom_action_records: Array.isArray(explicitCustomActions) ? explicitCustomActions : [],
       input_mapping_records: Array.isArray(explicitRows) ? explicitRows : [],
     }, options);
   }
@@ -91,6 +95,15 @@ function controllerProfileFromRecord(record = {}) {
   };
 }
 
+function customActionFromRecord(record = {}) {
+  const label = normalizeText(record.label || record.actionLabel || record.action);
+  const id = normalizeText(record.id) || mappingKeyFromText(label);
+  return {
+    id,
+    label: label || id,
+  };
+}
+
 function mappingFromRecord(record = {}) {
   return {
     action: normalizeText(record.action),
@@ -151,6 +164,17 @@ export function createInputMappingToolMockRepository(options = {}) {
       .map(controllerProfileFromRecord);
   }
 
+  function listCustomActions(projectId = "") {
+    const targetProjectId = normalizeText(projectId) || activeProjectId();
+    return [...(tables.input_custom_action_records || [])]
+      .sort((left, right) => (
+        (Number(left.recordOrder) || 0) - (Number(right.recordOrder) || 0)
+          || normalizeText(left.label).localeCompare(normalizeText(right.label))
+      ))
+      .filter((record) => normalizeText(record.projectId) === targetProjectId)
+      .map(customActionFromRecord);
+  }
+
   function replaceControllerProfiles(profiles = [], projectId = "") {
     const targetProjectId = normalizeText(projectId) || activeProjectId();
     const existingRows = new Map(
@@ -197,6 +221,46 @@ export function createInputMappingToolMockRepository(options = {}) {
     };
   }
 
+  function replaceCustomActions(actions = [], projectId = "") {
+    const targetProjectId = normalizeText(projectId) || activeProjectId();
+    const existingRows = new Map(
+      (tables.input_custom_action_records || [])
+        .filter((record) => normalizeText(record.projectId) === targetProjectId)
+        .map((record) => [normalizeText(record.id), record]),
+    );
+    const timestamp = new Date().toISOString();
+    const userKey = activeUserKey();
+    const nextRows = (Array.isArray(actions) ? actions : []).map((action, index) => {
+      const label = normalizeText(action.label || action.actionLabel || action.action);
+      const id = normalizeText(action.id) || mappingKeyFromText(label || `custom-action-${index + 1}`);
+      const previous = existingRows.get(id);
+      return {
+        createdAt: previous?.createdAt || timestamp,
+        createdBy: previous?.createdBy || userKey,
+        id,
+        key: previous?.key,
+        label: label || id,
+        projectId: targetProjectId,
+        recordOrder: index + 1,
+        updatedAt: timestamp,
+        updatedBy: userKey,
+      };
+    });
+
+    tables.input_custom_action_records = [
+      ...(tables.input_custom_action_records || []).filter(
+        (record) => normalizeText(record.projectId) !== targetProjectId,
+      ),
+      ...nextRows,
+    ];
+    persistTables();
+    return {
+      customActions: listCustomActions(targetProjectId),
+      saved: true,
+      snapshot: getSnapshot(),
+    };
+  }
+
   function replaceMappings(mappings = [], projectId = "") {
     const targetProjectId = normalizeText(projectId) || activeProjectId();
     const existingRows = new Map(
@@ -271,6 +335,7 @@ export function createInputMappingToolMockRepository(options = {}) {
     const normalizedTables = getTables();
     return {
       controllerProfiles: listControllerProfiles(),
+      customActions: listCustomActions(),
       mappings: listMappings(),
       tableCounts: tableCounts(normalizedTables),
       tables: normalizedTables,
@@ -282,8 +347,10 @@ export function createInputMappingToolMockRepository(options = {}) {
     getSnapshot,
     getTables,
     listControllerProfiles,
+    listCustomActions,
     listMappings,
     replaceControllerProfiles,
+    replaceCustomActions,
     replaceMappings,
     resetMappings,
   };