Persist Controls controller profiles through shared DB adapter - PR_26161_019-controls-db-controller-profiles

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -3,22 +3,26 @@ M docs_build/dev/reports/codex_changed_files.txt
  M docs_build/dev/reports/codex_review.diff
  M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
+ M src/dev-runtime/persistence/mock-db-store.js
+ M src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
  M tests/playwright/tools/InputMappingV2Tool.spec.mjs
  M toolbox/controls/index.html
  M toolbox/input-mapping-v2/index.html
-?? docs_build/dev/reports/controls-wireframe-controller-profiles-report.md
+ M toolbox/input-mapping-v2/input-mapping-v2.js
+?? docs_build/dev/reports/controls-db-controller-profiles-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-wireframe-controller-profiles-report.md
+docs_build/dev/reports/controls-db-controller-profiles-report.md
 
 # git diff --stat
-docs_build/dev/reports/codex_changed_files.txt     |   26 +-
- docs_build/dev/reports/codex_review.diff           | 1100 +++++++++++++++-----
- .../dev/reports/coverage_changed_js_guardrail.txt  |    7 -
- .../dev/reports/playwright_v8_coverage_report.txt  |   11 -
- .../guest-seeds/tool-metadata-inventory.js         |    4 +-
- tests/playwright/tools/InputMappingV2Tool.spec.mjs |   21 +-
- toolbox/controls/index.html                        |   32 +
- toolbox/input-mapping-v2/index.html                |   32 +
- 8 files changed, 927 insertions(+), 306 deletions(-)
+docs_build/dev/reports/codex_changed_files.txt     |   30 +-
+ docs_build/dev/reports/codex_review.diff           | 2400 ++++++++------------
+ .../dev/reports/coverage_changed_js_guardrail.txt  |    6 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |   14 +-
+ src/dev-runtime/persistence/mock-db-store.js       |    5 +-
+ .../input-mapping-mock-repository.js               |   98 +-
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs |   92 +-
+ toolbox/controls/index.html                        |   21 +-
+ toolbox/input-mapping-v2/index.html                |   21 +-
+ toolbox/input-mapping-v2/input-mapping-v2.js       |  326 ++-
+ 10 files changed, 1567 insertions(+), 1446 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,78 @@
+# PR_26161_019 Controls DB Controller Profiles Report
+
+## Branch Validation
+
+- PASS: Current branch was `main`.
+- Expected branch: `main`.
+- Worktree was clean before PR_26161_019 edits.
+
+## Scope
+
+- Impacted lane: Controls/Input Mapping recovery/UAT.
+- Playwright impacted: Yes.
+- Full samples validation: SKIPPED. Samples and sample JSON alignment are explicitly out of scope for this Controls DB-backed profile change.
+- Engine runtime behavior: Unchanged. No production controller runtime, engine input runtime, auth behavior, sample alignment, or unrelated rewrite was added.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- PASS: Verified branch `main` before edits.
+- PASS: Continued from PR_26161_018.
+- PASS: Controls status remains Wireframe.
+- PASS: Controller profiles persist through the shared DB/mock adapter using `input_controller_profile_records`.
+- PASS: Controller profile records include Device Type, Controller Name, Controller ID, Mapping Profile, Inputs, and Actions.
+- PASS: Page load reads mappings and controller profiles from the shared DB/mock adapter.
+- PASS: Mappings can reference a saved controller profile through `controllerProfileId` and `mappingProfile`.
+- PASS: Unknown controller status remains actionable and does not create fake profile rows.
+- PASS: Existing table-first mapping behavior, Add Mapping, keyboard capture, token delete, Mapping JSON, Devices, and Status panels are preserved.
+- PASS: No sample JSON alignment, auth behavior, or production controller runtime was added.
+
+## Files Changed
+
+- `src/dev-runtime/persistence/mock-db-store.js`
+- `src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js`
+- `toolbox/input-mapping-v2/input-mapping-v2.js`
+- `toolbox/input-mapping-v2/index.html`
+- `toolbox/controls/index.html`
+- `tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- `docs_build/dev/reports/controls-db-controller-profiles-report.md`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+
+## Testing Performed
+
+- PASS: `node --check toolbox/input-mapping-v2/input-mapping-v2.js`
+- PASS: `node --check src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js`
+- PASS: `node --check src/dev-runtime/persistence/mock-db-store.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: HTML restriction scan for inline scripts, style blocks, inline styles, and inline event handlers in both Controls routes.
+- PASS: `git diff --check`
+  - Note: Git reported CRLF normalization warnings on touched files only.
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --workers=1 --reporter=line`
+  - Final result: 5 passed.
+
+## Playwright Coverage
+
+- Generated `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
+- Generated `docs_build/dev/reports/coverage_changed_js_guardrail.txt`.
+- Coverage includes `toolbox/input-mapping-v2/input-mapping-v2.js` with browser V8 execution.
+- Coverage includes advisory WARN entries for server-side DB/mock adapter files because they are exercised through the local server API, not collected by browser V8 coverage.
+- The report may also list the prior Wireframe metadata file as advisory because the coverage helper includes the current HEAD comparison window; it is non-blocking and no Controls metadata file changed in PR_26161_019.
+
+## Manual Validation Steps
+
+1. Open `/toolbox/input-mapping-v2/index.html`.
+2. Confirm Controller Profiles shows no saved profile row before explicit user action.
+3. Confirm the unknown controller status tells the creator to Refresh Devices and use Add Profile.
+4. Click Add Profile, fill Device Type, Controller Name, Controller ID, Mapping Profile, Inputs, and Actions, then save.
+5. Reload and confirm the saved controller profile persists.
+6. Add a mapping, select the saved Mapping Profile, save, reload, and confirm the mapping still references the saved profile.
+7. Capture `KeyA`, confirm the mapping appears in the table and Mapping JSON, then click the token to delete it.
+
+## Skipped Lanes
+
+- Full samples smoke: SKIPPED because samples and sample JSON alignment are out of scope.
+- Broad workspace suite: SKIPPED because this PR only changes Controls/Input Mapping and its direct DB/mock adapter path.
+- Engine tests: SKIPPED because no production engine runtime behavior changed.

docs_build/dev/reports/controls-db-controller-profiles-report.md

@@ -7,7 +7,11 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 703/703; executed functions 80/87
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
 
 Guardrail warnings:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,27 +12,33 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(88%) Toolbox Index - exercised 4 runtime JS files
+(87%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 703/703; executed functions 80/87
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 703/703; executed functions 80/87
+(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
 (100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(92%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage
+(90%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -89,7 +89,7 @@ export const MOCK_DB_TOOL_GROUPS = Object.freeze({
   }),
   "input-mapping-v2": Object.freeze({
     label: "Input Mapping",
-    tableNames: Object.freeze(["input_mapping_records"]),
+    tableNames: Object.freeze(["input_mapping_records", "input_controller_profile_records"]),
   }),
   "project-journey": Object.freeze({
     label: "Project Journey",
@@ -136,7 +136,8 @@ const MOCK_DB_TABLE_SCHEMAS = Object.freeze({
   game_configuration_records: Object.freeze(["key", "projectKey", "status", "summary", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   game_configuration_validation_items: Object.freeze(["key", "projectKey", "label", "status", "action", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   object_definition_records: Object.freeze(["key", "id", "projectId", "name", "type", "state", "modelType", "renderType", "renderAssetKey", "renderPreviewPath", "capabilities", "behavior", "interaction", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
-  input_mapping_records: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "action", "actionLabel", "inputDevice", "source", "binding", "label", "engine", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  input_mapping_records: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "action", "actionLabel", "inputDevice", "source", "binding", "label", "engine", "controllerProfileId", "mappingProfile", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  input_controller_profile_records: Object.freeze(["key", "id", "projectId", "deviceType", "controllerName", "controllerId", "mappingProfile", "inputs", "actions", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_note_types: Object.freeze(["key", "typeSlug", "name", "seeded", "userExtensible", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_notes: Object.freeze(["key", "slug", "projectKey", "ownerKey", "name", "typeKey", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_templates: Object.freeze(["key", "templateSlug", "originalMeaning", "systemGuidance", "linkedToolContexts", "version", "isActive", "createdAt", "updatedAt", "createdBy", "updatedBy"]),

src/dev-runtime/persistence/mock-db-store.js

@@ -6,6 +6,7 @@ import {
 
 export const INPUT_MAPPING_TOOL_TABLES = Object.freeze([
   "input_mapping_records",
+  "input_controller_profile_records",
 ]);
 
 const INPUT_MAPPING_DB_OWNER = "input-mapping-v2";
@@ -24,6 +25,7 @@ function cloneTables(tables) {
 
 function createEmptyTables() {
   return {
+    input_controller_profile_records: [],
     input_mapping_records: [],
   };
 }
@@ -41,14 +43,26 @@ function mappingKeyFromText(value) {
 
 function initialTables(options = {}) {
   const explicitRows = options.memoryDbTables?.input_mapping_records;
-  if (Array.isArray(explicitRows)) {
+  const explicitProfiles = options.memoryDbTables?.input_controller_profile_records;
+  if (Array.isArray(explicitRows) || Array.isArray(explicitProfiles)) {
     return normalizeMockDbTables(INPUT_MAPPING_DB_OWNER, {
-      input_mapping_records: explicitRows,
+      input_controller_profile_records: Array.isArray(explicitProfiles) ? explicitProfiles : [],
+      input_mapping_records: Array.isArray(explicitRows) ? explicitRows : [],
     }, options);
   }
   return normalizeMockDbTables(INPUT_MAPPING_DB_OWNER, createEmptyTables(), options);
 }
 
+function normalizeList(value) {
+  if (Array.isArray(value)) {
+    return value.map(normalizeText).filter(Boolean);
+  }
+  return normalizeText(value)
+    .split(",")
+    .map(normalizeText)
+    .filter(Boolean);
+}
+
 function sortedMappingRows(tables) {
   return [...(tables.input_mapping_records || [])].sort((left, right) => (
     (Number(left.recordOrder) || 0) - (Number(right.recordOrder) || 0)
@@ -57,6 +71,26 @@ function sortedMappingRows(tables) {
   ));
 }
 
+function sortedControllerProfileRows(tables) {
+  return [...(tables.input_controller_profile_records || [])].sort((left, right) => (
+    (Number(left.recordOrder) || 0) - (Number(right.recordOrder) || 0)
+      || normalizeText(left.mappingProfile).localeCompare(normalizeText(right.mappingProfile))
+      || normalizeText(left.controllerName).localeCompare(normalizeText(right.controllerName))
+  ));
+}
+
+function controllerProfileFromRecord(record = {}) {
+  return {
+    actions: normalizeList(record.actions),
+    controllerId: normalizeText(record.controllerId),
+    controllerName: normalizeText(record.controllerName),
+    deviceType: normalizeText(record.deviceType),
+    id: normalizeText(record.id),
+    inputs: normalizeList(record.inputs),
+    mappingProfile: normalizeText(record.mappingProfile),
+  };
+}
+
 function mappingFromRecord(record = {}) {
   return {
     action: normalizeText(record.action),
@@ -66,6 +100,8 @@ function mappingFromRecord(record = {}) {
     id: normalizeText(record.id),
     inputDevice: normalizeText(record.inputDevice),
     label: normalizeText(record.label),
+    controllerProfileId: normalizeText(record.controllerProfileId),
+    mappingProfile: normalizeText(record.mappingProfile),
     objectKey: normalizeText(record.objectKey),
     objectName: normalizeText(record.objectName),
     source: normalizeText(record.source),
@@ -108,6 +144,59 @@ export function createInputMappingToolMockRepository(options = {}) {
       .map(mappingFromRecord);
   }
 
+  function listControllerProfiles(projectId = "") {
+    const targetProjectId = normalizeText(projectId) || activeProjectId();
+    return sortedControllerProfileRows(tables)
+      .filter((record) => normalizeText(record.projectId) === targetProjectId)
+      .map(controllerProfileFromRecord);
+  }
+
+  function replaceControllerProfiles(profiles = [], projectId = "") {
+    const targetProjectId = normalizeText(projectId) || activeProjectId();
+    const existingRows = new Map(
+      (tables.input_controller_profile_records || [])
+        .filter((record) => normalizeText(record.projectId) === targetProjectId)
+        .map((record) => [normalizeText(record.id), record]),
+    );
+    const timestamp = new Date().toISOString();
+    const userKey = activeUserKey();
+    const nextRows = (Array.isArray(profiles) ? profiles : []).map((profile, index) => {
+      const mappingProfile = normalizeText(profile.mappingProfile);
+      const controllerId = normalizeText(profile.controllerId);
+      const id = normalizeText(profile.id) || mappingKeyFromText(`${controllerId}-${mappingProfile}-${index + 1}`);
+      const previous = existingRows.get(id);
+      return {
+        actions: normalizeList(profile.actions),
+        controllerId,
+        controllerName: normalizeText(profile.controllerName),
+        createdAt: previous?.createdAt || timestamp,
+        createdBy: previous?.createdBy || userKey,
+        deviceType: normalizeText(profile.deviceType) || "Gamepad",
+        id,
+        inputs: normalizeList(profile.inputs),
+        key: previous?.key,
+        mappingProfile,
+        projectId: targetProjectId,
+        recordOrder: index + 1,
+        updatedAt: timestamp,
+        updatedBy: userKey,
+      };
+    });
+
+    tables.input_controller_profile_records = [
+      ...(tables.input_controller_profile_records || []).filter(
+        (record) => normalizeText(record.projectId) !== targetProjectId,
+      ),
+      ...nextRows,
+    ];
+    persistTables();
+    return {
+      profiles: listControllerProfiles(targetProjectId),
+      saved: true,
+      snapshot: getSnapshot(),
+    };
+  }
+
   function replaceMappings(mappings = [], projectId = "") {
     const targetProjectId = normalizeText(projectId) || activeProjectId();
     const existingRows = new Map(
@@ -134,6 +223,8 @@ export function createInputMappingToolMockRepository(options = {}) {
         inputDevice: normalizeText(mapping.inputDevice),
         key: previous?.key,
         label: normalizeText(mapping.label),
+        controllerProfileId: normalizeText(mapping.controllerProfileId),
+        mappingProfile: normalizeText(mapping.mappingProfile),
         objectKey,
         objectName: normalizeText(mapping.objectName) || "Global",
         projectId: targetProjectId,
@@ -179,6 +270,7 @@ export function createInputMappingToolMockRepository(options = {}) {
   function getSnapshot() {
     const normalizedTables = getTables();
     return {
+      controllerProfiles: listControllerProfiles(),
       mappings: listMappings(),
       tableCounts: tableCounts(normalizedTables),
       tables: normalizedTables,
@@ -189,7 +281,9 @@ export function createInputMappingToolMockRepository(options = {}) {
     INPUT_MAPPING_TOOL_TABLES,
     getSnapshot,
     getTables,
+    listControllerProfiles,
     listMappings,
+    replaceControllerProfiles,
     replaceMappings,
     resetMappings,
   };