Skip to content

Commit 20fd280

Browse files
authored
PR_26171_039 table first workspace governance
Add table-first workspace governance to project instructions. Validation: - git diff --check - confirmed TABLE-FIRST WORKSPACE GOVERNANCE heading exists - confirmed visual examples exist - confirmed Save/Cancel row-state example exists - no Playwright impact; docs/workflow only
1 parent f119084 commit 20fd280

3 files changed

Lines changed: 282 additions & 577 deletions

File tree

docs_build/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1660,6 +1660,81 @@ For tools that present Summary Table or Notes Table note-management surfaces:
16601660
- System-created notes may only have status changed when the tool explicitly allows status editing.
16611661
- Selected Note Metadata must be shown as table columns, not as a separate detached panel.
16621662

1663+
## TABLE-FIRST WORKSPACE GOVERNANCE
1664+
1665+
Primary tool work surfaces must be table-first unless a PR explicitly approves another interaction model.
1666+
1667+
Rules:
1668+
- The primary work surface is a table.
1669+
- Prefer inline table workflows over forms.
1670+
- No detached selected-item context panels.
1671+
- No detached notes/detail panels when child rows can render under the parent row.
1672+
- Parent name cells own accordion behavior.
1673+
- The chevron appears inside the parent name cell.
1674+
- The entire parent name cell toggles expansion.
1675+
- Child count columns are informational only.
1676+
- Only one parent row may be expanded at a time.
1677+
- The default state is all collapsed.
1678+
- Child rows are indented.
1679+
- The child Add button aligns with child rows.
1680+
- Metadata remains stored but hidden unless explicitly needed.
1681+
- Add buttons are left aligned and self-describing.
1682+
- Enumerated fields become dropdowns during edit mode.
1683+
1684+
Parent/child table pattern examples:
1685+
- Idea 1-* Notes
1686+
- Character 1-* Dialog
1687+
- Quest 1-* Objectives
1688+
- Audio Profile 1-* Effects
1689+
1690+
Visual examples:
1691+
1692+
1. Default collapsed table.
1693+
1694+
| Idea | Pitch | Status | Updated | Notes | Actions |
1695+
| --- | --- | --- | --- | --- | --- |
1696+
| > Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete |
1697+
| > Clockwork Courier | Deliver messages through looping city... | New | 2026-06-20 | 0 Notes | Edit Delete |
1698+
| Add Idea | | | | | |
1699+
1700+
2. Expanded parent with child rows indented.
1701+
1702+
| Idea | Pitch | Status | Updated | Notes | Actions |
1703+
| --- | --- | --- | --- | --- | --- |
1704+
| v Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete |
1705+
| Note | Actions | | | | |
1706+
| Wind test needs traversal risks. | Edit Delete | | | | |
1707+
| Island height should read from camera. | Edit Delete | | | | |
1708+
| Add Note | | | | | |
1709+
1710+
3. Normal row with Edit/Delete.
1711+
1712+
| Idea | Pitch | Status | Updated | Notes | Actions |
1713+
| --- | --- | --- | --- | --- | --- |
1714+
| > Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete |
1715+
1716+
4. Edit row with Save/Cancel and dropdown status.
1717+
1718+
| Idea | Pitch | Status | Updated | Notes | Actions |
1719+
| --- | --- | --- | --- | --- | --- |
1720+
| [Sky Orchard] | [Grow floating islands...] | [Exploring v] | 2026-06-20 | 3 Notes | Save Cancel |
1721+
1722+
5. Add row with Save/Cancel.
1723+
1724+
| Idea | Pitch | Status | Updated | Notes | Actions |
1725+
| --- | --- | --- | --- | --- | --- |
1726+
| [New idea] | [Pitch] | [New v] | auto | 0 Notes | Save Cancel |
1727+
1728+
Explicit row-state rules:
1729+
- Normal row actions: Edit Delete.
1730+
- Edit row actions: Save Cancel.
1731+
- Add row actions: Save Cancel.
1732+
- Save/Cancel is row-level only.
1733+
- No page-level Save for normal row editing.
1734+
- Cancel restores previous row state.
1735+
- Save commits only the edited row.
1736+
- Multiple simultaneous row edits are prohibited unless explicitly approved.
1737+
16631738
## INPUT RESOLUTION RULES
16641739

16651740
- Discover real files and directories.
Lines changed: 39 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,57 @@
1-
# Codex Changed Files - PR_26171_033-idea-board-inline-accordion-cell
1+
# Codex Changed Files - PR_26171_039-table-first-workspace-governance
22

33
## Git Workflow
4-
- Current branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`.
4+
- Current branch: `codex/pr-26171-039-table-first-workspace-governance`.
55
- Expected starting branch: `main` (PASS before branch creation).
6-
- Created branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`.
6+
- Created branch: `codex/pr-26171-039-table-first-workspace-governance`.
77
- Push result: pending until after commit.
88
- PR URL: pending until after push.
99
- Merge result: pending until after PR validation/merge.
1010
- Final main commit: pending until after merge and final pull.
1111

1212
## Changed Files
13-
- assets/theme-v2/images/gfs-chevron-down.svg
14-
- assets/theme-v2/images/gfs-chevron-up.svg
15-
- docs_build/dev/codex_commands.md
16-
- docs_build/dev/commit_comment.txt
13+
- docs_build/dev/PROJECT_INSTRUCTIONS.md
1714
- docs_build/dev/reports/codex_changed_files.txt
1815
- docs_build/dev/reports/codex_review.diff
19-
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
20-
- docs_build/dev/reports/playwright_v8_coverage_report.txt
21-
- docs_build/pr/APPLY_PR_26171_033-idea-board-inline-accordion-cell.md
22-
- docs_build/pr/BUILD_PR_26171_033-idea-board-inline-accordion-cell.md
23-
- docs_build/pr/PLAN_PR_26171_033-idea-board-inline-accordion-cell.md
24-
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
25-
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
26-
- toolbox/idea-board/index.js
2716

2817
## Requirement Evidence
29-
- PASS: Separate `>` expand/collapse button removed from `toolbox/idea-board/index.js`; no `data-idea-board-notes-chevron` control remains.
30-
- PASS: No separate expand/collapse control column was added; the visible Idea table remains Idea, Pitch, Status, Updated, Notes, Actions.
31-
- PASS: Notes count is rendered as a plain informational span and no longer carries `data-idea-board-toggle-notes`.
32-
- PASS: Chevron image is rendered inside the Idea row header cell.
33-
- PASS: Collapsed rows use `assets/theme-v2/images/gfs-chevron-down.svg`.
34-
- PASS: Expanded rows use `assets/theme-v2/images/gfs-chevron-up.svg`.
35-
- PASS: The whole Idea cell carries the toggle target and handles click plus Enter/Space keyboard activation.
36-
- PASS: Expanded notes continue to render directly under the owning idea row.
37-
- PASS: Targeted Playwright verifies clicking Notes count does not expand from a collapsed state.
38-
- PASS: Targeted Playwright verifies clicking Notes count does not collapse from an expanded state.
39-
- PASS: Targeted Playwright verifies clicking the Idea cell expands/collapses and the chevron switches down/up.
40-
- PASS: Theme V2 chevron SVG assets were added under `assets/theme-v2/images/`.
18+
- PASS: Added `TABLE-FIRST WORKSPACE GOVERNANCE` section to `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
19+
- PASS: Section states primary work surface is a table.
20+
- PASS: Section says to prefer inline table workflows over forms.
21+
- PASS: Section prohibits detached selected-item context panels.
22+
- PASS: Section prohibits detached notes/detail panels when child rows can render under the parent row.
23+
- PASS: Parent/child patterns include Idea 1-* Notes, Character 1-* Dialog, Quest 1-* Objectives, and Audio Profile 1-* Effects.
24+
- PASS: Section says parent name cell owns accordion behavior.
25+
- PASS: Section says chevron appears inside parent name cell.
26+
- PASS: Section says entire parent name cell toggles expansion.
27+
- PASS: Section says child count columns are informational only.
28+
- PASS: Section says only one parent row may be expanded at a time.
29+
- PASS: Section says default state is all collapsed.
30+
- PASS: Section says child rows are indented.
31+
- PASS: Section says child Add button aligns with child rows.
32+
- PASS: Section says metadata remains stored but hidden unless explicitly needed.
33+
- PASS: Section says Add buttons are left aligned and self-describing.
34+
- PASS: Section says enumerated fields become dropdowns during edit mode.
35+
- PASS: Visual examples include default collapsed table, expanded parent with indented child rows, normal Edit/Delete row, edit Save/Cancel row with dropdown status, and add Save/Cancel row.
36+
- PASS: Explicit row-state rules include Normal row actions: Edit Delete.
37+
- PASS: Explicit row-state rules include Edit row actions: Save Cancel.
38+
- PASS: Explicit row-state rules include Add row actions: Save Cancel.
39+
- PASS: Explicit row-state rules state Save/Cancel is row-level only.
40+
- PASS: Explicit row-state rules prohibit page-level Save for normal row editing.
41+
- PASS: Explicit row-state rules state Cancel restores previous row state.
42+
- PASS: Explicit row-state rules state Save commits only the edited row.
43+
- PASS: Explicit row-state rules prohibit multiple simultaneous row edits unless explicitly approved.
44+
- PASS: Runtime code was not changed.
45+
- PASS: Tests were not changed.
46+
- PASS: Roadmap status was not changed.
4147

4248
## Validation
43-
- PASS: `node --check toolbox/idea-board/index.js`.
44-
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
45-
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
46-
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed).
47-
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed).
48-
- SKIP: Full samples smoke was not run; it is not in scope for this PR.
49+
- PASS: `git diff --check`.
50+
- PASS: Heading confirmation found `## TABLE-FIRST WORKSPACE GOVERNANCE`.
51+
- PASS: Visual examples confirmation found `Visual examples:` and numbered examples.
52+
- PASS: Save/Cancel row-state confirmation found edit/add examples and explicit row-state rules.
53+
- PASS: No Playwright impact; this PR is docs/workflow only.
4954

5055
## ZIP
51-
- Path: `tmp/PR_26171_033-idea-board-inline-accordion-cell_delta.zip`.
56+
- Path: `tmp/PR_26171_039-table-first-workspace-governance_delta.zip`.
5257
- Size and contents: reported after final ZIP generation.

0 commit comments

Comments
 (0)