|
1 | | -# Codex Changed Files - PR_26171_033-idea-board-inline-accordion-cell |
| 1 | +# Codex Changed Files - PR_26171_039-table-first-workspace-governance |
2 | 2 |
|
3 | 3 | ## Git Workflow |
4 | | -- Current branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`. |
| 4 | +- Current branch: `codex/pr-26171-039-table-first-workspace-governance`. |
5 | 5 | - Expected starting branch: `main` (PASS before branch creation). |
6 | | -- Created branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`. |
| 6 | +- Created branch: `codex/pr-26171-039-table-first-workspace-governance`. |
7 | 7 | - Push result: pending until after commit. |
8 | 8 | - PR URL: pending until after push. |
9 | 9 | - Merge result: pending until after PR validation/merge. |
10 | 10 | - Final main commit: pending until after merge and final pull. |
11 | 11 |
|
12 | 12 | ## Changed Files |
13 | | -- assets/theme-v2/images/gfs-chevron-down.svg |
14 | | -- assets/theme-v2/images/gfs-chevron-up.svg |
15 | | -- docs_build/dev/codex_commands.md |
16 | | -- docs_build/dev/commit_comment.txt |
| 13 | +- docs_build/dev/PROJECT_INSTRUCTIONS.md |
17 | 14 | - docs_build/dev/reports/codex_changed_files.txt |
18 | 15 | - docs_build/dev/reports/codex_review.diff |
19 | | -- docs_build/dev/reports/coverage_changed_js_guardrail.txt |
20 | | -- docs_build/dev/reports/playwright_v8_coverage_report.txt |
21 | | -- docs_build/pr/APPLY_PR_26171_033-idea-board-inline-accordion-cell.md |
22 | | -- docs_build/pr/BUILD_PR_26171_033-idea-board-inline-accordion-cell.md |
23 | | -- docs_build/pr/PLAN_PR_26171_033-idea-board-inline-accordion-cell.md |
24 | | -- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs |
25 | | -- tests/playwright/tools/ToolboxRoutePages.spec.mjs |
26 | | -- toolbox/idea-board/index.js |
27 | 16 |
|
28 | 17 | ## Requirement Evidence |
29 | | -- PASS: Separate `>` expand/collapse button removed from `toolbox/idea-board/index.js`; no `data-idea-board-notes-chevron` control remains. |
30 | | -- PASS: No separate expand/collapse control column was added; the visible Idea table remains Idea, Pitch, Status, Updated, Notes, Actions. |
31 | | -- PASS: Notes count is rendered as a plain informational span and no longer carries `data-idea-board-toggle-notes`. |
32 | | -- PASS: Chevron image is rendered inside the Idea row header cell. |
33 | | -- PASS: Collapsed rows use `assets/theme-v2/images/gfs-chevron-down.svg`. |
34 | | -- PASS: Expanded rows use `assets/theme-v2/images/gfs-chevron-up.svg`. |
35 | | -- PASS: The whole Idea cell carries the toggle target and handles click plus Enter/Space keyboard activation. |
36 | | -- PASS: Expanded notes continue to render directly under the owning idea row. |
37 | | -- PASS: Targeted Playwright verifies clicking Notes count does not expand from a collapsed state. |
38 | | -- PASS: Targeted Playwright verifies clicking Notes count does not collapse from an expanded state. |
39 | | -- PASS: Targeted Playwright verifies clicking the Idea cell expands/collapses and the chevron switches down/up. |
40 | | -- PASS: Theme V2 chevron SVG assets were added under `assets/theme-v2/images/`. |
| 18 | +- PASS: Added `TABLE-FIRST WORKSPACE GOVERNANCE` section to `docs_build/dev/PROJECT_INSTRUCTIONS.md`. |
| 19 | +- PASS: Section states primary work surface is a table. |
| 20 | +- PASS: Section says to prefer inline table workflows over forms. |
| 21 | +- PASS: Section prohibits detached selected-item context panels. |
| 22 | +- PASS: Section prohibits detached notes/detail panels when child rows can render under the parent row. |
| 23 | +- PASS: Parent/child patterns include Idea 1-* Notes, Character 1-* Dialog, Quest 1-* Objectives, and Audio Profile 1-* Effects. |
| 24 | +- PASS: Section says parent name cell owns accordion behavior. |
| 25 | +- PASS: Section says chevron appears inside parent name cell. |
| 26 | +- PASS: Section says entire parent name cell toggles expansion. |
| 27 | +- PASS: Section says child count columns are informational only. |
| 28 | +- PASS: Section says only one parent row may be expanded at a time. |
| 29 | +- PASS: Section says default state is all collapsed. |
| 30 | +- PASS: Section says child rows are indented. |
| 31 | +- PASS: Section says child Add button aligns with child rows. |
| 32 | +- PASS: Section says metadata remains stored but hidden unless explicitly needed. |
| 33 | +- PASS: Section says Add buttons are left aligned and self-describing. |
| 34 | +- PASS: Section says enumerated fields become dropdowns during edit mode. |
| 35 | +- PASS: Visual examples include default collapsed table, expanded parent with indented child rows, normal Edit/Delete row, edit Save/Cancel row with dropdown status, and add Save/Cancel row. |
| 36 | +- PASS: Explicit row-state rules include Normal row actions: Edit Delete. |
| 37 | +- PASS: Explicit row-state rules include Edit row actions: Save Cancel. |
| 38 | +- PASS: Explicit row-state rules include Add row actions: Save Cancel. |
| 39 | +- PASS: Explicit row-state rules state Save/Cancel is row-level only. |
| 40 | +- PASS: Explicit row-state rules prohibit page-level Save for normal row editing. |
| 41 | +- PASS: Explicit row-state rules state Cancel restores previous row state. |
| 42 | +- PASS: Explicit row-state rules state Save commits only the edited row. |
| 43 | +- PASS: Explicit row-state rules prohibit multiple simultaneous row edits unless explicitly approved. |
| 44 | +- PASS: Runtime code was not changed. |
| 45 | +- PASS: Tests were not changed. |
| 46 | +- PASS: Roadmap status was not changed. |
41 | 47 |
|
42 | 48 | ## Validation |
43 | | -- PASS: `node --check toolbox/idea-board/index.js`. |
44 | | -- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`. |
45 | | -- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`. |
46 | | -- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed). |
47 | | -- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed). |
48 | | -- SKIP: Full samples smoke was not run; it is not in scope for this PR. |
| 49 | +- PASS: `git diff --check`. |
| 50 | +- PASS: Heading confirmation found `## TABLE-FIRST WORKSPACE GOVERNANCE`. |
| 51 | +- PASS: Visual examples confirmation found `Visual examples:` and numbered examples. |
| 52 | +- PASS: Save/Cancel row-state confirmation found edit/add examples and explicit row-state rules. |
| 53 | +- PASS: No Playwright impact; this PR is docs/workflow only. |
49 | 54 |
|
50 | 55 | ## ZIP |
51 | | -- Path: `tmp/PR_26171_033-idea-board-inline-accordion-cell_delta.zip`. |
| 56 | +- Path: `tmp/PR_26171_039-table-first-workspace-governance_delta.zip`. |
52 | 57 | - Size and contents: reported after final ZIP generation. |
0 commit comments