Complete Admin cleanup, R2 asset validation, GFSP package lifecycle, backup foundation, and Project Workspace real project flow - PR_26168_237-through-244-platform-foundation-stack

Author: ToolboxAid

admin/infrastructure.html

@@ -90,22 +90,6 @@ <h3 id="admin-infrastructure-image-zoom-title">Game Foundry Infrastructure</h3>
                                 </tbody>
                             </table>
                         </div>
-                        <div class="table-wrapper">
-                            <table class="data-table" aria-label="Admin storage connectivity results">
-                                <caption>Storage Connectivity Results</caption>
-                                <thead>
-                                    <tr>
-                                        <th scope="col">Action</th>
-                                        <th scope="col">Status</th>
-                                        <th scope="col">Executed</th>
-                                        <th scope="col">Message</th>
-                                    </tr>
-                                </thead>
-                                <tbody data-admin-storage-connectivity-result-rows>
-                                    <tr><td>startup</td><td>SKIP</td><td>no</td><td>No storage connectivity action has been run.</td></tr>
-                                </tbody>
-                            </table>
-                        </div>
                     </section>
                     <aside class="tool-column tool-group-platform">
                         <div class="tool-column-header">
@@ -125,17 +109,7 @@ <h2>Inspector</h2>
                                 <summary>Guardrails</summary>
                                 <div class="accordion-body content-stack">
                                     <p>Infrastructure status remains a read-only Admin reference.</p>
-                                    <p>Storage connectivity tests run through the Local API and never expose secrets.</p>
-                                </div>
-                            </details>
-                            <details class="vertical-accordion" open>
-                                <summary>Storage Connectivity</summary>
-                                <div class="accordion-body content-stack">
-                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-list">List</button>
-                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-write-test-object">Write Test Object</button>
-                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-read-test-object">Read Test Object</button>
-                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-delete-test-object">Delete Test Object</button>
-                                    <p class="status" role="status" data-admin-storage-connectivity-status>Storage connectivity not run.</p>
+                                    <p>Storage connectivity tests run from Admin System Health and never expose secrets.</p>
                                 </div>
                             </details>
                         </div>

admin/operations.html

@@ -32,8 +32,8 @@ <h2>Admin Operations</h2>
                             <details class="vertical-accordion" open>
                                 <summary>Project Packaging</summary>
                                 <div class="accordion-body content-stack">
-                                    <p>Package actions are routed through the Local API. Full .gfsp execution returns visible not implemented diagnostics until package tooling is completed.</p>
-                                    <p>Import Project Package requires explicit confirmation behavior before any overwrite can proceed.</p>
+                                    <p>Package actions are routed through the Local API. Export, Validate, and Import use the server-owned .gfsp package contract.</p>
+                                    <p>Import Project Package validates first and requires explicit confirmation before Replace Existing can proceed.</p>
                                     <div class="content-stack" data-admin-operation-group="project-packaging">
                                         <p class="status">Loading Project Packaging actions.</p>
                                     </div>
@@ -42,8 +42,8 @@ <h2>Admin Operations</h2>
                             <details class="vertical-accordion" open>
                                 <summary>Backup &amp; Recovery</summary>
                                 <div class="accordion-body content-stack">
-                                    <p>Backup and restore actions are staged for reviewed server-side execution.</p>
-                                    <p>Restore From Backup is risky and requires explicit confirmation messaging before any restore behavior is implemented.</p>
+                                    <p>Backup and restore actions use guarded Local API contracts.</p>
+                                    <p>Restore From Backup reports the current environment lane and requires explicit RESTORE confirmation before runtime state is restored.</p>
                                     <div class="content-stack" data-admin-operation-group="backup-recovery">
                                         <p class="status">Loading Backup &amp; Recovery actions.</p>
                                     </div>

assets/theme-v2/js/admin-infrastructure.js

@@ -1,6 +1,5 @@
 import {
-    readAdminInfrastructureStoragePathStatus,
-    runAdminInfrastructureStorageConnectivityAction
+    readAdminInfrastructureStoragePathStatus
 } from "../../../src/engine/api/admin-infrastructure-api-client.js";
 
 const STORAGE_PATH_LANES = Object.freeze([
@@ -13,46 +12,16 @@ const STORAGE_PATH_LANES = Object.freeze([
 class AdminInfrastructureStoragePathStatus {
     constructor(root) {
         this.root = root;
-        this.connectivityActionButtons = Array.from(root.querySelectorAll("[data-admin-storage-connectivity-action]"));
-        this.connectivityRows = root.querySelector("[data-admin-storage-connectivity-result-rows]");
-        this.connectivityStatus = root.querySelector("[data-admin-storage-connectivity-status]");
         this.rows = root.querySelector("[data-admin-storage-path-status-rows]");
     }
 
     init() {
         if (!this.rows) {
             return;
         }
-        this.connectivityActionButtons.forEach((button) => {
-            button.addEventListener("click", () => this.runStorageConnectivityAction(button.dataset.adminStorageConnectivityAction));
-        });
         this.load();
     }
 
-    setConnectivityStatus(status, message) {
-        if (this.connectivityStatus) {
-            this.connectivityStatus.textContent = `${status}: ${message}`;
-        }
-    }
-
-    appendConnectivityResult(result = {}) {
-        if (!this.connectivityRows) {
-            return;
-        }
-        const row = document.createElement("tr");
-        [
-            result.actionId || "storage-connectivity",
-            result.status || "WARN",
-            result.executed === true ? "yes" : "no",
-            result.message || "No storage connectivity message returned.",
-        ].forEach((value) => {
-            const cell = document.createElement("td");
-            cell.textContent = value;
-            row.append(cell);
-        });
-        this.connectivityRows.prepend(row);
-    }
-
     renderRows(rows) {
         this.rows.replaceChildren();
         rows.forEach((row) => {
@@ -90,15 +59,6 @@ class AdminInfrastructureStoragePathStatus {
         }
     }
 
-    runStorageConnectivityAction(actionId) {
-        try {
-            const result = runAdminInfrastructureStorageConnectivityAction(actionId);
-            this.appendConnectivityResult(result);
-            this.setConnectivityStatus(result.status || "WARN", result.message || "Storage connectivity action returned no message.");
-        } catch (error) {
-            this.setConnectivityStatus("FAIL", error instanceof Error ? error.message : "Storage connectivity action failed.");
-        }
-    }
 }
 
 document.addEventListener("DOMContentLoaded", () => {

assets/theme-v2/js/admin-operations.js

@@ -28,6 +28,57 @@ class AdminOperationsController {
         this.status.textContent = `${status}: ${message}`;
     }
 
+    createLabeledControl(labelText, control) {
+        const label = document.createElement("label");
+        label.textContent = labelText;
+        label.append(control);
+        return label;
+    }
+
+    renderActionInputs(container, action) {
+        if (action.requiresPackageFile) {
+            const input = document.createElement("input");
+            input.accept = ".gfsp";
+            input.dataset.adminOperationPackageFile = action.id || "";
+            input.type = "file";
+            container.append(this.createLabeledControl("Project Package", input));
+        }
+        if (action.requiresBackupFile) {
+            const input = document.createElement("input");
+            input.accept = ".json";
+            input.dataset.adminOperationBackupFile = action.id || "";
+            input.type = "file";
+            container.append(this.createLabeledControl("Backup File", input));
+        }
+        if (action.supportsImportModes) {
+            const select = document.createElement("select");
+            select.dataset.adminOperationImportMode = action.id || "";
+            [
+                ["import-as-new", "Import As New Project"],
+                ["replace-existing", "Replace Existing"],
+            ].forEach(([value, text]) => {
+                const option = document.createElement("option");
+                option.value = value;
+                option.textContent = text;
+                select.append(option);
+            });
+            container.append(this.createLabeledControl("Import Mode", select));
+        }
+        if (action.confirmationRequired) {
+            const checkbox = document.createElement("input");
+            checkbox.dataset.adminOperationConfirmation = action.id || "";
+            checkbox.type = "checkbox";
+            container.append(this.createLabeledControl("Confirm Risky Operation", checkbox));
+            if (action.confirmationPhrase) {
+                const phrase = document.createElement("input");
+                phrase.dataset.adminOperationConfirmationPhrase = action.id || "";
+                phrase.placeholder = action.confirmationPhrase;
+                phrase.type = "text";
+                container.append(this.createLabeledControl(`Type ${action.confirmationPhrase}`, phrase));
+            }
+        }
+    }
+
     renderActionGroups(actionGroups = []) {
         this.groupContainers.forEach((container, groupId) => {
             const group = actionGroups.find((candidate) => candidate.id === groupId);
@@ -40,12 +91,13 @@ class AdminOperationsController {
                 return;
             }
             group.actions.forEach((action, index) => {
+                this.renderActionInputs(container, action);
                 const button = document.createElement("button");
                 button.className = index === 0 ? "btn btn--compact primary" : "btn btn--compact";
                 button.dataset.adminOperationAction = action.id || "";
                 button.textContent = action.label || action.id || "Unnamed Action";
                 button.type = "button";
-                button.addEventListener("click", () => this.runAction(button.dataset.adminOperationAction));
+                button.addEventListener("click", () => this.runAction(action));
                 container.append(button);
                 if (action.confirmationRequired || action.risky || action.notImplemented) {
                     const warning = document.createElement("p");
@@ -94,6 +146,53 @@ class AdminOperationsController {
         this.resultRows.prepend(row);
     }
 
+    async readFileAsBase64(file) {
+        const bytes = new Uint8Array(await file.arrayBuffer());
+        const chunkSize = 32768;
+        let binary = "";
+        for (let index = 0; index < bytes.length; index += chunkSize) {
+            binary += String.fromCharCode(...bytes.slice(index, index + chunkSize));
+        }
+        return btoa(binary);
+    }
+
+    async collectActionOptions(action = {}) {
+        const options = {};
+        const packageFileInput = this.root.querySelector(`[data-admin-operation-package-file='${action.id}']`);
+        const packageFile = packageFileInput?.files?.[0];
+        if (packageFile) {
+            options.packageFileName = packageFile.name;
+            options.packageBytesBase64 = await this.readFileAsBase64(packageFile);
+        }
+
+        const backupFileInput = this.root.querySelector(`[data-admin-operation-backup-file='${action.id}']`);
+        const backupFile = backupFileInput?.files?.[0];
+        if (backupFile) {
+            options.backupFileName = backupFile.name;
+            options.backupBytesBase64 = await this.readFileAsBase64(backupFile);
+        }
+
+        const importMode = this.root.querySelector(`[data-admin-operation-import-mode='${action.id}']`);
+        if (importMode) {
+            options.importMode = importMode.value;
+        }
+
+        const confirmation = this.root.querySelector(`[data-admin-operation-confirmation='${action.id}']`);
+        if (confirmation) {
+            if (action.id === "restore-from-backup") {
+                options.restoreConfirmed = confirmation.checked;
+            } else {
+                options.overwriteConfirmed = confirmation.checked;
+            }
+        }
+
+        const phrase = this.root.querySelector(`[data-admin-operation-confirmation-phrase='${action.id}']`);
+        if (phrase) {
+            options.confirmationPhrase = phrase.value;
+        }
+        return options;
+    }
+
     load() {
         try {
             const payload = readAdminOperationsStatus();
@@ -107,9 +206,11 @@ class AdminOperationsController {
         }
     }
 
-    runAction(actionId) {
+    async runAction(action = {}) {
         try {
-            const result = runAdminOperationAction(actionId);
+            this.setStatus("SKIP", `Running ${action.label || action.id || "Admin Operation"} through the Local API.`);
+            const options = await this.collectActionOptions(action);
+            const result = runAdminOperationAction(action.id, options);
             this.appendResult(result);
             this.setStatus(result.status || "SKIP", result.message || "Admin operation returned no message.");
         } catch (error) {

assets/theme-v2/js/gamefoundry-partials.js

@@ -75,14 +75,11 @@
         owner: "admin/db-viewer.html",
         "admin-operations": "admin/operations.html",
         "admin-site-settings": "admin/site-settings.html",
-        "admin-site-setup": "admin/site-setup.html",
         "admin-branding": "admin/branding.html",
         "admin-themes": "admin/themes.html",
         "admin-design-system": "admin/design-system.html",
         "admin-controls": "admin/controls.html",
         "admin-db-viewer": "admin/db-viewer.html",
-        "admin-environments": "admin/environments.html",
-        "admin-game-migration": "admin/game-migration.html",
         "admin-grouping-colors": "admin/grouping-colors.html",
         "admin-platform-settings": "admin/platform-settings.html",
         "admin-ratings": "admin/ratings.html",

docs_build/codex/decisions/project-packages.md

@@ -6,6 +6,30 @@
 
 Game Foundry Studio project packages use an internal ZIP-based package format. The `.gfsp` extension identifies the package as a Game Foundry Studio Project while preserving the operational advantages of a ZIP container for export, import, validation, and inspection.
 
+## Package Metadata Contract
+
+The runtime package scaffold writes these required internal files:
+
+- `metadata/package.json`
+- `project/project.json`
+- `assets/asset-references.json`
+
+`metadata/package.json` owns the package identity and must include:
+
+- `packageType`: `Game Foundry Studio Project`
+- `extension`: `.gfsp`
+- `contractVersion`
+- `filename`
+- `filenameFormat`
+- `createdAt`
+- `project.projectKey`
+- `project.name`
+- `requiredFiles`
+
+`project/project.json` owns the exported Project Workspace project record. It must carry the API-owned project key, local record id, display name, owner key, and status.
+
+`assets/asset-references.json` owns storage references only. Asset binary/object bytes stay in configured project asset storage and are referenced by storage object keys; package metadata must not include storage secrets or browser-owned product data.
+
 ## Filename Format
 
 Project package filenames use:

docs_build/dev/reports/PR_26168_237-admin-ia-cleanup.md

@@ -0,0 +1,33 @@
+# PR_26168_237-admin-ia-cleanup
+
+## Branch Validation
+- PASS: current branch verified as `main`.
+- Expected branch: `main`.
+
+## Summary
+- Removed duplicated storage-connectivity status/actions from `admin/infrastructure.html`.
+- Kept Admin ownership clear: Infrastructure is architecture/reference, System Health owns status/connectivity, Operations owns actions.
+- Removed obsolete Admin status route aliases for `admin-site-setup`, `admin-environments`, and `admin-game-migration` from the shared route resolver.
+
+## Requirement Checklist
+- PASS: Remove/hide obsolete Admin/Owner status pages now replaced by System Health.
+- PASS: Verify navigation consistency; Admin menu still exposes Infrastructure, Operations, Platform Settings, System Health, Tool Votes, Users.
+- PASS: Remove duplicate health/status ownership from Infrastructure.
+- PASS: Keep PR222-236 behavior intact; System Health retains storage connectivity startup/manual actions.
+- PASS: No sample JSON or `start_of_day` changes.
+
+## Validation Lane Report
+- PASS: `npx playwright test tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs ... --workers=1 --reporter=line` targeted Admin/IA/System Health/Operations subset, 12/12 combined targeted tests passed.
+- PASS: `node --check assets/theme-v2/js/admin-infrastructure.js`.
+- PASS: `node --check assets/theme-v2/js/gamefoundry-partials.js`.
+- PASS: static HTML guard found no inline scripts/styles/event handlers in touched pages.
+- PASS: `npm run validate:browser-env-agnostic`.
+- PASS/WARN: Playwright V8 coverage report generated at `docs_build/dev/reports/playwright_v8_coverage_report.txt`; server-side files report advisory WARN when not browser-collected.
+
+## Manual Validation Notes
+- Infrastructure still displays only `assets/GFS-Infrastructure v1-3.png`.
+- Infrastructure path status remains visible for `/dev/projects/`, `/ist/projects/`, `/uat/projects/`, `/prd/projects/`.
+- Storage connectivity controls are visible on Admin System Health only.
+
+## Full Samples Decision
+- SKIP: no sample JSON or sample launch/runtime surface was changed.