Skip to content

Commit 28d163c

Browse files
committed
OWNER 009 finish artifact and template cleanup
1 parent 27ad97f commit 28d163c

18 files changed

Lines changed: 640 additions & 271 deletions

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ tests/results/
1919
tests/results/**
2020
dev/workspace/artifacts/tmp/
2121
dev/workspace/artifacts/tmp/**
22-
dev/workspace/artifacts/tmp/test-results/
23-
dev/workspace/artifacts/tmp/test-results/**
22+
dev/workspace/artifacts/test-results/
23+
dev/workspace/artifacts/test-results/**
2424
dev/workspace/artifacts/zips/
2525
dev/workspace/artifacts/zips/**
2626
tmp/

dev/config/playwright.config.cjs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,23 @@ const repoPath = (...segments) => path.join(repoRoot, ...segments);
55

66
module.exports = {
77
timeout: 120000,
8-
outputDir: repoPath("dev", "workspace", "artifacts", "tmp", "test-results"),
8+
outputDir: repoPath("dev", "workspace", "artifacts", "test-results"),
99
projects: [
1010
{
1111
name: "ui",
1212
testDir: repoPath("dev", "tests", "ui"),
13-
outputDir: repoPath("dev", "workspace", "artifacts", "tmp", "test-results", "artifacts")
13+
outputDir: repoPath("dev", "workspace", "artifacts", "test-results", "artifacts")
1414
},
1515
{
1616
name: "playwright",
1717
testDir: repoPath("dev", "tests", "playwright"),
18-
outputDir: repoPath("dev", "workspace", "artifacts", "tmp", "test-results", "artifacts")
18+
outputDir: repoPath("dev", "workspace", "artifacts", "test-results", "artifacts")
1919
}
2020
],
2121
reporter: [
2222
["list"],
23-
["html", { outputFolder: repoPath("dev", "workspace", "artifacts", "tmp", "test-results", "report"), open: "always" }],
24-
["json", { outputFile: repoPath("dev", "workspace", "artifacts", "tmp", "test-results", "playwright-results.json") }]
23+
["html", { outputFolder: repoPath("dev", "workspace", "artifacts", "test-results", "report"), open: "always" }],
24+
["json", { outputFile: repoPath("dev", "workspace", "artifacts", "test-results", "playwright-results.json") }]
2525
],
2626
use: {
2727
headless: false,
Lines changed: 31 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,39 @@
11
# PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
22

3-
Status: PASS
3+
Updated: 2026-06-27T22:21:05.953Z
44
Team: OWNER
55
Branch: PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
6-
Current HEAD before this update: 6c92de7eff93b4f5f1b951b8b0886a357cab626c
7-
Report refreshed: 2026-06-27T22:05:28.695Z
8-
ZIP: dev/workspace/artifacts/zips/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_delta.zip
6+
Scope: Finish PR_009 artifact collection and template cleanup.
97

10-
## Purpose
8+
## Summary
9+
- Moved generated Playwright test output ownership from dev/config/tmp/test-results/ to dev/workspace/artifacts/test-results/.
10+
- Kept dev/config/ limited to configuration files.
11+
- Converted the reusable Tool Template V2 file into dev/templates/tool-template-v2/index.html and removed the empty legacy toolbox/_tool_template-v2/ directory.
12+
- Updated active tests, coverage reporting, Playwright output config, and vector template path strings to the new template/artifact locations.
1113

12-
Finish the already-started root cleanup/workspace finalization PR.
14+
## Changed Files
15+
M .gitignore
16+
M dev/config/playwright.config.cjs
17+
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization.md
18+
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_branch-validation.md
19+
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_manual-validation-notes.md
20+
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_requirement-checklist.md
21+
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_validation-report.md
22+
M dev/scripts/validate-canonical-repository-structure.mjs
23+
M dev/scripts/validate-tool-registry.mjs
24+
R100 dev/templates/tool-template-v2.html dev/templates/tool-template-v2/index.html
25+
M dev/tests/helpers/playwrightV8CoverageReporter.mjs
26+
M dev/tests/playwright/tools/RootToolsFutureState.spec.mjs
27+
M dev/tests/playwright_installation.txt
28+
M dev/tests/tools/VectorNativeTemplate.test.mjs
29+
M src/shared/toolbox/vectorNativeTemplate.js
30+
M src/shared/toolbox/vectorTemplateSampleGame.js
1331

14-
## Scope Completed
32+
## Validation
33+
- PASS - npm run validate:canonical-structure
34+
- PASS - git diff --check
35+
- PASS - node ./dev/scripts/run-platform-validation-suite.mjs (8/8 scenarios)
36+
- PASS - node ./dev/scripts/run-node-test-files.mjs dev/tests/tools/VectorNativeTemplate.test.mjs
1537

16-
- Confirmed tracked dev/docs_build content is now under dev/build.
17-
- Confirmed active Project Instructions live at dev/build/ProjectInstructions.
18-
- Removed root projects and root tmp leftovers earlier in this PR; neither exists now.
19-
- Removed accidental generated ziproot folder from dev/workspace/artifacts/tmp.
20-
- Moved docker-compose.override.yml to deploy/docker-compose.override.yml.
21-
- Moved ignored local scripts/untracked scratch folder to dev/scripts/untracked.
22-
- Confirmed stale root codex report copies do not remain; active reports live under dev/reports.
23-
- Confirmed tracked dupes_called.txt is already under dev/reports.
24-
- Confirmed developer wrapper scripts are under dev/scripts.
25-
- Confirmed reusable templates are under dev/templates.
26-
- Updated references for moved build, template, Docker override, and script scratch locations.
27-
28-
## Notes
29-
30-
- No production page directories were moved.
31-
- Runtime/business logic was not moved into dev.
32-
- dev/scripts/untracked remains ignored developer-local scratch.
38+
## Blockers
39+
None.
Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
# PR_26179_OWNER_009-root-cleanup-and-workspace-finalization Branch Validation
1+
# Branch Validation - PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
22

3-
| Check | Result | Evidence |
4-
| --- | --- | --- |
5-
| Expected branch | PASS | PR_26179_OWNER_009-root-cleanup-and-workspace-finalization |
6-
| Worktree before edits | PASS | Clean before continuation edits. |
7-
| Scope attribution | PASS | Changes are root cleanup/workspace finalization only. |
8-
| No main commit | PASS | Work remained on the PR branch. |
3+
Updated: 2026-06-27T22:21:05.953Z
4+
5+
- Current branch: PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
6+
- Expected branch: PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
7+
- Branch validation: PASS
8+
- Worktree state before report refresh: DIRTY with intended PR changes
9+
- Scope validation: PASS - changes are limited to root cleanup/workspace artifact/template ownership and required reports.
Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
# PR_26179_OWNER_009-root-cleanup-and-workspace-finalization Manual Validation Notes
1+
# Manual Validation Notes - PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
22

3-
- Confirmed docker-compose.override.yml no longer exists at root and deploy/docker-compose.override.yml exists.
4-
- Confirmed scripts/ and scripts/untracked/ no longer exist at root.
5-
- Confirmed dev/scripts/untracked/ exists as ignored local scratch.
6-
- Confirmed generated ziproot folder is absent at root and under dev/workspace/artifacts/tmp.
7-
- Confirmed dev/build exists and dev/docs_build does not.
8-
- Confirmed projects/ does not exist.
9-
- Confirmed root codex_changed_files.txt and codex_review.diff do not exist.
3+
Updated: 2026-06-27T22:21:05.953Z
4+
5+
- Confirmed dev/workspace/artifacts/test-results/ exists and dev/config/tmp/ is removed.
6+
- Confirmed dev/config/ contains only configuration files.
7+
- Confirmed toolbox/_tool_template-v2/ is removed and no production toolbox pages were moved.
8+
- Confirmed dev/templates/tool-template-v2/index.html exists.
9+
- Confirmed root projects/ and root tmp/ are absent.
10+
- Confirmed deploy/docker-compose.override.yml exists.
11+
- Blockers: none.
Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
1-
# PR_26179_OWNER_009-root-cleanup-and-workspace-finalization Requirement Checklist
1+
# Requirement Checklist - PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
22

3-
| Status | Requirement | Evidence |
3+
Updated: 2026-06-27T22:21:05.953Z
4+
5+
| Requirement | Status | Notes |
46
| --- | --- | --- |
5-
| PASS | Continue on current branch | Work continued on PR_26179_OWNER_009-root-cleanup-and-workspace-finalization. |
6-
| PASS | Do not switch to main | No branch switch was performed. |
7-
| PASS | Rename dev/docs_build/ to dev/build/ | Already complete; dev/build exists and dev/docs_build does not. |
8-
| PASS | Update all references | Active references use dev/build; old scripts/untracked report mentions were updated to dev/scripts/untracked. |
9-
| PASS | Remove root projects/ | projects/ does not exist. |
10-
| PASS | Remove generated ziproot | PR ziproot staging folder does not exist at root or under dev/workspace/artifacts/tmp. |
11-
| PASS | Move docker-compose.override.yml | File moved to deploy/docker-compose.override.yml. |
12-
| PASS | Move scripts/untracked/ | Ignored scratch folder moved to dev/scripts/untracked/ and ignored in .gitignore. |
13-
| PASS | Move stale root codex artifacts | Root codex_changed_files.txt and codex_review.diff do not exist; active deliverables are under dev/reports. |
14-
| PASS | Move dupes_called.txt | Tracked artifact is under dev/reports/dupes_called.txt from earlier OWNER_009 cleanup. |
15-
| PASS | Move developer scripts | run_all and run_preprocessor cmd/ps1 files are under dev/scripts. |
16-
| PASS | Move reusable templates | page-template-v2.html and tool-template-v2.html are under dev/templates. |
17-
| PASS | Keep root product/config set | Required root product directories and standard config remain. |
18-
| PASS | Validate canonical structure | npm run validate:canonical-structure PASS. |
19-
| PASS | Validate diff whitespace | git diff --check PASS. |
20-
| PASS | Validate platform suite | node ./dev/scripts/run-platform-validation-suite.mjs PASS. |
7+
| Move dev/config/tmp/test-results/ to dev/workspace/artifacts/test-results/ | PASS | Existing Playwright test output was moved to dev/workspace/artifacts/test-results/. |
8+
| Remove dev/config/tmp/ if empty | PASS | dev/config/tmp/ was empty after the move and was removed. |
9+
| Generated test/report output lives under dev/workspace/artifacts/ | PASS | Playwright config now writes test results, artifacts, HTML report, and JSON report to dev/workspace/artifacts/test-results/. |
10+
| Keep dev/config/ for config files only | PASS | dev/config/ contains only configuration files. |
11+
| Move toolbox/_tool_template-v2/ to dev/templates/tool-template-v2/ | PASS | The legacy toolbox template folder was empty and removed; the tracked reusable template is now dev/templates/tool-template-v2/index.html. |
12+
| Remove toolbox/_tool_template-v2/ after move | PASS | toolbox/_tool_template-v2/ no longer exists. |
13+
| Do not move production toolbox pages | PASS | No production toolbox tool pages were moved. |
14+
| No root projects/ | PASS | projects/ is absent at repository root. |
15+
| No root tmp/ | PASS | tmp/ is absent at repository root. |
16+
| deploy/docker-compose.override.yml exists | PASS | deploy/docker-compose.override.yml exists. |
Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
# PR_26179_OWNER_009-root-cleanup-and-workspace-finalization Validation Report
1+
# Validation Report - PR_26179_OWNER_009-root-cleanup-and-workspace-finalization
22

3-
Status: PASS
3+
Updated: 2026-06-27T22:21:05.953Z
44

5-
| Command | Result | Notes |
5+
| Lane | Result | Notes |
66
| --- | --- | --- |
7-
| npm run validate:canonical-structure | PASS | Canonical repository structure guardrail passed. |
8-
| git diff --check | PASS | No whitespace errors reported. |
9-
| node ./dev/scripts/run-platform-validation-suite.mjs | PASS | Platform validation suite passed 8/8 scenarios; CI gate green. |
7+
| npm run validate:canonical-structure | PASS | Blocking violations: 0; approved legacy exceptions: 498. |
8+
| git diff --check | PASS | Only line-ending conversion warnings from Git on Windows; no whitespace errors. |
9+
| node ./dev/scripts/run-platform-validation-suite.mjs | PASS | 8/8 deterministic platform scenarios passed. |
10+
| node ./dev/scripts/run-node-test-files.mjs dev/tests/tools/VectorNativeTemplate.test.mjs | PASS | 1/1 targeted node test file passed. |
1011

11-
No Playwright browser lane was run; this update is root/dev workspace cleanup with no production page movement.
12+
Playwright full smoke was not run; no production page implementation was changed.
Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,18 @@
1-
M .gitignore
2-
R100 docker-compose.override.yml deploy/docker-compose.override.yml
3-
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization.md
4-
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_branch-validation.md
5-
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_manual-validation-notes.md
6-
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_requirement-checklist.md
7-
M dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_validation-report.md
8-
M dev/reports/codex_changed_files.txt
9-
M dev/reports/codex_review.diff
10-
M dev/reports/docs_archive_test_output_cleanup_report.md
11-
M dev/reports/legacy_surface_elimination_report.md
1+
.gitignore
2+
dev/config/playwright.config.cjs
3+
dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization.md
4+
dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_branch-validation.md
5+
dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_manual-validation-notes.md
6+
dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_requirement-checklist.md
7+
dev/reports/PR_26179_OWNER_009-root-cleanup-and-workspace-finalization_validation-report.md
8+
dev/reports/codex_changed_files.txt
9+
dev/reports/codex_review.diff
10+
dev/scripts/validate-canonical-repository-structure.mjs
11+
dev/scripts/validate-tool-registry.mjs
12+
dev/templates/tool-template-v2/index.html
13+
dev/tests/helpers/playwrightV8CoverageReporter.mjs
14+
dev/tests/playwright/tools/RootToolsFutureState.spec.mjs
15+
dev/tests/playwright_installation.txt
16+
dev/tests/tools/VectorNativeTemplate.test.mjs
17+
src/shared/toolbox/vectorNativeTemplate.js
18+
src/shared/toolbox/vectorTemplateSampleGame.js

0 commit comments

Comments
 (0)