Remove default source palettes and tighten Palette sort and size controls - PR_26156_170-palette-source-and-control-cleanup

ToolboxAid · ToolboxAid · commit 28e4938b6ba5 · 2026-06-05T18:50:41.000-04:00
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -6,11 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/assets/assets.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1013/1013; executed functions 95/110
-(92%) toolbox/colors/colors.js - executed lines 580/580; executed functions 59/64
+(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
+(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
 
 Guardrail warnings:
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) toolbox/assets/assets.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(100%) none - no changed runtime JS coverage warnings
diff --git a/docs_build/dev/reports/dependency_gating_report.md b/docs_build/dev/reports/dependency_gating_report.md
@@ -1,6 +1,6 @@
 # Dependency Gating Report
 
-Generated: 2026-06-05T21:27:53.718Z
+Generated: 2026-06-05T22:47:48.644Z
 Status: PASS
 
 ## Gate Order
diff --git a/docs_build/dev/reports/dependency_hydration_reuse_report.md b/docs_build/dev/reports/dependency_hydration_reuse_report.md
@@ -1,6 +1,6 @@
 # Dependency Hydration Reuse Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/execution_graph_reuse_report.md b/docs_build/dev/reports/execution_graph_reuse_report.md
@@ -1,6 +1,6 @@
 # Execution Graph Reuse Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/failure_fingerprint_report.md b/docs_build/dev/reports/failure_fingerprint_report.md
@@ -1,6 +1,6 @@
 # Failure Fingerprint Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/incremental_validation_report.md b/docs_build/dev/reports/incremental_validation_report.md
@@ -1,6 +1,6 @@
 # Incremental Validation Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Reuse Summary
diff --git a/docs_build/dev/reports/lane_compilation_report.md b/docs_build/dev/reports/lane_compilation_report.md
@@ -1,6 +1,6 @@
 # Lane Compilation Report
 
-Generated: 2026-06-05T21:27:53.718Z
+Generated: 2026-06-05T22:47:48.644Z
 Status: PASS
 
 ## Lane Graph
diff --git a/docs_build/dev/reports/lane_deduplication_report.md b/docs_build/dev/reports/lane_deduplication_report.md
@@ -1,6 +1,6 @@
 # Lane Deduplication Report
 
-Generated: 2026-06-05T21:27:53.718Z
+Generated: 2026-06-05T22:47:48.644Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/lane_input_validation_report.md b/docs_build/dev/reports/lane_input_validation_report.md
@@ -1,6 +1,6 @@
 # Lane Input Validation Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Input Files
diff --git a/docs_build/dev/reports/lane_runtime_optimization_report.md b/docs_build/dev/reports/lane_runtime_optimization_report.md
@@ -1,6 +1,6 @@
 # Lane Runtime Optimization Report
 
-Generated: 2026-06-05T21:27:53.718Z
+Generated: 2026-06-05T22:47:48.644Z
 Status: PASS
 
 ## Runtime Cost Summary
diff --git a/docs_build/dev/reports/lane_snapshot_report.md b/docs_build/dev/reports/lane_snapshot_report.md
@@ -1,6 +1,6 @@
 # Lane Snapshot Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 Snapshot directory: docs_build/dev/reports/lane_snapshots
 
diff --git a/docs_build/dev/reports/lane_warm_start_report.md b/docs_build/dev/reports/lane_warm_start_report.md
@@ -1,6 +1,6 @@
 # Lane Warm-Start Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 Warm-start directory: docs_build/dev/reports/lane_warm_starts
 
diff --git a/docs_build/dev/reports/monolith_trigger_removal_report.md b/docs_build/dev/reports/monolith_trigger_removal_report.md
@@ -1,6 +1,6 @@
 # Monolith Trigger Removal Report
 
-Generated: 2026-06-05T21:27:53.721Z
+Generated: 2026-06-05T22:47:48.647Z
 Status: PASS
 
 ## Removed Broad Execution Triggers
diff --git a/docs_build/dev/reports/palette-source-and-control-cleanup-report.md b/docs_build/dev/reports/palette-source-and-control-cleanup-report.md
@@ -0,0 +1,55 @@
+# PR_26156_170 Palette Source And Control Cleanup Report
+
+## Result
+PASS
+
+## Scope
+- Removed hardcoded/default source palette loading from the Palette Tool repository.
+- Source palettes now come from `palette_source_swatches` DB/mock-DB rows only.
+- Added a visible empty-state diagnostic when no source palette rows exist.
+- Replaced Palette Tool sort selects with small left-anchored buttons:
+  - Hue
+  - Sat
+  - Brit
+  - Name
+  - Tag
+- Replaced Palette Tool size selects with small right-anchored buttons:
+  - Small
+  - Medium
+  - Large
+- Applied the same control model to Active Project Palette and Source Swatches.
+
+## Source Palette Behavior
+- `DEFAULT_SOURCE_PALETTES` and `DEFAULT_SOURCE_PALETTE_LABELS` were removed.
+- `toolbox/colors/colors.js` no longer imports `src/engine/paletteList.js`.
+- `createProjectWorkspacePaletteRepository()` reads source palette swatches from:
+  - `options.sourcePaletteRows`
+  - `options.tables.palette_source_swatches`
+- Empty source rows render `No source palettes found. Add palette_source_swatches mock-DB records to browse source colors.`
+
+## UI Behavior
+- Active sort buttons use `primary` and `aria-pressed=true` for the selected sort.
+- Active sort direction renders a caret indicator in the active button text.
+- Active size buttons use `primary` and `aria-pressed=true`.
+- Source swatches and active palette colors render as swatch-only tiles with native browser `title` tooltips.
+- The swatch pin remains in the upper-right corner of the swatch tile.
+- Hover glow remains provided by existing Theme V2 `.palette-swatch-tile:hover` CSS.
+
+## CSS
+- No new CSS was added for this BUILD.
+- Existing reusable Theme V2 utilities are used for button groups, alignment, swatch tiles, tooltip/title behavior, and hover glow.
+
+## Files Changed For Implementation
+- `toolbox/colors/palette-workspace-repository.js`
+- `toolbox/colors/colors.js`
+- `toolbox/colors/index.html`
+- `tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+
+## Validation Summary
+- Targeted Palette Tool runtime/UI lane: PASS.
+- Static changed-file validation: PASS.
+- `DEFAULT_SOURCE_PALETTES` usage verification: PASS, no matches.
+- Empty source palette state: PASS.
+- Sort button alignment, active state, and caret direction: PASS.
+- Size button alignment and active state: PASS.
+- Full samples smoke: not run per BUILD instruction.
diff --git a/docs_build/dev/reports/persistent_lane_manifest_report.md b/docs_build/dev/reports/persistent_lane_manifest_report.md
@@ -1,6 +1,6 @@
 # Persistent Lane Manifest Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 Manifest directory: docs_build/dev/reports/lane_manifests
 
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -12,33 +12,26 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(83%) Toolbox Index - exercised 4 runtime JS files
+(77%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/assets/assets.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1013/1013; executed functions 95/110
-(92%) toolbox/colors/colors.js - executed lines 580/580; executed functions 59/64
+(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
+(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
+(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1013/1013; executed functions 95/110
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
-(92%) toolbox/colors/colors.js - executed lines 580/580; executed functions 59/64
-(100%) src/engine/paletteList.js - executed lines 1205/1205; executed functions 15/15
+(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
 
 Uncovered or low-coverage changed JS files:
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) toolbox/assets/assets.js - WARNING: uncovered changed runtime JS file; advisory only
+(100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
-(0%) tests/playwright/tools/AssetToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) toolbox/assets/assets-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) toolbox/assets/assets.js - changed JS file not collected as browser runtime coverage
-(86%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
-(92%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(74%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
+(88%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
diff --git a/docs_build/dev/reports/retry_suppression_report.md b/docs_build/dev/reports/retry_suppression_report.md
@@ -1,6 +1,6 @@
 # Retry Suppression Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/slow_path_pruning_report.md b/docs_build/dev/reports/slow_path_pruning_report.md
@@ -1,6 +1,6 @@
 # Slow Path Pruning Report
 
-Generated: 2026-06-05T21:27:53.721Z
+Generated: 2026-06-05T22:47:48.647Z
 Status: PASS
 Source timing evidence: docs_build/dev/reports/test_cleanup_performance_report.md (2026-05-26T21:18:42.199Z)
 
diff --git a/docs_build/dev/reports/static_validation_report.md b/docs_build/dev/reports/static_validation_report.md
@@ -1,6 +1,6 @@
 # Static Validation Report
 
-Generated: 2026-06-05T21:27:53.714Z
+Generated: 2026-06-05T22:47:48.639Z
 Status: PASS
 Static only: Yes
 Dry run: No
diff --git a/docs_build/dev/reports/targeted_file_manifest_report.md b/docs_build/dev/reports/targeted_file_manifest_report.md
@@ -1,6 +1,6 @@
 # Targeted File Manifest Report
 
-Generated: 2026-06-05T21:27:53.719Z
+Generated: 2026-06-05T22:47:48.645Z
 Status: PASS
 
 ## Manifest-Generated Lane Inputs
diff --git a/docs_build/dev/reports/test_cleanup_performance_report.md b/docs_build/dev/reports/test_cleanup_performance_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Performance Report
 
-Generated: 2026-06-05T21:27:53.721Z
+Generated: 2026-06-05T22:47:48.647Z
 Status: PASS
 
 ## Cost Summary
diff --git a/docs_build/dev/reports/test_cleanup_routing_report.md b/docs_build/dev/reports/test_cleanup_routing_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Routing Report
 
-Generated: 2026-06-05T21:27:53.721Z
+Generated: 2026-06-05T22:47:48.647Z
 Status: PASS
 
 ## Representative Routing Cases
diff --git a/docs_build/dev/reports/testing_lane_execution_report.md b/docs_build/dev/reports/testing_lane_execution_report.md
@@ -1,4 +1,4 @@
-# PR_26156_165-169 Testing Lane Execution Report
+# PR_26156_170 Testing Lane Execution Report
 
 ## Result
 PASS
@@ -10,31 +10,25 @@ PASS
   - PASS
 - `node --check tests\playwright\tools\PaletteToolMockRepository.spec.mjs`
   - PASS
+- `rg -n "DEFAULT_SOURCE_PALETTES|DEFAULT_SOURCE_PALETTE_LABELS|SOURCE_PALETTES|paletteList" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
 - `node .\node_modules\@playwright\test\cli.js test --project=playwright --workers=1 --reporter=list --grep "Palette (repository|Tool)"`
   - PASS, 3 tests
-- `node .\scripts\run-targeted-test-lanes.mjs --lane asset-tool`
-  - PASS, 6 Playwright tests
-- `npm run test:workspace-v2`
-  - PASS, 5 Playwright tests
-  - Note: command name is legacy; user-facing product language is Project Workspace.
 - `npm run test:playwright:static`
   - PASS
-- `node .\node_modules\@playwright\test\cli.js test --project=playwright --workers=1 --reporter=list --grep "Palette (repository|Tool)|Color assets consume"`
-  - PASS, 4 Playwright tests
 
 ## Required Lanes
 - Targeted Palette Tool runtime/UI lane: PASS.
-- Asset Tool Color picker handoff lane: PASS because Palette DB/color ownership changed.
-- Project Workspace palette handoff lane: PASS via Palette repository active project ownership coverage plus legacy `npm run test:workspace-v2`.
 - Changed-file/static validation: PASS.
 
 ## Playwright Coverage
-- Fullscreen layout: PASS.
-- DB-backed Palette Colors rename and `palette_colors` ownership: PASS.
-- Harmony controls and Add Selected action: PASS.
-- Sort and size controls: PASS.
-- Tag suggestions and Enter-to-add tag: PASS.
-- Source swatch row click pin/unpin behavior: PASS.
+- Source palettes from DB/mock-DB rows only: PASS.
+- Empty source palette diagnostic: PASS.
+- Sort controls are left-aligned buttons with visible active state and caret direction: PASS.
+- Size controls are right-aligned buttons with visible active state: PASS.
+- Active Project Palette and Source Swatches use consistent controls: PASS.
+- Swatch-only list rendering, upper-right pin, hover glow, and native browser `title` tooltip: PASS.
+- Harmony controls and Add Selected action remain covered: PASS.
 
 ## Not Run
 - Full samples smoke was not run, per BUILD instruction.
diff --git a/docs_build/dev/reports/validation_cache_report.md b/docs_build/dev/reports/validation_cache_report.md
@@ -1,6 +1,6 @@
 # Validation Cache Report
 
-Generated: 2026-06-05T21:27:53.721Z
+Generated: 2026-06-05T22:47:48.646Z
 Status: PASS
 
 ## Cache Summary
diff --git a/docs_build/dev/reports/zero_browser_preflight_report.md b/docs_build/dev/reports/zero_browser_preflight_report.md
@@ -1,6 +1,6 @@
 # Zero-Browser Preflight Report
 
-Generated: 2026-06-05T21:27:53.720Z
+Generated: 2026-06-05T22:47:48.646Z
 Status: PASS
 
 ## Prevented Browser Launches
diff --git a/tests/playwright/tools/PaletteToolMockRepository.spec.mjs b/tests/playwright/tools/PaletteToolMockRepository.spec.mjs
diff --git a/toolbox/colors/colors.js b/toolbox/colors/colors.js
diff --git a/toolbox/colors/index.html b/toolbox/colors/index.html
diff --git a/toolbox/colors/palette-workspace-repository.js b/toolbox/colors/palette-workspace-repository.js
