Skip to content

Commit 29276ae

Browse files
committed
Add configuration admin menu link and sort Admin submenu alphabetically - PR_26152_059-admin-menu-configuration-link
1 parent 490469e commit 29276ae

3 files changed

Lines changed: 61 additions & 7 deletions

File tree

GameFoundryStudio/assets/js/gamefoundry-partials.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"sound-studio": "tools/sound-studio.html",
1919
"storage-inspector": "tools/storage-inspector.html",
2020
"world-vector-studio": "tools/world-vector-studio.html",
21-
"configuration-admin": "admin/site-settings.html",
21+
"configuration-admin": "tools/groups/configuration-admin.html",
2222
games: "arcade/index.html",
2323
arcade: "arcade/index.html",
2424
"game-action": "arcade/index.html#action",
@@ -72,6 +72,7 @@
7272

7373
const rootPageRoutes = new Set([
7474
"tools",
75+
"configuration-admin",
7576
"ai-assistant",
7677
"animation-studio", "asset-studio", "code-studio", "input-studio", "midi-studio",
7778
"object-vector-studio", "palette-manager", "particle-studio", "sound-studio", "storage-inspector",

GameFoundryStudio/assets/partials/header-nav.html

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,18 @@
4343
<div class="nav-item">
4444
<a data-nav-link data-route="admin" href="admin/site-settings.html">Admin &#9662;</a>
4545
<div class="sub-menu">
46-
<a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
46+
<a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
4747
<a data-nav-link data-route="admin-branding" href="admin/branding.html">Branding</a>
48-
<a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
49-
<a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
5048
<a data-nav-link data-route="admin-controls" href="admin/controls.html">Controls</a>
49+
<a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
5150
<a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
51+
<a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
5252
<a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
53-
<a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
5453
<a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
55-
<a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
56-
<a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
54+
<a data-nav-link data-route="configuration-admin" href="/tools/groups/configuration-admin.html">Settings and Admin</a>
55+
<a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
56+
<a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
57+
<a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
5758
</div>
5859
</div>
5960
<div class="nav-item">
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# PR_26152_059 Admin Menu Configuration Link Validation
2+
3+
## Scope
4+
5+
- Changed root shared navigation only:
6+
- `GameFoundryStudio/assets/partials/header-nav.html`
7+
- `GameFoundryStudio/assets/js/gamefoundry-partials.js`
8+
- Added Admin submenu item `Settings and Admin`.
9+
- Routed `configuration-admin` to `/tools/groups/configuration-admin.html` through the shared partial loader.
10+
- No CSS, Theme V2 CSS, page content, tool runtime behavior, or page migrations were changed.
11+
12+
## Validation
13+
14+
Playwright impacted: Yes. This PR changes rendered root navigation behavior, so a targeted Playwright browser validation was run against `/tools/index.html`.
15+
16+
Lanes executed:
17+
- root navigation/static - because the shared header partial and route map changed.
18+
- root navigation/browser - because the partial loader rewrites menu hrefs at runtime.
19+
20+
Lanes skipped:
21+
- runtime, integration, engine, samples, and recovery/UAT - no tool runtime behavior, engine behavior, sample data, or broader recovery behavior changed.
22+
23+
Samples decision: SKIP because this PR only changes root navigation/menu routing.
24+
25+
Commands:
26+
- `node --check GameFoundryStudio/assets/js/gamefoundry-partials.js`
27+
- `git diff --check -- GameFoundryStudio/assets/partials/header-nav.html GameFoundryStudio/assets/js/gamefoundry-partials.js`
28+
- Inline Node static nav validation for Admin submenu order, expected links, target existence, and no inline script/style/event handlers.
29+
- Inline Playwright browser validation using a local static server for `/tools/index.html` and Admin submenu link targets.
30+
- `git diff --name-only -- "*.css"` and `git status --short -- "*.css"`
31+
32+
Results:
33+
- PASS: `Settings and Admin` appears in the Admin submenu.
34+
- PASS: Source href is `/tools/groups/configuration-admin.html`.
35+
- PASS: Runtime rendered href resolves to `/tools/groups/configuration-admin.html` from `/tools/index.html`.
36+
- PASS: Admin submenu order is alphabetized:
37+
`Analytics | Branding | Controls | Design System | Grouping Colors | Moderation | Ratings | Roles | Settings and Admin | Site Settings | Themes | Users`
38+
- PASS: Existing Admin submenu destinations were preserved.
39+
- PASS: Existing Admin submenu targets returned HTTP 200:
40+
`Analytics=200, Branding=200, Controls=200, Design System=200, Grouping Colors=200, Moderation=200, Ratings=200, Roles=200, Settings and Admin=200, Site Settings=200, Themes=200, Users=200`
41+
- PASS: `tools/groups/configuration-admin.html` exists and is reachable from the rendered menu.
42+
- PASS: No CSS files changed.
43+
- PASS: No unrelated page families changed.
44+
- PASS: No repo-wide tests were run.
45+
46+
Expected PASS behavior:
47+
- The root shared Admin menu renders the new `Settings and Admin` link.
48+
- The link reaches `/tools/groups/configuration-admin.html`.
49+
- Existing Admin menu links still resolve successfully.
50+
51+
Expected WARN behavior:
52+
- None for the targeted root navigation lane.

0 commit comments

Comments
 (0)