Skip to content

Commit 296d5db

Browse files
committed
Map root tool content into existing approved Theme V2 shell - PR_26152_055-map-tool-content-into-existing-shell
1 parent c8f118c commit 296d5db

13 files changed

Lines changed: 86 additions & 11 deletions
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# PR_26152_055 Root Tool Content Mapping Validation
2+
3+
## Scope
4+
- Assumed PR_26152_054 was reverted locally; the worktree was clean before this PR.
5+
- Changed only 11 root public tool HTML pages under `/tools/*.html`.
6+
- Did not change `/tools/index.html`; it was validated as the root Tools entry surface.
7+
- Did not touch Admin, Account, Company, Games, Samples, root index, CSS, Theme V2 CSS, JavaScript, data, or runtime behavior.
8+
9+
## Mapped pages
10+
- `tools/ai-assistant.html`
11+
- `tools/animation-studio.html`
12+
- `tools/asset-studio.html`
13+
- `tools/code-studio.html`
14+
- `tools/input-studio.html`
15+
- `tools/midi-studio.html`
16+
- `tools/object-vector-studio.html`
17+
- `tools/palette-manager.html`
18+
- `tools/particle-studio.html`
19+
- `tools/sound-studio.html`
20+
- `tools/storage-inspector.html`
21+
22+
## Mapping performed
23+
- Preserved the existing approved fixed shell structure on each page.
24+
- Preserved all existing shell classes and IDs.
25+
- Preserved left column, right column, accordion structure, center column header structure, image element, image path, and external scripts.
26+
- Mapped each page's existing descriptive copy into the existing center work-area paragraph.
27+
- Kept the original page title/lede copy in the page title section.
28+
- Kept existing Setup and Output accordion content in the left and right shell regions.
29+
30+
## Browser validation
31+
PASS - Opened `/tools/index.html` with a targeted local server and Playwright Chromium.
32+
PASS - Tools Index rendered 18 cards, preserved A-Z ordering, preserved grouped mode with 9 accordions, preserved tile images/descriptions, and retained group-colored outlines.
33+
PASS - Tools Index links to all 11 mapped root pages were present and loaded.
34+
PASS - Opened each affected root tool page.
35+
PASS - Each affected page rendered its existing fixed shell with direct center children in the same order: image, `h2 Workspace`, then center paragraph.
36+
PASS - Each affected page kept existing shell classes: `tool-workspace`, `tool-column tool-group-*`, `tool-column-header molten-orange`, `tool-column-header forge-gold`, and `tool-center-panel`.
37+
PASS - Each affected page preserved image sizing/layout; the center image path remained `/GameFoundryStudio/assets/images/forge-bot-single.png` and measured at 260px wide in the validation viewport.
38+
PASS - Each affected page loaded the center image, display-mode badge, and display-mode character image.
39+
PASS - Each affected page preserved Setup and Output accordion labels and body content.
40+
PASS - Accordions toggled closed and reopened on every affected page.
41+
PASS - No browser console errors, request failures, 404s, or 403s were detected.
42+
43+
## Static validation
44+
PASS - `git diff --name-only -- "*.css"` returned no CSS files.
45+
PASS - `git diff --name-only -- admin Admin account Account company Company games Games samples Samples index.html` returned no files.
46+
PASS - `git diff --check` passed for all changed root tool HTML pages.
47+
PASS - Changed pages contain no `<style>` blocks, inline script blocks, inline event handlers, inline `style` attributes, or `imageDataUrl` references.
48+
PASS - Diff audit confirmed only center work-area `<p>` content changed; no shell classes, IDs, accordion markup, center header markup, image markup, scripts, or stylesheet references changed.
49+
50+
## Tests intentionally not run
51+
- No repo-wide tests were run.
52+
- No tests outside affected root Tools/GameFoundryStudio paths were run.
53+
- No individual runtime/deeper first-class tool behavior was changed or tested beyond gap classification.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26152_055 Theme V2 Tool Shell Gaps
2+
3+
## Mapped in this PR
4+
The 11 simple root public tool pages were mapped because their existing shell already had stable left, center, and right regions. The safe change was limited to putting existing descriptive copy into the existing center work-area paragraph.
5+
6+
## Status/log handling
7+
The fixed public shell currently exposes the right column `Output` accordion as the output/status region. Adding a distinct status/log section would require changing accordion structure, which this PR explicitly forbids. No separate status/log section was added.
8+
9+
## Skipped root tool surfaces
10+
These `/tools/**` pages were intentionally skipped because content mapping would require changing shell structure, shell classes, IDs, CSS, runtime behavior, or tool-specific layout:
11+
12+
- First-Class Tool V2/runtime shells: `tools/_templates-v2/index.html`, `tools/workspace-manager-v2/index.html`, `tools/asset-manager-v2/index.html`, `tools/object-vector-studio-v2/index.html`, `tools/world-vector-studio-v2/index.html`, `tools/palette-manager-v2/index.html`, `tools/preview-generator-v2/index.html`, `tools/audio-sfx-playground-v2/index.html`, `tools/collision-inspector-v2/index.html`, `tools/input-mapping-v2/index.html`, `tools/midi-studio-v2/index.html`, `tools/storage-inspector-v2/index.html`, and `tools/text2speech-V2/index.html`.
13+
- Runtime/editor pages with custom local shells: `tools/Sprite Editor/index.html`, `tools/Tilemap Studio/index.html`, `tools/Parallax Scene Studio/index.html`, `tools/State Inspector/index.html`, `tools/Physics Sandbox/index.html`, `tools/Performance Profiler/index.html`, `tools/3D JSON Payload/index.html`, `tools/3D Asset Viewer/index.html`, `tools/3D Camera Path Editor/index.html`, `tools/Asset Pipeline/index.html`, and `tools/Replay Visualizer/index.html`.
14+
- Documentation/helper pages such as `how_to_use.html` files and `tools/shared/preview/*.html`; they are documentation/helper surfaces, not the fixed public tool shell targeted here.
15+
16+
## Theme V2 shell gap
17+
The affected fixed shell still depends on existing shell CSS loaded through the current page stylesheet. Converting this shell to Theme V2 without changing class names, accordion structure, center header structure, or image sizing/layout requires an approved reusable Theme V2 tool-shell pattern first. That migration was skipped in this PR because CSS changes and shell/class changes are explicitly out of scope.
18+
19+
## Future candidates
20+
- Approve a reusable Theme V2 public tool-shell pattern that preserves fixed shell semantics.
21+
- Define a Theme V2 status/log region that can be added without disrupting existing accordions.
22+
- Handle runtime/first-class tool shells in dedicated per-tool or per-template PRs with behavior validation.

tools/ai-assistant.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="ai-assistant" data-tool-icon-src="assets/images/badges/ai-assistant.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>AI Assistant</p>
41+
<p>AI Assistant: Get AI help with code, assets, logic and design.</p>
4242
</section>
4343
<aside class="tool-column tool-group-ai-learning">
4444
<div class="tool-column-header forge-gold">

tools/animation-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="animation-studio" data-tool-icon-src="assets/images/badges/animation-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Animation Studio</p>
41+
<p>Animation Studio: Animate characters and bring games to life.</p>
4242
</section>
4343
<aside class="tool-column tool-group-build-create">
4444
<div class="tool-column-header forge-gold">

tools/asset-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="asset-studio" data-tool-icon-src="assets/images/badges/asset-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Asset Studio</p>
41+
<p>Asset Studio: Create sprites, animations, vectors and palettes.</p>
4242
</section>
4343
<aside class="tool-column tool-group-content-assets">
4444
<div class="tool-column-header forge-gold">

tools/code-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="code-studio" data-tool-icon-src="assets/images/badges/code-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Code Studio</p>
41+
<p>Code Studio: Write code, extend systems and build custom logic.</p>
4242
</section>
4343
<aside class="tool-column tool-group-development-system">
4444
<div class="tool-column-header forge-gold">

tools/input-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="input-studio" data-tool-icon-src="assets/images/badges/input-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Input Studio</p>
41+
<p>Input Studio: Map keyboard, mouse, gamepad and touch controls.</p>
4242
</section>
4343
<aside class="tool-column tool-group-development-system">
4444
<div class="tool-column-header forge-gold">

tools/midi-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="midi-studio" data-tool-icon-src="assets/images/badges/midi-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>MIDI Studio</p>
41+
<p>MIDI Studio: Compose game music using MIDI tools and instruments.</p>
4242
</section>
4343
<aside class="tool-column tool-group-media-audio">
4444
<div class="tool-column-header forge-gold">

tools/object-vector-studio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="object-vector-studio" data-tool-icon-src="assets/images/badges/object-vector-studio.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Object Vector Studio</p>
41+
<p>Object Vector Studio: Design scalable objects and vector shapes with precision.</p>
4242
</section>
4343
<aside class="tool-column tool-group-build-create">
4444
<div class="tool-column-header forge-gold">

tools/palette-manager.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Toolbox</h2>
3838
<div data-tool-display-mode data-asset-root="assets/images" data-tool-slug="palette-manager" data-tool-icon-src="assets/images/badges/palette-manager.png"></div>
3939
<section class="tool-center-panel"><img src="assets/images/forge-bot-single.png" alt="ForgeBot">
4040
<h2>Workspace</h2>
41-
<p>Palette Manager</p>
41+
<p>Palette Manager: Craft and manage color palettes for your games.</p>
4242
</section>
4343
<aside class="tool-column tool-group-content-assets">
4444
<div class="tool-column-header forge-gold">

0 commit comments

Comments
 (0)