Converge toolbox inventory, close Theme V2 asset wiring, and complete legacy ownership audit - PR_26154_034-036-cleanup-stack

Author: ToolboxAid

docs_build/dev/codex_commands.md

@@ -2,63 +2,56 @@
 
 Task:
 
-- `PR_26154_031-toolbox-template-mismatch-closeout`
-- `PR_26154_032-active-test-suite-reconciliation`
-- `PR_26154_033-root-structure-final-polish`
+- `PR_26154_034-toolbox-inventory-convergence`
+- `PR_26154_035-theme-v2-asset-wiring-closeout`
+- `PR_26154_036-legacy-ownership-final-audit`
 
 Changes:
 
 - Read `.codex/skills/repo-build/SKILL.md`.
 - Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
-- Used the latest applied PR state as the baseline.
-- Re-ran template consistency checks for active public/root pages and active toolbox pages.
-- Updated stale grouping CSS copy in `admin/grouping-colors.html` and `docs_build/account/grouping-colors.html`.
-- Removed deprecated-only tests for old games, old samples, removed V2 tool pages, removed integration surfaces, and old template/tool registries.
-- Rewired active test lane metadata to `tests/playwright/tools/RootToolsFutureState.spec.mjs`.
-- Updated Playwright structure ownership metadata and V8 coverage entry-point labels for `toolbox/` and `assets/theme-v2/`.
-- Confirmed Marketplace is absent from `toolbox/index.html` and `toolbox/tools-page-accordions.js`.
-- Confirmed shared header/footer still keep Marketplace as a product destination.
-- Did not modify `old-tools/`, `old_games/`, `old_samples/`, or `start_of_day/`.
+- Used `PR_26154_031-033-template-test-root-polish` as the current baseline.
+- Inventoried all 20 active `toolbox/[toolname]/index.html` pages.
+- Added missing active toolbox index entries for Configuration Admin, Tool Builder, and Tool Creator.
+- Confirmed active toolbox pages are header-wired, index-wired, and template-marker complete.
+- Audited `assets/theme-v2` CSS, fonts, images, JS, and partials.
+- Confirmed Font Awesome is wired through `assets/theme-v2/fonts/fontawesome`.
+- Moved deprecated preview-generator support from `toolbox/shared/preview/` to `old-tools/shared-preview/`.
+- Classified toolbox, old-tools, games, old_games, old_samples, scripts, and tests ownership.
+- Did not modify `start_of_day/`.
 
 Validation:
 
-- Ran changed JavaScript syntax checks:
-  - `node --check scripts/run-targeted-test-lanes.mjs`
-  - `node --check scripts/audit-playwright-test-locations.mjs`
-  - `node --check tests/run-tests.mjs`
-  - `node --check tests/helpers/playwrightV8CoverageReporter.mjs`
-- Ran template consistency audit:
-  - Public/root pages: `43/43`
-  - Active toolbox pages: `20/20`
-- Ran targeted stale reference checks for `toolbox`, `assets/theme-v2`, footer/header links, `styles.css`, `favicon.ico`, `assets/theme/v2`, `GameFoundryStudio/`, `src/engine/theme`, removed `tools/` routes, and removed `samples/` routes.
-- Ran active toolbox index ordering and header coverage checks.
-- Ran direct removed-samples import/route scan in active tests.
+- Ran targeted active toolbox inventory checks.
+- Ran targeted Theme V2 reference resolution checks.
+- Ran targeted retired path checks for `assets/theme/v2`, `assets/theme-v2/assets`, `assets/theme-v2/css/styles.css`, `favicon.ico`, and `GameFoundryStudio/`.
+- Ran active reference check for `toolbox/shared/preview/` after moving it.
+- Ran `node --check toolbox/tools-page-accordions.js`.
 - Ran `npm run test:playwright:static`.
 - Ran `npm run test:workspace-v2`.
 - Ran `git diff --check`.
 - Regenerated required Codex review artifacts.
 - Packaged repo-structured ZIP:
-  - `tmp/PR_26154_031-033-template-test-root-polish_delta.zip`
+  - `tmp/PR_26154_034-036-toolbox-theme-legacy-audit_delta.zip`
 
 Required reports:
 
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
-- `docs_build/dev/reports/toolbox_template_mismatch_closeout_report.md`
-- `docs_build/dev/reports/active_test_suite_reconciliation_report.md`
-- `docs_build/dev/reports/root_structure_final_polish_report.md`
-- `docs_build/dev/reports/remaining_cleanup_report.md`
+- `docs_build/dev/reports/toolbox_inventory_convergence_report.md`
+- `docs_build/dev/reports/theme_v2_asset_wiring_closeout_report.md`
+- `docs_build/dev/reports/legacy_ownership_final_audit_report.md`
+- `docs_build/dev/reports/final_remaining_cleanup_inventory.md`
 
 Validation summary:
 
-- PASS template audit: public/root pages `43/43`.
-- PASS template audit: active toolbox pages `20/20`.
-- PASS active toolbox header coverage: `20/20`.
-- PASS Marketplace is absent from active toolbox index data.
-- PASS active public pages do not use `assets/theme-v2/css/styles.css`.
-- PASS zero active public `tools/` route references remain.
+- PASS active toolbox inventory: `20/20` header-wired, `20/20` index-wired, `20/20` template-marker complete.
+- PASS toolbox index group order and in-group tool order are alphabetical.
+- PASS active Theme V2 file references resolve on disk.
+- PASS no active dependency on `assets/theme-v2/css/styles.css`.
+- PASS no active imports of `toolbox/shared/preview/` remain after the move.
 - PASS `npm run test:playwright:static`.
 - PASS `npm run test:workspace-v2` with `2 passed`.
 - PASS `git diff --check`.
-- SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples` per request.
+- SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples/` per request.
 - SKIPPED full samples smoke test per request.

docs_build/dev/commit_comment.txt

@@ -1,8 +1,8 @@
-Close out toolbox templates, reconcile active tests, and polish root paths - PR_26154_031-033
+Converge toolbox inventory, audit Theme V2 wiring, and move deprecated preview support - PR_26154_034-036
 
-- Confirm active public/root and toolbox template consistency remains clean at 43/43 and 20/20.
-- Fix stale Theme V2 grouping CSS path copy in active admin/docs pages.
-- Remove deprecated-only tests for old games, old samples, removed V2 tools, old template baselines, and removed integration surfaces.
-- Rewire active test lanes and coverage labels to current toolbox and assets/theme-v2 paths.
-- Confirm Marketplace stays outside toolbox index while remaining in product header/footer navigation.
-- Validate static checks, Workspace V2, targeted stale-path scans, diff hygiene, and repo-structured delta packaging.
+- Add missing active toolbox index entries for Configuration Admin, Tool Builder, and Tool Creator.
+- Confirm all 20 active toolbox pages are header-wired, index-wired, and template-marker complete.
+- Audit Theme V2 CSS, fonts, images, JS, and partials, including Font Awesome wiring and unwired residue.
+- Move deprecated old-samples preview-generator support from toolbox/shared/preview to old-tools/shared-preview.
+- Classify remaining toolbox, legacy, scripts, and tests ownership and document remaining cleanup candidates.
+- Validate static checks, Workspace V2, targeted path scans, diff hygiene, and repo-structured delta packaging.

docs_build/dev/reports/final_remaining_cleanup_inventory.md

@@ -0,0 +1,37 @@
+# PR_26154_034-036 Final Remaining Cleanup Inventory
+
+## Completed In This Stack
+
+- Added missing active toolbox pages to the toolbox index grouping:
+  - Configuration Admin
+  - Tool Builder
+  - Tool Creator
+- Confirmed all 20 active toolbox pages are header-wired, index-wired, and template-marker complete.
+- Moved deprecated preview-generator support from `toolbox/shared/preview/` to `old-tools/shared-preview/`.
+- Confirmed active Theme V2 references resolve and no active `styles.css` dependency remains.
+
+## Remaining Cleanup Candidates
+
+| Candidate | Classification | Recommended Follow-Up |
+| --- | --- | --- |
+| `toolbox/toolRegistry.js` | Ambiguous active/legacy bridge | Split active registry from legacy registry, then move legacy entries to `old-tools` ownership. |
+| `toolbox/renderToolsIndex.js` | Ambiguous legacy renderer | Decide whether it remains an active validation target or moves with legacy registry/rendering support. |
+| `assets/theme-v2/css/styles.css` | Unwired aggregate | Remove in a dedicated Theme V2 CSS residue PR if no external consumer exists. |
+| `assets/theme-v2/css/site-colors.css`, `site-controls.css`, `gamefoundrystudio.css`, `pages.css`, `tokens.css` | Unwired or aggregate-era residue | Confirm whether any are intended design-system modules, then delete or wire intentionally. |
+| `assets/theme-v2/css/tools/grouping/*.css` | Unwired grouping residue | Consolidate with active `colors.css` ownership or rewire intentionally. |
+| `assets/theme-v2/partials/page-shell.html` and `tool-shell.html` | Unwired partial stubs | Delete or wire through a documented partial-loader contract. |
+| `assets/theme-v2/images/icons/*` | Unwired icon image set | Decide whether icons are future image assets or move/delete as residue. |
+| `assets/theme-v2/images/ChatGPT Image*.png`, `forge-bot.svg`, `magic-panel.png`, `toolboxaid-header.png`, typo variants | Unwired image candidates | Delete or relocate after visual asset ownership review. |
+| `tests/games/` | Deprecated-adjacent/ambiguous | Separate active game tests from deprecated old-game tests before pruning. |
+| `tests/validation/samples.*.json` | Historical/ambiguous fixtures | Retire only after contract tests stop using sample report fixtures. |
+| Historical docs mentioning `toolbox/shared/preview/` | Historical docs | Update only in a docs-history normalization PR, not runtime cleanup. |
+
+## Current Active Structure Confirmation
+
+- `toolbox/`: active toolbox pages, active toolbox index, template source, schemas, and shared/validation support.
+- `old-tools/`: deprecated tools and legacy support, now including `shared-preview/`.
+- `games/`: active public game discovery/type pages.
+- `old_games/`: deprecated playable reference games.
+- `old_samples/`: deprecated reference samples.
+- `scripts/`: active validation and artifact tooling.
+- `tests/`: active and ambiguous validation inventory, with deprecated-only tests already pruned in prior stack.

docs_build/dev/reports/legacy_ownership_final_audit_report.md

@@ -0,0 +1,66 @@
+# PR_26154_036 Legacy Ownership Final Audit
+
+Baseline used: `PR_26154_035-theme-v2-asset-wiring-closeout`.
+
+## Scope
+
+Audited:
+
+- `toolbox`
+- `old-tools`
+- `games`
+- `old_games`
+- `old_samples`
+- `scripts`
+- `tests`
+
+Moved only clearly deprecated ownership. Ambiguous items were reported and left in place.
+
+## Ownership Classifications
+
+| Surface | Classification | Notes |
+| --- | --- | --- |
+| `toolbox/[toolname]/index.html` | Active | 20 active toolbox pages are template-aligned, header-wired, and index-wired. |
+| `toolbox/_tool_template-v2/` | Active template source | Required first-class toolbox template source. |
+| `toolbox/tools-page-accordions.js` | Active | Drives the active toolbox index grouping. |
+| `toolbox/toolRegistry.js` | Ambiguous active/legacy bridge | Still imported by active shared modules, scripts, and tests, but contains legacy `old-tools` and `old_samples` entries. Not moved. |
+| `toolbox/renderToolsIndex.js` | Ambiguous legacy renderer | Referenced by active validation/tests but not by the current `toolbox/index.html`; not moved. |
+| `toolbox/dev/` | Ambiguous active tooling | Package scripts and validation guards still reference this folder. Not moved. |
+| `toolbox/shared/` | Active/ambiguous shared tooling | Many modules are imported by active tests and shared tool contracts. Not moved wholesale. |
+| `toolbox/shared/preview/` | Deprecated | Moved to `old-tools/shared-preview/`. It only referenced `old_samples` and had no active imports outside itself. |
+| `toolbox/schemas/` | Active/ambiguous contract schemas | Active tests and scripts still reference toolbox schemas. Not moved. |
+| `old-tools/` | Deprecated | Retained as deprecated tool/reference ownership. New `shared-preview/` added here. |
+| `games/` | Active | Owns active public game-type pages and game assets. |
+| `old_games/` | Deprecated playable references | Retained; no tests were run against it. |
+| `old_samples/` | Deprecated sample references | Retained; no tests were run against it. |
+| `scripts/` | Active/ambiguous validation tooling | Current validation and artifact scripts remain active. No clear deprecated script was moved in this PR. |
+| `tests/` | Active/ambiguous validation inventory | Active runner, Playwright future-state test, and retained legacy boundary fixtures coexist. No ambiguous tests were deleted. |
+
+## Move Completed
+
+| From | To | Reason |
+| --- | --- | --- |
+| `toolbox/shared/preview/` | `old-tools/shared-preview/` | Self-contained preview-generator support for `old_samples`; no active imports outside the folder were found. |
+
+Moved files:
+
+- `old-tools/shared-preview/generate-list-previews.html`
+- `old-tools/shared-preview/generate-previews.html`
+- `old-tools/shared-preview/move-preview-svg-to-assets.ps1`
+- `old-tools/shared-preview/preview-pages.css`
+
+## Remaining Legacy References
+
+- `toolbox/toolRegistry.js` keeps hidden legacy `old-tools` and `old_samples` entries. It is still imported by active validation/shared code, so it needs a dedicated registry split before relocation.
+- `toolbox/renderToolsIndex.js` still references `old_samples` and is read by active validation/tests. It needs a dedicated renderer retirement or validation rewrite.
+- Some historical docs still mention `toolbox/shared/preview/`; they were left untouched because they are historical PR/design documents rather than active runtime wiring.
+- `tests/games/` and parts of `tests/validation/` still preserve old-game/sample boundary coverage. They were classified as ambiguous or deprecated-adjacent and left in place.
+
+## Validation
+
+- PASS: active reference scan found no imports of `toolbox/shared/preview/` after the move.
+- PASS: `old-tools/shared-preview/` exists with the moved preview files.
+- PASS: `node --check toolbox/tools-page-accordions.js`.
+- PASS: `npm run test:playwright:static`.
+- PASS: `npm run test:workspace-v2`.
+- SKIPPED tests against `old-tools`, `old_games`, and `old_samples` per request.

docs_build/dev/reports/theme_v2_asset_wiring_closeout_report.md

@@ -0,0 +1,89 @@
+# PR_26154_035 Theme V2 Asset Wiring Closeout
+
+Baseline used: `PR_26154_034-toolbox-inventory-convergence`.
+
+## Scope
+
+- Audited `assets/theme-v2/css`, `assets/theme-v2/fonts`, `assets/theme-v2/images`, `assets/theme-v2/js`, and `assets/theme-v2/partials`.
+- Confirmed active Theme V2 references resolve.
+- Confirmed Font Awesome wiring.
+- Checked retired path references.
+
+## CSS
+
+| Asset | Status | Notes |
+| --- | --- | --- |
+| `assets/theme-v2/css/theme.css` | Active | Public/root pages and toolbox pages use this as the Theme V2 entry point. |
+| `assets/theme-v2/css/accordion.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/base.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/buttons.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/colors.css` | Active via `theme.css` | Owns active color, meaning, swatch, and tool-group variables. |
+| `assets/theme-v2/css/controls.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/dialogs.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/forms.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/layout.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/panels.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/spacing.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/status.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/tables.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/tools.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/typography.css` | Active via `theme.css` | Imported by the active entry point. |
+| `assets/theme-v2/css/styles.css` | Unwired aggregate | No active page depends on it. It was reported only and left in place. |
+| `assets/theme-v2/css/site-colors.css` | Unwired except through `styles.css` | Retained as aggregate-era residue. |
+| `assets/theme-v2/css/site-controls.css` | Unwired except through `styles.css` | Retained as aggregate-era residue. |
+| `assets/theme-v2/css/gamefoundrystudio.css` | Unwired except through `styles.css` | Retained as aggregate-era residue. |
+| `assets/theme-v2/css/pages.css` | Unwired except through `styles.css` | Retained as aggregate-era residue. |
+| `assets/theme-v2/css/tokens.css` | Unwired except through `styles.css` | Retained as aggregate-era residue. |
+| `assets/theme-v2/css/tools/grouping/*.css` | Unwired except through `styles.css` | Group color variables are active through `colors.css`; the grouping files are retained for later consolidation/deletion review. |
+
+## Fonts
+
+- PASS: Font Awesome is wired from `assets/theme-v2/fonts/fontawesome` through `assets/theme-v2/css/theme.css`.
+- The active import is `@import url("../fonts/fontawesome/css/font-awesome.min.css");`.
+- No active page links a different Font Awesome path.
+- No active `.fa-*` class consumers were found outside the Font Awesome stylesheet itself; the library is globally wired but lightly or not directly consumed.
+
+## JavaScript
+
+| Asset | Status | Notes |
+| --- | --- | --- |
+| `assets/theme-v2/js/gamefoundry-partials.js` | Active | Loaded by public/root pages, games index/type pages, active toolbox pages, and templates. |
+| `assets/theme-v2/js/tool-display-mode.js` | Active | Loaded by active toolbox pages and `toolbox/_tool_template-v2/index.html`. |
+| `assets/theme-v2/js/account-controls.js` | Active | Loaded by `admin/controls.html`. |
+
+## Partials
+
+| Asset | Status | Notes |
+| --- | --- | --- |
+| `assets/theme-v2/partials/header-nav.html` | Active | Loaded by `gamefoundry-partials.js`. |
+| `assets/theme-v2/partials/footer.html` | Active | Loaded by `gamefoundry-partials.js`. |
+| `assets/theme-v2/partials/page-shell.html` | Unwired | No active loader mapping or page reference found. |
+| `assets/theme-v2/partials/tool-shell.html` | Unwired | No active loader mapping or page reference found. |
+
+## Images
+
+Active image groups:
+
+- Root/brand images used by active pages: `game-foundry-studio-logo.png`, `game-foundry-mascot-sheet.png`, `game-foundry-tools-poster.png`, `forge-bot-single.png`, `logo-mark.svg`, `spark.png`, `pixel-smith.png`, `forgebot.png`, and `foundry-bot.png`.
+- Tool index images used by active toolbox and public pages: active `images/tools/*.png` entries for AI Assistant, Cloud, Localization, Publish, Storage Inspector, MIDI, Sound, Palette Manager, Input, Animation, Assets, Code, Object Vector, Settings, Game Builder, Game Design, Particles, World Vector, Arcade, Learn, and Marketplace.
+- ToolDisplayMode badge/character images are dynamically resolved from `assets/theme-v2/images/badges/` and `assets/theme-v2/images/characters/`.
+
+Reported unwired image candidates:
+
+- `images/ChatGPT Image May 30, 2026, 07_57_30 PM.png`
+- `images/ChatGPT Image May 30, 2026, 07_57_30 PM2.png`
+- `images/forge-bot.svg`
+- `images/magic-panel.png`
+- `images/toolboxaid-header.png`
+- `images/icons/*`
+- typo/variant tool images such as `images/tools/localizaton.png` and `images/tools/match_format.png`
+
+These were reported only because this PR did not request asset deletion.
+
+## Retired Path Checks
+
+- PASS: active checked files have zero references to `assets/theme/v2`.
+- PASS: active checked files have zero references to `assets/theme-v2/assets`.
+- PASS: active checked files have zero references to `assets/theme-v2/css/styles.css`.
+- PASS: active checked files have zero references to `favicon.ico`.
+- PASS: active Theme V2 file references resolve on disk.