Finish dev runtime isolation and remove remaining fallback paths - PR_26157_019-dev-runtime-final-isolation-fix

Author: ToolboxAid

admin/db-viewer.js

@@ -1,124 +1,18 @@
-import {
-  getMockDbSessionMode,
-  getMockDbSessionModes,
-  getMockDbSessionUser,
-  getMockDbSessionUsers,
-  getStandaloneMockDbTables,
-  setMockDbSessionMode,
-  setMockDbSessionUser,
-} from "../../../src/engine/persistence/mock-db-store.js";
-
-const modeButtons = Array.from(document.querySelectorAll("[data-login-mode]"));
-const modeTitle = document.querySelector("[data-login-mode-title]");
-const modeDescription = document.querySelector("[data-login-mode-description]");
-const modeStatus = document.querySelector("[data-login-mode-status]");
-const userControls = document.querySelector("[data-login-user-controls]");
-const userStatus = document.querySelector("[data-login-user-status]");
-const continueLink = document.querySelector("[data-login-continue]");
-
-function currentReturnTo() {
-  const params = new URLSearchParams(window.location.search);
-  const value = params.get("returnTo") || "";
-  if (!value || value.startsWith("/") || value.includes("://") || value.includes("..")) {
-    return "toolbox/index.html";
-  }
-  return value;
-}
-
-function modeById(modeId) {
-  return getMockDbSessionModes().find((mode) => mode.id === modeId) || getMockDbSessionMode();
-}
-
-function updateContinueLink() {
-  if (continueLink) {
-    continueLink.href = currentReturnTo();
-  }
-}
-
-function setSelectedButton(button, selected) {
-  button.classList.toggle("primary", selected);
-  button.setAttribute("aria-pressed", String(selected));
-  if (selected) {
-    button.setAttribute("aria-current", "true");
-  } else {
-    button.removeAttribute("aria-current");
-  }
+function devRuntimeAllowed() {
+  const host = window.location.hostname;
+  return window.GameFoundryDevRuntime?.enabled === true ||
+    window.location.protocol === "file:" ||
+    host === "localhost" ||
+    host === "127.0.0.1";
 }
 
-function renderModeButtons(mode) {
-  modeButtons.forEach((button) => {
-    setSelectedButton(button, button.dataset.loginMode === mode.id);
-  });
-}
-
-function renderUserButtons(mode) {
-  if (!userControls) {
-    return;
-  }
-
-  userControls.replaceChildren();
-  if (mode.id === "dev") {
-    userControls.hidden = true;
-    if (userStatus) {
-      userStatus.textContent = "DEV mode uses read-only/demo JSON access. No users are selectable.";
-    }
+async function loadLocalLoginSession() {
+  if (!devRuntimeAllowed()) {
     return;
   }
-
-  getStandaloneMockDbTables();
-  userControls.hidden = false;
-  const sessionUser = getMockDbSessionUser();
-  getMockDbSessionUsers().forEach((user) => {
-    const button = document.createElement("button");
-    button.className = "btn btn--compact";
-    button.type = "button";
-    button.textContent = user.label;
-    button.dataset.loginUser = user.userKey || "";
-    setSelectedButton(button, (user.userKey || "") === (sessionUser.userKey || ""));
-    userControls.append(button);
-  });
-  if (userStatus) {
-    userStatus.textContent = sessionUser.userKey
-      ? `Selected local user: ${sessionUser.label}.`
-      : "Guest is unauthenticated and is not stored in the users table.";
-  }
-}
-
-function render() {
-  const mode = getMockDbSessionMode();
-  renderModeButtons(mode);
-  if (modeTitle) {
-    modeTitle.textContent = mode.label;
-  }
-  if (modeDescription) {
-    modeDescription.textContent = mode.description;
-  }
-  if (modeStatus) {
-    modeStatus.textContent = `${mode.label} mode selected.`;
-  }
-  renderUserButtons(mode);
-  updateContinueLink();
+  await import("../../../src/dev-runtime/auth/login-session.js");
 }
 
-modeButtons.forEach((button) => {
-  button.addEventListener("click", () => {
-    const mode = setMockDbSessionMode(button.dataset.loginMode || "local");
-    if (mode.id === "local") {
-      getStandaloneMockDbTables();
-    }
-    render();
-  });
+loadLocalLoginSession().catch((error) => {
+  console.error("Unable to load Local login session.", error);
 });
-
-userControls?.addEventListener("click", (event) => {
-  const button = event.target.closest("[data-login-user]");
-  if (!button) {
-    return;
-  }
-  setMockDbSessionMode("local");
-  getStandaloneMockDbTables();
-  setMockDbSessionUser(button.dataset.loginUser || "");
-  render();
-});
-
-render();

assets/theme-v2/js/login-session.js

@@ -6,11 +6,12 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(70%) toolbox/colors/palette-workspace-repository.js - executed lines 1316/1316; executed functions 89/127
-(81%) toolbox/assets/assets-mock-repository.js - executed lines 919/919; executed functions 61/75
-(95%) src/dev-runtime/persistence/mock-db-store.js - executed lines 682/682; executed functions 77/81
-(98%) toolbox/project-journey/project-journey.js - executed lines 991/991; executed functions 105/107
-(100%) src/engine/persistence/mock-db-store.js - executed lines 1/1; executed functions 1/1
+(64%) src/engine/persistence/mock-db-store.js - executed lines 36/36; executed functions 7/11
+(70%) toolbox/colors/palette-workspace-repository.js - executed lines 1361/1361; executed functions 92/132
+(82%) toolbox/assets/assets-mock-repository.js - executed lines 943/943; executed functions 63/77
+(95%) src/dev-runtime/admin/db-viewer.js - executed lines 478/478; executed functions 86/91
+(95%) src/dev-runtime/persistence/mock-db-store.js - executed lines 727/727; executed functions 78/82
+(100%) src/dev-runtime/auth/login-session.js - executed lines 107/107; executed functions 12/12
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -1,6 +1,6 @@
 # Dependency Gating Report
 
-Generated: 2026-06-07T04:35:29.033Z
+Generated: 2026-06-07T05:10:39.389Z
 Status: PASS
 
 ## Gate Order

docs_build/dev/reports/dependency_gating_report.md

@@ -1,6 +1,6 @@
 # Dependency Hydration Reuse Report
 
-Generated: 2026-06-07T04:35:29.034Z
+Generated: 2026-06-07T05:10:39.389Z
 Status: PASS
 
 ## Summary

docs_build/dev/reports/dependency_hydration_reuse_report.md

@@ -0,0 +1,72 @@
+# PR_26157_019 Dev Runtime Final Isolation Fix Report
+
+## Summary
+
+Status: PASS
+
+This PR finishes the PR_26157_018 dev-runtime boundary by moving the remaining DB Viewer and login/session mock implementations under `src/dev-runtime/`, replacing the direct engine re-export with a named adapter facade, and making audit-user fallback fail visibly outside controlled seed initialization.
+
+Full samples smoke: SKIP. The scope is auth/login, DB Viewer, shared mock DB, import/static validation, and Project Journey regression coverage; samples were not changed.
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first | PASS | Read before implementation. |
+| Use PR_26157_018 delta as context | PASS | Continued from existing `src/dev-runtime/` structure and PR018 auth/mock DB files. |
+| Fix remaining PR_26157_018 issues before packaging | PASS | Dev-only DB Viewer/login moved, engine direct re-export removed, fallback audit behavior hardened. |
+| Include 100% requested-work checklist | PASS | This table maps every requested item. |
+| Keep `admin/db-viewer.html` as route/page shell | PASS | HTML unchanged; JS route file is gateway only. |
+| Move DB Viewer implementation out of `admin/db-viewer.js` | PASS | Implementation now in `src/dev-runtime/admin/db-viewer.js`; `admin/db-viewer.js` only gates and dynamically loads. |
+| `admin/db-viewer.js` has no DB business/render/clear/seed logic | PASS | Gateway only checks dev runtime/local mode and calls `startDevRuntimeDbViewer`. |
+| DB Viewer remains Local-only and admin-only | PASS | Local-mode gate in `admin/db-viewer.js`; admin role protection validated by `LoginSessionMode.spec.mjs` and `AdminDbViewer.spec.mjs`. |
+| DEV/UAT/PROD do not expose DB Viewer implementation | PASS | Gateway imports dev-runtime only on file/localhost or explicit `GameFoundryDevRuntime.enabled`; DEV mode shows Local-only status instead of loading viewer. |
+| Keep `login.html` as route/page shell | PASS | HTML unchanged; public login JS is gateway only. |
+| Move mock login/session selector out of `assets/theme-v2/js/login-session.js` | PASS | Implementation now in `src/dev-runtime/auth/login-session.js`; asset JS only gates and dynamically imports local dev runtime. |
+| Public login gateway has no mock users/Local selector/fallback behavior | PASS | `assets/theme-v2/js/login-session.js` contains only dev-runtime gate and dynamic import. |
+| Login still works in Local mode | PASS | `LoginSessionMode.spec.mjs` passed 5/5 in final combined run. |
+| UAT/PROD must not import Local mock login implementation | PASS | Gateway refuses dev-runtime import outside file/localhost unless explicitly enabled. |
+| Replace direct engine dev-runtime re-export | PASS | `src/engine/persistence/mock-db-store.js` is no longer `export *`; it is a named adapter facade with `configureMockDbRuntimeAdapter`. |
+| Active tools import stable engine contract paths only | PASS | Boundary scan: `rg ... toolbox` returned no `src/dev-runtime` imports. |
+| UAT/PROD can swap gateway to server/API adapter without tool-code changes | PASS | Engine facade exposes `configureMockDbRuntimeAdapter(adapter)` while tools keep importing `src/engine/persistence/mock-db-store.js`. |
+| Gateway does not expose dev seed/clear/session-selector APIs | PASS | Engine facade no longer exports seed/clear/all-snapshot/session-mode/session-selector helpers. |
+| Review and remove silent `normalizeUserKey(value, fallbackUserKey)` behavior | PASS | Signature changed; invalid audit users now throw unless `allowSeedAuditFallback` is explicitly set. |
+| Invalid audit users fail visibly or produce diagnostics outside seed creation | PASS | `AdminDbViewer.spec.mjs` verifies DB Viewer visible error; unit assertion verifies invalid audit user throws. |
+| Seed fallback, if present, is isolated under `src/dev-runtime/` | PASS | Seed-only fallback lives in `src/dev-runtime/persistence/mock-db-store.js`. |
+| Seed fallback emits diagnostic and never runs for normal writes | PASS | Controlled seed fallback emits diagnostics; normal `saveMockDbTables` path is strict. |
+| No fallback admin/user/forge-bot/static auth map | PASS | Scans found no `localSessionUsers`, legacy audit map, role query fallback, accountType/isSystemUser, or actor code. |
+| Verify `admin/db-viewer.js` shell/loader only | PASS | Syntax and diff review; file only contains runtime/local gate and dynamic import. |
+| Verify DB Viewer implementation under `src/dev-runtime/admin/` | PASS | `src/dev-runtime/admin/db-viewer.js`. |
+| Verify `assets/theme-v2/js/login-session.js` shell/gateway only | PASS | Syntax and diff review; file only contains runtime gate and dynamic import. |
+| Verify mock login implementation under `src/dev-runtime/auth/` | PASS | `src/dev-runtime/auth/login-session.js`. |
+| Verify engine file is not direct dev-runtime re-export | PASS | Static scan found no `export * from .*dev-runtime`. |
+| Verify no active tool imports `src/dev-runtime` directly | PASS | `rg ... toolbox` returned no matches. |
+| Verify no fallback auth/user/session remains | PASS | Removed-field/fallback scan returned no matches. |
+| Verify invalid audit users fail visibly outside controlled seed creation | PASS | New Admin DB Viewer visible diagnostic test passed. |
+| Verify Local login still works | PASS | `LoginSessionMode.spec.mjs` final combined run. |
+| Verify DB Viewer Local-only/admin-only | PASS | `AdminDbViewer.spec.mjs` and `LoginSessionMode.spec.mjs` final combined run. |
+| Verify DEV cannot access DB Viewer | PASS | Login/session lane verifies DEV mode and protected page behavior; gateway blocks non-Local mode. |
+| Verify Guest unauthenticated and not stored in users | PASS | `LoginSessionMode.spec.mjs` and `ProjectJourneyTool.spec.mjs` final combined run. |
+| Run changed-file/static validation | PASS | `npm run test:playwright:static` PASS and `git diff --check` PASS. |
+| Do not run full samples smoke | PASS | Samples smoke skipped intentionally; no sample scope. |
+
+## Validation
+
+| Lane | Command | Result |
+| --- | --- | --- |
+| Auth/header/login lane | `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs tests/playwright/tools/AdminDbViewer.spec.mjs tests/playwright/tools/ProjectJourneyTool.spec.mjs --project=playwright --reporter=list --workers=1` | PASS, 23/23 |
+| DB Viewer lane | Same final combined command; DB Viewer tests 5/5 | PASS |
+| Shared mock DB lane | Same final combined command; live persistence, DB-shaped Palette/Asset rows, invalid audit behavior covered | PASS |
+| Project Journey lane | Same final combined command; Project Journey tests 13/13 | PASS |
+| Import/static validation lane | `npm run test:playwright:static`; `git diff --check`; boundary `rg` scans | PASS |
+| Runtime JS syntax | `node --check` on changed runtime/test modules | PASS |
+
+Seed-only diagnostic note: final Playwright output intentionally included seed diagnostics for Palette source seed rows and the invalid-audit test seed. These are controlled `src/dev-runtime/` seed-initialization diagnostics, not normal write fallbacks.
+
+## Artifacts
+
+- `docs_build/dev/reports/dev-runtime-final-isolation-fix-report.md`
+- `docs_build/dev/reports/testing_lane_execution_report.md`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`

docs_build/dev/reports/dev-runtime-final-isolation-fix-report.md

@@ -1,6 +1,6 @@
 # Execution Graph Reuse Report
 
-Generated: 2026-06-07T04:35:29.034Z
+Generated: 2026-06-07T05:10:39.389Z
 Status: PASS
 
 ## Summary

docs_build/dev/reports/execution_graph_reuse_report.md

@@ -1,6 +1,6 @@
 # Failure Fingerprint Report
 
-Generated: 2026-06-07T04:35:29.034Z
+Generated: 2026-06-07T05:10:39.389Z
 Status: PASS
 
 ## Summary

docs_build/dev/reports/failure_fingerprint_report.md

@@ -1,6 +1,6 @@
 # Incremental Validation Report
 
-Generated: 2026-06-07T04:35:29.034Z
+Generated: 2026-06-07T05:10:39.390Z
 Status: PASS
 
 ## Reuse Summary

docs_build/dev/reports/incremental_validation_report.md

@@ -1,6 +1,6 @@
 # Lane Compilation Report
 
-Generated: 2026-06-07T04:35:29.033Z
+Generated: 2026-06-07T05:10:39.389Z
 Status: PASS
 
 ## Lane Graph