Add Assets source selection with real upload filename handling - PR_26163_072-assets-source-upload-reference-details

Author: ToolboxAid

docs_build/dev/reports/PR_26163_072-assets-source-upload-reference-details.md

@@ -0,0 +1,77 @@
+# PR_26163_072-assets-source-upload-reference-details
+
+## Branch Validation
+- PASS: current branch is `main`.
+- Expected branch: `main`.
+
+## Impacted Lanes
+- Toolbox Assets runtime lane.
+- Assets mock DB repository lane.
+- Targeted Playwright lane: `tests/playwright/tools/AssetToolMockRepository.spec.mjs`.
+- Workspace contract lane via legacy command `npm run test:workspace-v2`.
+
+## Requirement Checklist
+- PASS: `docs_build/dev/PROJECT_INSTRUCTIONS.md` was read before implementation.
+- PASS: `toolbox/assets/index.html` remains external-JS/external-CSS only; no inline script/style/event handlers were added.
+- PASS: asset add/edit rows expose Source selection where supported.
+- PASS: Upload source shows a file picker, not a free-text File field.
+- PASS: Images Upload file selection updates the visible File detail with the selected filename.
+- PASS: Audio Upload file selection updates the visible File detail with the selected filename.
+- PASS: Fonts Upload file selection updates the visible File detail with the selected filename.
+- PASS: Images show Reference as an option after a valid same-type reference source exists.
+- PASS: Fonts show Upload only until a valid reference source exists.
+- PASS: Reference source shows a Reference selector instead of an upload picker.
+- PASS: missing reference sources fail visibly with `No valid reference source exists.` and save is blocked.
+- PASS: upload save without a selected file fails visibly with `Choose an upload file before saving.`
+- PASS: generated fake filenames were removed from the catalog asset path; `catalogFileNameForName` no longer exists.
+- PASS: Source does not silently switch between Upload and Reference; changes happen through the Source dropdown.
+- PASS: active MVP asset types remain Images, Audio, Fonts, Sprites, Vectors, Palette References, and Data.
+- PASS: Projectile remains absent from usage dropdown values.
+- PASS: shared Tags type-ahead behavior is preserved.
+- PASS: user-owned asset records remain scoped to the owning user.
+- PASS: scope stayed limited to Assets source/upload/reference behavior, targeted tests, and required reports.
+
+## Changed Files
+- `toolbox/assets/assets.js`
+- `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`
+- `tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/PR_26163_072-assets-source-upload-reference-details.md`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+
+## Validation Performed
+- PASS: `node --check toolbox/assets/assets.js`
+- PASS: `node --check src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`
+- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- PASS: `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --reporter=line --workers=1`
+  - Result: 3 passed.
+- PASS: `npm run test:workspace-v2`
+  - Result: 5 passed.
+
+## Playwright Result
+- PASS: targeted Assets Playwright validates source dropdowns, upload file selection, reference selector behavior, missing reference failure, upload-without-file failure, shared Tags type-ahead, owner scope, and absence of Projectile.
+
+## V8 Coverage
+- WARN/PASS: browser runtime coverage for `toolbox/assets/assets.js` was collected at 94%.
+- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` is exercised through Node-side repository assertions and API-backed browser behavior, but is not browser-collected V8 runtime code.
+- Details: `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
+
+## Skipped Lanes
+- Samples validation: SKIP. Samples are explicitly out of scope; this PR only changes the Assets tool source/upload/reference behavior and its mock repository contract.
+- Full samples smoke: SKIP. The request explicitly says not to run full samples smoke.
+- Broad unrelated toolbox lanes: SKIP. No shared navigation, tool registry, auth, sample JSON, or production runtime behavior changed.
+
+## Manual Validation Steps
+1. Open `toolbox/assets/index.html`.
+2. Reset Asset Library.
+3. In Images, click Add Images, confirm Source defaults to Upload and the File cell shows an upload picker.
+4. Try Save without selecting a file and confirm a visible failure.
+5. Select an image file and confirm the File detail shows the filename.
+6. Save, then add another Images row and confirm Reference appears as a Source option.
+7. Select Reference and confirm a Reference selector appears instead of an upload picker.
+8. Open Audio and Fonts add rows and confirm Upload file selection displays the selected filename.
+9. Open Palette References add row with no palette source and confirm the missing reference failure is visible.
+
+## Samples Decision
+- SKIP: no sample JSON alignment, sample runtime, or sample smoke behavior is in scope for PR_26163_072.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,98 +1,7 @@
-# git status --short
-M docs_build/dev/admin-notes/PS_commands.txt
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
- M docs_build/dev/reports/dependency_gating_report.md
- M docs_build/dev/reports/dependency_hydration_reuse_report.md
- M docs_build/dev/reports/execution_graph_reuse_report.md
- M docs_build/dev/reports/failure_fingerprint_report.md
- M docs_build/dev/reports/filesystem_scan_reduction_report.md
- M docs_build/dev/reports/incremental_validation_report.md
- M docs_build/dev/reports/lane_compilation_report.md
- M docs_build/dev/reports/lane_deduplication_report.md
- M docs_build/dev/reports/lane_input_validation_report.md
- M docs_build/dev/reports/lane_manifests/workspace-contract.json
- M docs_build/dev/reports/lane_runtime_optimization_report.md
- M docs_build/dev/reports/lane_snapshot_report.md
- M docs_build/dev/reports/lane_snapshots/workspace-contract.json
- M docs_build/dev/reports/lane_warm_start_report.md
- M docs_build/dev/reports/lane_warm_starts/workspace-contract.json
- M docs_build/dev/reports/monolith_trigger_removal_report.md
- M docs_build/dev/reports/persistent_lane_manifest_report.md
- M docs_build/dev/reports/playwright_discovery_ownership_report.md
- M docs_build/dev/reports/playwright_discovery_scope_report.md
- M docs_build/dev/reports/playwright_structure_audit.md
- M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M docs_build/dev/reports/retry_suppression_report.md
- M docs_build/dev/reports/slow_path_pruning_report.md
- M docs_build/dev/reports/static_validation_report.md
- M docs_build/dev/reports/targeted_file_manifest_report.md
- M docs_build/dev/reports/test_cleanup_performance_report.md
- M docs_build/dev/reports/test_cleanup_routing_report.md
- M docs_build/dev/reports/testing_lane_execution_report.md
- M docs_build/dev/reports/validation_cache_report.md
- M docs_build/dev/reports/zero_browser_preflight_report.md
- M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
- M src/dev-runtime/persistence/mock-db-store.js
- M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
- M src/dev-runtime/persistence/tool-repositories/tags-mock-repository.js
- M tests/playwright/tools/AssetToolMockRepository.spec.mjs
- M tests/playwright/tools/TagsTool.spec.mjs
- M toolbox/assets/assets.js
- M toolbox/tags/index.html
-?? assets/theme-v2/images/badges/tags-1024.png
-?? assets/theme-v2/images/badges/tags.png
-?? assets/theme-v2/images/tools/tags-1024.png
-?? assets/theme-v2/images/tools/tags.png
-?? docs_build/dev/reports/PR_26163_071-tags-assets-completion-fixes.md
-?? docs_build/tools-images-generated/tags.txt
-
-# git ls-files --others --exclude-standard
-assets/theme-v2/images/badges/tags-1024.png
-assets/theme-v2/images/badges/tags.png
-assets/theme-v2/images/tools/tags-1024.png
-assets/theme-v2/images/tools/tags.png
-docs_build/dev/reports/PR_26163_071-tags-assets-completion-fixes.md
-docs_build/tools-images-generated/tags.txt
-
-# git diff --stat
-docs_build/dev/admin-notes/PS_commands.txt         |   4 +-
- .../dev/reports/coverage_changed_js_guardrail.txt  |   2 +-
- docs_build/dev/reports/dependency_gating_report.md |   2 +-
- .../reports/dependency_hydration_reuse_report.md   |  12 +-
- .../dev/reports/execution_graph_reuse_report.md    |  16 +-
- .../dev/reports/failure_fingerprint_report.md      |   2 +-
- .../reports/filesystem_scan_reduction_report.md    |   2 +-
- .../dev/reports/incremental_validation_report.md   |  14 +-
- docs_build/dev/reports/lane_compilation_report.md  |   2 +-
- .../dev/reports/lane_deduplication_report.md       |   2 +-
- .../dev/reports/lane_input_validation_report.md    |   2 +-
- .../reports/lane_manifests/workspace-contract.json |  10 +-
- .../reports/lane_runtime_optimization_report.md    |  14 +-
- docs_build/dev/reports/lane_snapshot_report.md     |  12 +-
- .../reports/lane_snapshots/workspace-contract.json |  22 +-
- docs_build/dev/reports/lane_warm_start_report.md   |  12 +-
- .../lane_warm_starts/workspace-contract.json       |  16 +-
- .../dev/reports/monolith_trigger_removal_report.md |   2 +-
- .../dev/reports/persistent_lane_manifest_report.md |  12 +-
- .../playwright_discovery_ownership_report.md       |   2 +-
- .../reports/playwright_discovery_scope_report.md   |   2 +-
- .../dev/reports/playwright_structure_audit.md      |   2 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |  14 +-
- docs_build/dev/reports/retry_suppression_report.md |   2 +-
- docs_build/dev/reports/slow_path_pruning_report.md |  16 +-
- docs_build/dev/reports/static_validation_report.md |  12 +-
- .../dev/reports/targeted_file_manifest_report.md   |   8 +-
- .../dev/reports/test_cleanup_performance_report.md |  22 +-
- .../dev/reports/test_cleanup_routing_report.md     |   2 +-
- .../dev/reports/testing_lane_execution_report.md   |  52 ++---
- docs_build/dev/reports/validation_cache_report.md  |  30 +--
- .../dev/reports/zero_browser_preflight_report.md   |  10 +-
- .../guest-seeds/tool-metadata-inventory.js         |   6 +-
- src/dev-runtime/persistence/mock-db-store.js       |   2 +-
- .../tool-repositories/assets-mock-repository.js    | 228 ++++++++-------------
- .../tool-repositories/tags-mock-repository.js      |   1 +
- .../tools/AssetToolMockRepository.spec.mjs         |  56 ++++-
- tests/playwright/tools/TagsTool.spec.mjs           |  27 +++
- toolbox/assets/assets.js                           |  92 +++++++--
- toolbox/tags/index.html                            |  11 +-
- 40 files changed, 417 insertions(+), 340 deletions(-)
+docs_build/dev/reports/PR_26163_072-assets-source-upload-reference-details.md
+docs_build/dev/reports/codex_review.diff
+docs_build/dev/reports/playwright_v8_coverage_report.txt
+src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
+tests/playwright/tools/AssetToolMockRepository.spec.mjs
+toolbox/assets/assets.js
+docs_build/dev/reports/codex_changed_files.txt

docs_build/dev/reports/codex_review.diff

@@ -1,66 +1,14 @@
 Playwright V8 Coverage Report
 
-PR: generated by current Playwright run.
-Coverage source: Playwright/Chromium built-in V8 coverage.
-Coverage scope: all repo-relative browser JavaScript collected by Playwright/Chromium V8 coverage.
+PR: PR_26163_072-assets-source-upload-reference-details
+Coverage source: targeted Playwright/Chromium V8 coverage from tests/playwright/tools/AssetToolMockRepository.spec.mjs.
 Dependencies: no new npm packages.
-Thresholds: none enforced.
-Note: coverage is an advisory baseline only for this PR.
-Note: missing changed runtime JS coverage is reported as WARN, not FAIL.
-Note: line counts are V8 range-based and advisory; function counts show partial module exercise where available.
-Note: entry percentages use function coverage when available, otherwise line coverage.
-Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
+Thresholds: none enforced; coverage is advisory.
+Result: WARN only for dev-runtime code that is exercised by tests but not collectible by browser V8 runtime coverage.
 
-Exercised tool entry points detected:
-(84%) Toolbox Index - exercised 7 runtime JS files
-(0%) Tool Template V2 - not exercised by this Playwright run
-(57%) Theme V2 Shared JS - exercised 2 runtime JS files
+Changed runtime JavaScript files:
+(94%) toolbox/assets/assets.js - covered by targeted Assets Playwright; V8 reported executed lines 704/704 and executed functions 67/71.
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARN: dev-runtime repository code is exercised by Node-side repository assertions and browser behavior through the API adapter, but it is not browser runtime JavaScript collected by Playwright V8 coverage.
 
-Changed runtime JS files covered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/tags-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(67%) toolbox/assets/assets-api-client.js - executed lines 19/19; executed functions 2/3
-(96%) toolbox/assets/assets.js - executed lines 533/533; executed functions 52/54
-(100%) toolbox/tags/tags-api-client.js - executed lines 10/10; executed functions 2/2
-(100%) toolbox/tags/tags.js - executed lines 242/242; executed functions 19/19
-
-Files with executed line/function counts where available:
-(33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
-(38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
-(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
-(56%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 650/650; executed functions 30/54
-(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(67%) toolbox/assets/assets-api-client.js - executed lines 19/19; executed functions 2/3
-(75%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 77/103
-(86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(96%) toolbox/assets/assets.js - executed lines 533/533; executed functions 52/54
-(100%) toolbox/game-workspace/game-workspace-api-client.js - executed lines 12/12; executed functions 2/2
-(100%) toolbox/tags/tags-api-client.js - executed lines 10/10; executed functions 2/2
-(100%) toolbox/tags/tags.js - executed lines 242/242; executed functions 19/19
-
-Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/tags-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
-
-Changed JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/tags-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AssetToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/BuildPathProgressSimplification.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/RootToolsFutureState.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/TagsTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolboxRoutePages.spec.mjs - changed JS file not collected as browser runtime coverage
-(67%) toolbox/assets/assets-api-client.js - changed JS file with browser V8 coverage
-(96%) toolbox/assets/assets.js - changed JS file with browser V8 coverage
-(100%) toolbox/tags/tags-api-client.js - changed JS file with browser V8 coverage
-(100%) toolbox/tags/tags.js - changed JS file with browser V8 coverage
+Changed non-runtime validation files:
+(0%) tests/playwright/tools/AssetToolMockRepository.spec.mjs - Playwright spec updated for PR072 behavior; test files are not browser runtime coverage targets.