Audit safe CSS replacements and close template consistency gaps - PR_26154_023-template-consistency-safe-css-audit

ToolboxAid · ToolboxAid · commit 2e125ca4a55a · 2026-06-03T18:11:03.000-04:00
diff --git a/admin/controls.html b/admin/controls.html
@@ -7,7 +7,7 @@
     <title>Controls - Game Foundry Studio</title>
     <meta name="description" content="Game Foundry Studio controls and form component examples.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/admin/grouping-colors.html b/admin/grouping-colors.html
@@ -7,7 +7,7 @@
     <title>Grouping Colors - Game Foundry Studio</title>
     <meta name="description" content="Game Foundry Studio tool grouping and badge color reference.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/admin/ratings.html b/admin/ratings.html
@@ -7,7 +7,7 @@
     <title>Ratings - Game Foundry Studio</title>
     <meta name="description" content="Game Foundry Studio rating reference for games, content, playability and community quality.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/admin/themes.html b/admin/themes.html
@@ -7,7 +7,7 @@
     <title>Themes - Game Foundry Studio</title>
     <meta name="description" content="Plan theme administration for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/community/index.html b/community/index.html
@@ -7,7 +7,7 @@
     <title>Community - Game Foundry Studio</title>
     <meta name="description" content="Game Foundry Studio creators, players, and shared projects.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/company/contact.html b/company/contact.html
@@ -7,7 +7,7 @@
     <title>Contact - Game Foundry Studio</title>
     <meta name="description" content="Plan contact options for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/docs/index.html b/docs/index.html
@@ -7,7 +7,7 @@
     <title>Documentation - Game Foundry Studio</title>
     <meta name="description" content="Game Foundry Studio documentation.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/docs/reference.html b/docs/reference.html
@@ -7,7 +7,7 @@
     <title>Reference - Game Foundry Studio</title>
     <meta name="description" content="Plan reference resources for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/docs/support.html b/docs/support.html
@@ -7,7 +7,7 @@
     <title>Support - Game Foundry Studio</title>
     <meta name="description" content="Plan support resources for Game Foundry Studio creators.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/docs_build/dev/codex_commands.md b/docs_build/dev/codex_commands.md
@@ -2,49 +2,45 @@
 
 Task:
 
-- `PR_26154_022-toolbox-footer-template-consistency-bundle`
+- `PR_26154_023-template-consistency-safe-css-audit`
 
 Commands run:
 
-- `Get-Content .codex/skills/repo-build/SKILL.md`
 - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
-- Targeted inspection of:
+- `Get-Content docs_build/dev/reports/template_consistency_audit_report.md`
+- Inspected:
+  - `assets/theme/v2/css/styles.css`
+  - `assets/theme/v2/css/theme.css`
   - `_page_template_v2.html`
   - `toolbox/_tool_template-v2/index.html`
-  - `assets/theme/v2/partials/header-nav.html`
-  - `assets/theme/v2/partials/footer.html`
-  - `assets/theme/v2/js/gamefoundry-partials.js`
-  - `toolbox/index.html`
-  - `toolbox/tools-page-accordions.js`
-  - active route tests and validators
-- Renamed `tools/` to `toolbox/`.
-- Renamed `toolbox/_templates-v2/` to `toolbox/_tool_template-v2/`.
-- Updated active references from `tools/` to `toolbox/` across public routes, scripts, tests, docs_build references, and Workspace/tool launch paths.
-- Updated `docs_build/dev/PROJECT_INSTRUCTIONS.md` to name `toolbox/_tool_template-v2` as the required first-class tool template source.
-- Updated `assets/theme/v2/partials/footer.html` to the requested footer IA.
-- Updated `assets/theme/v2/js/gamefoundry-partials.js` route/root-segment handling for `toolbox`.
-- Added `theme.css` wiring to `marketplace/index.html` for shared Theme V2 nav/footer behavior.
-- Corrected CSS asset imports in `assets/theme/v2/css/styles.css` back to `tools/grouping/...`.
-- Created:
-  - `docs_build/dev/reports/template_consistency_audit_report.md`
-  - `docs_build/dev/reports/toolbox_footer_template_bundle_report.md`
-- Ran structural validation for PR021 cleanup, footer IA, template rename, toolbox rename, and tools index ordering.
-- Ran active HTML/CSS path validation.
-- Ran targeted `node --check` and JSON parse validation.
+  - active public/root pages from the PR_26154_022 audit
+  - active toolbox pages from the PR_26154_022 audit
+- Ran targeted stylesheet coverage checks for public/root pages using `styles.css`.
+- Replaced `styles.css` with `theme.css` for safe public/root pages only.
+- Added `theme.css` wiring to PR022-listed active toolbox pages where the tool template clearly expects it.
+- Added missing ToolDisplayMode host markers to `toolbox/builder/index.html` and `toolbox/creator/index.html`.
+- Left aggregate-only CSS cases documented for later approved Theme V2 extraction.
+- Left `toolbox/cloud/index.html` documented as an ambiguous display-only page.
+- Reran the template consistency audit and recorded before/after mismatch counts.
+- Ran targeted reference checks for:
+  - `assets/theme/v2/css/styles.css`
+  - `assets/theme/v2/css/theme.css`
+  - `_page_template_v2.html`
+  - `toolbox/_tool_template-v2`
+- Ran static path validation for changed active HTML and CSS references.
+- Ran targeted static syntax validation for changed file types.
 - Ran `git diff --check`.
-- Ran `npm run test:workspace-v2`.
-- Ran a focused Playwright marketplace nested-menu visibility check.
 - Ran `npm run codex:review-artifacts`.
 - Packaged repo-structured ZIP:
-  - `tmp/PR_26154_022-toolbox-footer-template-consistency-bundle_delta.zip`
+  - `tmp/PR_26154_023-template-consistency-safe-css-audit_delta.zip`
 
 Validation summary:
 
-- PASS structural validation for PR021 cleanup, exact footer IA, active toolbox rename, active template rename, and toolbox index alphabetical ordering.
-- PASS active HTML/CSS path validation: 66 HTML files and 515 references checked.
-- PASS targeted static syntax validation: 34 JS/MJS files checked and 4 JSON files parsed.
-- PASS focused marketplace menu browser check: Toolbox, Objects, and Worlds menus visible as expected with no failed requests.
+- PASS targeted PR023 reference checks: 14 safe public/root pages no longer reference `styles.css`, expected aggregate-only public/root references remain documented, and template source paths exist.
+- PASS template consistency audit rerun: public/root pages improved from 15/43 matching to 28/43 matching; active toolbox pages improved from 11/20 matching to 19/20 matching.
+- PASS static path validation for changed active HTML/CSS references.
+- PASS targeted static syntax validation for changed file types.
 - PASS `git diff --check`.
-- PASS `npm run test:workspace-v2`.
+- SKIPPED `npm run test:workspace-v2` because this PR did not change active toolbox launch or navigation behavior.
 - SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples` per request.
 - SKIPPED full samples smoke test per request.
diff --git a/docs_build/dev/commit_comment.txt b/docs_build/dev/commit_comment.txt
@@ -1,8 +1,7 @@
-Rename active tools surface to toolbox and align footer/template wiring - PR_26154_022-toolbox-footer-template-consistency-bundle
+Safe Theme V2 CSS/template consistency cleanup - PR_26154_023-template-consistency-safe-css-audit
 
-- Rename active `tools/` surface to `toolbox/` and update active routes, docs, scripts, tests, and Workspace/tool launch references.
-- Rename the active tool template source to `toolbox/_tool_template-v2/` and update project instructions.
-- Align shared footer IA to the requested Product, Community, Docs & Help, Account, Legal, and Company groups.
-- Add Theme V2 CSS wiring to marketplace and verify Toolbox, Objects, and Worlds menu behavior there.
-- Produce template consistency audit and bundle reports with remaining mismatches documented.
-- Validate with targeted path/static checks, `git diff --check`, and `npm run test:workspace-v2`.
+- Replace `styles.css` with `theme.css` only for public/root pages classified as safe-replace.
+- Document aggregate-only `styles.css` cases that need approved Theme V2 extraction before migration.
+- Add missing `theme.css` wiring to PR022-listed active toolbox pages and add ToolDisplayMode hosts to builder and creator.
+- Leave display-only or ambiguous pages unchanged and report remaining template mismatches.
+- Produce before/after template consistency counts and required Codex review artifacts.
diff --git a/docs_build/dev/reports/template_consistency_before_after_report.md b/docs_build/dev/reports/template_consistency_before_after_report.md
@@ -0,0 +1,44 @@
+# PR_26154_023 Template Consistency Before/After
+
+Input report: `docs_build/dev/reports/template_consistency_audit_report.md`.
+
+The rerun audit used the same template-critical scope as PR_26154_022: CSS wiring, shared template labels/slots, header/footer partials, public page-title presence where applicable, ToolDisplayMode host wiring, tool display script wiring, and left/center/right toolbox shell markers. The root homepage was counted as a public/root page but was not required to use the ordinary `page-title` section.
+
+## Counts
+
+| Surface | Before total | Before matching | Before mismatches | After total | After matching | After mismatches |
+| --- | ---: | ---: | ---: | ---: | ---: | ---: |
+| Public/root pages | 43 | 15 | 28 | 43 | 28 | 15 |
+| Active toolbox pages | 20 | 11 | 9 | 20 | 19 | 1 |
+
+## Remaining Public/Root Mismatches
+
+- `admin/branding.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `admin/controls.html`: missing page-title section.
+- `community/assets.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `community/publish.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `company/about.html`: missing page-title section.
+- `docs/faq.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/action/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/adventure/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/arcade/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/puzzle/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/racing/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/retro/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `games/strategy/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `learn/index.html`: missing `theme.css` link; uses `styles.css` aggregate.
+- `marketplace/index.html`: still uses `styles.css` aggregate. It also keeps the existing `theme.css` link from PR_26154_022.
+
+## Remaining Toolbox Mismatch
+
+- `toolbox/cloud/index.html`: missing ToolDisplayMode host, `tool-display-mode.js`, `tool-workspace` shell, two side tool columns, and center tool panel.
+
+Reason kept: `toolbox/cloud/index.html` appears to be an intentionally display-only cloud page. This PR did not convert it into an interactive left/center/right tool shell.
+
+## Net Result
+
+- Public/root mismatches reduced by 13.
+- Active toolbox mismatches reduced by 8.
+- No new CSS was added.
+- No page-local, tool-local, or inline CSS was introduced.
+- No display-only page was forcibly converted into a tool shell.
diff --git a/docs_build/dev/reports/template_consistency_safe_css_audit_report.md b/docs_build/dev/reports/template_consistency_safe_css_audit_report.md
@@ -0,0 +1,91 @@
+# PR_26154_023 Template Consistency Safe CSS Audit
+
+Input report: `docs_build/dev/reports/template_consistency_audit_report.md` from PR_26154_022.
+
+Scope:
+- Audited public/root pages from the PR022 mismatch list that still used `assets/theme/v2/css/styles.css`.
+- Inspected the aggregate stylesheet before changing references.
+- Replaced `styles.css` with `theme.css` only when the page used template-critical Theme V2 structure and did not depend on selectors that are unique to the aggregate stylesheet.
+- Did not create page-local CSS, tool-local CSS, inline CSS, or new Theme V2 CSS.
+
+## Stylesheet Findings
+
+`assets/theme/v2/css/styles.css` remains an aggregate stylesheet. It imports shared Theme V2-adjacent surfaces including `site-colors.css`, tool grouping CSS, `tokens.css`, `base.css`, `site-controls.css`, `gamefoundrystudio.css`, `pages.css`, and `tools.css`.
+
+`assets/theme/v2/css/theme.css` is the core Theme V2 stylesheet used by the current page template. It covers the template-critical structure for the safe-replace pages below, but it does not currently provide all legacy aggregate selectors used by every page.
+
+## Safe-Replaced Pages
+
+The following public/root pages were classified as `safe-replace` and now reference `theme.css` instead of `styles.css`:
+
+- `admin/controls.html`
+- `admin/grouping-colors.html`
+- `admin/ratings.html`
+- `admin/themes.html`
+- `community/index.html`
+- `company/contact.html`
+- `docs/index.html`
+- `docs/reference.html`
+- `docs/support.html`
+- `games/index.html`
+- `legal/cookie-policy.html`
+- `legal/disclaimer.html`
+- `legal/privacy-policy.html`
+- `legal/terms.html`
+
+Reason: these pages use template-critical page structure that is covered by `theme.css`, and no unique aggregate-only selectors were required for the checked template migration surface.
+
+## Needs Extraction
+
+The following public/root pages still depend on aggregate-only selectors and were classified as `needs-extraction`:
+
+- `admin/branding.html`: uses `feature-image`.
+- `community/assets.html`: uses `feature-image`.
+- `community/publish.html`: uses `page-hero`.
+- `docs/faq.html`: uses `accordion-stack`.
+- `games/action/index.html`: uses `page-hero`.
+- `games/adventure/index.html`: uses `page-hero`.
+- `games/arcade/index.html`: uses `page-hero`.
+- `games/puzzle/index.html`: uses `page-hero`.
+- `games/racing/index.html`: uses `page-hero`.
+- `games/retro/index.html`: uses `page-hero`.
+- `games/strategy/index.html`: uses `page-hero`.
+- `learn/index.html`: uses `page-hero`.
+
+Recommended next step: promote reusable equivalents for `page-hero`, `feature-image`, and `accordion-stack` into approved Theme V2 CSS before replacing these references. No extraction or CSS authoring was performed in this PR.
+
+## Keep For Now
+
+- `marketplace/index.html`: kept `styles.css` while retaining the PR022-added `theme.css` link. The page still uses aggregate-only `page-hero` styling, while shared Theme V2 navigation and footer behavior comes from `theme.css`.
+
+## Public Template Fixes
+
+No page-title structure was added. The remaining missing page-title cases were not clear enough for a surgical template fix:
+
+- `admin/controls.html` uses an intentional `controls-hero` structure.
+- `company/about.html` uses an intentional `about-hero` structure.
+
+## Toolbox Template Fixes
+
+Added `theme.css` wiring to these active toolbox pages from the PR022 audit:
+
+- `toolbox/builder/index.html`
+- `toolbox/cloud/index.html`
+- `toolbox/configuration-admin/index.html`
+- `toolbox/creator/index.html`
+- `toolbox/game-builder/index.html`
+- `toolbox/game-design/index.html`
+- `toolbox/localization/index.html`
+- `toolbox/publish/index.html`
+- `toolbox/world-vector/index.html`
+
+Added the missing ToolDisplayMode host where the existing page already had the tool shell and script wiring:
+
+- `toolbox/builder/index.html`
+- `toolbox/creator/index.html`
+
+Left `toolbox/cloud/index.html` as a reported mismatch. It appears to be an intentionally display-only cloud page, not a left/center/right tool shell, so this PR did not force ToolDisplayMode behavior or workspace columns into it.
+
+## Deletions
+
+`assets/theme/v2/css/styles.css` was not deleted. Active references remain in pages that need approved Theme V2 extraction and in active toolbox pages that still use the aggregate tool styling surface.
diff --git a/games/index.html b/games/index.html
@@ -7,7 +7,7 @@
   <title>Games - Game Foundry Studio</title>
   <meta name="description" content="Browse Game Foundry Studio game types and playable game folders.">
   <link rel="icon" href="/favicon.svg">
-  <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+  <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/legal/cookie-policy.html b/legal/cookie-policy.html
@@ -7,7 +7,7 @@
     <title>Cookie Policy - Game Foundry Studio</title>
     <meta name="description" content="Cookie Policy for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/legal/disclaimer.html b/legal/disclaimer.html
@@ -7,7 +7,7 @@
     <title>Disclaimer - Game Foundry Studio</title>
     <meta name="description" content="Disclaimer for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/legal/privacy-policy.html b/legal/privacy-policy.html
@@ -7,7 +7,7 @@
     <title>Privacy Policy - Game Foundry Studio</title>
     <meta name="description" content="Privacy Policy for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/legal/terms.html b/legal/terms.html
@@ -7,7 +7,7 @@
     <title>Terms and Legal - Game Foundry Studio</title>
     <meta name="description" content="Terms and Legal information for Game Foundry Studio.">
     <link rel="icon" href="/favicon.svg">
-    <link rel="stylesheet" href="../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/toolbox/builder/index.html b/toolbox/builder/index.html
@@ -8,6 +8,7 @@
     <meta name="description" content="Game Foundry Studio Tool Builder layout.">
     <link rel="icon" href="/favicon.svg">
     <link rel="stylesheet" href="../../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../../assets/theme/v2/css/theme.css">
 </head>
 
 <body class="meaning-molten-orange">
@@ -35,6 +36,7 @@ <h2>Toolbox</h2>
                             </details>
                         </div>
                     </aside>
+                    <div data-tool-display-mode></div>
                     <section class="tool-center-panel"><img src="../../assets/theme/v2/images/forge-bot-single.png" alt="ForgeBot">
                         <h2>Workspace</h2>
                         <p>Tool Builder</p>
diff --git a/toolbox/cloud/index.html b/toolbox/cloud/index.html
@@ -8,6 +8,7 @@
     <meta name="description" content="Game Foundry Studio cloud storage and publishing.">
     <link rel="icon" href="/favicon.svg">
     <link rel="stylesheet" href="../../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../../assets/theme/v2/css/theme.css">
 </head>
 
 <body>
diff --git a/toolbox/configuration-admin/index.html b/toolbox/configuration-admin/index.html
@@ -8,6 +8,7 @@
     <meta name="description" content="Game Foundry Studio configuration and admin tool group.">
     <link rel="icon" href="/favicon.svg">
     <link rel="stylesheet" href="../../assets/theme/v2/css/styles.css">
+    <link rel="stylesheet" href="../../assets/theme/v2/css/theme.css">
 </head>
 
 <body class="meaning-steel-gray">
diff --git a/toolbox/creator/index.html b/toolbox/creator/index.html
diff --git a/toolbox/game-builder/index.html b/toolbox/game-builder/index.html
diff --git a/toolbox/game-design/index.html b/toolbox/game-design/index.html
diff --git a/toolbox/localization/index.html b/toolbox/localization/index.html
diff --git a/toolbox/publish/index.html b/toolbox/publish/index.html
diff --git a/toolbox/world-vector/index.html b/toolbox/world-vector/index.html
