Skip to content

Commit 39de54a

Browse files
ToolboxAidToolboxAid
committed
Resolve remaining root src dependencies
1 parent 2e38e9e commit 39de54a

158 files changed

Lines changed: 6122 additions & 21089 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_branch-validation.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Branch Validation
2+
3+
- Expected branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
4+
- Actual branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
5+
- Branch validation: PASS
6+
- Base branch: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
7+
- Worktree before implementation: clean
8+
- Stacked dependency order documented: PASS

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_manual-validation-notes.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Manual Validation Notes
2+
3+
- Read Project Instructions version `2026.06.28.021` from the repository.
4+
- Confirmed Branching Policy version `2026.06.28.002`.
5+
- Confirmed canonical reports path `dev/reports/` and ZIP path `dev/workspace/zips/`.
6+
- Confirmed `src/shared/number/numbers.js` was not tracked on this base.
7+
- Confirmed `git ls-files -- src` count: before 65, after 0.
8+
- Confirmed no files under root `src/` remain on disk after cleanup.
9+
- Confirmed `dev/workspace/generated/tool-images/**` was not touched.
10+
- Confirmed no API/server files were moved into browser paths.
11+
- Confirmed the only browser file update is a path correction to use the existing `www/src` equivalent.
12+
- Full affected test lane still has four behavioral failures unrelated to path movement; keep PR draft until Owner decides whether those failures are acceptable or should be fixed in separate contract-behavior PRs.

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_report.md‎

Lines changed: 144 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Report
2+
3+
## Executive Summary
4+
5+
Resolved the remaining tracked root `src/` files by moving active dev/test/validation-owned contracts, schemas, and the project data store validation helper into `dev/tests/shared/`. Root `src` tracked file count is now `0`.
6+
7+
The requested known case `src/shared/number/numbers.js` was not present on the PR021 base; the existing equivalent remains under `www/src/shared/number/numbers.js`.
8+
9+
## Branch Model
10+
11+
- Model: Owner stacked PR
12+
- Base: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
13+
- Source branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
14+
- Current HEAD before commit: `2e38e9e31cf0b9a2718681ea95a6b8054f4a7a93`
15+
16+
## Root Src Count
17+
18+
- Before: 65 tracked files under `src/`
19+
- After: 0 tracked files under `src/`
20+
21+
## File-by-file Source Decisions
22+
23+
| Source | Destination | Decision |
24+
|---|---|---|
25+
26+
27+
## Additional Active Reference Updates
28+
29+
- Updated dev tests to import contract modules from `dev/tests/shared/contracts/`.
30+
- Updated dev validation schemas to live under `dev/tests/shared/schemas/`.
31+
- Updated `dev/scripts/validate-json-contracts.mjs` to index schemas from `www/src/shared/schemas/` and `dev/tests/shared/schemas/`.
32+
- Updated `www/toolbox/toolRegistry.js` from a root `src` traversal to the existing `www/src/shared/toolbox/tool-metadata-inventory.js` equivalent.
33+
- Regenerated `dev/tools/toolbox-dev/checkSharedExtractionGuard.baseline.json` after root `src` removal.
34+
35+
## Known Delete Candidate Decisions
36+
37+
- `src/shared/projectDataStore/inMemoryProjectDataStore.js`: active only as dev validation helper; moved to `dev/tests/shared/projectDataStore/inMemoryProjectDataStore.js` so no root source or runtime dependency remains.
38+
- `src/shared/schemas/samples/sample.tool-payload.schema.json`: active dev validation schema; moved to `dev/tests/shared/schemas/samples/sample.tool-payload.schema.json`.
39+
- Old manifest/game schema: `game.manifest.schema.json` remains active for dev validation; moved to `dev/tests/shared/schemas/game.manifest.schema.json`.
40+
- Tool `-v2` contract modules: active dev contract tests still import them; moved to `dev/tests/shared/contracts/tools/`.
41+
42+
## Changed Files
43+
44+
- `dev/scripts/validate-json-contracts.mjs`
45+
- `dev/tests/fixtures/workspace-v2/uat.manifest.json`
46+
- `dev/tests/shared/AuditEventContract.test.mjs`
47+
- `dev/tests/shared/BackupSnapshotContract.test.mjs`
48+
- `dev/tests/shared/CollaborationRoleContract.test.mjs`
49+
- `dev/tests/shared/ContractChainValidation.test.mjs`
50+
- `dev/tests/shared/ContractIndexValidation.test.mjs`
51+
- `dev/tests/shared/CreatorProfileContract.test.mjs`
52+
- `dev/tests/shared/DownloadGrantContract.test.mjs`
53+
- `dev/tests/shared/EntitlementContract.test.mjs`
54+
- `dev/tests/shared/GameManifestContract.test.mjs`
55+
- `dev/tests/shared/IdentityPermissionsContract.test.mjs`
56+
- `dev/tests/shared/InMemoryProjectDataStore.test.mjs`
57+
- `dev/tests/shared/InstallReceiptContract.test.mjs`
58+
- `dev/tests/shared/LibraryItemContract.test.mjs`
59+
- `dev/tests/shared/MarketplaceListingContract.test.mjs`
60+
- `dev/tests/shared/MarketplaceTransactionBoundaryContract.test.mjs`
61+
- `dev/tests/shared/MigrationPlanContract.test.mjs`
62+
- `dev/tests/shared/ModerationQueueContract.test.mjs`
63+
- `dev/tests/shared/NotificationContract.test.mjs`
64+
- `dev/tests/shared/OrganizationContract.test.mjs`
65+
- `dev/tests/shared/ProjectContract.test.mjs`
66+
- `dev/tests/shared/ProjectDataStoreContract.test.mjs`
67+
- `dev/tests/shared/ProjectWorkspaceLaunchBoundaryValidation.test.mjs`
68+
- `dev/tests/shared/ProjectWorkspaceLifecycleValidation.test.mjs`
69+
- `dev/tests/shared/ProjectWorkspaceManifestHandoffBoundaryValidation.test.mjs`
70+
- `dev/tests/shared/ProjectWorkspaceRuntimeContract.test.mjs`
71+
- `dev/tests/shared/ProjectWorkspaceStateBoundaryValidation.test.mjs`
72+
- `dev/tests/shared/ProjectWorkspaceToolComplianceValidation.test.mjs`
73+
- `dev/tests/shared/ProjectWorkspaceToolRegistrationValidation.test.mjs`
74+
- `dev/tests/shared/PublishContract.test.mjs`
75+
- `dev/tests/shared/ReleaseContract.test.mjs`
76+
- `dev/tests/shared/RestoreSnapshotContract.test.mjs`
77+
- `dev/tests/shared/ReviewRatingContract.test.mjs`
78+
- `dev/tests/shared/SharedFoundationCombinedPass.test.mjs`
79+
- `dev/tests/shared/ToolStateContract.test.mjs`
80+
- `dev/tests/shared/UpdateChannelContract.test.mjs`
81+
- `dev/tests/shared/VersionCompatibilityContract.test.mjs`
82+
- `dev/tests/shared/Wave1ToolContractBaselineValidation.test.mjs`
83+
- `dev/tests/shared/Wave1ToolStateBoundaryValidation.test.mjs`
84+
- `dev/tests/shared/Wave2ToolContractBaselineValidation.test.mjs`
85+
- `dev/tests/shared/Wave2ToolStateBoundaryValidation.test.mjs`
86+
- `dev/tests/shared/Wave3ToolContractBaselineValidation.test.mjs`
87+
- `dev/tests/shared/Wave3ToolStateBoundaryValidation.test.mjs`
88+
- `dev/tests/shared/schemas/game.manifest.schema.json`
89+
- `dev/tests/shared/schemas/samples/sample.tool-payload.schema.json`
90+
- `dev/tests/shared/tools/AiAssistantToolContract.test.mjs`
91+
- `dev/tests/shared/tools/AnimationStudioToolContract.test.mjs`
92+
- `dev/tests/shared/tools/AssetManagerV2ToolContract.test.mjs`
93+
- `dev/tests/shared/tools/AssetPipelineToolContract.test.mjs`
94+
- `dev/tests/shared/tools/AssetStudioToolContract.test.mjs`
95+
- `dev/tests/shared/tools/AudioSfxPlaygroundV2ToolContract.test.mjs`
96+
- `dev/tests/shared/tools/CodeStudioToolContract.test.mjs`
97+
- `dev/tests/shared/tools/CollisionInspectorV2ToolContract.test.mjs`
98+
- `dev/tests/shared/tools/GameDesignStudioToolContract.test.mjs`
99+
- `dev/tests/shared/tools/InputMappingV2ToolContract.test.mjs`
100+
- `dev/tests/shared/tools/InputStudioToolContract.test.mjs`
101+
- `dev/tests/shared/tools/LocalizationStudioToolContract.test.mjs`
102+
- `dev/tests/shared/tools/MidiStudioV2ToolContract.test.mjs`
103+
- `dev/tests/shared/tools/ObjectVectorStudioV2ToolContract.test.mjs`
104+
- `dev/tests/shared/tools/PaletteManagerV2ToolContract.test.mjs`
105+
- `dev/tests/shared/tools/ParallaxEditorToolContract.test.mjs`
106+
- `dev/tests/shared/tools/ParticleStudioToolContract.test.mjs`
107+
- `dev/tests/shared/tools/PerformanceProfilerToolContract.test.mjs`
108+
- `dev/tests/shared/tools/PhysicsSandboxToolContract.test.mjs`
109+
- `dev/tests/shared/tools/PreviewGeneratorV2ToolContract.test.mjs`
110+
- `dev/tests/shared/tools/PublishStudioToolContract.test.mjs`
111+
- `dev/tests/shared/tools/ReplayVisualizerToolContract.test.mjs`
112+
- `dev/tests/shared/tools/SoundStudioToolContract.test.mjs`
113+
- `dev/tests/shared/tools/SpriteEditorToolContract.test.mjs`
114+
- `dev/tests/shared/tools/StateInspectorToolContract.test.mjs`
115+
- `dev/tests/shared/tools/StorageInspectorV2ToolContract.test.mjs`
116+
- `dev/tests/shared/tools/Text2SpeechV2ToolContract.test.mjs`
117+
- `dev/tests/shared/tools/ThreeDAssetViewerToolContract.test.mjs`
118+
- `dev/tests/shared/tools/ThreeDCameraPathEditorToolContract.test.mjs`
119+
- `dev/tests/shared/tools/ThreeDJsonPayloadToolContract.test.mjs`
120+
- `dev/tests/shared/tools/TileMapEditorToolContract.test.mjs`
121+
- `dev/tests/shared/tools/ToolContractCoverage.test.mjs`
122+
- `dev/tests/shared/tools/ToolOutputDeclarationContract.test.mjs`
123+
- `dev/tests/shared/tools/WorkspaceManagerV2ToolContract.test.mjs`
124+
- `dev/tests/shared/tools/WorldVectorStudioV2ToolContract.test.mjs`
125+
- `dev/tests/tools/ToolManifestBoundary.test.mjs`
126+
- `dev/tests/validation/samples.curriculum.validation.json`
127+
- `dev/tests/validation/samples.runtime.validation.report.json`
128+
- `dev/tests/validation/samples.shared.boundaries.report.json`
129+
- `dev/tools/toolbox-dev/checkSharedExtractionGuard.baseline.json`
130+
- `www/toolbox/toolRegistry.js`
131+
132+
## Validation Summary
133+
134+
- `git diff --check`: PASS
135+
- `npm run validate:canonical-structure`: PASS
136+
- `npm run check:shared-extraction-guard`: PASS
137+
- `node --check` changed JS/MJS files: PASS
138+
- Browser registry import smoke: PASS
139+
- Focused path tests: PASS (`ContractIndexValidation`, `InMemoryProjectDataStore`, `ToolManifestBoundary`, `ContractChainValidation`)
140+
- Full affected contract lane: FAILED, 60/64 pass. Failures are behavioral/count assertions in existing contract tests, not path-resolution failures.
141+
142+
## Outcome
143+
144+
Implementation changes are complete for root `src` dependency resolution, but the Codex outcome is marked FAILED because the full affected contract validation lane has existing failing behavioral assertions.

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_requirement-checklist.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Requirement Checklist
2+
3+
| Requirement | Status | Notes |
4+
|---|---:|---|
5+
| Base from `PR_26180_OWNER_021-archive-legacy-games-samples-teardown` | PASS | Branch created from PR021. |
6+
| Do not leave duplicate code in root `src/` | PASS | `git ls-files -- src` is now 0. |
7+
| Find references for every remaining `src/` file | PASS | Active references were audited and updated. |
8+
| Prefer equivalent under `www/`, `api/`, or `dev/` when present | PASS | `www/toolbox/toolRegistry.js` now uses existing `www/src` equivalent. |
9+
| Move active browser code to `www/src/shared/` | PASS | No remaining root `src` files were classified browser-owned. |
10+
| Move active API/server code to `api/` | PASS | No remaining root `src` files were classified API/server-owned. |
11+
| Move active dev/test/validation code to `dev/` | PASS | Contracts, validation schemas, and project data store helper moved to `dev/tests/shared/`. |
12+
| Delete/archive obsolete manifest/sample/in-memory code where safe | PASS_WITH_NOTE | Candidate files had active dev validation references, so they were moved to dev validation ownership instead of deleted from validation. |
13+
| Resolve `src/shared/number/numbers.js` | PASS_WITH_NOTE | File was not present on the PR021 base; `www/src/shared/number/numbers.js` already exists. |
14+
| Stop on ambiguous ownership | PASS | No ambiguous ownership remained after audit. |
15+
| Preserve product behavior | PASS | Runtime behavior not changed; one browser import path now targets existing `www/src` equivalent. |
16+
| Targeted reference scan for root `src` | PASS | Root contract/project-store/validation-schema refs: 0. |
17+
| Targeted tests for affected imports/contracts/schemas | FAIL | 60/64 affected contract tests pass; four behavioral assertions fail. |
18+
| Reports and ZIP under canonical paths | PASS | Reports under `dev/reports/`; ZIP under `dev/workspace/zips/`. |

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_validation-report.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Validation Report
2+
3+
## Commands Run
4+
5+
| Command | Result | Notes |
6+
|---|---:|---|
7+
| `git diff --check` and `git diff --cached --check` | PASS | Whitespace checks passed after normalizing generated diff report. |
8+
| `npm run validate:canonical-structure` | PASS | Canonical structure guardrail passed. |
9+
| Targeted root `src` reference scan | PASS | Root contract/project-store/validation schema refs are 0. Public `/src/...` browser schema IDs remain intentionally under `www/src`. |
10+
| `npm run check:shared-extraction-guard` | PASS | Baseline regenerated and guard passed. |
11+
| `node --check` on changed JS/MJS files | PASS | 80 changed JS/MJS files checked. |
12+
| `node --input-type=module -e "import('./www/toolbox/toolRegistry.js')..."` | PASS | Browser registry import resolves through `www/src`. |
13+
| `node ./dev/scripts/run-node-test-files.mjs dev/tests/shared/ContractIndexValidation.test.mjs dev/tests/shared/InMemoryProjectDataStore.test.mjs dev/tests/tools/ToolManifestBoundary.test.mjs dev/tests/shared/ContractChainValidation.test.mjs` | PASS | 4/4 focused path tests passed. |
14+
| Full affected contract lane | FAIL | 60/64 passed. Failing files: `MarketplaceListingContract`, `PublishContract`, `ReleaseContract`, `ProjectWorkspaceToolComplianceValidation`. |
15+
| `node ./dev/scripts/validate-json-contracts.mjs --mode=tools --reportDir dev/workspace/tmp/PR_26180_OWNER_022-schema-validation` | PASS_WITH_FINDINGS | Command completed; existing tool schema strictness findings remain. |
16+
17+
## Full Affected Contract Lane Failure Details
18+
19+
- `dev/tests/shared/MarketplaceListingContract.test.mjs`: behavioral visibility assertion failure.
20+
- `dev/tests/shared/PublishContract.test.mjs`: behavioral publish edit-policy assertion failure.
21+
- `dev/tests/shared/ReleaseContract.test.mjs`: behavioral release edit-policy assertion failure.
22+
- `dev/tests/shared/ProjectWorkspaceToolComplianceValidation.test.mjs`: expected 33 migrated tools, actual 32.
23+
24+
These failures are not unresolved root `src` path dependencies. They remain validation blockers for merge readiness.

0 commit comments

Comments
 (0)