Skip to content

Commit 43963d1

Browse files
committed
PR_26155_100-102-tool-display-mode-nav, oops, jumped the gun.
1 parent c3a131c commit 43963d1

5 files changed

Lines changed: 174 additions & 1 deletion

File tree

docs_build/dev/codex_commands.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,34 @@ Required reports:
111111
- `docs_build/dev/reports/codex_review.diff`
112112
- `docs_build/dev/reports/codex_changed_files.txt`
113113

114+
## PR_26155_100-102
115+
116+
Changes:
117+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
118+
- Updated shared Tool Display Mode body layout to identity row plus navigation row.
119+
- Kept character image and tool name on the first row.
120+
- Kept Previous/Next navigation on the second row.
121+
- Changed missing previous/next targets from disabled buttons to disabled text.
122+
- Kept enabled Previous/Next controls as registry-driven links.
123+
- Added the targeted `tool-display-mode` Playwright lane.
124+
125+
Validation:
126+
- `node --check assets/theme-v2/js/tool-display-mode.js`
127+
- `node --check tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs`
128+
- `node --check tests/playwright/tools/ToolNavigationPrevNext.spec.mjs`
129+
- `node --check scripts/run-targeted-test-lanes.mjs`
130+
- `npm run test:lane:tool-display-mode`
131+
- `npm run test:lane:tool-navigation`
132+
- `npm run test:workspace-v2`
133+
- `git diff --check`
134+
135+
Required reports:
136+
- `docs_build/dev/reports/tool-display-mode-nav-layout.md`
137+
- `docs_build/dev/reports/tool-display-mode-registry-links.md`
138+
- `docs_build/dev/reports/tool-display-mode-targeted-msj-tests.md`
139+
- `docs_build/dev/reports/codex_review.diff`
140+
- `docs_build/dev/reports/codex_changed_files.txt`
141+
114142
## PR_26154_053
115143

116144
Changes:

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add registry-driven tool navigation links and Tool Display previous/next controls - PR_26155_096-099-tool-navigation
1+
Refine Tool Display Mode previous next row layout and targeted coverage - PR_26155_100-102-tool-display-mode-nav
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# Tool Display Mode Navigation Layout
2+
3+
PR: PR_26155_100-tool-display-mode-nav-layout
4+
5+
## Summary
6+
7+
- Updated `assets/theme-v2/js/tool-display-mode.js` so Tool Display Mode body renders two explicit rows.
8+
- Row 1 uses `tool-display-mode__identity-row content-cluster` with:
9+
- character image
10+
- tool name
11+
- Row 2 uses `tool-display-mode__navigation-row content-cluster` with:
12+
- Previous link/text
13+
- Next link/text
14+
- Character and tool name are no longer appended as separate stacked body children.
15+
- Navigation no longer renders buttons inside Tool Display Mode.
16+
- No CSS was added.
17+
18+
## Layout Markers
19+
20+
- `data-tool-display-mode-row="identity"`
21+
- `data-tool-display-mode-row="navigation"`
22+
23+
These markers are markup-only validation hooks and do not add styling or behavior.
24+
25+
## Validation
26+
27+
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`
28+
- PASS: `node --check tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs`
29+
- PASS: `npm run test:lane:tool-display-mode`
30+
- PASS: `npm run test:lane:tool-navigation`
31+
- PASS: `npm run test:workspace-v2`
32+
- PASS: `git diff --check`
33+
34+
`npm run test:workspace-v2` is a legacy command name. User-facing naming remains Project Workspace.
35+
36+
## Manual Test Notes
37+
38+
1. Open `toolbox/game-design/index.html?role=user`.
39+
2. Confirm the Tool Display Mode body shows the character and `Game Design` on the first row.
40+
3. Confirm the second row shows `Previous: Project Workspace` and `Next: Game Configuration`.
41+
4. Confirm Tool Display Mode navigation uses links/text only and no buttons.
42+
43+
## Theme V2 Gap Findings
44+
45+
No Theme V2 gap was found. Existing `content-cluster`, `btn`, `btn-secondary`, and `pill` classes were sufficient.
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# Tool Display Mode Registry Links
2+
3+
PR: PR_26155_101-tool-display-mode-registry-links
4+
5+
## Summary
6+
7+
- Previous/Next navigation remains registry-driven through `getToolNavigationTargets(toolSlug)`.
8+
- Tool pages do not hardcode previous or next labels/routes.
9+
- Enabled previous/next controls render as anchors.
10+
- Missing previous/next controls render disabled text with a `pill` class instead of a broken link.
11+
- Multi-path next destinations still route to Toolbox Group view with the target group expanded.
12+
- Current `role` query parameter is preserved when building navigation links.
13+
14+
## Verified Routes
15+
16+
- Game Design:
17+
- Previous: Project Workspace
18+
- Next: Game Configuration
19+
- Project Workspace:
20+
- Previous: AI Assistant
21+
- Next: Game Design
22+
- Game Configuration:
23+
- Previous: Game Design
24+
- Next: Design Tools through `toolbox/index.html?view=group&group=design`
25+
- AI Assistant:
26+
- Previous: disabled text
27+
- Next: Project Workspace
28+
29+
## Validation
30+
31+
- PASS: `npm run test:lane:tool-display-mode`
32+
- PASS: `npm run test:lane:tool-navigation`
33+
- PASS: `git diff --check`
34+
35+
## Manual Test Notes
36+
37+
1. Open `toolbox/project-workspace/index.html?role=user`.
38+
2. Confirm Previous/Next routes match registry build order.
39+
3. Open `toolbox/game-configuration/index.html?role=admin`.
40+
4. Confirm Next routes to `toolbox/index.html?view=group&group=design&role=admin`.
41+
5. Click the link and confirm only the Design accordion is expanded.
42+
43+
## Skipped Lane Rationale
44+
45+
- Game Design, Game Configuration, and Project Workspace runtime lanes were skipped because no tool repository, save/update, validation, handoff, or project data behavior changed.
46+
- Engine and samples lanes were skipped because no engine runtime or sample JSON behavior changed.
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# Tool Display Mode Targeted MSJ Tests
2+
3+
PR: PR_26155_102-tool-display-mode-targeted-msj-tests
4+
5+
## Summary
6+
7+
- Added `npm run test:lane:tool-display-mode`.
8+
- Added `tool-display-mode` lane registration to `scripts/run-targeted-test-lanes.mjs`.
9+
- Added `tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs`.
10+
- Updated the existing `ToolNavigationPrevNext` expectations to match the new `Previous:` / `Next:` link labels.
11+
12+
## Targeted Coverage
13+
14+
The new lane validates:
15+
16+
- Game Design row layout:
17+
- identity row
18+
- navigation row
19+
- character and tool name in the first row
20+
- Previous/Next anchors in the second row
21+
- Game Design registry links:
22+
- `Previous: Project Workspace`
23+
- `Next: Game Configuration`
24+
- Project Workspace registry links.
25+
- Game Configuration multi-path fallback to Toolbox Group view.
26+
- AI Assistant missing previous target as disabled text with no `href`.
27+
- No console errors, page errors, failed requests, or navigation buttons inside Tool Display Mode navigation.
28+
29+
## Validation Results
30+
31+
- PASS: `npm run test:lane:tool-display-mode`
32+
- 4 tests passed.
33+
- PASS: `npm run test:lane:tool-navigation`
34+
- 5 tests passed.
35+
- PASS: `npm run test:workspace-v2`
36+
- 4 tests passed.
37+
- PASS: `git diff --check`
38+
39+
`npm run test:workspace-v2` is a legacy command name. User-facing naming remains Project Workspace.
40+
41+
## Impacted Lanes
42+
43+
- `tool-display-mode`
44+
- `tool-navigation` because existing expectations were updated to the new labels.
45+
- `workspace-contract` through the legacy `npm run test:workspace-v2` command because shared Tool Display Mode behavior changed.
46+
47+
## Skipped Lanes
48+
49+
- `game-design`, `game-configuration`, and `project-workspace`: skipped because no tool-owned runtime or mock repository behavior changed.
50+
- `build-path` and `tools-progress`: skipped because registry build order data and Admin Tools Progress table behavior were not changed in this stack.
51+
- `engine-src`: skipped because no `src/` engine/shared runtime code changed.
52+
- `samples`: skipped because sample JSON and sample runtime behavior are out of scope.
53+
54+
Full suite is required only when shared runtime, shared parser, shared DB, shared Theme V2, or cross-tool integration behavior changes beyond the targeted Tool Display Mode surface.

0 commit comments

Comments
 (0)