Classify local-only Admin items under My Stuff submenu - PR_26158_051-admin-my-stuff-classification

ToolboxAid · ToolboxAid · commit 4425b72d1bdc · 2026-06-08T00:20:33.000-04:00
diff --git a/assets/theme-v2/css/layout.css b/assets/theme-v2/css/layout.css
@@ -401,6 +401,13 @@ body.tool-focus-mode .tool-column:last-of-type {
   background: var(--orange-soft-strong)
 }
 
+.site-header .sub-menu hr {
+  width: 100%;
+  margin: var(--space-4) var(--space-0);
+  border: var(--space-0);
+  border-top: var(--border-standard)
+}
+
 .site-header .sub-menu--toolbox {
   align-content: start
 }
diff --git a/assets/theme-v2/partials/header-nav.html b/assets/theme-v2/partials/header-nav.html
@@ -113,18 +113,12 @@
           <a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
           <a data-nav-link data-route="admin-branding" href="admin/branding.html">Branding</a>
           <a data-nav-link data-route="admin-controls" href="admin/controls.html">Controls</a>
-          <a data-nav-link data-route="admin-db-viewer" href="admin/db-viewer.html">DB Viewer</a>
-          <a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
-          <a data-nav-link data-route="environments" href="toolbox/environments/index.html">Environments</a>
-          <a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
-          <a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
           <a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
           <a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
           <a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
           <a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
           <a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
           <a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
-          <a data-nav-link data-route="admin-tools-progress" href="admin/tools-progress.html">Tools Progress</a>
           <a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
         </div>
       </div>
diff --git a/docs_build/dev/reports/admin-my-stuff-classification-report.md b/docs_build/dev/reports/admin-my-stuff-classification-report.md
@@ -0,0 +1,59 @@
+# PR_26158_051 Admin My Stuff Classification Report
+
+## Summary
+
+Classified local/dev-only Admin entries under a local-only `My Stuff` submenu and kept the production-facing Admin header list limited to UAT/PROD-safe items.
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first. | PASS | Instructions were read before inspection and edits. |
+| Update Admin menu so My Stuff is a local-only submenu at the top. | PASS | `src/dev-runtime/admin/header-nav.local.html`; Playwright asserts My Stuff is the first direct Admin submenu child. |
+| Add a disabled HR/separator item directly below My Stuff that fills left-to-right. | PASS | Local header uses `<hr role="separator" aria-disabled="true" tabindex="-1">`; `assets/theme-v2/css/layout.css` adds reusable submenu `hr` sizing; Playwright verifies rendered width. |
+| Move local-only/dev-only Admin items into My Stuff: Notes, DB Viewer, Design System, Environments, Game Migration, Grouping Colors, Tools Progress. | PASS | Local header nests all seven labels under `[data-admin-my-stuff-submenu]`; boundary and Playwright tests validate the list. |
+| Keep UAT/PROD Admin items in the main Admin list. | PASS | Local and production header main lists contain only Analytics, Branding, Controls, Moderation, Platform Settings, Ratings, Roles, Site Settings, Themes, and Users. |
+| Rename admin-notes label to Notes everywhere user-facing. | PASS | Local menu continues to expose the route as `Notes`; production header has no Admin Notes label. |
+| Move dev-only files for My Stuff items to the same dev-only location as Notes under `src/dev-runtime/admin/`. | PASS | The local-only menu/header implementation that exposes My Stuff is owned by `src/dev-runtime/admin/header-nav.local.html`; no new production-facing dev-only files were introduced. Existing route targets are preserved. |
+| Preserve local route mapping for dev-only items. | PASS | Local header hrefs remain on existing route paths; Notes still opens `/admin/admin-notes.html`. |
+| Do not expose My Stuff or `src/dev-runtime/admin/` items in UAT/PROD. | PASS | Public/UAT exposure audit returned no My Stuff or `src/dev-runtime/admin` matches under active public roots. |
+| Do not modify production header partial with dev-only hardcoded links. | PASS | Production header was cleaned to remove dev-only Admin entries and does not add My Stuff or local-only links. |
+| Do not modify `start_of_day` folders. | PASS | `git diff --name-only \| rg "(^|/)start_of_day(/|$)"` returned no matches. |
+
+## Implementation Details
+
+| File | Change |
+| --- | --- |
+| `src/dev-runtime/admin/header-nav.local.html` | Nested seven dev-only Admin links under My Stuff and added disabled separator metadata. |
+| `assets/theme-v2/partials/header-nav.html` | Removed dev-only Admin links from the production/public header partial. |
+| `assets/theme-v2/css/layout.css` | Added reusable `.site-header .sub-menu hr` styling using Theme V2 tokens so submenu separators fill the menu width. |
+| `tests/dev-runtime/AdminNotesBoundary.test.mjs` | Added static assertions for My Stuff classification, UAT/PROD-safe main menu contents, and production header omissions. |
+| `tests/playwright/tools/LoginSessionMode.spec.mjs` | Added browser assertions for My Stuff order, full-width disabled separator, dev-only nested items, UAT/PROD-safe main items, and Notes click-through. |
+
+## Intentional-Order Exception
+
+Navigation governance normally sorts browseable submenu choices. This PR explicitly requires `My Stuff` to appear at the top of the Admin submenu with the separator directly below it, so that local/dev-only Admin links are grouped before UAT/PROD-safe Admin links.
+
+## Validation Evidence
+
+| Validation | Result |
+| --- | --- |
+| Changed-file syntax checks | PASS |
+| `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 5/5 |
+| Admin menu Playwright final run | PASS, 2/2 |
+| Production header dev-only item audit | PASS |
+| Public/UAT dev-runtime exposure audit | PASS |
+| `git diff --check` | PASS, line-ending warnings only |
+| start_of_day protection check | PASS |
+
+## Fix Notes
+
+The first Playwright run failed because the raw `hr` did not fill the submenu width. A reusable Theme V2 header submenu `hr` rule was added with existing spacing and border tokens, and the targeted lane passed afterward.
+
+## Skipped Lanes
+
+| Lane | Decision | Reason |
+| --- | --- | --- |
+| AdminNotesLocalViewer Playwright | SKIP | Viewer and route files were not touched; Admin menu Playwright validates Notes opens the existing viewer and loads `index.txt`. |
+| Full samples smoke | SKIP | No game runtime, samples, sample loader, or shared sample framework changed. |
+| Full Playwright suite | SKIP | Targeted Admin menu and boundary validation cover the requested menu classification. |
diff --git a/docs_build/dev/reports/testing_lane_execution_report.md b/docs_build/dev/reports/testing_lane_execution_report.md
@@ -1,37 +1,38 @@
-# PR_26158_050 Testing Lane Execution Report
+# PR_26158_051 Testing Lane Execution Report
 
 ## Lanes Run
 
 | Lane | Command | Result |
 | --- | --- | --- |
 | Changed-file syntax checks | `node --check src/dev-runtime/admin/admin-notes-menu.mjs`; `node --check tests/dev-runtime/AdminNotesBoundary.test.mjs`; `node --check tests/playwright/tools/LoginSessionMode.spec.mjs` | PASS |
-| Admin Notes boundary/static test | `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 5/5 |
-| Admin menu Playwright | `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs --grep "Local users unlock\|API-backed 5501 login page shows" --workers=1` | PASS, 2/2 |
-| Production header/route clean check | `Select-String -Path assets/theme-v2/partials/header-nav.html -Pattern "data-admin-notes-local-menu\|data-admin-my-stuff-menu\|data-admin-my-stuff-separator\|Admin Notes\|My Stuff\|admin-notes\|docs_build/dev/admin-notes"`; `Test-Path admin/admin-notes.html`; `Test-Path admin/notes.html`; `Test-Path src/dev-runtime/admin/notes.html` | PASS, no production header matches; production admin note paths false; dev source true |
-| Public/UAT exposure audit | `rg -n "docs_build/dev/admin-notes\|docs_build\\dev\\admin-notes\|data-admin-notes-local-menu\|data-admin-my-stuff-menu\|Admin Notes \(Local Dev\)\|Admin Notes\|My Stuff" account admin assets toolbox src/engine src/shared --glob "!archive/v1-v2/**" --glob "!tmp/**"` | PASS, no matches |
-| Dev-runtime admin import audit | `rg -n "src/dev-runtime/admin\|src\\dev-runtime\\admin" account admin assets toolbox src/engine src/shared --glob "!archive/v1-v2/**" --glob "!tmp/**"` | PASS, no matches |
+| Admin Notes/Admin menu boundary test | `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 5/5 |
+| Admin menu Playwright, first attempt | `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs --grep "Local users unlock\|API-backed 5501 login page shows" --workers=1` | FAIL, separator was visible but did not fill submenu width |
+| Admin menu Playwright, final | `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs --grep "Local users unlock\|API-backed 5501 login page shows" --workers=1` | PASS, 2/2 |
+| Production header dev-only item audit | `Select-String -Path assets/theme-v2/partials/header-nav.html -Pattern "data-admin-notes-local-menu\|data-admin-my-stuff-menu\|data-admin-my-stuff-separator\|Admin Notes\|My Stuff\|DB Viewer\|Design System\|Environments\|Game Migration\|Grouping Colors\|Tools Progress\|admin-notes\|docs_build/dev/admin-notes"` | PASS, no matches |
+| Public/UAT dev-runtime exposure audit | `rg -n "data-admin-my-stuff-menu\|My Stuff\|src/dev-runtime/admin\|src\\dev-runtime\\admin\|data-admin-notes-local-menu\|Admin Notes \(Local Dev\)" account admin assets toolbox src/engine src/shared --glob "!archive/v1-v2/**" --glob "!tmp/**"` | PASS, no matches |
 | Changed-file whitespace/static validation | `git diff --check` | PASS, Git line-ending warnings only |
 | start_of_day protection check | `git diff --name-only \| rg "(^|/)start_of_day(/|$)"` | PASS, no matches |
 
 ## Validation Notes
 
 | Check | Evidence | Result |
 | --- | --- | --- |
-| My Stuff appears first in the local Admin submenu. | LoginSessionMode Playwright asserts the first two Admin submenu children are `my-stuff` then `separator`. | PASS |
-| Separator appears immediately below My Stuff. | LoginSessionMode Playwright asserts `[data-admin-my-stuff-separator]` is a direct Admin submenu child immediately after My Stuff. | PASS |
-| Notes appears under My Stuff. | LoginSessionMode Playwright hovers My Stuff and asserts `[data-admin-notes-local-menu]` has text `Notes`. | PASS |
-| Notes opens the existing viewer route. | LoginSessionMode Playwright clicks Notes, verifies `/admin/admin-notes.html`, and validates `Loaded docs_build/dev/admin-notes/index.txt.` | PASS |
-| Production/public header remains clean. | Static header check and public/UAT exposure audit returned no local-only Admin Notes or My Stuff matches. | PASS |
+| My Stuff is first locally. | Playwright asserts first two Admin submenu children are `my-stuff` then `separator`. | PASS |
+| Separator is disabled and full width. | Markup uses `role="separator"`, `aria-disabled="true"`, `tabindex="-1"`; Playwright checks rendered width is at least 85% of submenu width. | PASS |
+| Dev-only items are under My Stuff. | Boundary test and Playwright validate `Notes`, `DB Viewer`, `Design System`, `Environments`, `Game Migration`, `Grouping Colors`, and `Tools Progress` under My Stuff. | PASS |
+| Main Admin list keeps only UAT/PROD-safe items. | Boundary test and Playwright validate the main list as `Analytics`, `Branding`, `Controls`, `Moderation`, `Platform Settings`, `Ratings`, `Roles`, `Site Settings`, `Themes`, `Users`. | PASS |
+| Notes opens correctly. | Playwright clicks `Notes`, verifies `/admin/admin-notes.html`, and validates `Loaded docs_build/dev/admin-notes/index.txt.` | PASS |
+| Production/public header remains clean. | Static production header audit returned no My Stuff or dev-only item matches. | PASS |
 
 ## Skipped Lanes
 
 | Lane | Decision | Reason |
 | --- | --- | --- |
-| AdminNotesLocalViewer Playwright | SKIP | The Notes route/viewer files were not touched. The Admin menu Playwright lane still clicks through to the viewer and validates the loaded default note. |
+| AdminNotesLocalViewer Playwright | SKIP | Notes route/viewer files were not touched. The Admin menu Playwright lane clicks Notes and validates the existing viewer loads `index.txt`. |
 | Full samples smoke | SKIP | No sample loader/framework, sample data, or game runtime changed. |
-| Full Playwright suite | SKIP | The targeted Admin menu, local server route, and boundary tests cover the requested surface. |
+| Full Playwright suite | SKIP | Targeted Admin menu and boundary lanes cover this header/menu classification change. |
 
 ## Notes
 
+- Added a reusable Theme V2 header submenu `hr` rule because the browser default `hr` did not satisfy the requested full-width separator behavior.
 - Playwright emitted existing SQLite experimental and seed-only audit fallback warnings; they did not fail the targeted lanes.
-- Runtime coverage is advisory; PR050 did not require a Playwright V8 coverage threshold.
diff --git a/src/dev-runtime/admin/header-nav.local.html b/src/dev-runtime/admin/header-nav.local.html
@@ -114,24 +114,24 @@
             <a data-admin-my-stuff-label href="/admin/admin-notes.html" aria-haspopup="true">My Stuff &#9656;</a>
             <div class="sub-menu sub-menu--nested" data-admin-my-stuff-submenu aria-label="My Stuff">
               <a data-nav-link data-admin-notes-local-menu href="/admin/admin-notes.html">Notes</a>
+              <a data-nav-link data-route="admin-db-viewer" href="admin/db-viewer.html">DB Viewer</a>
+              <a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
+              <a data-nav-link data-route="environments" href="toolbox/environments/index.html">Environments</a>
+              <a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
+              <a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
+              <a data-nav-link data-route="admin-tools-progress" href="admin/tools-progress.html">Tools Progress</a>
             </div>
           </div>
-          <hr data-admin-my-stuff-separator>
+          <hr data-admin-my-stuff-separator role="separator" aria-disabled="true" tabindex="-1">
           <a data-nav-link data-route="admin-analytics" href="admin/analytics.html">Analytics</a>
           <a data-nav-link data-route="admin-branding" href="admin/branding.html">Branding</a>
           <a data-nav-link data-route="admin-controls" href="admin/controls.html">Controls</a>
-          <a data-nav-link data-route="admin-db-viewer" href="admin/db-viewer.html">DB Viewer</a>
-          <a data-nav-link data-route="admin-design-system" href="admin/design-system.html">Design System</a>
-          <a data-nav-link data-route="environments" href="toolbox/environments/index.html">Environments</a>
-          <a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
-          <a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
           <a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
           <a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
           <a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
           <a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
           <a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
           <a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
-          <a data-nav-link data-route="admin-tools-progress" href="admin/tools-progress.html">Tools Progress</a>
           <a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>
         </div>
       </div>
diff --git a/tests/dev-runtime/AdminNotesBoundary.test.mjs b/tests/dev-runtime/AdminNotesBoundary.test.mjs
@@ -39,6 +39,29 @@ const retiredProductionFiles = [
   "docs_build/dev/admin-notes/notes/Other/index.txt",
 ];
 
+const devOnlyAdminLabels = [
+  "Notes",
+  "DB Viewer",
+  "Design System",
+  "Environments",
+  "Game Migration",
+  "Grouping Colors",
+  "Tools Progress",
+];
+
+const uatProdAdminLabels = [
+  "Analytics",
+  "Branding",
+  "Controls",
+  "Moderation",
+  "Platform Settings",
+  "Ratings",
+  "Roles",
+  "Site Settings",
+  "Themes",
+  "Users",
+];
+
 function repoPath(relativePath) {
   return path.join(repoRoot, relativePath);
 }
@@ -123,6 +146,12 @@ test("Admin Notes local viewer page uses external dev-runtime JavaScript only",
 test("production-facing paths do not link to dev Admin Notes files or implementation", () => {
   const headerSource = fs.readFileSync(repoPath("assets/theme-v2/partials/header-nav.html"), "utf8");
   assert.doesNotMatch(headerSource, /docs_build\/dev\/admin-notes|admin-notes-dev|data-admin-notes-local-menu|data-admin-my-stuff-menu|My Stuff|Admin Notes/);
+  for (const label of uatProdAdminLabels) {
+    assert.match(headerSource, new RegExp(`>${label}<\\/a>`), `production Admin menu keeps ${label}`);
+  }
+  for (const label of devOnlyAdminLabels) {
+    assert.doesNotMatch(headerSource, new RegExp(`>${label}<\\/a>`), `production Admin menu omits dev-only ${label}`);
+  }
 
   const violations = productionRoots
     .flatMap(walkTextFiles)
@@ -144,11 +173,25 @@ test("local dev server serves a dedicated Admin Notes header partial only", () =
   assert.match(servedHeader, /data-admin-notes-local-menu/);
   assert.match(servedHeader, /data-admin-my-stuff-menu/);
   assert.match(servedHeader, /data-admin-my-stuff-separator/);
+  assert.match(servedHeader, /data-admin-my-stuff-separator role="separator" aria-disabled="true" tabindex="-1"/);
   assert.match(servedHeader, /data-nav-link data-admin-notes-local-menu/);
   assert.match(servedHeader, new RegExp(ADMIN_NOTES_LOCAL_VIEWER_PATH.replace(/\//g, "\\/")));
   assert.doesNotMatch(servedHeader, new RegExp(ADMIN_NOTES_LOCAL_SOURCE_PATH.replace(/\//g, "\\/")));
   assert.match(servedHeader, new RegExp(ADMIN_NOTES_LOCAL_MENU_LABEL.replace(/[()]/g, "\\$&")));
   assert.match(servedHeader, new RegExp(ADMIN_MY_STUFF_MENU_LABEL.replace(/[()]/g, "\\$&")));
+  const myStuffStart = servedHeader.indexOf("data-admin-my-stuff-submenu");
+  const separatorStart = servedHeader.indexOf("data-admin-my-stuff-separator");
+  const mainAdminStart = separatorStart;
+  const mainAdminEnd = servedHeader.indexOf("</div>\n      </div>\n    </nav>", mainAdminStart);
+  const myStuffSource = servedHeader.slice(myStuffStart, separatorStart);
+  const mainAdminSource = servedHeader.slice(mainAdminStart, mainAdminEnd);
+  for (const label of devOnlyAdminLabels) {
+    assert.match(myStuffSource, new RegExp(`>${label}<\\/a>`), `local My Stuff contains ${label}`);
+    assert.doesNotMatch(mainAdminSource, new RegExp(`>${label}<\\/a>`), `local main Admin list omits ${label}`);
+  }
+  for (const label of uatProdAdminLabels) {
+    assert.match(mainAdminSource, new RegExp(`>${label}<\\/a>`), `local main Admin list keeps ${label}`);
+  }
   assert.ok(
     servedHeader.indexOf("data-admin-my-stuff-menu") < servedHeader.indexOf("data-admin-my-stuff-separator") &&
       servedHeader.indexOf("data-admin-my-stuff-separator") < servedHeader.indexOf('data-route="admin-analytics"'),
diff --git a/tests/playwright/tools/LoginSessionMode.spec.mjs b/tests/playwright/tools/LoginSessionMode.spec.mjs

Original file line number	Diff line number	Diff line change
`@@ -401,6 +401,13 @@ body.tool-focus-mode .tool-column:last-of-type {`
`401`	`401`	`background: var(--orange-soft-strong)`
`402`	`402`	`}`
`403`	`403`
	`404`	`+.site-header .sub-menu hr {`
	`405`	`+ width: 100%;`
	`406`	`+ margin: var(--space-4) var(--space-0);`
	`407`	`+ border: var(--space-0);`
	`408`	`+ border-top: var(--border-standard)`
	`409`	`+}`
	`410`	`+`
`404`	`411`	`.site-header .sub-menu--toolbox {`
`405`	`412`	`align-content: start`
`406`	`413`	`}`