Skip to content

Commit 44b6ace

Browse files
committed
PR_26171_BETA_073 message tts table ui correction
1 parent eaee83f commit 44b6ace

48 files changed

Lines changed: 1558 additions & 648 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction Instruction Compliance Checklist
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
Branch: pr/26171-BETA-073-message-tts-table-ui-correction
6+
7+
## Gate
8+
9+
- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
10+
- PASS: Read `docs_build/dev/PROJECT_MULTI_PC.txt`.
11+
- PASS: Current branch was `main` before creating `pr/26171-BETA-073-message-tts-table-ui-correction`.
12+
- PASS: Repository was clean and synced with `origin/main` before branch creation.
13+
- PASS: PR name includes required TEAM token `BETA`.
14+
- PASS: Team BETA owns Messages, Text To Speech/TTS, and Audio content work.
15+
- PASS: Implementation path uses active `toolbox/text-to-speech/` and `toolbox/messages/` paths.
16+
- PASS: No `tools/text2speech/` path was created.
17+
- PASS: Required validation scope was targeted TTS Studio, targeted Message Studio, and legacy `npm run test:workspace-v2` for Project Workspace/Game Hub coverage.
18+
- PASS: Required report and ZIP outputs are included in this PR.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction Manual Validation Notes
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
Branch: pr/26171-BETA-073-message-tts-table-ui-correction
6+
7+
## Manual Review
8+
9+
- Reviewed `src/shared/toolbox/tool-metadata-inventory.js` to confirm Text To Speech uses the active `text-to-speech/index.html` registry entry and beta release metadata.
10+
- Reviewed `toolbox/text-to-speech/index.html` to confirm the summary uses only Theme V2 reusable classes and keeps all live data hooks.
11+
- Reviewed `toolbox/messages/index.html` and `toolbox/messages/messages.js` to confirm Add Message/Add Part are table-row workflows and Message Parts remain child table content.
12+
- Reviewed targeted Playwright coverage for Message Studio TTS Profile dropdown compatibility.
13+
14+
## Automated Browser Validation Used As Manual Proxy
15+
16+
- TTS validation clicked through the toolbox index Text To Speech card and confirmed the active path.
17+
- TTS validation exercised the TTS Studio page, summary hooks, profile/emotion table behavior, and speech synthesis.
18+
- Message validation exercised add/edit message rows, add/edit part rows, name-cell expansion, part-count non-expansion, message playback, part playback, and unavailable audio errors.
19+
20+
## Not Performed
21+
22+
- No unscripted manual browser session was run beyond Playwright browser validation.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction Message Parent-Child Table Checklist
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
6+
- PASS: Parent table remains `Messages`.
7+
- PASS: Message name cell owns expand/collapse and exposes `aria-expanded`.
8+
- PASS: Keyboard Enter/Space on the message name cell toggles the child table.
9+
- PASS: Clicking the Parts count cell does not expand the child table.
10+
- PASS: Child table remains `Message Parts` with ordered parts.
11+
- PASS: Child table includes Order, Text, Emotion, TTS Profile, Status, and Actions columns.
12+
- PASS: Add Message is an inline table action row and opens an inline add row.
13+
- PASS: Edit Message opens an inline edit row.
14+
- PASS: Add Part is an inline child-table action row and opens an inline add row.
15+
- PASS: Edit Part opens an inline edit row.
16+
- PASS: Play Message, Play Part, and Stop remain visible and validated.
17+
- PASS: No separate Emotion Studio was introduced.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction TTS Summary Layout Checklist
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
6+
- PASS: TTS summary uses existing Theme V2 `content-cluster content-cluster--nowrap` classes.
7+
- PASS: TTS summary uses existing `pill`, `mini-stat`, and `mini-stat--inline` classes.
8+
- PASS: Summary row includes TTS Studio, Characters, TTS Profiles, Emotion Settings, Voices, and Engine items.
9+
- PASS: The existing live data hooks remain: `data-tts-text-count`, `data-tts-profile-count`, `data-tts-emotion-count`, `data-tts-voice-count`, and `data-tts-engine-label`.
10+
- PASS: No page-local CSS, tool-local CSS, inline style, or style block was added.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction TTS Tools Registration Checklist
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
6+
- PASS: Text To Speech metadata uses `path: text-to-speech`.
7+
- PASS: Text To Speech metadata uses `entryPoint: text-to-speech/index.html`.
8+
- PASS: Text To Speech metadata now uses `status: beta` and `releaseChannel: beta`.
9+
- PASS: Toolbox index validation finds `Text To Speech` with href `/toolbox/text-to-speech/index.html`.
10+
- PASS: Toolbox index validation finds `data-registered-tool-route=toolbox/text-to-speech/index.html`.
11+
- PASS: Validation asserts no link targets `tools/text2speech`.
12+
- PASS: No `tools/text2speech/` directory was created.
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction Validation Report
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
Branch: pr/26171-BETA-073-message-tts-table-ui-correction
6+
7+
## Required Validation
8+
9+
- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`
10+
- 3 passed. Covers TTS page behavior, one-line summary row, toolbox registration path, and unavailable speech error.
11+
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
12+
- 4 passed. Covers TTS shell/profile contract.
13+
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off`
14+
- 2 passed. Covers Messages parent/child table, inline add/edit rows, TTS Profile dropdown compatibility, playback, and unavailable audio error.
15+
- PASS: `npm run test:workspace-v2`
16+
- Legacy command name; user-facing product language is Project Workspace/Game Hub. Final rerun passed 5 workspace-contract tests.
17+
- PASS: `git diff --check`
18+
- No whitespace errors; Git emitted line-ending normalization warnings only.
19+
20+
## Additional Focused Sanity Validation
21+
22+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index shows wireframe" --trace=off`
23+
- 1 passed after updating expected toolbox counts for Text To Speech moving from planned/missing metadata into active beta registration.
24+
25+
## Notes
26+
27+
- Initial Message Studio validation exposed a missing Add Message control on empty tables; fixed and reran to PASS.
28+
- Initial Project Workspace validation exposed stale toolbox count expectations; fixed and reran to PASS.
29+
- Node emitted experimental SQLite warnings during relevant test runs; tests passed.
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# PR_26171_BETA_073-message-tts-table-ui-correction
2+
3+
Generated: 2026-06-20T23:06:25.711Z
4+
Team ownership: BETA
5+
Branch: pr/26171-BETA-073-message-tts-table-ui-correction
6+
Base HEAD: eaee83f9327b336ec5679ebd591d94e50fab0523
7+
origin/main at branch start: eaee83f9327b336ec5679ebd591d94e50fab0523
8+
Ahead/behind before commit: 0 0
9+
Spec source: latest user request in Codex session; no repository BUILD_PR doc for PR_26171_BETA_073 was found by targeted search.
10+
11+
## Purpose
12+
13+
Correct TTS and Message Studio UI alignment while preserving Theme V2, external JavaScript, existing Local API contracts, and server/API-backed product data ownership.
14+
15+
## Requirement Checklist
16+
17+
- PASS: TTS Studio appears on the toolbox index through the active registry path `toolbox/text-to-speech/index.html`.
18+
- PASS: No `tools/text2speech/` path was created or linked.
19+
- PASS: TTS summary uses a single Theme V2 inline row with TTS Studio, Characters, TTS Profiles, Emotion Settings, Voices, and Engine items.
20+
- PASS: Message Studio keeps parent table `Messages`.
21+
- PASS: Message name cell owns expand/collapse for the Message Parts child table; clicking the Parts count does not expand.
22+
- PASS: Message Parts child table keeps ordered parts with Text, Emotion, TTS Profile, Status, and Actions.
23+
- PASS: Add/Edit Message and Add/Edit Part remain inline row workflows.
24+
- PASS: Play Message, Play Part, and Stop controls remain visible and validated.
25+
- PASS: No separate Emotion Studio was created.
26+
- PASS: No database tables or browser-owned product data source of truth were added.
27+
- PASS: No inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were added.
28+
29+
## Implementation Summary
30+
31+
- Corrected Text To Speech registry metadata from uppercase `Beta` to authoritative `beta` release-channel metadata so the DB-backed toolbox registry exposes it as active/visible.
32+
- Reworked the TTS summary from a five-card grid into a Theme V2 nowrap inline summary row.
33+
- Moved Message Studio Add Message and Add Part actions into table rows.
34+
- Tightened Message Studio expansion to the parent message name cell with keyboard support.
35+
- Updated targeted and workspace tests for the corrected TTS registration and table behavior.
36+
37+
## Git Workflow
38+
39+
- Current branch: pr/26171-BETA-073-message-tts-table-ui-correction
40+
- Created branch: `pr/26171-BETA-073-message-tts-table-ui-correction`
41+
- Push result: pending until commit/push step completes.
42+
- PR URL: pending until PR creation step completes.
43+
- Merge result: pending until PR merge step completes.
44+
- Final main commit: pending until post-merge sync completes.

docs_build/dev/reports/codex_changed_files.txt

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-manual-validation-notes.md
2-
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-validation.md
3-
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table.md
41
docs_build/dev/reports/codex_changed_files.txt
52
docs_build/dev/reports/codex_review.diff
63
docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -13,15 +10,25 @@ docs_build/dev/reports/incremental_validation_report.md
1310
docs_build/dev/reports/lane_compilation_report.md
1411
docs_build/dev/reports/lane_deduplication_report.md
1512
docs_build/dev/reports/lane_input_validation_report.md
13+
docs_build/dev/reports/lane_manifests/workspace-contract.json
1614
docs_build/dev/reports/lane_runtime_optimization_report.md
1715
docs_build/dev/reports/lane_snapshot_report.md
16+
docs_build/dev/reports/lane_snapshots/workspace-contract.json
1817
docs_build/dev/reports/lane_warm_start_report.md
18+
docs_build/dev/reports/lane_warm_starts/workspace-contract.json
1919
docs_build/dev/reports/monolith_trigger_removal_report.md
2020
docs_build/dev/reports/persistent_lane_manifest_report.md
2121
docs_build/dev/reports/playwright_discovery_ownership_report.md
2222
docs_build/dev/reports/playwright_discovery_scope_report.md
2323
docs_build/dev/reports/playwright_structure_audit.md
2424
docs_build/dev/reports/playwright_v8_coverage_report.txt
25+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-instruction-compliance-checklist.md
26+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-manual-validation-notes.md
27+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-message-parent-child-table-checklist.md
28+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-summary-layout-checklist.md
29+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-tools-registration-checklist.md
30+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-validation-report.md
31+
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction.md
2532
docs_build/dev/reports/retry_suppression_report.md
2633
docs_build/dev/reports/slow_path_pruning_report.md
2734
docs_build/dev/reports/static_validation_report.md
@@ -31,5 +38,11 @@ docs_build/dev/reports/test_cleanup_routing_report.md
3138
docs_build/dev/reports/testing_lane_execution_report.md
3239
docs_build/dev/reports/validation_cache_report.md
3340
docs_build/dev/reports/zero_browser_preflight_report.md
41+
src/shared/toolbox/tool-metadata-inventory.js
42+
tests/playwright/tools/MessagesTool.spec.mjs
43+
tests/playwright/tools/RootToolsFutureState.spec.mjs
3444
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
35-
toolbox/text-to-speech/text2speech.js
45+
tests/playwright/tools/ToolboxRoutePages.spec.mjs
46+
toolbox/messages/index.html
47+
toolbox/messages/messages.js
48+
toolbox/text-to-speech/index.html

0 commit comments

Comments
 (0)