Skip to content

Commit 464aa69

Browse files
ToolboxAidToolboxAid
committed
Fix src shared toolbox import paths - PR_26155_031-src-shared-toolbox-imports
1 parent 7cc903f commit 464aa69

10 files changed

Lines changed: 80 additions & 19 deletions

‎docs_build/dev/reports/src-shared-toolbox-import-fix.md‎

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
# Src Shared Toolbox Import Fix
2+
3+
## Summary
4+
5+
- Audited only `src/shared/toolbox` for imports containing `../../src/`.
6+
- Corrected broken imports from files already under `src/shared/toolbox` so they no longer route through `../../src/`.
7+
- Did not modify imports under `tests/`.
8+
- Did not move files, rename files, change Toolbox UI, change Theme V2, or alter tool naming.
9+
10+
## Changed Import Paths
11+
12+
- `src/shared/toolbox/runtimeAssetLoader.js`
13+
- `../../src/engine/assets/AssetRegistry.js` -> `../../engine/assets/AssetRegistry.js`
14+
- `../../src/engine/assets/AssetLoaderSystem.js` -> `../../engine/assets/AssetLoaderSystem.js`
15+
- `../../src/engine/assets/ImageAssetLoader.js` -> `../../engine/assets/ImageAssetLoader.js`
16+
- `src/shared/toolbox/runtimeStreaming.js`
17+
- `../../src/engine/assets/AssetRegistry.js` -> `../../engine/assets/AssetRegistry.js`
18+
- `../../src/engine/assets/AssetLoaderSystem.js` -> `../../engine/assets/AssetLoaderSystem.js`
19+
- `../../src/engine/assets/ImageAssetLoader.js` -> `../../engine/assets/ImageAssetLoader.js`
20+
- `src/shared/toolbox/assetUsageIntegration.js`
21+
- `../../src/engine/persistence/LocalStorageService.js` -> `../../engine/persistence/LocalStorageService.js`
22+
- `src/shared/toolbox/devConsoleDebugOverlay.js`
23+
- `../../src/engine/debug/inspectors/shared/inspectorUtils.js` -> `../../engine/debug/inspectors/shared/inspectorUtils.js`
24+
- `src/shared/toolbox/documentModeGuards.js`
25+
- `../../src/engine/persistence/LocalStorageService.js` -> `../../engine/persistence/LocalStorageService.js`
26+
- `../../src/engine/persistence/SessionStorageService.js` -> `../../engine/persistence/SessionStorageService.js`
27+
- `src/shared/toolbox/platformShell.js`
28+
- `../../src/engine/logging/Logger.js` -> `../../engine/logging/Logger.js`
29+
- `../../src/engine/persistence/LocalStorageService.js` -> `../../engine/persistence/LocalStorageService.js`
30+
- `../../src/engine/persistence/SessionStorageService.js` -> `../../engine/persistence/SessionStorageService.js`
31+
- `../../src/engine/runtime/RuntimeMonitoringHooks.js` -> `../../engine/runtime/RuntimeMonitoringHooks.js`
32+
- `src/shared/toolbox/projectSystem.js`
33+
- `../../src/engine/persistence/FilePersistenceService.js` -> `../../engine/persistence/FilePersistenceService.js`
34+
- `src/shared/toolbox/toolHostSharedContext.js`
35+
- `../../src/engine/persistence/LocalStorageService.js` -> `../../engine/persistence/LocalStorageService.js`
36+
- `../../src/engine/persistence/SessionStorageService.js` -> `../../engine/persistence/SessionStorageService.js`
37+
- `src/shared/toolbox/toolLaunchSSoT.js`
38+
- `../../src/engine/persistence/LocalStorageService.js` -> `../../engine/persistence/LocalStorageService.js`
39+
- `../../src/engine/persistence/SessionStorageService.js` -> `../../engine/persistence/SessionStorageService.js`
40+
41+
## Audit Results
42+
43+
- `rg -n "\.\./\.\./src/" src/shared/toolbox`: PASS, no matches remain.
44+
- `../../src/shared/...` was checked under `src/shared/toolbox`; no matches were present.
45+
- Test imports under `tests/` were intentionally left unchanged.
46+
47+
## Targeted Validation
48+
49+
- `RuntimeAssetLoader`: PASS.
50+
- `RuntimeStreamingSystem`: PASS.
51+
- `DevConsoleDebugOverlay`: PASS.
52+
- `AssetUsageIntegration`: FAILS after successful module import on an existing behavior assertion:
53+
- actual `#`
54+
- expected `../palette-manager-v2/index.html?sourceToolId=sprite-editor`
55+
- The failure is outside this PR scope because the requested change is import-path-only and the assertion targets old Palette Manager routing behavior.
56+
- `git diff --check`: PASS.
57+
58+
## Playwright Impact
59+
60+
- Playwright impacted: No.
61+
- No Playwright tests were run because this PR only fixes shared module import paths.

‎src/shared/toolbox/assetUsageIntegration.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import LocalStorageService from '../../src/engine/persistence/LocalStorageService.js';
1+
import LocalStorageService from '../../engine/persistence/LocalStorageService.js';
22
import { sanitizeText } from "../string/strings.js";
33
import { getToolById } from "../../../toolbox/toolRegistry.js";
44

‎src/shared/toolbox/devConsoleDebugOverlay.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ const CORE_PANEL_SPECS = Object.freeze([
9595
{ id: "validation-warnings", title: "Validation", source: "validation", priority: 1000, renderMode: "text-block", enabled: true }
9696
]);
9797

98-
import { sanitizeText } from "../../src/engine/debug/inspectors/shared/inspectorUtils.js";
98+
import { sanitizeText } from "../../engine/debug/inspectors/shared/inspectorUtils.js";
9999
import { isObject } from "../object/objects.js";
100100
import { cloneJson } from "../json/clone.js";
101101

‎src/shared/toolbox/documentModeGuards.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import LocalStorageService from '../../src/engine/persistence/LocalStorageService.js';
2-
import SessionStorageService from '../../src/engine/persistence/SessionStorageService.js';
1+
import LocalStorageService from '../../engine/persistence/LocalStorageService.js';
2+
import SessionStorageService from '../../engine/persistence/SessionStorageService.js';
33
import { sanitizeText } from "../string/strings.js";
44
const VIEWER_PAYLOAD_STORAGE_KEY_PREFIX = "toolboxaid.viewerPayload.";
55

‎src/shared/toolbox/platformShell.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ import { createWorkspaceSystemController } from "./projectSystem.js";
1212
import { bindEventHandlers, createCommandDispatcher } from "./eventCommandUtils.js";
1313
import { asHtmlInput, queryAll, queryFirst, readDataAttribute, setTextContent } from "./uiSafeUtils.js";
1414
import { escapeHtml } from "../string/strings.js";
15-
import Logger from "../../src/engine/logging/Logger.js";
16-
import LocalStorageService from '../../src/engine/persistence/LocalStorageService.js';
17-
import SessionStorageService from '../../src/engine/persistence/SessionStorageService.js';
18-
import { createRuntimeMonitoringHooks } from '../../src/engine/runtime/RuntimeMonitoringHooks.js';
15+
import Logger from "../../engine/logging/Logger.js";
16+
import LocalStorageService from '../../engine/persistence/LocalStorageService.js';
17+
import SessionStorageService from '../../engine/persistence/SessionStorageService.js';
18+
import { createRuntimeMonitoringHooks } from '../../engine/runtime/RuntimeMonitoringHooks.js';
1919
import { logToolUiControlReady, logToolUiFinalReady, logToolUiLifecycle } from "./toolLoadDiagnostics.js";
2020

2121
let workspaceController = null;

‎src/shared/toolbox/projectSystem.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { getToolById } from "../../../toolbox/toolRegistry.js";
2-
import { downloadTextFile, readFileText } from '../../src/engine/persistence/FilePersistenceService.js';
2+
import { downloadTextFile, readFileText } from '../../engine/persistence/FilePersistenceService.js';
33
import {
44
ACTIVE_PROJECT_STORAGE_KEY,
55
captureSharedReferenceSnapshot,

‎src/shared/toolbox/runtimeAssetLoader.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import AssetRegistry from "../../src/engine/assets/AssetRegistry.js";
2-
import AssetLoaderSystem from "../../src/engine/assets/AssetLoaderSystem.js";
3-
import ImageAssetLoader from "../../src/engine/assets/ImageAssetLoader.js";
1+
import AssetRegistry from "../../engine/assets/AssetRegistry.js";
2+
import AssetLoaderSystem from "../../engine/assets/AssetLoaderSystem.js";
3+
import ImageAssetLoader from "../../engine/assets/ImageAssetLoader.js";
44
import { prepareVectorGeometryRuntimeAsset } from "./vectorGeometryRuntime.js";
55
import { validatePackageManifest, createRegistryDefinition } from "./runtimeAssetValidationUtils.js";
66
import { createRuntimeReport, sanitizeRuntimeText } from "./runtimeAssetSharedUtils.js";

‎src/shared/toolbox/runtimeStreaming.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import AssetRegistry from "../../src/engine/assets/AssetRegistry.js";
2-
import AssetLoaderSystem from "../../src/engine/assets/AssetLoaderSystem.js";
3-
import ImageAssetLoader from "../../src/engine/assets/ImageAssetLoader.js";
1+
import AssetRegistry from "../../engine/assets/AssetRegistry.js";
2+
import AssetLoaderSystem from "../../engine/assets/AssetLoaderSystem.js";
3+
import ImageAssetLoader from "../../engine/assets/ImageAssetLoader.js";
44
import { cloneJson } from "../json/clone.js";
55
import { validatePackageManifest, createRegistryDefinition } from "./runtimeAssetValidationUtils.js";
66
import { createRuntimeReport, sanitizeRuntimeText } from "./runtimeAssetSharedUtils.js";

‎src/shared/toolbox/toolHostSharedContext.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import LocalStorageService from '../../src/engine/persistence/LocalStorageService.js';
2-
import SessionStorageService from '../../src/engine/persistence/SessionStorageService.js';
1+
import LocalStorageService from '../../engine/persistence/LocalStorageService.js';
2+
import SessionStorageService from '../../engine/persistence/SessionStorageService.js';
33

44
const TOOL_HOST_CONTEXT_KEY_PREFIX = "toolboxaid.toolHost.context.";
55

‎src/shared/toolbox/toolLaunchSSoT.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import {
22
getSampleToolLaunchDefinition,
33
validateLaunchDefinitionAccess
44
} from "./toolLaunchSSoTData.js";
5-
import LocalStorageService from '../../src/engine/persistence/LocalStorageService.js';
6-
import SessionStorageService from '../../src/engine/persistence/SessionStorageService.js';
5+
import LocalStorageService from '../../engine/persistence/LocalStorageService.js';
6+
import SessionStorageService from '../../engine/persistence/SessionStorageService.js';
77
import { normalizeText } from "../string/strings.js";
88

99
const TOOLBOXAID_STORAGE_KEY_PREFIX = "toolboxaid.";

0 commit comments

Comments
 (0)