|
| 1 | +# PR_26163_055-account-aside-left-column-accordion-fix |
| 2 | + |
| 3 | +## Branch Validation |
| 4 | + |
| 5 | +- Current branch: `main` |
| 6 | +- Expected branch: `main` |
| 7 | +- Branch validation: PASS |
| 8 | + |
| 9 | +## Requirement Checklist |
| 10 | + |
| 11 | +- PASS - Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before implementation. |
| 12 | +- PASS - Created PR scope `PR_26163_055-account-aside-left-column-accordion-fix`. |
| 13 | +- PASS - Account Pages / Account Guidance accordion is present and visible in the account left column. |
| 14 | +- PASS - Aside remains on the left through `.account-panel > .side-menu` Theme V2 layout wiring. |
| 15 | +- PASS - Center content column fills the remaining available space beside the left aside through `.account-panel > .card` Theme V2 layout wiring. |
| 16 | +- PASS - Account Pages appears above Account Guidance as one stacked vertical accordion column. |
| 17 | +- PASS - Existing Theme V2/tool accordion classes are reused: `tool-column`, `tool-column-header`, `accordion-stack`, and `vertical-accordion`. |
| 18 | +- PASS - No new accordion system was created. |
| 19 | +- PASS - No page-local CSS, inline styles, script blocks, or inline event handlers were added. |
| 20 | +- PASS - Scope stayed limited to account side-nav partial/layout wiring, approved Theme V2 layout CSS, targeted tests, and required reports. |
| 21 | + |
| 22 | +## Changed Files |
| 23 | + |
| 24 | +- `assets/theme-v2/css/layout.css` |
| 25 | +- `assets/theme-v2/partials/account-side-nav.html` |
| 26 | +- `tests/playwright/tools/InputMappingV2Tool.spec.mjs` |
| 27 | +- `docs_build/dev/reports/PR_26163_055-account-aside-left-column-accordion-fix.md` |
| 28 | +- `docs_build/dev/reports/codex_review.diff` |
| 29 | +- `docs_build/dev/reports/codex_changed_files.txt` |
| 30 | + |
| 31 | +## Implementation Notes |
| 32 | + |
| 33 | +- `account/user-controls.html` already loads the shared account side-nav with `<div data-partial="account-side-nav" data-partial-replace></div>`. |
| 34 | +- The fix was applied to the loaded side-nav partial so Account/User Controls and other account pages receive the same left-column accordion structure. |
| 35 | +- `assets/theme-v2/partials/account-side-nav.html` now uses the Toolbox-style left column container pattern: `side-menu tool-column tool-group-platform`, a `tool-column-header`, and a stacked `accordion-stack`. |
| 36 | +- `assets/theme-v2/css/layout.css` adds account-panel-specific grid placement so `.side-menu` stays in column 1 and the `.card` center content stays in column 2 on desktop, while preserving the existing mobile single-column stack. |
| 37 | +- The layout CSS is needed because a standalone account `<aside>` with `tool-column` otherwise matches both generic `tool-column:first-of-type` and `tool-column:last-of-type` rules. |
| 38 | + |
| 39 | +## Impacted Lanes |
| 40 | + |
| 41 | +- Account/User Controls layout lane. |
| 42 | +- Theme V2 account-panel layout lane. |
| 43 | +- Targeted Playwright account navigation lane. |
| 44 | +- Workspace V2 validation lane. |
| 45 | + |
| 46 | +## Skipped Lanes |
| 47 | + |
| 48 | +- Full samples smoke: SKIP. This PR does not change samples, sample JSON contracts, game runtime behavior, or sample launch paths; the user explicitly requested not to run full samples smoke. |
| 49 | +- Engine lane: SKIP. No engine or runtime input behavior changed. |
| 50 | +- Runtime JavaScript V8 coverage: SKIP/N/A. No runtime JavaScript files changed in this PR. |
| 51 | + |
| 52 | +## Validation Performed |
| 53 | + |
| 54 | +- PASS - Branch check: `git branch --show-current` returned `main`. |
| 55 | +- PASS - Syntax check: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`. |
| 56 | +- PASS - Static patch check: `git diff --check -- assets/theme-v2/partials/account-side-nav.html assets/theme-v2/css/layout.css tests/playwright/tools/InputMappingV2Tool.spec.mjs`. |
| 57 | +- PASS - Targeted Playwright: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --grep "Account navigation"` passed 1 test. |
| 58 | +- PASS - Workspace V2 validation: `npm run test:workspace-v2` passed 5 tests. |
| 59 | + |
| 60 | +## Playwright Result |
| 61 | + |
| 62 | +- PASS - Account side accordion is present. |
| 63 | +- PASS - Account side accordion is positioned in the left column. |
| 64 | +- PASS - Account Pages appears above Account Guidance. |
| 65 | +- PASS - Accordion expand/collapse works. |
| 66 | +- PASS - Center column fills the remaining available width beside the left aside. |
| 67 | + |
| 68 | +## Coverage |
| 69 | + |
| 70 | +- PASS/N/A - No runtime JavaScript changed, so no changed-runtime-JS Playwright V8 coverage report was required. |
| 71 | + |
| 72 | +## Search Evidence |
| 73 | + |
| 74 | +- PASS - `rg -n "tool-column|tool-column-header|account-panel>|stacked|left-right|style=|<style|onclick=" assets/theme-v2/css/layout.css assets/theme-v2/partials/account-side-nav.html account/user-controls.html tests/playwright/tools/InputMappingV2Tool.spec.mjs` shows the shared Theme V2 column/accordion classes and no page-local style or inline handler additions. |
| 75 | +- PASS - `git diff -- assets/theme-v2/css/layout.css assets/theme-v2/partials/account-side-nav.html tests/playwright/tools/InputMappingV2Tool.spec.mjs` shows only account panel layout, account side-nav partial, and targeted Playwright coverage changes. |
| 76 | + |
| 77 | +## Manual Validation Steps |
| 78 | + |
| 79 | +1. Open `/account/user-controls.html`. |
| 80 | +2. Confirm the Account left aside appears to the left of the User Controls content. |
| 81 | +3. Confirm the left aside shows the Account header, Account Pages accordion, and Account Guidance accordion. |
| 82 | +4. Confirm Account Pages is stacked above Account Guidance. |
| 83 | +5. Collapse and reopen Account Pages. |
| 84 | +6. Open and close Account Guidance. |
| 85 | +7. Confirm the User Controls card fills the remaining width to the right of the aside. |
| 86 | + |
| 87 | +## Samples Validation Decision |
| 88 | + |
| 89 | +- SKIP - Full samples smoke was not run because this PR is scoped to account layout and account side-nav wiring only. |
| 90 | + |
| 91 | +## Completion |
| 92 | + |
| 93 | +- PASS - Every requested item was implemented, validated, and explicitly marked PASS or documented as N/A/skipped where applicable. |
0 commit comments