Complete dev-only admin notes cleanup and ownership boundary - PR_26158_041-admin-notes-cleanup

Author: ToolboxAid

admin/notes.html

@@ -79,7 +79,6 @@
         "admin-users": "admin/users.html",
         "admin-roles": "admin/roles.html",
         "admin-moderation": "admin/moderation.html",
-        "admin-notes": "admin/notes.html",
         "admin-analytics": "admin/analytics.html",
         "admin-tools-progress": "admin/tools-progress.html",
         "cookie-policy": "legal/cookie-policy.html",

admin/notes/index.txt

@@ -119,7 +119,6 @@
           <a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
           <a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
           <a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
-          <a data-nav-link data-route="admin-notes" href="admin/notes.html">Notes</a>
           <a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
           <a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
           <a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>

admin/notes/other/index.txt

@@ -0,0 +1,15 @@
+# Admin Notes Ownership
+
+Admin Notes are dev-only documentation artifacts.
+
+Owned paths:
+- `docs_build/dev/admin-notes/index.txt` is the root admin note.
+- `docs_build/dev/admin-notes/other/index.txt` is the simple subnote fixture.
+- `docs_build/dev/admin-notes/quick-reference.txt` is a linked text-note fixture.
+- `docs_build/dev/admin-notes/sample.txt` is a root-relative link example note.
+- `docs_build/dev/admin-notes/notes/index.txt` is retained historical admin-note content.
+
+Runtime boundary:
+- Admin Notes viewer implementation, when needed for local/dev inspection, belongs under `src/dev-runtime/admin/`.
+- Production-facing paths must not link to or fetch `docs_build/dev/admin-notes/`.
+- UAT/PROD bundles must not import `src/dev-runtime/admin/`.

assets/theme-v2/js/gamefoundry-partials.js

@@ -0,0 +1,64 @@
+# PR_26158_041 Admin Notes Cleanup Report
+
+## Summary
+
+Admin Notes are now dev-owned files under `docs_build/dev/admin-notes/`, with the previous production-facing route, nav link, duplicate production note files, and active Playwright route coverage removed.
+
+The prior viewer implementation was moved from `admin/notes.js` to `src/dev-runtime/admin/admin-notes-viewer.js` so any future local/dev admin-only viewer work starts from the dev-runtime boundary instead of a production path.
+
+## Final Admin Notes Ownership
+
+| Path | Ownership | Status |
+| --- | --- | --- |
+| `docs_build/dev/admin-notes/README.md` | Dev-only ownership note and boundary reminder. | ADDED |
+| `docs_build/dev/admin-notes/index.txt` | Root Admin Notes text. | KEPT |
+| `docs_build/dev/admin-notes/other/index.txt` | Simple subnote fixture/content. | KEPT |
+| `docs_build/dev/admin-notes/quick-reference.txt` | Linked text-note fixture. | KEPT |
+| `docs_build/dev/admin-notes/sample.txt` | Root-relative link example note. | KEPT |
+| `docs_build/dev/admin-notes/notes/index.txt` | Historical admin-note content retained under dev docs. | KEPT |
+| `src/dev-runtime/admin/admin-notes-viewer.js` | Local/dev-only viewer implementation, not linked from production routes. | MOVED |
+
+## Removed Or Moved Files
+
+| Previous Path | Action | Reason |
+| --- | --- | --- |
+| `admin/notes.js` | Moved to `src/dev-runtime/admin/admin-notes-viewer.js`. | Admin Notes implementation does not belong in a production-facing admin path. |
+| `admin/notes.html` | Removed. | Production-facing Admin Notes route exposed dev docs. |
+| `admin/notes/index.txt` | Removed. | Duplicate production-path note content. Dev-owned copy remains under `docs_build/dev/admin-notes/notes/index.txt`. |
+| `admin/notes/other/index.txt` | Removed. | Duplicate production-path subnote content. Dev-owned copy remains under `docs_build/dev/admin-notes/other/index.txt`. |
+| `docs_build/dev/admin-notes/notes/Other/index.txt` | Removed. | Empty orphaned subnote scaffold. |
+| `assets/theme-v2/partials/header-nav.html` Admin Notes nav item | Removed. | Production navigation must not expose dev-only Admin Notes. |
+| `assets/theme-v2/js/gamefoundry-partials.js` `admin-notes` route mapping | Removed. | Production route registry must not expose dev-only Admin Notes. |
+| `tests/playwright/tools/AdminNotesViewer.spec.mjs` | Removed. | Active Playwright route coverage targeted the retired production `admin/notes.html` page. |
+| `tests/helpers/playwrightRepoServer.mjs` Admin Notes directory endpoint | Removed. | Test helper no longer serves Admin Notes filesystem listings for a retired production route. |
+
+## Requirement Checklist
+
+| Requirement | Evidence | Result |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first. | Read before edits. | PASS |
+| Complete Admin Notes under `docs_build/dev/admin-notes/`. | Added `README.md`; retained meaningful note files under dev docs. | PASS |
+| Move or remove files that do not belong in `docs_build/dev/admin-notes/`. | Removed duplicate `admin/notes/*`; removed empty dev scaffold. | PASS |
+| Keep admin notes documentation/dev artifacts out of production-facing paths. | Removed `admin/notes.html`, header link, route mapping, and test-server directory endpoint. | PASS |
+| Keep runtime/admin-only implementation under `src/dev-runtime/admin/` if needed. | Moved viewer implementation to `src/dev-runtime/admin/admin-notes-viewer.js`. | PASS |
+| Do not place Admin Notes implementation in public assets, toolbox pages, root pages, or production bundles. | Production-facing string audit returned no matches. | PASS |
+| Document final file ownership and removed/moved files. | This report plus `docs_build/dev/admin-notes/README.md`. | PASS |
+| Do not modify `start_of_day` folders. | `git diff --name-only | rg "start_of_day"` returned no matches. | PASS |
+
+## Validation
+
+| Lane | Command | Result |
+| --- | --- | --- |
+| Changed-file syntax checks | `node --check assets/theme-v2/js/gamefoundry-partials.js`; `node --check src/dev-runtime/admin/admin-notes-viewer.js`; `node --check tests/helpers/playwrightRepoServer.mjs`; `node --check tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS |
+| Docs/static boundary validation | `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 3/3 |
+| Production path Admin Notes link/import audit | `rg -n "docs_build/dev/admin-notes\|docs_build\\dev\\admin-notes\|admin-notes\|Admin Notes\|data-admin-notes" account admin assets toolbox src --glob '!src/dev-runtime/**' --glob '!archive/v1-v2/**' --glob '!tmp/**'` | PASS, no matches |
+| UAT/PROD dev-runtime admin import audit | `rg -n "src/dev-runtime/admin\|src\\dev-runtime\\admin" account admin assets toolbox src --glob '!src/dev-runtime/**' --glob '!archive/v1-v2/**' --glob '!tmp/**'` | PASS, no matches |
+| Changed-file whitespace/static validation | `git diff --check` | PASS, Git line-ending warnings only |
+
+## Playwright Decision
+
+Playwright was not run. The production Admin Notes UI route was intentionally retired instead of changed in place, and the old Playwright lane targeted that retired route. Static ownership validation now covers the requested cleanup boundary.
+
+## Remaining Violations
+
+None found in active production-facing paths.

assets/theme-v2/partials/header-nav.html

@@ -1,34 +1,36 @@
-# PR_26158_040 Testing Lane Execution Report
+# PR_26158_041 Testing Lane Execution Report
 
 ## Lanes Run
 
 | Lane | Command | Result |
 | --- | --- | --- |
-| Docs/static content validation | PowerShell content check for required sections in `docs_build/dev/reports/game-deploy-path-plan-report.md` | PASS |
-| Changed-file whitespace/static validation | `git diff --check` | PASS |
+| Changed-file syntax checks | `node --check assets/theme-v2/js/gamefoundry-partials.js`; `node --check src/dev-runtime/admin/admin-notes-viewer.js`; `node --check tests/helpers/playwrightRepoServer.mjs`; `node --check tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS |
+| Docs/static Admin Notes boundary validation | `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 3/3 |
+| Production path Admin Notes exposure audit | `rg -n "docs_build/dev/admin-notes\|docs_build\\dev\\admin-notes\|admin-notes\|Admin Notes\|data-admin-notes" account admin assets toolbox src --glob '!src/dev-runtime/**' --glob '!archive/v1-v2/**' --glob '!tmp/**'` | PASS, no matches |
+| UAT/PROD dev-runtime admin import audit | `rg -n "src/dev-runtime/admin\|src\\dev-runtime\\admin" account admin assets toolbox src --glob '!src/dev-runtime/**' --glob '!archive/v1-v2/**' --glob '!tmp/**'` | PASS, no matches |
+| Changed-file whitespace/static validation | `git diff --check` | PASS, Git line-ending warnings only |
 | start_of_day protection check | `git diff --name-only \| rg "start_of_day"` | PASS, no matches |
 
 ## Validation Notes
 
 | Check | Evidence | Result |
 | --- | --- | --- |
-| MVP end-to-end path is defined. | `game-deploy-path-plan-report.md` includes `Minimum End-To-End Path` and `MVP Flow`. | PASS |
-| Current implemented pieces are identified. | Report includes `Current Implemented Pieces` with evidence file paths. | PASS |
-| Missing pieces and blockers are identified. | Report includes `Missing Pieces` and `Blockers`. | PASS |
-| DB-owned data is separated from generated deploy artifacts. | Report includes `DB Versus Generated Deploy Artifacts`. | PASS |
-| UAT deployment path for one playable game is defined. | Report includes `Required UAT Deployment Path For One Playable Game`. | PASS |
-| Manifest, asset, debug, publish-state, and public-play gates are defined. | Report includes `Validation Gates`. | PASS |
-| Runtime publish behavior was not implemented. | Only docs/reports changed. | PASS |
+| Admin Notes docs live under `docs_build/dev/admin-notes/`. | `tests/dev-runtime/AdminNotesBoundary.test.mjs`; `docs_build/dev/admin-notes/README.md`. | PASS |
+| Production-facing Admin Notes route was removed. | `admin/notes.html` deleted; header nav and partial route map removed. | PASS |
+| Duplicate production-path note files were removed. | `admin/notes/index.txt` and `admin/notes/other/index.txt` deleted. | PASS |
+| Runtime implementation moved under dev-runtime admin. | `src/dev-runtime/admin/admin-notes-viewer.js`. | PASS |
+| Production paths do not link/import dev Admin Notes content. | Static `rg` audit returned no matches. | PASS |
+| UAT/PROD candidate paths do not import `src/dev-runtime/admin/`. | Static `rg` audit returned no matches. | PASS |
 
 ## Skipped Lanes
 
 | Lane | Decision | Reason |
 | --- | --- | --- |
-| Playwright | SKIP | PR is docs/planning only; no runtime, page, API, or UI behavior changed. |
-| Full samples smoke | SKIP | No sample loader/framework, runtime, manifest fixture, or sample artifact changed. |
-| Node test suite | SKIP | No executable source or test logic changed. |
+| Playwright | SKIP | The production Admin Notes route was retired; the old Playwright lane targeted the removed route. Static boundary validation is the requested lane for this cleanup. |
+| Full samples smoke | SKIP | No sample loader/framework, sample fixture, or game runtime path changed. |
+| Full Node suite | SKIP | Targeted Node syntax and Admin Notes boundary test covered the changed files and requested static ownership validation. |
 
 ## Notes
 
-- No V8 coverage was generated for this PR because Playwright was intentionally skipped by request.
-- No `start_of_day` folders were modified.
+- `git diff --check` emitted line-ending warnings only.
+- No `start_of_day` files were modified.

docs_build/dev/admin-notes/README.md

@@ -1,3 +1,4 @@
+// Dev-runtime only: do not import this viewer from production-facing pages or bundles.
 const NOTES_DIRECTORY = "docs_build/dev/admin-notes";
 const DEFAULT_NOTE = "index";
 const LINK_CLASS = "btn btn--compact primary";