Finalize legacy theme teardown, clean stale asset references, and inventory root structure - PR_26154_011-013-root-cleanup-stack

ToolboxAid · ToolboxAid · commit 4c487132cd3f · 2026-06-03T15:43:41.000-04:00
diff --git a/docs_build/dev/codex_commands.md b/docs_build/dev/codex_commands.md
@@ -1,51 +1,59 @@
 # Codex Commands
 
-Task: `PR_26154_010-svg-favicon-normalization`
+Tasks:
+
+- `PR_26154_011-theme-v1-final-teardown`
+- `PR_26154_012-root-asset-reference-cleanup`
+- `PR_26154_013-root-structure-inventory-closeout`
 
 Commands run:
 
 - `Get-Content .codex/skills/repo-build/SKILL.md`
 - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
 - `git status --short --untracked-files=all`
-- Targeted `rg`, `Get-ChildItem`, and `Get-Content` inventory for:
-  - `favicon.svg`
-  - `favicon.ico`
-  - active HTML favicon links
-  - manifest files
-  - Theme V2 favicon references
-  - root-level branding asset candidates
-- Node move/rewrite script for:
-  - `assets/theme/v2/images/favicon.svg` -> `favicon.svg`
-  - removing `favicon.ico`
-  - active HTML favicon links -> `/favicon.svg`
-- Targeted patch for:
-  - `scripts/PS/deploy/WebsiteRepoDeploymentCommon.ps1`
-    - `favicon.ico` -> `favicon.svg`
-- Targeted reference checks for:
-  - `favicon.svg`
+- Targeted `Get-ChildItem`, `Get-Content`, and `rg` inventory for:
+  - `src/engine/theme/`
+  - `assets/theme/v1/`
+  - active public/root pages
+  - active tool surfaces under `tools/`
+  - `games/`
+  - `docs/`
+  - stale path strings
+  - current root ownership folders
+- Updated `src/engine/theme/README.md` to document runtime ownership and the current direct helper import path.
+- Targeted stale-reference checks for:
+  - `GameFoundryStudio/`
+  - `src/engine/theme/index.js`
+  - `assets/theme/v2/assets/`
+  - `assets/theme/v2/images/games/`
   - `favicon.ico`
-  - `assets/theme/v2/images/favicon.svg`
-  - active HTML icon links
-  - manifest references
-- Node static/path validation for changed HTML, JS, JSON, and Markdown paths.
-- PowerShell parser validation for the changed deployment helper.
-- Node HTTP validation for `/favicon.svg`.
+- Root structure inventory counts for:
+  - `assets/`
+  - `tools/`
+  - `old-tools/`
+  - `games/`
+  - `old_games/`
+  - `old_samples/`
+  - `docs/`
+  - `docs_build/`
+  - `schemas/`
+  - `src/`
+- Node targeted static validation for changed HTML, JS, CSS, JSON, and Markdown paths.
 - `git status --short -- start_of_day old_games old_samples`
 - `git diff --check`
 - `npm run codex:review-artifacts`
-- Python ZIP packaging for `tmp/PR_26154_010-svg-favicon-normalization_delta.zip`
+- Python ZIP packaging for `tmp/PR_26154_011-013-root-structure-closeout_delta.zip`
 
 Validation summary:
 
-- PASS root `/favicon.svg` exists and resolves.
-- PASS root `/favicon.ico` no longer exists.
-- PASS old Theme V2 favicon source path removed.
-- PASS active HTML favicon references use `/favicon.svg`.
-- PASS no active references remain to `favicon.ico`.
-- PASS no active references remain to `assets/theme/v2/images/favicon.svg`.
-- PASS no active manifest icon references were found.
-- PASS changed PowerShell deployment helper parses successfully.
-- PASS `old_games/`, `old_samples/`, and `start_of_day/` unchanged.
+- PASS no confirmed V1 legacy/static assets remain under `src/engine/theme/`.
+- PASS remaining `src/engine/theme/` files are runtime-owned or runtime documentation.
+- PASS `src/engine/theme/README.md` no longer references the removed `index.js` barrel.
+- PASS no active public/root page, active tool page, game page, public doc, asset, script, or source helper references remain to stale public asset paths.
+- PASS remaining `src/engine/theme/` references are intentional runtime/guard/test references or historical/generated records.
+- PASS root structure ownership inventory completed.
+- PASS `schemas/` absence confirmed; active schemas are under `tools/schemas/`.
+- PASS `start_of_day/`, `old_games/`, and `old_samples/` unchanged.
 - PASS `git diff --check`.
 - PASS `npm run codex:review-artifacts`.
 - SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
diff --git a/docs_build/dev/commit_comment.txt b/docs_build/dev/commit_comment.txt
@@ -1,7 +1,12 @@
-SVG favicon normalization - PR_26154_010-svg-favicon-normalization
+Theme V1 final teardown, root asset reference cleanup, and structure inventory closeout
 
-- Move the canonical site icon from `assets/theme/v2/images/favicon.svg` to root `/favicon.svg`.
-- Remove obsolete root `/favicon.ico`.
-- Update active HTML favicon links and the website deployment include list to use `/favicon.svg`.
-- Report historical favicon references and additional root-level branding candidates without moving unrelated assets.
-- Validate targeted references, root HTTP loading, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
+Stack:
+- PR_26154_011-theme-v1-final-teardown
+- PR_26154_012-root-asset-reference-cleanup
+- PR_26154_013-root-structure-inventory-closeout
+
+- Confirm no further V1 static/theme assets can safely move from `src/engine/theme/` because the remaining files are runtime-owned.
+- Update `src/engine/theme/README.md` to remove a stale removed-barrel import and document current runtime ownership.
+- Audit active root/page/tool/game/doc references for stale path strings and report remaining intentional runtime, generated, or historical references.
+- Create root structure ownership inventory and cleanup candidate report without moving unrelated files.
+- Validate targeted references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
diff --git a/docs_build/dev/reports/root_asset_reference_cleanup_report.md b/docs_build/dev/reports/root_asset_reference_cleanup_report.md
@@ -0,0 +1,103 @@
+# Root Asset Reference Cleanup
+
+Task: `PR_26154_012-root-asset-reference-cleanup`
+
+## Summary
+
+- Audited active public/root pages, active tools, games, public docs, assets, scripts, and source helpers for stale asset/root paths.
+- Fixed one stale runtime-theme documentation reference in `src/engine/theme/README.md`.
+- Did not modify `old_games/` or `old_samples/`.
+- Did not rewrite historical `docs_build/dev/reports/**` content.
+
+## Fixed References
+
+Updated:
+
+- `src/engine/theme/README.md`
+
+Change:
+
+- Removed the stale `/src/engine/theme/index.js` import example.
+- Replaced it with `/src/engine/theme/toolboxaid-header.js`, which exists and exports the documented runtime helper.
+
+## Active Surface Audit
+
+Scanned active surfaces for:
+
+- `GameFoundryStudio/`
+- `src/engine/theme/`
+- `assets/theme/v2/assets/`
+- `assets/theme/v2/images/games/`
+- `favicon.ico`
+
+Included active roots:
+
+- `index.html`
+- `_page_template_v2.html`
+- `account/`
+- `admin/`
+- `community/`
+- `company/`
+- `docs/`
+- `games/`
+- `learn/`
+- `legal/`
+- `marketplace/`
+- `tools/`
+- `assets/`
+- `scripts/`
+- `src/`
+- selected active tests/guards for reference classification
+
+Excluded:
+
+- `start_of_day/`
+- `old_games/`
+- `old_samples/`
+- `old-tools/`
+- `node_modules/`
+- `tmp/`
+- `tests/results/`
+
+## Results
+
+No active public/root page, active tool page, game page, or public doc references remain to:
+
+- `GameFoundryStudio/`
+- `assets/theme/v2/assets/`
+- `assets/theme/v2/images/games/`
+- `favicon.ico`
+
+Remaining `src/engine/theme/` references are intentional runtime/guard/test references, not stale public asset references:
+
+- `tools/shared/tooling/CapturePreviewRuntime.js` imports runtime theme helpers.
+- `tools/dev/checkStyleSystemGuard.mjs` references runtime theme CSS as its guard baseline.
+- `tools/dev/checkSharedExtractionGuard.baseline.json` records a runtime helper baseline.
+- `tests/theme.test.js` imports runtime theme helpers.
+- Workspace/tool smoke tests assert legacy/runtime shell references where those fixtures are still expected.
+- `assets/theme/v1/README.md` documents that Theme V1 Font Awesome is consumed by `src/engine/theme/main.css`.
+- `src/engine/theme/README.md` documents runtime ownership.
+
+Remaining generated or historical references not fixed:
+
+- `tests/validation/samples.shared.boundaries.report.json` still contains `/src/engine/theme/index.js`.
+
+Reason:
+
+- It is a generated validation report artifact, not an active public/root page, active tool, game, or public doc reference.
+- Updating generated evidence by hand would be outside this cleanup PR.
+
+Historical docs under `docs_build/**` still contain older `GameFoundryStudio/`, favicon, and Theme V2 migration references.
+
+Reason:
+
+- They are historical PR/audit records.
+- The active runtime/page/tool/doc surfaces no longer depend on those paths.
+
+## Validation Notes
+
+- PASS: zero active references to `GameFoundryStudio/` in public/root pages, active tool pages, game pages, public docs, assets, scripts, and source helpers.
+- PASS: zero active references to `assets/theme/v2/assets/`.
+- PASS: zero active references to `assets/theme/v2/images/games/`.
+- PASS: zero active references to `favicon.ico`.
+- PASS: the only fixed stale `src/engine/theme/index.js` source-doc reference now points to the existing runtime helper.
diff --git a/docs_build/dev/reports/root_structure_inventory_closeout_report.md b/docs_build/dev/reports/root_structure_inventory_closeout_report.md
@@ -0,0 +1,66 @@
+# Root Structure Inventory Closeout
+
+Task: `PR_26154_013-root-structure-inventory-closeout`
+
+## Summary
+
+Created a current root ownership inventory without moving files.
+
+No `start_of_day/` folders were modified.
+
+## Current Ownership
+
+| Path | Status | Current Ownership |
+| --- | --- | --- |
+| `assets/` | active | Public/root static asset ownership. Contains `assets/theme/v1/` legacy static assets and `assets/theme/v2/` public Theme V2 CSS, JS, partials, and imagery. |
+| `tools/` | active | Active public tool pages plus active tool support surfaces, including `tools/shared/`, `tools/dev/`, and `tools/schemas/`. |
+| `old-tools/` | deprecated | Deprecated legacy tool references. Kept for reference/playable legacy behavior where applicable; not an active future-state tool surface. |
+| `games/` | active | Current public games surface, game-type pages, arcade entry, and `games/assets/images/`. |
+| `old_games/` | deprecated | Deprecated playable reference games. Kept playable, but excluded from active validation. |
+| `old_samples/` | deprecated | Deprecated reference samples. Excluded from active validation. |
+| `docs/` | active public docs | User-facing documentation only: `index.html`, `faq.html`, `reference.html`, `support.html`, and `README.md`. |
+| `docs_build/` | development docs | Development, build, PR, governance, workflow, audit, report, release, security, and archived documentation. |
+| `schemas/` | absent | No root `schemas/` folder currently exists. Active schema ownership is under `tools/schemas/`; historical schema docs live under `docs_build/schemas/`. |
+| `src/` | active source | Engine, shared, advanced, assets, and tool source/runtime code. `src/engine/theme/` remains runtime-owned per project instructions. |
+
+## Root Folder Counts
+
+| Path | Files | Directories |
+| --- | ---: | ---: |
+| `assets/` | 150 | 19 |
+| `tools/` | 201 | 48 |
+| `old-tools/` | 356 | 123 |
+| `games/` | 12 | 9 |
+| `old_games/` | 311 | 132 |
+| `old_samples/` | 1580 | 858 |
+| `docs/` | 5 | 0 |
+| `docs_build/` | 4478 | 316 |
+| `schemas/` | missing | missing |
+| `src/` | 464 | 103 |
+
+## Observations
+
+- Root `favicon.svg` is the canonical browser favicon.
+- Public Theme V2 assets are under `assets/theme/v2/`.
+- Legacy static Theme V1 assets are under `assets/theme/v1/`.
+- Runtime engine shell styling remains under `src/engine/theme/`.
+- Current games imagery lives under `games/assets/images/`.
+- Active schema files live under `tools/schemas/`, not root `schemas/`.
+
+## Remaining Cleanup Candidates
+
+No files were moved for these candidates in this PR.
+
+- Review whether `tools/_templates-v2/` is still an active template surface or should be deprecated after a future template replacement.
+- Review whether `old-tools/codex/` and `old-tools/common/` are still needed as deprecated references.
+- Regenerate or retire stale generated validation artifacts that reference removed paths, such as `tests/validation/samples.shared.boundaries.report.json`.
+- Decide whether root-level branding assets should move out of `assets/theme/v2/images/` in a future root-branding PR.
+- Decide whether root `schemas/` should remain absent permanently or receive an explicit redirect/documentation marker pointing to `tools/schemas/`.
+- Continue reducing historical path noise in `docs_build/` only if a future archival cleanup PR explicitly targets historical docs.
+
+## Validation Notes
+
+- PASS: required ownership paths were inventoried.
+- PASS: `schemas/` absence was confirmed.
+- PASS: no root structure moves were performed in this closeout PR.
+- PASS: `start_of_day/`, `old_games/`, and `old_samples/` were not modified.
diff --git a/docs_build/dev/reports/theme_v1_final_teardown_report.md b/docs_build/dev/reports/theme_v1_final_teardown_report.md
@@ -0,0 +1,78 @@
+# Theme V1 Final Teardown
+
+Task: `PR_26154_011-theme-v1-final-teardown`
+
+## Summary
+
+- Audited `src/engine/theme/` after the earlier Theme V1 static asset move.
+- Moved no additional files.
+- Confirmed the remaining files are active engine/runtime shell styling, runtime helpers, or runtime header markup.
+- Updated `src/engine/theme/README.md` to remove a stale `index.js` import example and document current runtime ownership.
+
+## Assets Already Under Theme V1
+
+The confirmed static legacy assets are already under `assets/theme/v1/`:
+
+- `assets/theme/v1/fontawesome/css/font-awesome.min.css`
+- `assets/theme/v1/fontawesome/fonts/fontawesome-webfont.ttf`
+- `assets/theme/v1/fontawesome/fonts/fontawesome-webfont.woff`
+- `assets/theme/v1/fontawesome/fonts/fontawesome-webfont.woff2`
+- `assets/theme/v1/images/toolboxaid-header.png`
+
+## Remaining `src/engine/theme/` Inventory
+
+Runtime CSS ownership:
+
+- `src/engine/theme/accordion.css`
+- `src/engine/theme/games.css`
+- `src/engine/theme/header.css`
+- `src/engine/theme/layout.css`
+- `src/engine/theme/main.css`
+- `src/engine/theme/nav.css`
+- `src/engine/theme/pages.css`
+- `src/engine/theme/samples.css`
+- `src/engine/theme/tokens.css`
+- `src/engine/theme/tool-shell.css`
+- `src/engine/theme/toolboxaid-header.css`
+- `src/engine/theme/tools.css`
+- `src/engine/theme/accordionV2/accordionV2.css`
+
+Runtime JS ownership:
+
+- `src/engine/theme/Theme.js`
+- `src/engine/theme/ThemeTokens.js`
+- `src/engine/theme/mount-shared-header.js`
+- `src/engine/theme/toolboxaid-header.js`
+- `src/engine/theme/accordionV2/accordionV2.js`
+
+Runtime markup/documentation:
+
+- `src/engine/theme/toolboxaid-header.html`
+- `src/engine/theme/README.md`
+
+## Why These Files Remain
+
+`docs_build/dev/PROJECT_INSTRUCTIONS.md` defines `src/engine/theme` as the engine/runtime first-class tool shell styling surface.
+
+The remaining files are not confirmed public/static Theme V1 assets. They are runtime shell modules, runtime helper modules, or runtime-owned header assets. Moving them in this PR would cross the requested boundary:
+
+- Do not move active engine runtime code.
+- Do not deprecate `src/engine/theme` at this time.
+- Do not expand into unrelated theme cleanup.
+
+## Reference Notes
+
+Expected active/runtime references remain:
+
+- `tools/shared/tooling/CapturePreviewRuntime.js` imports `Theme.js` and `ThemeTokens.js`.
+- `tools/dev/checkStyleSystemGuard.mjs` references runtime CSS files as its guard baseline.
+- runtime/test files still reference `src/engine/theme` as an engine/runtime shell surface.
+
+No additional `src/engine/theme` files were deleted because the folder is not empty and remains runtime-owned.
+
+## Validation Notes
+
+- PASS: no `src/engine/theme/fontawesome` folder remains.
+- PASS: no `src/engine/theme/toolboxaid-header.png` file remains.
+- PASS: static legacy Theme V1 assets resolve under `assets/theme/v1/`.
+- PASS: `src/engine/theme/README.md` now references the existing `toolboxaid-header.js` helper instead of the removed `index.js` barrel.
diff --git a/src/engine/theme/README.md b/src/engine/theme/README.md
@@ -1,16 +1,23 @@
-# Shared Toolbox Aid Header
+# Engine Runtime Theme
 
-This folder now contains the raw shared header source plus the importable module.
+`src/engine/theme/` owns engine/runtime first-class tool shell styling and shared runtime header helpers.
 
 ## Files
-- `toolboxaid-header.html` → raw shared header markup
-- `toolboxaid-header.css` → shared styling
-- `toolboxaid-header.js` → importable module that exports the HTML and mount helpers
-- `index.js` → re-export entry
+
+- `main.css` imports the runtime theme CSS modules.
+- `toolboxaid-header.html` contains the raw shared runtime header markup.
+- `toolboxaid-header.css` imports runtime header/nav styling.
+- `toolboxaid-header.js` exports the runtime header HTML and mount helpers.
+- `mount-shared-header.js` mounts the runtime header and related runtime page enhancements.
+- `Theme.js` and `ThemeTokens.js` provide runtime theme helpers used by tooling.
+- `accordionV2/` contains the runtime accordion component CSS and JS.
+
+Static legacy assets consumed by this runtime surface now live under `assets/theme/v1/`.
 
 ## Import
+
 ```js
-import { mountToolboxAidHeader } from '/src/engine/theme/index.js';
+import { mountToolboxAidHeader } from '/src/engine/theme/toolboxaid-header.js';
 
 window.addEventListener('DOMContentLoaded', () => {
   mountToolboxAidHeader(document.body);
