Select newly added Palette swatches and show tooltip source - PR_26156_180-palette-added-selection-and-tooltip-source

Author: ToolboxAid

docs_build/dev/reports/palette-added-selection-and-tooltip-source-report.md

@@ -0,0 +1,49 @@
+# PR_26156_180 Palette Added Selection And Tooltip Source Report
+
+## Result
+PASS
+
+## Summary
+- Newly added Palette Colors now become selected immediately for user-defined adds, source pin/add, Source Pin All, harmony pin/add, and harmony Add All.
+- Multi-add operations select the last newly added swatch while duplicate-only runs keep the prior selection unchanged.
+- Swatch browser tooltips now use browser `title` text in the order Name, Hex, Source, Tags.
+- Empty user-tag sets omit the Tags line instead of showing `Tags: None`.
+- Active source labels now resolve to `custom` for user-defined swatches, the source palette label for copied source colors, and the harmony scheme label for generated harmony colors.
+
+## Behavior Details
+- `replaceSwatches` accepts an explicit selected symbol so add/update callers can persist the intended selected swatch after table writes.
+- Source Pin All tracks the last successfully added swatch symbol and uses it as the selected item.
+- Harmony swatches persist their scheme source, such as `complementary` or `triadic`, so active Palette Colors can display the scheme label as Source.
+- Harmony rendered swatches suppress generated/source metadata tags in the tooltip; user palette colors still show only user-entered tags.
+
+## Validation
+- `node --check toolbox/colors/colors.js`
+  - PASS
+- `node --check toolbox/colors/palette-workspace-repository.js`
+  - PASS
+- `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS
+- `rg -n "DEFAULT_SOURCE_PALETTES|style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
+  - PASS, 3 tests
+- `npm run test:playwright:static`
+  - PASS
+- `git diff --check -- toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS with Git LF-to-CRLF warning for the touched Playwright spec
+
+## Verification Coverage
+- Newly added swatches become selected immediately.
+- Source Palette Browser direct pin/add selects the added swatch.
+- Pin All selects the last newly added swatch and duplicate-only Pin All keeps selection unchanged.
+- Harmony pin/add selects the added harmony swatch.
+- Harmony Add All selects the last newly added swatch and duplicate-only Add All keeps selection unchanged.
+- User Defined Swatch add selects the newly added custom swatch.
+- Tooltip text includes Source before Tags.
+- Color Harmony Source uses the scheme name.
+- User Defined Source displays as `custom`.
+- Tags line is omitted when the active user palette color has no user tags.
+
+## Skipped
+- Full samples smoke was not run, per BUILD instruction.
+- Broad tool/runtime lanes were skipped because this PR changes only Palette Tool behavior and the targeted Palette Tool spec covers the affected runtime/UI paths.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,25 +12,27 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(85%) Toolbox Index - exercised 5 runtime JS files
+(87%) Toolbox Index - exercised 5 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1218/1218; executed functions 116/134
+(89%) toolbox/colors/palette-workspace-repository.js - executed lines 1244/1244; executed functions 125/140
+(96%) toolbox/colors/colors.js - executed lines 794/794; executed functions 78/81
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
-(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1218/1218; executed functions 116/134
-(95%) toolbox/colors/colors.js - executed lines 793/793; executed functions 77/81
+(89%) toolbox/colors/palette-workspace-repository.js - executed lines 1244/1244; executed functions 125/140
+(96%) toolbox/colors/colors.js - executed lines 794/794; executed functions 78/81
 (100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(87%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
+(89%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
+(96%) toolbox/colors/colors.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,4 +1,4 @@
-# PR_26156_179 Testing Lane Execution Report
+# PR_26156_180 Testing Lane Execution Report
 
 ## Result
 PASS
@@ -10,41 +10,44 @@ PASS
   - PASS
 - `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
   - PASS
-- `rg "style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+- `rg -n "DEFAULT_SOURCE_PALETTES|style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
   - PASS, no matches
 - `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
   - PASS, 3 tests
 - `npm run test:playwright:static`
   - PASS
-- `git diff --check`
-  - PASS
+- `git diff --check -- toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS with Git LF-to-CRLF warning for the touched Playwright spec
 
 ## Required Lanes
-- Targeted Palette Tool harmony runtime lane: PASS.
+- Targeted Palette Tool runtime/UI lane: PASS.
 - Changed-file/static validation: PASS.
 
 ## Playwright Coverage
-- Adding complementary harmony colors creates unique generated names: PASS.
-- Generated complementary suggestions that start as `Complementary 1` save as `Complementary 1` and `Complementary 2`: PASS.
-- Add All adds all non-duplicate generated harmony colors: PASS.
-- Repeated Add All skips existing harmony hex values without duplicates: PASS.
-- Duplicate-name validation still blocks true user-entered duplicate names: PASS.
-- Auto-generated harmony duplicate names are incremented instead of surfacing duplicate-name validation: PASS.
+- Source Palette Browser direct pin/add selects the newly added active swatch: PASS.
+- Source Pin All selects the last newly added swatch: PASS.
+- Duplicate-only Source Pin All keeps the existing selected swatch: PASS.
+- User Defined Swatch add selects the newly added custom swatch: PASS.
+- Harmony pin/add selects the newly added harmony swatch: PASS.
+- Harmony Add All selects the last newly added harmony swatch: PASS.
+- Duplicate-only Harmony Add All keeps the current selected swatch: PASS.
+- Browser tooltip order is Name, Hex, Source, Tags: PASS.
+- Empty active user-tag sets omit the Tags line: PASS.
 
 ## Impacted Lane
-- Palette Tool harmony runtime lane.
+- Palette Tool runtime/UI lane.
 - Changed-file/static validation lane.
 
 ## Skipped Lanes
 - Full samples smoke was skipped by BUILD instruction.
-- Shared Tool Center fullscreen UI lane was skipped because PR179 does not modify shared Tool Center or Theme V2 behavior.
-- Broader tool lanes were skipped because changes are confined to Palette harmony repository behavior and targeted Palette spec assertions.
+- Shared Tool Center fullscreen UI lane was skipped because PR180 does not modify shared Tool Center or Theme V2 behavior.
+- Broader tool lanes were skipped because changes are confined to Palette Tool repository/UI behavior and targeted Palette spec assertions.
 
 ## Not Run
 - Full samples smoke was not run, per BUILD instruction.
 
 ## Notes
-- Static validation generated companion reports during the run; non-required generated companion report updates were reverted so the PR remains scoped to the requested report artifacts.
+- Static validation generated companion reports during the run; non-required generated companion report updates were restored to their prior contents so the PR remains scoped to the requested report artifacts.
 
 ## Coverage Artifact
 - Final V8 coverage artifact: `docs_build/dev/reports/playwright_v8_coverage_report.txt`.