Finish engine input ownership for Input Mapping V2 - PR_26140_117-finish-engine-input-ownership-for-input-mapping-v2

Author: ToolboxAid

docs/dev/reports/engine_input_ownership_for_input_mapping_v2_report.md

@@ -0,0 +1,70 @@
+# Engine Input Ownership For Input Mapping V2 Report
+
+PR: `PR_26140_117-finish-engine-input-ownership-for-input-mapping-v2`
+
+## Summary
+- Added engine-owned `InputCaptureSession` state for active capture sessions, combo-visible capture state, keyboard release, double-click, drag, live drag, and visual capture transitions.
+- Added engine-owned `InputCaptureService` descriptor capture helpers for keyboard, mouse, wheel, pointer drag, and pointer drag snapshots.
+- Added engine-owned `GamepadInputClassifier` support for gamepad button, trigger, stick, DPad, hold, release, and active gamepad binding classification.
+- Moved reusable input-device/gesture compatibility into `src/engine/input/InputCapabilityDescriptors.js`.
+- Updated Input Mapping V2 to consume the engine input session, capture service, compatibility helper, and gamepad classifier while keeping tool code focused on UI rendering, selected action/tile state, toolState import/export/copy, and layout.
+- Preserved filtered JSON export behavior that excludes actions with empty `inputs`, preserved `Action Mapping(s)` naming, and did not touch sample JSON.
+
+## Files Changed
+- `src/engine/input/GamepadInputClassifier.js`
+- `src/engine/input/InputCaptureService.js`
+- `src/engine/input/InputCaptureSession.js`
+- `src/engine/input/InputCapabilityDescriptors.js`
+- `src/engine/input/PointerDragState.js`
+- `tools/input-mapping-v2/js/ToolStarterApp.js`
+- `tools/input-mapping-v2/js/services/EngineInputSourceService.js`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `docs/dev/commit_comment.txt`
+- `docs/dev/codex_commands.md`
+- `docs/dev/reports/engine_input_ownership_for_input_mapping_v2_report.md`
+
+## Validation
+- PASS: `node --check src/engine/input/InputCaptureSession.js`
+- PASS: `node --check src/engine/input/InputCaptureService.js`
+- PASS: `node --check src/engine/input/GamepadInputClassifier.js`
+- PASS: `node --check src/engine/input/InputCapabilityDescriptors.js`
+- PASS: `node --check src/engine/input/PointerDragState.js`
+- PASS: `node --check tools/input-mapping-v2/js/services/EngineInputSourceService.js`
+- PASS: `node --check tools/input-mapping-v2/js/ToolStarterApp.js`
+- PASS: `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- PASS: engine input module import validation with `node --input-type=module`.
+- PASS: focused Input Mapping V2 Playwright run passed 11/11 tests.
+- PASS: `npm run test:workspace-v2` passed 70/70 tests.
+- PASS: `git diff --check` reported no whitespace errors. It emitted the existing Windows LF-to-CRLF warning for `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
+
+## Playwright Coverage Added/Updated
+- Proves Input Mapping V2 imports and uses engine-backed capture/session/compatibility services.
+- Proves no duplicate local-only combo/capture state remains in the tool for the moved behaviors.
+- Proves release capture is engine-backed and commits on release.
+- Proves hold capture is engine-backed.
+- Proves double-click capture is engine-backed.
+- Proves drag capture is engine-backed.
+- Proves device/gesture compatibility is engine-backed.
+- Preserves existing functional coverage for filtered JSON export excluding empty actions.
+
+## Coverage Report
+- Browser V8 coverage was generated by the workspace-v2 run.
+- Changed runtime JS coverage lines are present in `docs/dev/reports/playwright_v8_coverage_report.txt`:
+  - `(79%) src/engine/input/InputCaptureService.js - changed JS file with browser V8 coverage`
+  - `(83%) tools/input-mapping-v2/js/services/EngineInputSourceService.js - changed JS file with browser V8 coverage`
+  - `(90%) src/engine/input/InputCapabilityDescriptors.js - changed JS file with browser V8 coverage`
+  - `(93%) tools/input-mapping-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage`
+  - `(95%) src/engine/input/PointerDragState.js - changed JS file with browser V8 coverage`
+  - `(97%) src/engine/input/InputCaptureSession.js - changed JS file with browser V8 coverage`
+  - `(100%) src/engine/input/GamepadInputClassifier.js - changed JS file with browser V8 coverage`
+- `docs/dev/reports/coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+
+## Manual Test Notes
+1. Open `tools/input-mapping-v2/index.html`.
+2. Create or select an `Action Mapping(s)` tile with `Add`.
+3. Select an input device, select a compatible capture gesture, and press the relevant capture button.
+4. Confirm keyboard release waits for down then commits on release, double-click waits for the second click, drag waits for real pointer down/move/up, and gamepad release commits on released state.
+5. Click JSON or Copy JSON and confirm actions with empty `inputs: []` are omitted from the exported/copied payload.
+
+## Full Samples Smoke Test
+- Not run, per request and project instructions. This PR is scoped to engine input ownership, Input Mapping V2, and Workspace V2 validation.