Skip to content

Commit 555e48e

Browse files
committed
Complete Playwright Chromium validation
1 parent e37112b commit 555e48e

4 files changed

Lines changed: 172 additions & 109 deletions

File tree

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# PR_26177_BRAVO_014-playwright-chromium-validation
2+
3+
## Branch Validation
4+
- PASS: Work stayed on `bravo/26177-text-to-speech`.
5+
- PASS: Main was not checked out.
6+
- PASS: No `start_of_day` folders were modified.
7+
8+
## Chromium Validation
9+
- Chromium installed: NO
10+
- Expected executable: `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`
11+
- Initial executable check: missing.
12+
- Install attempted: YES
13+
- `npx playwright install chromium`
14+
- `npx playwright install chromium`
15+
- `npx playwright install chromium --force`
16+
- Install result: FAIL
17+
- Each install attempt timed out.
18+
- The Playwright cache contained only a partial `chromium-1217` folder.
19+
- `chrome.exe` was still absent after each attempt.
20+
- Hung Playwright installer Node processes were stopped; no repo files were changed by the install attempts.
21+
- The partial `chromium-1217` cache folder was removed after the failed attempts so the next retry starts cleanly.
22+
23+
## Playwright Execution
24+
- Playwright executed: NO
25+
- Reason: Chromium installation failed before impacted browser tests could be launched.
26+
27+
## Tests Requested
28+
- NOT RUN: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright`
29+
- NOT RUN: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
30+
31+
## Tests Passed/Failed
32+
- Passed: 0 browser tests in PR_014.
33+
- Failed: 0 browser tests in PR_014.
34+
- Blocked: both requested browser specs are blocked by missing Playwright Chromium.
35+
36+
## Browser Regressions Fixed
37+
- None. Browser tests did not launch, so no browser regression could be diagnosed or fixed.
38+
39+
## Validation Already Passing Before PR_014
40+
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs tests/tools/MessagesPlaybackSource.test.mjs tests/dev-runtime/MessagesPublishValidation.test.mjs tests/dev-runtime/DbSeedIntegrity.test.mjs` (23/23) from PR_013.
41+
42+
## Current Status
43+
- Current branch: `bravo/26177-text-to-speech`
44+
- Git status before PR_014 report edits: clean, ahead of `origin/main` by 11 commits.
45+
- Main touched: NO
46+
- Ready for EOD merge: FAIL
47+
48+
## Required Next Step
49+
- Complete Playwright Chromium installation from a clean Playwright browser cache, then rerun:
50+
- `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright`
51+
- `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
52+
53+
## Repo-Structured ZIP
54+
- `tmp/PR_26177_BRAVO_014-playwright-chromium-validation_delta.zip`

docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ Branch Validation
55
=========================================
66
FAIL
77
- PASS: Started on Bravo branch `bravo/26177-text-to-speech`.
8-
- FAIL: Ended on main. EOD hard-stopped on `bravo/26177-text-to-speech` because impacted Playwright validation failed before push or merge.
9-
- PASS: Working tree clean after PR_013 report/fix commit is expected; verify with final `git status --short --branch`.
8+
- FAIL: Ended on main. EOD hard-stopped on `bravo/26177-text-to-speech` because Playwright Chromium installation failed before impacted browser validation could run.
9+
- PASS: Working tree clean after PR_014 report commit is expected; verify with final `git status --short --branch`.
1010
- FAIL: Local/origin synchronized. Bravo remains ahead of `origin/main` and was not pushed because EOD validation failed.
1111

1212
=========================================
@@ -23,9 +23,10 @@ Bravo branch dependency order reviewed:
2323
8. `87db3eb65` Delete empty TTS profile parents
2424
9. `9b8af1f2c` Force delete broken TTS profiles
2525
10. `36a574959` Add emotion editor preview playback
26-
11. PR_26177_BRAVO_013 Fix Local DB snapshot EOD gate
26+
11. `e37112bf5` Fix Local DB snapshot EOD gate
27+
12. PR_26177_BRAVO_014 Playwright Chromium validation report
2728

28-
No merge into main was attempted. No merge conflicts were encountered because the hard stop occurred during Playwright validation before main integration.
29+
No merge into main was attempted. No merge conflicts were encountered because the hard stop occurred before browser validation and before main integration.
2930

3031
=========================================
3132
Validation
@@ -35,9 +36,14 @@ FAIL
3536
- Command: `node --test tests/tools/Text2SpeechShell.test.mjs tests/tools/MessagesPlaybackSource.test.mjs tests/dev-runtime/MessagesPublishValidation.test.mjs tests/dev-runtime/DbSeedIntegrity.test.mjs`
3637
- Result: 23 passing, 0 failing.
3738
- FAIL: Playwright.
38-
- Command: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
39-
- Result: 9 failed before page code ran.
40-
- Failure: Chromium executable is missing at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
39+
- Chromium installed: NO.
40+
- Install commands attempted:
41+
- `npx playwright install chromium`
42+
- `npx playwright install chromium`
43+
- `npx playwright install chromium --force`
44+
- Result: install attempts timed out and left no `chrome.exe` at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
45+
- The partial `chromium-1217` browser cache was removed after the failed install attempts.
46+
- Browser specs were not rerun after install failure.
4147
- PASS: Local API. `/api/local-db/snapshot`, `/api/local-db/seed`, and `/api/dev/testing/mock-db-state` passed through `DbSeedIntegrity.test.mjs`.
4248
- PASS: Text to Speech. Focused TTS unit assertions passed.
4349
- PASS: Emotion Profiles. Focused Messages publish/profile assertions passed.
@@ -48,17 +54,18 @@ FAIL
4854
Repository Status
4955
=========================================
5056
Current branch: `bravo/26177-text-to-speech`
51-
Working tree: expected clean after PR_013 commit
52-
Local commits ahead: expected 11 after PR_013 commit
57+
Working tree: expected clean after PR_014 report commit
58+
Local commits ahead: expected 12 after PR_014 report commit
5359
Remote commits ahead: 0 relative to `origin/main`
5460
Latest main commit: `8cdd87bf2 Merge pull request #208 from ToolboxAid/PR_26177_DELTA_056-shared-validation-assertions`
5561

5662
=========================================
5763
Outstanding Bravo Work
5864
=========================================
59-
- Install or restore the expected Playwright Chromium browser at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
65+
- Complete Playwright Chromium installation from a clean browser cache so `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe` exists.
6066
- Rerun impacted Playwright coverage:
61-
- `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
67+
- `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright`
68+
- `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
6269
- Push the Bravo branch only after all EOD validation passes.
6370
- Merge Bravo into main only after all EOD validation passes.
6471
- Push main and verify local/origin synchronization.
@@ -67,7 +74,9 @@ Outstanding Bravo Work
6774
=========================================
6875
Manual Validation
6976
=========================================
70-
- Verified EOD retry stayed on `bravo/26177-text-to-speech`.
71-
- Verified the exact unit/API validation command now passes 23/23.
72-
- Verified impacted Playwright is blocked by missing Chromium before page code runs.
73-
- Stopped before push, main merge, main push, and branch deletion because Playwright validation failed.
77+
- Verified PR_014 stayed on `bravo/26177-text-to-speech`.
78+
- Verified Chromium was missing at the expected Playwright cache path.
79+
- Attempted Playwright Chromium installation three times, including one clean-cache `--force` attempt.
80+
- Verified `chrome.exe` remained missing after install attempts.
81+
- Removed the partial `chromium-1217` cache left by the failed installation attempts.
82+
- Stopped before browser tests, push, main merge, main push, and branch deletion because Chromium installation failed.
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
docs_build/database/seed/guest/idea-board.json
2-
docs_build/database/seed/guest/messages.json
3-
docs_build/database/seed/guest/text-to-speech.json
4-
docs_build/database/seed/guest/users.json
51
docs_build/dev/reports/codex_changed_files.txt
62
docs_build/dev/reports/codex_review.diff
7-
docs_build/dev/reports/PR_26177_BRAVO_013-fix-local-db-snapshot-eod-gate.md
3+
docs_build/dev/reports/PR_26177_BRAVO_014-playwright-chromium-validation.md
84
docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
9-
src/dev-runtime/server/local-api-router.mjs
Lines changed: 93 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -1,93 +1,98 @@
1+
diff --git a/docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md b/docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
2+
index 87ef7975a..004761a72 100644
3+
--- a/docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
4+
+++ b/docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
5+
@@ -5,8 +5,8 @@ Branch Validation
6+
=========================================
7+
FAIL
8+
- PASS: Started on Bravo branch `bravo/26177-text-to-speech`.
9+
-- FAIL: Ended on main. EOD hard-stopped on `bravo/26177-text-to-speech` because impacted Playwright validation failed before push or merge.
10+
-- PASS: Working tree clean after PR_013 report/fix commit is expected; verify with final `git status --short --branch`.
11+
+- FAIL: Ended on main. EOD hard-stopped on `bravo/26177-text-to-speech` because Playwright Chromium installation failed before impacted browser validation could run.
12+
+- PASS: Working tree clean after PR_014 report commit is expected; verify with final `git status --short --branch`.
13+
- FAIL: Local/origin synchronized. Bravo remains ahead of `origin/main` and was not pushed because EOD validation failed.
14+
15+
=========================================
16+
@@ -23,9 +23,10 @@ Bravo branch dependency order reviewed:
17+
8. `87db3eb65` Delete empty TTS profile parents
18+
9. `9b8af1f2c` Force delete broken TTS profiles
19+
10. `36a574959` Add emotion editor preview playback
20+
-11. PR_26177_BRAVO_013 Fix Local DB snapshot EOD gate
21+
+11. `e37112bf5` Fix Local DB snapshot EOD gate
22+
+12. PR_26177_BRAVO_014 Playwright Chromium validation report
23+
24+
-No merge into main was attempted. No merge conflicts were encountered because the hard stop occurred during Playwright validation before main integration.
25+
+No merge into main was attempted. No merge conflicts were encountered because the hard stop occurred before browser validation and before main integration.
26+
27+
=========================================
28+
Validation
29+
@@ -35,9 +36,14 @@ FAIL
30+
- Command: `node --test tests/tools/Text2SpeechShell.test.mjs tests/tools/MessagesPlaybackSource.test.mjs tests/dev-runtime/MessagesPublishValidation.test.mjs tests/dev-runtime/DbSeedIntegrity.test.mjs`
31+
- Result: 23 passing, 0 failing.
32+
- FAIL: Playwright.
33+
- - Command: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
34+
- - Result: 9 failed before page code ran.
35+
- - Failure: Chromium executable is missing at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
36+
+ - Chromium installed: NO.
37+
+ - Install commands attempted:
38+
+ - `npx playwright install chromium`
39+
+ - `npx playwright install chromium`
40+
+ - `npx playwright install chromium --force`
41+
+ - Result: install attempts timed out and left no `chrome.exe` at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
42+
+ - The partial `chromium-1217` browser cache was removed after the failed install attempts.
43+
+ - Browser specs were not rerun after install failure.
44+
- PASS: Local API. `/api/local-db/snapshot`, `/api/local-db/seed`, and `/api/dev/testing/mock-db-state` passed through `DbSeedIntegrity.test.mjs`.
45+
- PASS: Text to Speech. Focused TTS unit assertions passed.
46+
- PASS: Emotion Profiles. Focused Messages publish/profile assertions passed.
47+
@@ -48,17 +54,18 @@ FAIL
48+
Repository Status
49+
=========================================
50+
Current branch: `bravo/26177-text-to-speech`
51+
-Working tree: expected clean after PR_013 commit
52+
-Local commits ahead: expected 11 after PR_013 commit
53+
+Working tree: expected clean after PR_014 report commit
54+
+Local commits ahead: expected 12 after PR_014 report commit
55+
Remote commits ahead: 0 relative to `origin/main`
56+
Latest main commit: `8cdd87bf2 Merge pull request #208 from ToolboxAid/PR_26177_DELTA_056-shared-validation-assertions`
57+
58+
=========================================
59+
Outstanding Bravo Work
60+
=========================================
61+
-- Install or restore the expected Playwright Chromium browser at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`.
62+
+- Complete Playwright Chromium installation from a clean browser cache so `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe` exists.
63+
- Rerun impacted Playwright coverage:
64+
- - `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
65+
+ - `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright`
66+
+ - `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright`
67+
- Push the Bravo branch only after all EOD validation passes.
68+
- Merge Bravo into main only after all EOD validation passes.
69+
- Push main and verify local/origin synchronization.
70+
@@ -67,7 +74,9 @@ Outstanding Bravo Work
71+
=========================================
72+
Manual Validation
73+
=========================================
74+
-- Verified EOD retry stayed on `bravo/26177-text-to-speech`.
75+
-- Verified the exact unit/API validation command now passes 23/23.
76+
-- Verified impacted Playwright is blocked by missing Chromium before page code runs.
77+
-- Stopped before push, main merge, main push, and branch deletion because Playwright validation failed.
78+
+- Verified PR_014 stayed on `bravo/26177-text-to-speech`.
79+
+- Verified Chromium was missing at the expected Playwright cache path.
80+
+- Attempted Playwright Chromium installation three times, including one clean-cache `--force` attempt.
81+
+- Verified `chrome.exe` remained missing after install attempts.
82+
+- Removed the partial `chromium-1217` cache left by the failed installation attempts.
83+
+- Stopped before browser tests, push, main merge, main push, and branch deletion because Chromium installation failed.
184
diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt
2-
index 9bb1d6b6e..c0935b1f9 100644
85+
index c0935b1f9..b051a237f 100644
386
--- a/docs_build/dev/reports/codex_changed_files.txt
487
+++ b/docs_build/dev/reports/codex_changed_files.txt
5-
@@ -1,6 +1,9 @@
6-
-assets/toolbox/text-to-speech/js/index.js
7-
+docs_build/database/seed/guest/idea-board.json
8-
+docs_build/database/seed/guest/messages.json
9-
+docs_build/database/seed/guest/text-to-speech.json
10-
+docs_build/database/seed/guest/users.json
88+
@@ -1,9 +1,4 @@
89+
-docs_build/database/seed/guest/idea-board.json
90+
-docs_build/database/seed/guest/messages.json
91+
-docs_build/database/seed/guest/text-to-speech.json
92+
-docs_build/database/seed/guest/users.json
1193
docs_build/dev/reports/codex_changed_files.txt
1294
docs_build/dev/reports/codex_review.diff
13-
-docs_build/dev/reports/PR_26177_BRAVO_012-add-emotion-editor-preview.md
14-
-tests/playwright/tools/TextToSpeechFunctional.spec.mjs
15-
-tests/tools/Text2SpeechShell.test.mjs
16-
+docs_build/dev/reports/PR_26177_BRAVO_013-fix-local-db-snapshot-eod-gate.md
17-
+docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
18-
+src/dev-runtime/server/local-api-router.mjs
19-
diff --git a/src/dev-runtime/server/local-api-router.mjs b/src/dev-runtime/server/local-api-router.mjs
20-
index 91f78c104..206cfec57 100644
21-
--- a/src/dev-runtime/server/local-api-router.mjs
22-
+++ b/src/dev-runtime/server/local-api-router.mjs
23-
@@ -3529,7 +3529,15 @@ class ApiRuntimeDataSource {
24-
}
25-
26-
async currentStateSnapshot() {
27-
- return this.snapshot();
28-
+ return this.snapshot({ includePostgresCompletionMetrics: false });
29-
+ }
30-
+
31-
+ async resetStateSnapshot() {
32-
+ this.applyStateSnapshot({
33-
+ cleared: false,
34-
+ tables: createServerSeedTables(),
35-
+ });
36-
+ return this.currentStateSnapshot();
37-
}
38-
39-
applyStateSnapshot(state = {}) {
40-
@@ -5416,6 +5424,10 @@ SELECT pg_database_size(current_database()) AS database_size_bytes,
41-
}
42-
43-
setMode(modeId) {
44-
+ const normalizedModeId = String(modeId || "").trim();
45-
+ if (normalizedModeId && normalizedModeId !== "local-db" && normalizedModeId !== FIXED_ACCOUNT_SESSION_MODE.id) {
46-
+ throw new Error(`Unknown local login environment: ${normalizedModeId}.`);
47-
+ }
48-
return {
49-
...clone(FIXED_ACCOUNT_SESSION_MODE),
50-
diagnostic: "Session mode switching is disabled; account sessions use the fixed server-owned auth session.",
51-
@@ -6704,7 +6716,7 @@ SELECT pg_database_size(current_database()) AS database_size_bytes,
52-
return result;
53-
}
54-
55-
- async snapshot() {
56-
+ async snapshot({ includePostgresCompletionMetrics = true } = {}) {
57-
const schemas = getMockDbTableSchemas();
58-
const toolGroups = getMockDbToolGroups();
59-
const owners = {
60-
@@ -6754,7 +6766,7 @@ SELECT pg_database_size(current_database()) AS database_size_bytes,
61-
...gameConfigurationTables(this.gameConfigurationRepository),
62-
...objectsTables(this.objectsRepository),
63-
...controlsTables(this.inputMappingRepository),
64-
- ...(await gameJourneyTables(this.gameJourneyRepository)),
65-
+ ...(includePostgresCompletionMetrics ? await gameJourneyTables(this.gameJourneyRepository) : {}),
66-
...paletteTables(this.paletteRepository),
67-
...tagsTables(this.tagsRepository),
68-
...assetTables(this.assetRepository),
69-
@@ -6943,6 +6955,24 @@ export function createLocalApiRouter({
70-
return true;
71-
}
72-
73-
+ if (parts[1] === "local-db") {
74-
+ if (request.method === "GET" && parts[2] === "snapshot") {
75-
+ ok(response, await dataSource.currentStateSnapshot());
76-
+ return true;
77-
+ }
78-
+ if (request.method === "POST" && parts[2] === "seed") {
79-
+ ok(response, await dataSource.resetStateSnapshot());
80-
+ return true;
81-
+ }
82-
+ }
83-
+
84-
+ if (parts[1] === "dev" && parts[2] === "testing" && request.method === "POST" && parts[3] === "mock-db-state") {
85-
+ const body = await readRequestJson(request);
86-
+ dataSource.applyStateSnapshot(body.state);
87-
+ ok(response, await dataSource.currentStateSnapshot());
88-
+ return true;
89-
+ }
90-
+
91-
if (parts[1] === "project-workspace" && request.method === "GET" && parts[2] === "projects") {
92-
ok(response, dataSource.projectWorkspaceProjectsForRoute());
93-
return true;
95+
-docs_build/dev/reports/PR_26177_BRAVO_013-fix-local-db-snapshot-eod-gate.md
96+
+docs_build/dev/reports/PR_26177_BRAVO_014-playwright-chromium-validation.md
97+
docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md
98+
-src/dev-runtime/server/local-api-router.mjs

0 commit comments

Comments
 (0)