Complete MIDI Studio V2 composition workflow with generation mapping regeneration sync and preview polish - PR_26146_085-088-midi-studio-v2-composition-workflow-lane

Author: ToolboxAid

docs/dev/reports/PR_26146_085_088_bundle_validation.md

@@ -0,0 +1,41 @@
+# PR_26146_085-088 Bundle Validation
+
+## Scope
+- Completed MIDI Studio V2 composition workflow lane for section-to-lane generation, regenerate, edit sync, audition, and playback state polish.
+- Baseline: PR_26146_081-084.
+
+## Changed Surface
+- `tools/midi-studio-v2/index.html`
+- `tools/midi-studio-v2/js/bootstrap.js`
+- `tools/midi-studio-v2/js/MidiStudioV2App.js`
+- `tools/midi-studio-v2/js/controls/SongSheetControl.js`
+- `tools/midi-studio-v2/js/controls/PlaybackControl.js`
+- `tests/playwright/tools/MidiStudioV2.spec.mjs`
+
+## Validation
+- PASS: changed-file syntax checks
+  - `node --check tools/midi-studio-v2/js/MidiStudioV2App.js`
+  - `node --check tools/midi-studio-v2/js/bootstrap.js`
+  - `node --check tools/midi-studio-v2/js/controls/SongSheetControl.js`
+  - `node --check tools/midi-studio-v2/js/controls/PlaybackControl.js`
+  - `node --check tests/playwright/tools/MidiStudioV2.spec.mjs`
+- PASS: targeted MIDI Studio Playwright
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs -g "validates PR085-088 composition mapping regenerate sync audition and playback states"`
+  - Result: 1 passed.
+- PASS: baseline plus lane targeted MIDI Studio Playwright
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs -g "PR081-084|PR085-088"`
+  - Result: 2 passed.
+- PASS: `git diff --check`
+  - Only Git CRLF normalization warnings were printed.
+- TIMEOUT: `npm run test:workspace-v2`
+  - First run timed out after 124 seconds.
+  - Second run timed out after 604 seconds.
+  - The runner left child Node/Playwright processes and generated cache report side effects; those processes were stopped and only the runner-generated side-effect files were restored.
+
+## Playwright Coverage Notes
+- `docs/dev/reports/playwright_v8_coverage_report.txt` and `docs/dev/reports/coverage_changed_js_guardrail.txt` are present from the targeted MIDI Studio Playwright run.
+- Guardrail status is advisory and reports no changed runtime JS coverage warnings.
+
+## Result
+PASS for changed-file syntax, targeted MIDI Studio behavior, and diff hygiene.
+Workspace V2 command was executed as required but did not complete within the available timeout window.

docs/dev/reports/PR_26146_085_088_generation_mapping.md

@@ -0,0 +1,40 @@
+# PR_26146_085-088 Generation Mapping
+
+## Authoritative Inputs
+- Populated Song Sheet sections.
+- Song Sequence order.
+- Apply Song Sheet To selections.
+
+## Target Mapping
+- Chords/Pad enabled:
+  - Writes canonical `chords`.
+  - Generates `pad` from the chord lane.
+- Bass enabled:
+  - Generates `bass` from the chord lane.
+- Drums enabled:
+  - Generates `drums` from the current section map.
+- Lead enabled:
+  - Generates `lead` from the chord lane.
+
+## Summary Output
+Song Sheet Summary now includes:
+- Generation targets.
+- Lane mapping.
+- Manual lanes preserved.
+- Target lanes affected.
+- Sections used, bars generated, and notes generated.
+
+## Regenerate Arrangement
+- Added `Regenerate Arrangement`.
+- Regenerate reparses the current guided Song Sheet, uses the current sequence, and applies the current target selections.
+- Status reports the targets, generated bar count, generated note count, and preservation behavior.
+
+## Manual Preservation
+- Targeted lanes are regenerated.
+- Untargeted lanes are preserved when their bar count matches the regenerated arrangement.
+- Untargeted lanes that no longer match the regenerated bar count are aligned with rest bars to keep the canonical instrument grid parseable.
+
+## Validation
+- Playwright verified Chords/Pad and Bass generation while Drums and Lead were skipped.
+- Playwright verified an untargeted Lead lane edit survived Regenerate Arrangement.
+- Playwright verified enabling Lead caused Lead to regenerate from the Song Sheet.

docs/dev/reports/PR_26146_085_088_sync_audit.md

@@ -0,0 +1,29 @@
+# PR_26146_085-088 Sync Audit
+
+## Song Sheet Edits
+- Section editor edits call the existing Song Sheet field-change path.
+- The field-change path persists canonical `studioArrangement.songSheet`, reparses the guided sheet, reapplies generation targets, and refreshes diagnostics and JSON Details.
+- Sequence edits continue to drive playback/build order.
+
+## Canonical Model
+- Generated section order is written to `music.songs[].studioArrangement.sections`.
+- Guided Song Sheet source is written to `music.songs[].studioArrangement.songSheet.sections`.
+- Song Sequence is written to `music.songs[].studioArrangement.songSheet.sequence`.
+- Apply targets are written to `music.songs[].studioArrangement.songSheet.applyTargets`.
+- Lane text is written to `music.songs[].studioArrangement.lanes`.
+
+## Timeline Sync
+- Octave Timeline uses the normalized instrument grid after Song Sheet parse/regenerate.
+- Timeline section labels and colors continue to come from the normalized section map.
+- Current playback section highlighting is preserved through the canvas-backed timeline.
+
+## Audition And Playback
+- Instrument previews now stop active Preview Synth audio before starting a new instrument audition.
+- Keyboard and edited-note auditions stop active Preview Synth/timing playback before auditioning, avoiding stale Play/Stop state.
+- Playback state now distinguishes playing, looping, stopped, and completed preview states.
+
+## Validation
+- Playwright verified canonical model synchronization after a Song Sheet edit changed bar counts.
+- Playwright verified timeline section labels after regeneration.
+- Playwright verified keyboard audition status.
+- Playwright verified non-loop playback completion and loop playback stop behavior.

tests/playwright/tools/MidiStudioV2.spec.mjs

@@ -761,6 +761,7 @@ async function visibleMidiStudioControlOwnership(page, activeTabId) {
       playButton: { canonical: "playback from selected canonical song model", kind: "action", owner: "Global NAV", wired: "wired" },
       playLoopButton: { canonical: "timing preview playback state", kind: "workflow-state", owner: "Octave Timeline", wired: "wired" },
       playSectionButton: { canonical: "timing preview playback state", kind: "workflow-state", owner: "Octave Timeline", wired: "wired" },
+      regenerateArrangementButton: { canonical: "music.songs[].studioArrangement generated lanes from Song Sheet sequence", kind: "canonical-action", owner: "Song Setup", wired: "wired" },
       renderedExportSaveButton: { canonical: "future rendered audio renderer", kind: "unwired", owner: "Export", wired: "unwired" },
       renderedExportTargetTypeSelect: { canonical: "future rendered audio renderer", kind: "unwired", owner: "Export", wired: "unwired" },
       resetSongEditsButton: { canonical: "music.songs[] reset baseline", kind: "canonical-action", owner: "Global NAV", wired: "wired" },
@@ -5153,6 +5154,96 @@ test.describe("MIDI Studio V2", () => {
     }
   });
 
+  test("validates PR085-088 composition mapping regenerate sync audition and playback states", async ({ page }) => {
+    await page.setViewportSize({ width: 1600, height: 900 });
+    const server = await openMidiStudioForImport(page);
+    try {
+      await page.locator("#toolImportManifestInput").setInputFiles(uatManifestPath);
+      await selectMidiStudioTab(page, "song-setup");
+      await page.locator("#songSheetTempoInput").fill("960");
+      await fillSongSheetSectionBuilder(page, "Intro: G C\nVerse: G Em\nChorus: C G\nBridge:\nOutro:\nBreak: F");
+      await clearSongSheetSequence(page);
+      await addSongSheetSequenceLabels(page, ["Intro", "Verse", "Chorus"]);
+      await page.locator("#songSheetApplyChordsPadInput").setChecked(true);
+      await page.locator("#songSheetApplyBassInput").setChecked(true);
+      await page.locator("#songSheetApplyDrumsInput").setChecked(false);
+      await page.locator("#songSheetApplyLeadInput").setChecked(false);
+      await page.locator("#parseSongSheetButton").click();
+
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='generation-targets'] dd")).toHaveText("Chords/Pad, Bass");
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='lane-mapping'] dd")).toHaveText("Chords/Pad -> chords, pad; Bass -> bass; Drums -> skipped; Lead -> skipped");
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='target-lanes-affected'] dd")).toHaveText("Chords/Pad, Bass");
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='bars-generated'] dd")).toHaveText("6");
+
+      await selectMidiStudioTab(page, "auto-create-parts");
+      await page.locator(".midi-studio-v2__advanced-lane-source").evaluate((details) => {
+        details.open = true;
+      });
+      const manualLead = "C5 - - - | D5 - - - | E5 - - - | F5 - - - | G5 - - - | A5 - - -";
+      await page.locator("#instrumentGridLeadInput").fill(manualLead);
+      await page.locator("#normalizeInstrumentGridButton").click();
+      await selectMidiStudioTab(page, "song-setup");
+      await page.locator("#regenerateArrangementButton").click();
+      await expect(page.locator("#instrumentGridLeadInput")).toHaveValue(manualLead);
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='manual-lanes-preserved'] dd")).toContainText("kept lead");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Regenerated arrangement for Chords\/Pad, Bass: 6 bars, \d+ notes\. Manual lanes .*kept lead/);
+
+      await page.locator("#songSheetApplyLeadInput").setChecked(true);
+      await page.locator("#regenerateArrangementButton").click();
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='generation-targets'] dd")).toHaveText("Chords/Pad, Bass, Lead");
+      await expect(page.locator("#instrumentGridLeadInput")).not.toHaveValue(manualLead);
+
+      await page.locator("#songSheetSectionIntroInput").fill("G C D");
+      await expect(page.locator("#songSheetSummary [data-song-sheet-summary-field='bars-generated'] dd")).toHaveText("7");
+      await expect(page.locator("#instrumentGridSectionsInput")).toHaveValue("Intro:3, Verse:2, Chorus:2");
+
+      const synced = await page.evaluate(() => {
+        const app = window.__midiStudioV2App;
+        const song = app.selectedSong();
+        const gridResult = app.currentInstrumentGridResult();
+        return {
+          applyTargets: song.studioArrangement.songSheet.applyTargets,
+          barCount: gridResult.barCount,
+          leadEvents: gridResult.timeline.filter((event) => event.lane === "lead").length,
+          sections: song.studioArrangement.sections,
+          sequence: song.studioArrangement.songSheet.sequence
+        };
+      });
+      expect(synced).toEqual(expect.objectContaining({
+        applyTargets: { bass: true, chordsPad: true, drums: false, lead: true },
+        barCount: 7,
+        sections: "Intro:3, Verse:2, Chorus:2",
+        sequence: "Intro, Verse, Chorus"
+      }));
+      expect(synced.leadEvents).toBeGreaterThan(0);
+
+      await selectMidiStudioTab(page, "studio");
+      await waitForCanvasRender(page);
+      expect((await canvasTimelineState(page)).sections.map((section) => section.label)).toEqual(["Intro", "Verse", "Chorus"]);
+      await timelineQuickInstrumentRow(page, "lead").locator("[data-quick-instrument-label='lead']").click();
+      await clickCanvasKeyboardKey(page, "C5");
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO Auditioned C5 for Lead/);
+
+      await page.locator("#loopToggle").setChecked(false);
+      await page.locator("#playButton").click();
+      await expect(page.locator("#playbackState")).toContainText("Playing audible preview");
+      await expect.poll(async () => (await page.locator("#playbackState").textContent()) || "", { timeout: 4000 }).toContain("Completed audible preview");
+      await expect(page.locator("#playButton")).toBeEnabled();
+      await expect(page.locator("#stopButton")).toBeDisabled();
+
+      await page.locator("#loopToggle").setChecked(true);
+      await page.locator("#playButton").click();
+      await expect(page.locator("#playbackState")).toContainText("(looping)");
+      await expect(page.locator("#stopButton")).toBeEnabled();
+      await page.locator("#stopButton").click();
+      await expect(page.locator("#playbackState")).toContainText("Stopped audible preview");
+      await expect(page.locator("#playButton")).toBeEnabled();
+    } finally {
+      await workspaceV2CoverageReporter.stop(page);
+      await server.close();
+    }
+  });
+
   test("derives primary song, instrument, grid, playback, and diagnostics views from the canonical selected song", async ({ page }) => {
     const server = await openMidiStudioForImport(page);
     try {
@@ -5778,7 +5869,7 @@ test.describe("MIDI Studio V2", () => {
         "Warnings": "none"
       });
       await expect(page.locator("#statusLog")).toHaveValue(/OK Song Sheet parsed: 2 sections, 6 bars, 6 chords\./);
-      await expect(page.locator("#statusLog")).toHaveValue(/OK Song Sheet updated the editable note grid\./);
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Song Sheet updated the editable note grid for /);
     } finally {
       await workspaceV2CoverageReporter.stop(page);
       await server.close();

tools/midi-studio-v2/index.html

@@ -352,6 +352,7 @@ <h3 id="exportStatusHeading">Export Status</h3>
             </fieldset>
             <div class="midi-studio-v2__song-sheet-actions">
               <button id="parseSongSheetButton" type="button">Parse Guided Song Sheet</button>
+              <button id="regenerateArrangementButton" type="button">Regenerate Arrangement</button>
             </div>
             <dl id="songSheetSummary" class="midi-studio-v2__details"></dl>
           </div>