Skip to content

Commit 69ba4ce

Browse files
committed
Clean up Colors terminology fullscreen titles and card spacing - PR_26159_051-colors-terminology-fullscreen-spacing
1 parent e9d3ca1 commit 69ba4ce

11 files changed

Lines changed: 262 additions & 113 deletions

File tree

assets/theme-v2/css/layout.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,11 @@ body.tool-focus-mode .tool-center-panel {
255255
grid-row: 2
256256
}
257257

258+
body.tool-focus-mode .tool-center-panel>h2,
259+
body.tool-focus-mode .tool-center-panel>h2+p {
260+
display: none
261+
}
262+
258263
body.tool-focus-mode .tool-column:last-of-type {
259264
grid-column: 3;
260265
grid-row: 1 / span 2

assets/theme-v2/css/panels.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838
padding: var(--space-18)
3939
}
4040

41+
.tool-workspace article.card>.card-body.content-stack {
42+
margin: var(--space-8)
43+
}
44+
4145
.surface {
4246
border: var(--border-standard);
4347
border-radius: var(--radius-lg);
Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
# PR_26159_051 Colors Terminology, Fullscreen, And Spacing Report
2+
3+
## Branch Guard
4+
5+
| Check | Status | Evidence |
6+
| --- | --- | --- |
7+
| Current branch is `main` before build | PASS | `git branch --show-current` returned `main`. |
8+
9+
## Requirement Checklist
10+
11+
| Requirement | Status | Evidence |
12+
| --- | --- | --- |
13+
| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first | PASS | Read before edits; main-branch guard followed. |
14+
| Hard stop if branch is not `main` | PASS | Branch validated as `main`; build continued. |
15+
| Colors page top title says `Colors`, not `Palette` | PASS | `toolbox/colors/index.html`; Playwright title/heading assertions in `PaletteToolMockRepository.spec.mjs`. |
16+
| Replace stale user-facing Palette wording | PASS | Replaced page title, lede, headings, validation copy, status/log copy, table display labels, and repository-surfaced messages. |
17+
| Keep `Palette Type` only for the selector type dropdown | PASS | `toolbox/colors/index.html` label for `paletteGeneratorType`; tooltips retain `Palette Type` as requested. |
18+
| Preserve internal `palette-browser` compatibility | PASS | Internal constants/data attributes remain in `palette-api-client.js`, `colors.js`, and `palette-workspace-repository.js`; visible `tools.palette-browser.swatches` text removed from Colors UI. |
19+
| Fullscreen hides tool H2 and descriptive text | PASS | `assets/theme-v2/css/layout.css`; `ToolDisplayModeNavigation.spec.mjs` asserts hidden in `tool-focus-mode`. |
20+
| Fullscreen exit restores H2 and descriptive text | PASS | `ToolDisplayModeNavigation.spec.mjs` toggles fullscreen off and asserts restored visibility. |
21+
| Card body spacing adds 8px reusable tool spacing | PASS | `assets/theme-v2/css/panels.css`; `GameConfigurationMockRepository.spec.mjs` asserts 8px margins on `data-game-configuration-form-card` body. |
22+
| No page-local/tool-local CSS, inline styles, or inline handlers | PASS | Shared Theme V2 CSS only; `rg` check for inline style/script/event handlers returned no matches in changed active files. |
23+
| No broken internal storage/contracts | PASS | Repository unit/Playwright lane passed; internal contract names preserved while visible labels are mapped. |
24+
| No console errors | PASS | Targeted Playwright lanes collect console errors and passed. |
25+
| Playwright impacted | PASS | Targeted Colors, shared display mode, fullscreen accordion, and Game Configuration lanes passed. |
26+
27+
## User-Facing Terms Changed
28+
29+
- `Palette Tool` -> `Colors`
30+
- `Palette` page/column/center heading -> `Colors`
31+
- `Manage the active project palette at tools.palette-browser.swatches.` -> `Manage active project swatches for tool and asset color handoff.`
32+
- `Selected palette swatch tag editor fields` -> `Project Swatches tag editor fields`
33+
- `Selected palette color tags` -> `Project Swatches color tags`
34+
- `Palette summary` -> `Colors summary`
35+
- `palette swatches` / `project palette colors` -> `project swatches` / `Project Swatches colors`
36+
- `Source Palette Closest Match` -> `Current Source Closest Match`
37+
- `All Palettes Closest Match` -> `All Sources Closest Match`
38+
- `Validation` / `Palette Validation` -> `Swatch Validation`
39+
- `tools.palette-browser.swatches` visible status -> `Colors storage contract active.`
40+
- Raw `palette_*` table labels in the Colors UI -> `Project Swatches`, `Source Swatches`, `Swatch Usage`, `Project Swatch Settings`
41+
- `Palette generator` runtime messages -> `Picker Preview` / `Picker controls`
42+
- `Invalid palette payload` surfaced messages -> `Invalid Colors payload`
43+
44+
## Internal Keys Preserved
45+
46+
- `PALETTE_TOOL_KEY = "palette-browser"`
47+
- `PALETTE_WORKSPACE_PATH = tools.palette-browser.swatches`
48+
- `data-palette-*` attributes
49+
- `palette_colors`
50+
- `palette_source_swatches`
51+
- `palette_swatch_usages`
52+
- `project_workspace_palette_globals`
53+
- `palette-api-client.js` and repository function names needed by current compatibility contracts
54+
55+
## Validation Evidence
56+
57+
| Lane | Status | Evidence |
58+
| --- | --- | --- |
59+
| Syntax checks | PASS | `node --check toolbox/colors/colors.js`; `node --check src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js`; `node --check assets/theme-v2/js/tool-display-mode.js`. |
60+
| Static diff check | PASS | `git diff --check` passed with line-ending warnings only. |
61+
| Static terminology sweep | PASS | `rg` for targeted stale Palette UI phrases returned no matches in Colors active files and repository-surfaced messages. |
62+
| Inline style/script/event handler sweep | PASS | `rg` for inline style/script/event handlers returned no matches in changed active files. |
63+
| Colors runtime/UI | PASS | `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs` -> 9 passed. |
64+
| Shared display mode | PASS | `npx playwright test tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs` -> 5 passed. |
65+
| Tool center fullscreen accordions | PASS | `npx playwright test tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs` -> 1 passed. |
66+
| Game Configuration spacing | PASS | `npx playwright test tests/playwright/tools/GameConfigurationMockRepository.spec.mjs` -> 4 passed. |
67+
| Playwright V8 coverage | PASS | `docs_build/dev/reports/playwright_v8_coverage_report.txt`; Colors runtime collected at 86% advisory coverage. |
68+
69+
## Skipped Lanes
70+
71+
- Full samples validation: skipped per request.
72+
- Broad repo-wide Playwright: skipped because the PR touched Colors, shared display-mode CSS, shared card spacing CSS, and targeted tests covered those surfaces directly.
73+

docs_build/dev/reports/coverage_changed_js_guardrail.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ Missing changed runtime JS files are WARN, not FAIL.
66
Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
77

88
Changed runtime JS files considered:
9-
(86%) toolbox/colors/colors.js - executed lines 2127/2127; executed functions 182/211
9+
(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
10+
(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
1011
(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
1112

1213
Guardrail warnings:
13-
(100%) none - no changed runtime JS coverage warnings
14+
(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/playwright_v8_coverage_report.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,26 @@ Exercised tool entry points detected:
1717
(77%) Theme V2 Shared JS - exercised 3 runtime JS files
1818

1919
Changed runtime JS files covered:
20-
(86%) toolbox/colors/colors.js - executed lines 2127/2127; executed functions 182/211
20+
(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
21+
(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
2122
(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
2223

2324
Files with executed line/function counts where available:
2425
(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
2526
(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 9/14
2627
(76%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 525/525; executed functions 35/46
2728
(78%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 21/27
28-
(86%) toolbox/colors/colors.js - executed lines 2127/2127; executed functions 182/211
29+
(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
2930
(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
3031
(100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
3132

3233
Uncovered or low-coverage changed JS files:
33-
(100%) none - no low-coverage changed runtime JS files
34+
(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: uncovered changed runtime JS file; advisory only
3435

3536
Changed JS files considered:
36-
(0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
37+
(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - changed JS file not collected as browser runtime coverage
38+
(0%) tests/playwright/tools/GameConfigurationMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
3739
(0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
40+
(0%) tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs - changed JS file not collected as browser runtime coverage
3841
(86%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
3942
(92%) assets/theme-v2/js/account-controls.js - changed JS file with browser V8 coverage

0 commit comments

Comments
 (0)