Skip to content

Commit 701f166

Browse files
ToolboxAidToolboxAid
authored
PR_26171_042 clean up idea board navigation fallback
Remove the creator-visible Tool Display Mode navigation fallback when optional navigation cannot load. Keep the failure logged to the console only and validate that Idea Board remains usable with and without registry-backed navigation data.
1 parent 9df4942 commit 701f166

10 files changed

Lines changed: 708 additions & 2026 deletions

File tree

‎assets/theme-v2/js/tool-display-mode.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,6 @@
154154
body.appendChild(navigationRow);
155155
} catch (error) {
156156
console.warn("Tool navigation could not be loaded.", error);
157-
const diagnostic = document.createElement("p");
158-
diagnostic.className = "status";
159-
diagnostic.setAttribute("role", "status");
160-
diagnostic.textContent = "Tool navigation is temporarily unavailable. Refresh the page or try again shortly.";
161-
body.appendChild(diagnostic);
162157
}
163158
}
164159

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 76 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,78 @@
1-
# Codex Changed Files - PR_26171_061-text2speech-engine-audio-feature-parity
2-
3-
## Git Workflow
4-
- Starting branch: `main`.
5-
- Created branch: `pr/26171-061-text2speech-engine-audio-feature-parity`.
6-
- Initial commit: `e4541d63719ab777b0654c8fecf4b13237d31256`.
7-
- PR branch was merged with `origin/main` during PR conflict recovery.
8-
- Conflicts were limited to generated report artifacts.
9-
10-
## Scoped Diff Stat
11-
```text
12-
...R_26171_061-engine-audio-ownership-checklist.md | 25 +
13-
...R_26171_061-instruction-compliance-checklist.md | 32 +
14-
.../PR_26171_061-manual-validation-notes.md | 27 +
15-
...R_26171_061-old-tts-feature-parity-checklist.md | 48 ++
16-
..._061-text2speech-engine-audio-feature-parity.md | 71 ++
17-
docs_build/dev/reports/PR_26171_061-validation.md | 42 +
18-
docs_build/dev/reports/codex_changed_files.txt | 118 +--
19-
.../dev/reports/coverage_changed_js_guardrail.txt | 7 +-
20-
.../dev/reports/playwright_v8_coverage_report.txt | 36 +-
21-
src/engine/audio/TextToSpeechEngine.js | 208 ++++-
22-
.../tools/TextToSpeechFunctional.spec.mjs | 30 +
23-
toolbox/text-to-speech/index.html | 119 +--
24-
toolbox/text-to-speech/text2speech.js | 853 +++++++++++++++++----
25-
13 files changed, 1317 insertions(+), 299 deletions(-)
26-
```
27-
28-
## Changed Files
29-
- src/engine/audio/TextToSpeechEngine.js
30-
- toolbox/text-to-speech/index.html
31-
- toolbox/text-to-speech/text2speech.js
32-
- tests/playwright/tools/TextToSpeechFunctional.spec.mjs
33-
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
34-
- docs_build/dev/reports/playwright_v8_coverage_report.txt
35-
- docs_build/dev/reports/PR_26171_061-text2speech-engine-audio-feature-parity.md
36-
- docs_build/dev/reports/PR_26171_061-instruction-compliance-checklist.md
37-
- docs_build/dev/reports/PR_26171_061-old-tts-feature-parity-checklist.md
38-
- docs_build/dev/reports/PR_26171_061-engine-audio-ownership-checklist.md
39-
- docs_build/dev/reports/PR_26171_061-validation.md
40-
- docs_build/dev/reports/PR_26171_061-manual-validation-notes.md
41-
- docs_build/dev/reports/codex_review.diff
42-
- docs_build/dev/reports/codex_changed_files.txt
1+
# PR_26171_042 Codex Changed Files Report
2+
3+
## Instruction Compliance Gate
4+
5+
- Current branch before execution: `main`
6+
- Required execution branch before PR branch: `main`
7+
- Branch validation: PASS
8+
- Clean repository before branch creation: PASS
9+
- PR owner/parity: PASS, `042` is even and Idea/Tool Display navigation scope maps to PC / Environment 1.
10+
- Implementation path: PASS, active Idea Board and Theme V2 files only.
11+
- Validation scope: PASS, targeted Idea Board, targeted Toolbox route for Idea Board, and workspace contract lane because shared Tool Display Mode behavior changed.
12+
- Required reports: PASS, `docs_build/dev/reports/codex_review.diff` and this report are updated.
13+
- ZIP requirement: PASS, `tmp/PR_26171_042-idea-board-navigation-fallback-cleanup_delta.zip` is required and produced before final delivery.
14+
15+
## Git Workflow Fields
16+
17+
- Created branch: `codex/pr-26171-042-idea-board-navigation-fallback-cleanup`
18+
- Push result: PASS, branch pushed to `origin/codex/pr-26171-042-idea-board-navigation-fallback-cleanup`.
19+
- PR URL: `https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/19`
20+
- Merge result: recorded in final Codex delivery after GitHub merge returns the merge SHA.
21+
- Final main commit: recorded in final Codex delivery after returning to `main` and pulling latest.
22+
- Conflict resolution: PASS, merged latest `origin/main` (`9df4942226b0c1a25cfc9567040fc237d90df8f9`) and resolved conflicts only in singleton generated report artifacts.
23+
24+
## Scoped Files
25+
26+
- `assets/theme-v2/js/tool-display-mode.js`
27+
- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
28+
- `tests/playwright/tools/ToolboxRoutePages.spec.mjs`
29+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/PLAN_PR.md`
30+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/BUILD_PR.md`
31+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/APPLY_PR.md`
32+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
33+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
34+
- `docs_build/dev/reports/codex_review.diff`
35+
- `docs_build/dev/reports/codex_changed_files.txt`
36+
37+
## Requirement Evidence
38+
39+
- PASS: Removed creator-visible Tool Display Mode navigation diagnostic fallback. `tool-display-mode.js` now logs the navigation load failure to console only and appends no status paragraph.
40+
- PASS: Removed visible message `Tool navigation is temporarily unavailable. Refresh the page or try again shortly.`
41+
- PASS: Idea Board stays usable when registry-backed navigation cannot load. Static/no-registry Playwright path expands notes and adds a note successfully.
42+
- PASS: Creator-facing UI does not mention server, API, local server, port, registry, snapshot, or implementation details in the navigation fallback area.
43+
- PASS: Navigation failure does not affect Idea Board table functionality.
44+
- PASS: API-backed local route validated by targeted Idea Board and Toolbox route Playwright.
45+
- PASS: Static/no-registry route behavior validated by targeted Idea Board Playwright with the registry snapshot returning no data.
46+
- PASS: Optional previous/next navigation is omitted when unavailable.
47+
- PASS: Idea Board lifecycle, Show filter, Create Project, Archive, chevron, and table row editing behavior were not changed.
4348

4449
## Validation
45-
- PASS: `node --check src\engine\audio\TextToSpeechEngine.js`.
46-
- PASS: `node --check toolbox\text-to-speech\text2speech.js`.
47-
- PASS: `node --test tests\tools\Text2SpeechShell.test.mjs`.
48-
- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`.
49-
- PASS: `npm run test:workspace-v2` (legacy command name; user-facing language is Project Workspace).
50-
- PASS: `git diff --check`.
51-
- PASS: Post-conflict validation rerun after merging `origin/main` into the PR branch.
52-
53-
## ZIP
54-
- Path: `tmp/PR_26171_061-text2speech-engine-audio-feature-parity_delta.zip`.
50+
51+
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`
52+
- PASS: `node --check toolbox/idea-board/index.js`
53+
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
54+
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
55+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000`
56+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000`
57+
- PASS: `npm run test:workspace-v2`
58+
- PASS: `git diff --check`
59+
- SKIP: Full samples smoke, per user instruction.
60+
61+
## Coverage Evidence
62+
63+
- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` updated.
64+
- PASS: `docs_build/dev/reports/coverage_changed_js_guardrail.txt` updated.
65+
- PASS: Changed runtime JS coverage lists `assets/theme-v2/js/tool-display-mode.js` at 64% advisory function coverage.
66+
67+
## ZIP Contents
68+
69+
- `assets/theme-v2/js/tool-display-mode.js`
70+
- `docs_build/dev/reports/codex_changed_files.txt`
71+
- `docs_build/dev/reports/codex_review.diff`
72+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
73+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
74+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/APPLY_PR.md`
75+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/BUILD_PR.md`
76+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/PLAN_PR.md`
77+
- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
78+
- `tests/playwright/tools/ToolboxRoutePages.spec.mjs`

0 commit comments

Comments
 (0)