Skip to content

Commit 72348a8

Browse files
committed
PR_26171_ALPHA_048 wire idea journey handoff
1 parent a0da3ad commit 72348a8

8 files changed

Lines changed: 197 additions & 111 deletions

File tree

Lines changed: 47 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -1,125 +1,64 @@
1-
PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff
2-
3-
Git workflow:
4-
- Current branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
5-
- Created branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
6-
- Push result: PASS; pushed to origin/pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
7-
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/32
8-
- Merge approval status: pending explicit Team Alpha owner approval
9-
- Merge result: not performed; merge is blocked until explicit Team Alpha owner approval
10-
- Rebase/conflict resolution: PASS; rebased onto origin/main at e8845dae6 after GitHub reported the branch was behind current main. Conflicts were limited to generated Codex report artifacts and reports were regenerated.
11-
- Latest rebase/conflict resolution: PASS; rebased onto origin/main at 195c90a64 after PR_26171_BETA_075 landed. Conflicts were resolved in generated Codex report artifacts and tests/playwright/tools/RootToolsFutureState.spec.mjs; the test expectations now preserve current-main Text To Speech coverage and ALPHA_047 canonical game-hub route/filter behavior.
12-
- Final approved rebase: PASS; Team Alpha approval granted for ALPHA_047, rebased onto origin/main at 1451a1173, with conflicts limited to generated Codex report artifacts.
1+
PR_26171_ALPHA_048-idea-project-journey-execution-flow
132

143
Instruction compliance:
15-
- PASS: docs_build/dev/PROJECT_INSTRUCTIONS.md was read before file changes.
16-
- PASS: docs_build/dev/PROJECT_MULTI_PC.txt was read before file changes.
4+
- PASS: docs_build/dev/PROJECT_INSTRUCTIONS.md was read before implementation.
5+
- PASS: docs_build/dev/PROJECT_MULTI_PC.txt was read before implementation.
176
- PASS: BUILD_PR.md was created and read before implementation.
18-
- PASS: Team Alpha owner scope applies to Game Hub, Game Journey handoff, and Idea Board continuity.
7+
- PASS: Branch was created from clean main after ALPHA_047 was merged and main was pulled to a0da3ad30.
8+
- PASS: PR TEAM owner applies to Idea Board, Game Hub, and Game Journey.
199
- PASS: Full samples smoke was not run.
2010

11+
Git workflow:
12+
- Current branch: pr/26171-ALPHA-048-idea-project-journey-execution-flow
13+
- Created branch: pr/26171-ALPHA-048-idea-project-journey-execution-flow
14+
- Clean status: PASS after final amendment
15+
- Push result: PASS; pushed pr/26171-ALPHA-048-idea-project-journey-execution-flow to origin
16+
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/41
17+
- Merge approval status: pending explicit Team Alpha owner approval; PR is open and mergeable
18+
- Merge result: not performed; do not merge without explicit Team Alpha owner approval
19+
2120
Validation:
22-
- PASS: node --check toolbox/game-hub/game-hub.js
23-
- PASS: node --check toolbox/game-hub/game-hub-api-client.js
24-
- PASS: node --check toolbox/idea-board/index.js
25-
- PASS: node --check toolbox/game-journey/game-journey.js
26-
- PASS: node --check src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
27-
- PASS: node --check src/dev-runtime/server/local-api-router.mjs
28-
- PASS: node --check tests/playwright/tools/GameHubMockRepository.spec.mjs
2921
- PASS: node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
3022
- PASS: node --check tests/playwright/tools/GameJourneyTool.spec.mjs
31-
- PASS: npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --project=playwright --workers=1 --reporter=line (11 passed)
23+
- PASS: node --check toolbox/idea-board/index.js
24+
- PASS: node --check toolbox/game-hub/game-hub.js
25+
- PASS: node --check toolbox/game-journey/game-journey.js
3226
- PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line (2 passed)
33-
- PASS: npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line --grep "Game Hub hands the active game route to Game Journey|Game Journey requires an active game" (2 passed)
27+
- PASS: npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --project=playwright --workers=1 --reporter=line (11 passed)
28+
- PASS: npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line --grep "Game Hub hands the active game route to Game Journey" (1 passed)
3429
- PASS: npm run test:workspace-v2 (5 passed)
35-
- PASS: git diff --check (line-ending warnings only)
36-
- PASS: Completion revalidation for PR_26171_ALPHA_048 start-gate blocker; ALPHA_047 scoped validation was rerun while still on branch pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff, and ALPHA_048 implementation was not started.
37-
- PASS: Latest post-rebase validation after origin/main 195c90a64: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.
38-
- PASS: Final approved validation after origin/main 1451a1173: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.
3930

4031
Requirement-by-requirement evidence:
41-
- PASS: Rename active path toolbox/game-workspace/ to toolbox/game-hub/.
42-
- PASS: Rename active game-workspace.js to game-hub.js.
43-
- PASS: Rename active game-workspace-api-client.js to game-hub-api-client.js.
44-
- PASS: Deep-audit and update imports, variables, data attributes, tests, toolbox navigation/registry, tool display mode slug, page titles, and creator-facing labels to Game Hub.
45-
- PASS: Do not leave active navigation pointing to toolbox/game-workspace; active route audit found no active legacy route.
46-
- PASS: Do not create duplicate active Game Hub paths; registry reads filter stale game-workspace rows and active metadata points to game-hub.
47-
- PASS: Idea Board Create Project creates/links a Game Hub project when a Ready idea becomes Project.
48-
- PASS: Project ideas lock original Idea, Pitch, and Notes.
49-
- PASS: Game Hub shows Source Idea/Pitch/Notes as read-only creator-facing content.
50-
- PASS: Game Journey receives executable Journey items from Idea notes when the linked project opens.
32+
- PASS: Ready Idea -> Create Project -> Game Hub -> Game Journey flow remains wired through the existing shared Game Hub project contract.
33+
- PASS: Create Project appears only for Ready ideas; the targeted Idea Board test verifies the Ready row action sequence.
34+
- PASS: Clicking Create Project creates or links a Game Hub project and sets the Idea status to Project.
35+
- PASS: Project ideas lock original Idea, Pitch, and Notes as read-only; targeted Idea Board coverage verifies no Edit/Delete/Add Note/note actions after Project status.
36+
- PASS: Project actions become Open in Game Hub and Archive.
37+
- PASS: Game Hub displays read-only Source Idea, Pitch, and Notes for the linked project.
38+
- PASS: Game Hub exposes the creator-facing action as Open Journey.
39+
- PASS: Open Journey navigates to the related Game Journey project route.
40+
- PASS: Game Journey receives an editable Journey item generated from the Idea note.
41+
- PASS: Targeted Idea Board coverage edits the generated Journey item and confirms the Source Idea note remains unchanged.
5142
- PASS: Original Idea notes are not mutated or moved.
52-
- PASS: Project/source-linked actions avoid Delete and use Open in Game Hub plus Archive.
53-
- PASS: No real database migration was added; existing shared mock/server contracts are reused.
54-
- PASS: Merge is not performed without explicit Team Alpha owner approval.
43+
- PASS: No real database persistence or schema work was added.
44+
45+
ZIP:
46+
- Path: tmp/PR_26171_ALPHA_048-idea-project-journey-execution-flow_delta.zip
47+
- Size: 191263 bytes
48+
- Contents:
49+
- docs_build/dev/reports/codex_changed_files.txt
50+
- docs_build/dev/reports/codex_review.diff
51+
- docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/APPLY_PR.md
52+
- docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/BUILD_PR.md
53+
- docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/PLAN_PR.md
54+
- tests/playwright/tools/GameJourneyTool.spec.mjs
55+
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
56+
- toolbox/game-hub/index.html
5557

5658
Changed files:
57-
- deleted: assets/theme-v2/images/badges/game-workspace-1024.png
58-
- deleted: assets/theme-v2/images/badges/game-workspace.png
59-
- added: assets/theme-v2/images/badges/game-hub-1024.png
60-
- added: assets/theme-v2/images/badges/game-hub.png
61-
- deleted: assets/theme-v2/images/tools/game-workspace-1024.png
62-
- deleted: assets/theme-v2/images/tools/game-workspace.png
63-
- added: assets/theme-v2/images/tools/game-hub-1024.png
64-
- added: assets/theme-v2/images/tools/game-hub.png
65-
- updated: assets/theme-v2/js/account-achievements.js
66-
- updated: assets/theme-v2/js/gamefoundry-partials.js
67-
- updated: assets/theme-v2/partials/header-nav.html
68-
- updated: docs_build/database/ddl/game-workspace.sql
69-
- updated: docs_build/database/dml/DML_INDEX.md
70-
- updated: docs_build/database/dml/game-workspace.sql
71-
- updated: docs_build/database/seed/game-workspace.json
72-
- updated: docs_build/database/seed/guest/game-workspace.json
73-
- updated: docs_build/dev/admin-notes/deployment-uat-prod/index.txt
74-
- added: docs_build/dev/reports/codex_changed_files.txt
75-
- added: docs_build/dev/reports/codex_review.diff
76-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/APPLY_PR.md
77-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/BUILD_PR.md
78-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/PLAN_PR.md
79-
- deleted: learn/game-workspace/index.html
80-
- added: learn/game-hub/index.html
81-
- updated: learn/getting-started/index.html
82-
- updated: learn/index.html
83-
- updated: package.json
84-
- updated: scripts/run-targeted-test-lanes.mjs
85-
- updated: scripts/validate-browser-env-agnostic.mjs
86-
- updated: scripts/validate-local-postgres-runtime.mjs
87-
- updated: src/dev-runtime/admin/header-nav.local.html
88-
- updated: src/dev-runtime/persistence/mock-db-store.js
89-
- updated: src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
90-
- updated: src/dev-runtime/seed/server-seed-loader.mjs
91-
- updated: src/dev-runtime/server/local-api-router.mjs
92-
- updated: src/shared/toolbox/tool-metadata-inventory.js
93-
- updated: tests/dev-runtime/DevRuntimeBoundary.test.mjs
94-
- updated: tests/dev-runtime/ProductDataProviderContractHardening.test.mjs
95-
- updated: tests/dev-runtime/SupabaseProductDataCutover.test.mjs
96-
- updated: tests/playwright/account/AchievementsPage.spec.mjs
97-
- updated: tests/playwright/tools/AdminDbViewer.spec.mjs
98-
- added: tests/playwright/tools/GameHubMockRepository.spec.mjs
59+
- added: docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/APPLY_PR.md
60+
- added: docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/BUILD_PR.md
61+
- added: docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/PLAN_PR.md
9962
- updated: tests/playwright/tools/GameJourneyTool.spec.mjs
100-
- deleted: tests/playwright/tools/GameWorkspaceMockRepository.spec.mjs
10163
- updated: tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
102-
- updated: tests/playwright/tools/RootToolsFutureState.spec.mjs
103-
- updated: tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs
104-
- updated: tests/playwright/tools/ToolImageRegistry.spec.mjs
105-
- updated: tests/playwright/tools/ToolNavigationPrevNext.spec.mjs
106-
- updated: tests/playwright/tools/ToolboxRoutePages.spec.mjs
107-
- updated: toolbox/colors/index.html
108-
- updated: toolbox/controls/controls.js
109-
- updated: toolbox/controls/index.html
110-
- updated: toolbox/game-design/index.html
111-
- added: toolbox/game-hub/game-hub-api-client.js
112-
- added: toolbox/game-hub/game-hub.js
113-
- added: toolbox/game-hub/index.html
114-
- updated: toolbox/game-journey/game-journey.js
115-
- deleted: toolbox/game-workspace/game-workspace-api-client.js
116-
- deleted: toolbox/game-workspace/game-workspace.js
117-
- deleted: toolbox/game-workspace/index.html
118-
- updated: toolbox/idea-board/index.js
119-
- updated: toolbox/project-workspace/index.html
120-
- updated: toolbox/tools-page-accordions.js
121-
122-
ZIP:
123-
- Path: tmp/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff_delta.zip
124-
- Size: generated after branch push; final byte size is reported in the delivery response because the ZIP is not committed.
125-
- Contents: repo-structured scoped delta files. Deleted legacy paths are documented in the changed-files list and are not represented as physical files in the archive.
64+
- updated: toolbox/game-hub/index.html
-67.9 KB
Binary file not shown.
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
# PR_26171_ALPHA_048-idea-project-journey-execution-flow APPLY
2+
3+
## Git Workflow
4+
- Current branch: `pr/26171-ALPHA-048-idea-project-journey-execution-flow`
5+
- Created branch: `pr/26171-ALPHA-048-idea-project-journey-execution-flow`
6+
- Push result: PASS; pushed `pr/26171-ALPHA-048-idea-project-journey-execution-flow` to origin.
7+
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/41
8+
- Merge approval status: pending explicit Team Alpha owner approval; PR is open and mergeable.
9+
- Merge result: not performed; do not merge without explicit Team Alpha owner approval.
10+
11+
## Validation
12+
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
13+
- PASS: `node --check tests/playwright/tools/GameJourneyTool.spec.mjs`
14+
- PASS: `node --check toolbox/idea-board/index.js`
15+
- PASS: `node --check toolbox/game-hub/game-hub.js`
16+
- PASS: `node --check toolbox/game-journey/game-journey.js`
17+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (2 passed)
18+
- PASS: `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --project=playwright --workers=1 --reporter=line` (11 passed)
19+
- PASS: `npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line --grep "Game Hub hands the active game route to Game Journey"` (1 passed)
20+
- PASS: `npm run test:workspace-v2` (5 passed)
21+
22+
## ZIP
23+
- Path: `tmp/PR_26171_ALPHA_048-idea-project-journey-execution-flow_delta.zip`
24+
- Size: 191263 bytes
25+
- Contents:
26+
- `docs_build/dev/reports/codex_changed_files.txt`
27+
- `docs_build/dev/reports/codex_review.diff`
28+
- `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/APPLY_PR.md`
29+
- `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/BUILD_PR.md`
30+
- `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/PLAN_PR.md`
31+
- `tests/playwright/tools/GameJourneyTool.spec.mjs`
32+
- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
33+
- `toolbox/game-hub/index.html`
34+
35+
## Requirement Evidence
36+
- Instruction compliance: PASS; PROJECT_INSTRUCTIONS.md and PROJECT_MULTI_PC.txt were read before implementation.
37+
- Team Alpha owner: PASS; scope is Idea, Game Hub, and Game Journey.
38+
- Branch gate: PASS; branch was created from clean `main` after ALPHA_047 merged.
39+
- PASS: Ready Idea -> Create Project -> Game Hub -> Game Journey flow remains wired through the existing shared Game Hub project contract.
40+
- PASS: Create Project remains available only for Ready ideas; targeted Idea Board Playwright verifies Ready action state before creation.
41+
- PASS: Clicking Create Project creates or links a Game Hub project, sets the idea to Project, locks the Idea/Pitch/Notes, and shows Open in Game Hub plus Archive.
42+
- PASS: Game Hub displays read-only Source Idea, Pitch, and Notes for the linked project.
43+
- PASS: Game Hub now exposes the creator action as `Open Journey`.
44+
- PASS: Game Journey receives an editable item generated from the Idea note; targeted Idea Board Playwright edits the generated Journey item after handoff.
45+
- PASS: Original Idea notes are not mutated or moved; targeted Idea Board Playwright confirms the Game Hub Source Idea note remains unchanged after editing the Journey item.
46+
- PASS: No real database persistence or schema work was added.
47+
- PASS: Full samples smoke was not run.
48+
49+
## Changed Files
50+
- added: `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/APPLY_PR.md`
51+
- added: `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/BUILD_PR.md`
52+
- added: `docs_build/pr/PR_26171_ALPHA_048-idea-project-journey-execution-flow/PLAN_PR.md`
53+
- updated: `tests/playwright/tools/GameJourneyTool.spec.mjs`
54+
- updated: `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
55+
- updated: `toolbox/game-hub/index.html`
Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
# PR_26171_ALPHA_048-idea-project-journey-execution-flow BUILD
2+
3+
## Start Gate
4+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
5+
- Read `docs_build/dev/PROJECT_MULTI_PC.txt`.
6+
- Confirm current branch is clean latest `main` before branch creation.
7+
- Confirm Team Alpha owns Idea, Game Hub, and Game Journey work.
8+
- Confirm `toolbox/game-hub/` exists on `main`.
9+
- Confirm merge requires explicit Team Alpha owner approval.
10+
11+
## Exact Targets
12+
- `toolbox/idea-board/index.js`
13+
- `toolbox/game-hub/game-hub.js`
14+
- `toolbox/game-journey/game-journey.js`
15+
- `src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js`
16+
- Targeted Playwright tests for Idea Board, Game Hub, and Game Journey flow
17+
- `docs_build/dev/reports/codex_review.diff`
18+
- `docs_build/dev/reports/codex_changed_files.txt`
19+
20+
## Required Implementation
21+
- Create Project appears only for Ready ideas.
22+
- Clicking Create Project:
23+
- creates or links a Game Hub project,
24+
- sets Idea status to Project,
25+
- locks original Idea, Pitch, and Notes as read-only,
26+
- changes actions to Open in Game Hub and Archive,
27+
- creates editable Game Journey Items from Idea Notes.
28+
- Do not mutate or move original Idea Notes.
29+
- Game Hub displays read-only Source Idea:
30+
- Idea
31+
- Pitch
32+
- Notes
33+
- Add Open Journey action from Game Hub where appropriate.
34+
- Keep creator-facing production copy only.
35+
36+
## Required Validation
37+
- `node --check` for changed JS files.
38+
- Targeted Idea Board Playwright.
39+
- Targeted Game Hub Playwright.
40+
- Targeted Game Journey Playwright.
41+
- `npm run test:workspace-v2`.
42+
- Do not run full samples smoke.
43+
44+
## Required Delivery
45+
- Update required reports.
46+
- Produce repo-structured ZIP under `tmp/PR_26171_ALPHA_048-idea-project-journey-execution-flow_delta.zip`.
47+
- Stage only scoped files.
48+
- Commit.
49+
- Push branch.
50+
- Create PR.
51+
- Stop before merge until explicit Team Alpha owner approval is present.
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR_26171_ALPHA_048-idea-project-journey-execution-flow PLAN
2+
3+
## Purpose
4+
Wire the creator execution flow from a Ready Idea through Game Hub into editable Game Journey items.
5+
6+
## Source of Truth
7+
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
8+
- `docs_build/dev/PROJECT_MULTI_PC.txt`
9+
10+
## Team Ownership
11+
- Team Alpha owns Idea, Game Hub, and Game Journey work.
12+
13+
## Scope
14+
- Ready Idea -> Create Project -> Game Hub -> Game Journey.
15+
- Project and Archived Idea locking remains read-only for Idea, Pitch, and Notes.
16+
- Game Hub displays Source Idea/Pitch/Notes read-only.
17+
- Game Journey receives editable Journey Items generated from Idea Notes.
18+
- Original Idea Notes are not mutated or moved.
19+
- Add Open Journey action from Game Hub where appropriate.
20+
21+
## Out of Scope
22+
- Game Journey image wiring.
23+
- Game Hub table polish unrelated to execution flow.
24+
- Real database persistence or schema changes.
25+
- Full samples smoke.

tests/playwright/tools/GameJourneyTool.spec.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1457,7 +1457,7 @@ test("Game Hub hands the active game route to Game Journey", async ({ page }) =>
14571457
const failures = await openRepoPage(page, "/toolbox/game-hub/index.html");
14581458

14591459
try {
1460-
const journeyLink = page.getByRole("link", { name: "Open Game Journey" });
1460+
const journeyLink = page.getByRole("link", { name: "Open Journey" });
14611461
await expect(journeyLink).toHaveAttribute("href", /toolbox\/game-journey\/index\.html\?game=demo-game$/);
14621462
await journeyLink.click();
14631463
await page.waitForURL(/toolbox\/game-journey\/index\.html\?game=demo-game$/);

0 commit comments

Comments
 (0)